Commit Graph

1573 Commits

Author SHA1 Message Date
838fab822c Resolves: tdf#79250 add typed list to form control listbox
... so numeric and text data can be distinguished input.

Change-Id: I63280a93c272ccc6f5e7ca06a1a1fcbfb3db8455
2017-02-14 11:49:35 +01:00
d3293c7173 Revert "Resolves: tdf#79250 add typed list to form control listbox"
This reverts commit e387b69967aabc44d5da5aaad8d94191437dc57c.

It breaks toolkit.subsequentcheck with
propertyChangeListener wasn´t called for ´TypedItemList´

Back to the drawing board for the twisted property logic of forms and
toolkit uno control models.
2017-02-11 01:19:37 +01:00
e387b69967 Resolves: tdf#79250 add typed list to form control listbox
... so numeric and text data can be distinguished input.

Change-Id: I63280a93c272ccc6f5e7ca06a1a1fcbfb3db8455
2017-02-10 20:58:52 +01:00
6dce9c6757 Add missing #includes
...and remove some unncessary using directives/declarations, in preparation of
removing now-unnecessary #includes from cppumaker-generated files, post
e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception
specifications".

Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-06 17:21:16 +01:00
f4826959c1 new loplugin:unusedenumconstants
These are the simple removals, where it is obviously safe,
the more complex ones will come in separate commits

Change-Id: I7211945a6a5576354b60d9c709940ce9b674f308
Reviewed-on: https://gerrit.libreoffice.org/33828
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-03 08:59:39 +00:00
dce867e8c4 loplugin:stringconstant handle calls to constructors with one arg
Change-Id: Ide9148a908bef46ba14640dfa6f556beaf6e3f60
Reviewed-on: https://gerrit.libreoffice.org/33772
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-01 07:57:16 +00:00
e57ca02849 Remove dynamic exception specifications
...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-26 12:54:43 +00:00
b98811106b use rtl::Reference in OImageControlModel
instead of storing both a raw pointer and an uno::Reference

Change-Id: If0e1380815e93015249cc19bc66b40befbfab50e
Reviewed-on: https://gerrit.libreoffice.org/33570
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26 10:23:56 +00:00
bf110d40ef Change all Idle* LINKs to be Timer*
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles
Link in the Timer class. Now there are two possible solution:

  1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or
  2. split the inheritance of Idle from Timer again to maintain
     different Link<>s and move all common code into a TimerBase.

While the 1st is more correct, the 2nd has a better indicator for
Idles. This implements the first solution.

And while at it, this also converts all call sites of SetTimeoutHdl
and SetIdleHdl to SetInvokeHandler and gets rid of some local Link
objects, which are just passed to the SetInvokeHandler call.

It also introduces ClearInvokeHandler() and replaces the respective
call sites of SetInvokeHandler( Link<Timer *, void>() ).

Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-01-23 20:49:05 +01:00
dc33775281 use rtl::Reference in ODatabaseForm
rather than manual acquire/release

Change-Id: Ic5f013b7e4cafc597c659c61fbf568adccfd806a
2017-01-23 07:56:34 +02:00
f9bad9e8fb don't need an intermediate Image
Change-Id: I090d94cfe433763ded70f28b5139772bca229c34
2017-01-20 17:17:52 +00:00
36d7778f46 New loplugin:dynexcspec: Add @throws documentation, forms
Change-Id: Ib5e1f2ef4143ad1c75ec705624a547e47affbc79
2017-01-19 18:03:20 +01:00
d3ff66999d use rtl::Reference in OClickableImageBaseModel
instead of storing both a raw pointer and an uno::Reference

Change-Id: I92dc79edef9046acc137a878d35dde935bb17674
2017-01-19 13:06:47 +02:00
afb60a273f use rtl::Reference in OComponentEventThread
instead of storing both a raw pointer and an uno::Reference

Change-Id: I8cd4d04ffb9f40a48d48ade2b171a9a9942cf87f
2017-01-19 13:06:47 +02:00
fdc612619c Refactor Scheduler to add Task class
Moves all the "task-specific" stuff into a Task class and just
keeps the "real" static Scheduler functions in the original
Scheduler class.

Change-Id: I9eb02d46e2bcf1abb06af5bab1fa0ee734d1984c
2017-01-17 16:08:47 +01:00
70fed865df new loplugin: useuniqueptr: forms..framework
Change-Id: I4300a13f455148b7156ac3f444c7102d63ae6db3
Reviewed-on: https://gerrit.libreoffice.org/33164
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-17 11:31:40 +00:00
4ec87ca784 add dbtools for !HAVE_FEATURE_DBCONNECTIVITY anyway
Change-Id: I7a769ab3c7881eae80849efc5e75eca5846d254f
2016-12-17 15:47:15 +00:00
818d93f1db more !HAVE_FEATURE_DBCONNECTIVITY build fixing
Change-Id: I1f949c29020c498200decdac487e0519f48a4142
2016-12-17 15:21:26 +00:00
bfde4866e0 convert DecodeMechanism to scoped enum
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-12-05 12:49:02 +02:00
803215142e convert INetURLObject::EncodeMechanism to scoped enum
Change-Id: I50ea17c7779c7b5cacddf548f1773fd7d6c8bade
2016-12-05 12:49:02 +02:00
ccda3f37a4 loplugin:unnecessaryoverride (dtors) in forms
Change-Id: Ia6787aa9dc7963b1e44604f22bfc95e0333a7f79
2016-12-05 09:03:49 +01:00
66ccfcd290 remove use of tryPropertyValue Any specialisation
change return value of getCurrentMultiValue from Any<Sequence<Any> >
to Sequence<Any>.
return value of getCurrentSingleValue (Any of connectivity::ORowSetValue)
can't be changed to use tryPropertyValue.
inline functionality

Change-Id: I3180cf5b9e63a3da9257b03ba02967a2d5402ec3
Reviewed-on: https://gerrit.libreoffice.org/30091
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-11-21 14:36:11 +00:00
bb674aa550 loplugin:unusedfields
Change-Id: Id2dbbf384637223db3d334d95332251832918003
Reviewed-on: https://gerrit.libreoffice.org/30927
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-17 13:10:42 +00:00
1ba4bb6397 loplugin:countusersofdefaultparams in editeng..rsc
Change-Id: I8a8d13faf228cbc934ae21d6763d92d370eb42ec
2016-11-11 12:12:22 +02:00
389999abdb make comphelper::containerToSequence a little smarter
So we don't have to specify the source and destination type as often.

Change-Id: Id9e286417a1cb246d163cbc3c536b231a4a92624
Reviewed-on: https://gerrit.libreoffice.org/30700
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-09 07:48:18 +00:00
bbf6c51717 loplugin:expandablemethods in forms..formula
Change-Id: Idc948ad06913def28cb642c3a4e5ea9322b9fb3b
Reviewed-on: https://gerrit.libreoffice.org/30688
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08 09:49:48 +00:00
c123c528bf loplugin:unnecessaryvirtual in comphelper..forms
Change-Id: Iabe292e68cb84b97f207061347ed6a30309dc9fd
Reviewed-on: https://gerrit.libreoffice.org/30679
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08 06:57:57 +00:00
8a22bc93e0 update unnecessaryoverride plugin to find pure forwarding methods
which can be replaced with using declarations.

Is there a more efficient way to code the search? Seems to slow the
build down a little.

Change-Id: I08cda21fa70dce6572e1acc71bf5e6df36bb951f
Reviewed-on: https://gerrit.libreoffice.org/30157
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28 12:56:17 +00:00
798c107a1a coverity#1374310 Uncaught exception
Change-Id: Ie0ae4412d42d15e2c6c52a8cb0b7b3893405a16b
2016-10-27 21:47:03 +01:00
f20a45808f coverity#1374311 Uncaught exception
Change-Id: I3f0e2fdfbf3c0517593ef87bc7bcbfe2ee693eef
2016-10-27 21:46:19 +01:00
7580c5e5bd coverity#1374312 Uncaught exception
Change-Id: I901c5399cdc33d55c4d3bdfa7a566adc74340405
2016-10-27 21:45:06 +01:00
3cc1a10c7b coverity#1374313 Uncaught exception
Change-Id: I9562deb23324f44b16735b0d376b4c37e20c58c1
2016-10-27 21:41:47 +01:00
db337150cd coverity#1374315 Uncaught exception
Change-Id: Id7a01c652d1d11675b87ee732ff40ddd76de6236
2016-10-27 21:37:42 +01:00
6e14070332 coverity#1374316 Uncaught exception
Change-Id: I32f872d74f167604de006f1d77a9219a37011bfa
2016-10-27 21:34:57 +01:00
95af8bfcdf coverity#1374286 Uncaught exception
Change-Id: Ied3abcd1f2bd7754e3861905f441c46f828f7f5d
2016-10-26 09:56:30 +01:00
b23e979157 coverity#1374281 Uncaught exception
Change-Id: Iaffb4b67c67b5877a5a53d9ae81927b28883fc56
2016-10-26 09:56:30 +01:00
77c3b365c6 coverity#1374280 Uncaught exception
Change-Id: I18f7f006256ac7df575d9235e7121b45fbd05370
2016-10-26 09:56:30 +01:00
f96f2adc28 coverity#1374279 Uncaught exception
Change-Id: I5818bb0a2fe64fd808de5ca7f6d8393f92ab55e2
2016-10-26 09:56:30 +01:00
b1de670d6a coverity#1374278 Uncaught exception
Change-Id: Ide557d1a3237c36067107d357ac2df6186994e10
2016-10-26 09:56:30 +01:00
1ae7f7fcae coverity#1374277 Uncaught exception
Change-Id: I2475056682252111af78a7594c04d15a93fda47f
2016-10-26 09:56:30 +01:00
487738732b coverity#1374276 Uncaught exception
Change-Id: I0572e4365831cf0be2b73c5255812aaf4516ccb0
2016-10-26 09:56:30 +01:00
9b6cb97e43 coverity#1374275 Uncaught exception
Change-Id: I6fcc5d75d8a4b131dc4e3b2e294761b152763a1b
2016-10-26 09:56:30 +01:00
adf3ec2032 coverity#1374274 Uncaught exception
Change-Id: I9e3cee79dfdc06c751d1e5b3d0806c49a7e30da7
2016-10-26 09:56:30 +01:00
0aa597d063 coverity#1374273 Uncaught exception
Change-Id: Ia2738aeb9d1092dd0738801022c5a729b9081f26
2016-10-26 09:56:30 +01:00
0b069a35d3 coverity#1374272 Uncaught exception
Change-Id: Iea7cb5d35e78b89398e8aca7bbdbd17015cb7120
2016-10-26 09:56:30 +01:00
759c585e0c coverity#1374271 Uncaught exception
Change-Id: I043cd76ae0da65cac09130f0e761266fd8730be6
2016-10-26 09:56:30 +01:00
07385355db coverity#1374270 Uncaught exception
Change-Id: Ia29b644748f00aa7dc31af9ccc510976d8646241
2016-10-26 09:56:30 +01:00
ae68c27457 coverity#1374269 Uncaught exception
Change-Id: Ib3a876ea6463396784062bd53bfedff177818498
2016-10-26 09:56:30 +01:00
0aa24916cb loplugin:expandablemethodds in filter..forms
Change-Id: Ic1f64f804acc10b1a48d82de9fc6a2b39af465a0
Reviewed-on: https://gerrit.libreoffice.org/30014
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19 06:32:58 +00:00
d1ea6ecda6 replace <<= with assign for <<= with rhs Any
found by deleting specialization of '<<=' template

Change-Id: I253f15177ab20fd3ef9baf4158da8c662cb47e6c
Reviewed-on: https://gerrit.libreoffice.org/29956
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-18 19:16:44 +00:00