508c95f1b6
improve passstuffbyref return analysis
...
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c
Reviewed-on: https://gerrit.libreoffice.org/27317
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-07-27 06:48:25 +00:00
bfe6c2dedb
tdf#100726: Improve readability of OUString concatenation a bit
...
Change-Id: I6c51b9004089721f199bc35b1e5c13df36847f02
Reviewed-on: https://gerrit.libreoffice.org/27227
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-07-15 08:38:00 +00:00
b19ac3c4c6
clang-tidy modernize-loop-convert in a*
...
Change-Id: If8eada464c6dc7350e50fc90eb27aa47bd90e198
2016-04-21 10:12:01 +02:00
dff9873c27
loplugin:unusedfields UnoControls,ucb
...
Change-Id: I2ff2db21d79d80785f3b6849c879537d5111a960
2015-12-21 12:45:50 +02:00
21a9bc8716
no need to take a mutex when only dealing with stack-local data
...
Change-Id: Ie45e626aad55a8174a53b769a98601bf54dedf65
Reviewed-on: https://gerrit.libreoffice.org/19979
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-16 11:37:11 +00:00
25aec383f9
use initialiser for Sequence<OUString>
...
replaced using:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)'
| xargs perl -0777 -pi -e
"s/Sequence<\s*OUString\s*> (\w+)\(\s*1\s*\);
.*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g"
Change-Id: I20ad0489da887a9712982531c3b127339bb8b3b9
Reviewed-on: https://gerrit.libreoffice.org/19969
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-15 12:18:55 +00:00
c504477e7c
com::sun::star->css in UnoControls/
...
and remove some noise comments
Change-Id: I290ec365b58fa1b21838a6faf84006434c3e7bbd
Reviewed-on: https://gerrit.libreoffice.org/19904
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-11 11:01:31 +00:00
3bf5bc0374
loplugin:nullptr (automatic rewrite)
...
Change-Id: I8be8b75317f0a8cf9005feefea05c053b76c7b0f
2015-11-10 10:31:14 +01:00
065c8b48a6
use uno::Reference::set method instead of assignment
...
Change-Id: I58410209f32f988f258a588364e0b037c2790211
2015-10-30 08:10:22 +02:00
367105e024
cleanup some local var declarations
...
found with
git grep -nP '(\w+)\s+=\s+\g1\(' | lots-of-hand-filtering
Change-Id: I598b0cfa6607823eaef09d95e610e05145c727f7
2015-10-19 13:08:29 +02:00
82f0a4f930
Fix typos
...
Change-Id: I3926eca56ac9f54f9ddbf88610888ce97cf00b34
Reviewed-on: https://gerrit.libreoffice.org/18990
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-09-30 10:41:48 +00:00
2660d24a07
new loplugin: refcounting
...
This was a feature requested by mmeeks, as a result of
tdf#92611.
It validates that things that extend XInterface are not
directly heap/stack-allocated, but have their lifecycle managed
via css::uno::Reference or rtl::Reference.
Change-Id: I28e3b8b236f6a4a56d0a6d6f26ad54e44b36e692
Reviewed-on: https://gerrit.libreoffice.org/16924
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-08-03 06:37:16 +00:00
cbce40e965
Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug builds
...
...to avoid lots of loplugin:staticmethods warnings. Also enables DBG_ASSERT
etc. also for --enable-debug builds in addition to --enable-dbgutil builds.
Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
2015-07-13 18:14:11 +02:00
b997705c07
loplugin:cstylecast: deal with remaining pointer casts
...
Change-Id: I2828f5fe78efffaa5dee19a3d56592d12878d956
2015-06-08 16:22:58 +02:00
d5129a9dd6
new clang plugin: loopvartoosmall
...
Idea from bubli - look for loops where the index variable is of such
size that it cannot cover the range revealed by examining the length
part of the condition.
So far, I have only run the plugin up till the VCL module.
Also the plugin deliberately excludes anything more complicated than a
straightforward incrementing for loop.
Change-Id: Ifced18b01c03ea537c64168465ce0b8287a42015
2015-05-28 12:49:54 +02:00
cbaca2c1ce
remove unused #include awt/InvalidateStyle.hpp
...
Change-Id: I7ea52365157fc642401db64c3b4a40d4643d16ae
2015-05-05 15:51:09 +02:00
5d5f447e73
UnoControls, toolkit, uuoi, xmlsecurity: convert new to ::Create.
...
Change-Id: I7b8c7ece656589c50fb066e9fa1565fd59f930da
2015-04-16 22:21:04 +01:00
d246f47422
Replace remaining getCppuType et al with cppu::UnoType
...
Change-Id: I61a85caf1587291eaa6b999050a52c92d9e416e3
2015-04-01 08:35:13 +02:00
3099c70b11
Fix various XServiceInfo implementations
...
...to match what is recorded in the .component files
Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
2015-03-17 12:25:11 +01:00
556373c41f
V668 no sense in testing the result of new against null
...
Change-Id: I4a33bd92fc8448638a4bfe1eab7e5041a4c5cc39
2015-03-11 09:58:36 +00:00
5f6fcb4e7c
Typos
...
Change-Id: Ibc378fa5f515de61bb768b4ef082638b40c94e00
2015-03-08 16:45:30 +01:00
ba233e87ef
remove unnecessary parenthesis in return statements
...
found with
$ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;'
Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-02-23 09:26:58 +02:00
81cb993127
Fix of a few typos
...
Change-Id: Ib2a311f0341d165a8f9d3f7a11ec36378fd69519
Reviewed-on: https://gerrit.libreoffice.org/14373
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2015-02-09 16:20:09 +00:00
1990c75175
Daft += "\0" triggers assert
...
...try
GetProcessServiceManager().createInstance("stardiv.UnoControls.ProgressMonitor").addText("foo", "bar", false)
in Basic...
Change-Id: I30318c3e8e671a97b6a3fe2dd9ec03add21794ab
2014-12-16 13:31:48 +01:00
8502d64878
Daft "\0" triggers assert in OUString literal ctor
...
...try
GetProcessServiceManager().createInstance("stardiv.UnoControls.StatusIndicator")
in Basic...
Change-Id: Iafc22188feb8a1d3f1b19ac4f6e209be62a44d17
2014-12-16 13:23:19 +01:00
15b4ab8d19
cppuhelper: clean up public headers with include-what-you-use
...
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18 18:51:49 +01:00
0371a63365
remove unnecessary 'using namespace rtl' declarations
...
It turns out that almost none of them were necessary.
Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-29 11:28:54 +00:00
15652daf08
UnoControls: sal_False/True -> false/true
...
Change-Id: If30d43a2693c6df2d483ec135efa54ccb643fdb0
2014-09-15 17:23:23 +02:00
9bac4d413e
typo: more then -> more than
...
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
2014-08-01 23:40:12 +09:00
3e82897353
improve the inlinesimplememberfunctions clang plugin
...
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
dc0b96639f
-Werror,-Wtautological-undefined-compare
...
Change-Id: If546680f4c16ccd733188a65d82129ec2358017b
2014-06-10 10:53:46 +02:00
ac76cc7e60
Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part20
...
Change-Id: If87cdfb2c605254f6d69baa4ca5aec09091caa68
2014-05-23 22:11:52 +02:00
e6ac6cbccf
automaticly -> automatically.
...
Change-Id: Iae55083160eee86ac8301f272634dd3ae65fd847
2014-04-27 01:28:55 +02:00
fdecbd4a41
Kill superfluous spacing before semicolons
...
Change-Id: I2c5c2c2e8c57796d147141748fb57a4c5645a96a
2014-04-06 20:00:28 +03:00
5814e76432
Kill superfluous vertical whitespace
...
Change-Id: Ieb7956acdc24d6b18939e916e33eb12dc268e778
2014-04-06 20:00:27 +03:00
5e21a413c7
cppuhelper: retrofit std::exception into overriding exception specs
...
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
b06820d74c
Remove visual noise from UnoControls
...
Change-Id: I0ffbc08cf769e39e8c3b7519e8d2e13ccbe6e3d8
Reviewed-on: https://gerrit.libreoffice.org/8331
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-26 06:02:19 -06:00
0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-23 03:38:49 +00:00
8bcb8b187e
UnoControls: sal_Bool -> bool
...
Change-Id: Ic548cf07fe115c101771999a0dc8d370e57cd3ab
2014-02-18 08:18:29 +01:00
064c628842
fdo#63154 Remove unused solar.h ref in vcl, basctl, desktop..
...
Change-Id: Ic0187495d8f7f64ddf9d3c202ec41201c9ac3a8c
Reviewed-on: https://gerrit.libreoffice.org/8001
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com >
2014-02-12 07:23:09 +00:00
d706527fd8
bool improvements
...
Change-Id: I24fae431d9e2b99cd6ac937956bb401ecfebc943
2014-01-21 18:24:04 +01:00
2dde51e172
Remove odd service names (that duplicate type names)
...
Looks like no code instantiated these via those odd service names (except for
ProgressMonitor/StatusIndicator instantiating ProgressBar via odd
"com.sun.star.awt.XProgressBar" service name until that got cleaned up in the
previous commit).
Also looks like no code instantiates them via their implementation names either
(in which case ProgressBar/ProgressMonitor/StatusIndicator would be dead code),
but maybe there is code that dynamically constructs those implemenation names
and calls creeateInstance on them? So best leave the implementations in for
now...
Change-Id: I20b92345e343b1f776387f63d9b02a5b0a47fe21
2013-12-19 18:00:36 +01:00
f8db395a8a
Clean up UnoControls/source/controls/ further
...
...and create ProgressBar directly in ProgressMonitor/StatusIndicator, instead
of going via service manager.
Change-Id: I798e0c415c113cfc65d70ed17cb16aafded41a6d
2013-12-19 18:00:35 +01:00
8233226fe4
No need for implbase1.hxx to include XComponentContext.hpp
...
...which it did unlike all the other implbaseN.hxx. Required lots of downstream clean-up,
of course.
Change-Id: Ib720e7a0a43410dcd7e6338b84a3973dfbb20866
2013-12-17 17:32:58 +01:00
96bd18f692
fdo#67213 - crash on opening AutoText dialog (Ctrl+F3
...
Revert "fdo#46808, Convert frame::FrameControl service to new style"
This reverts commit 32eaa77db33b3b1f5793e92167b9f8c2708ea543.
Conflicts:
UnoControls/source/controls/framecontrol.cxx
UnoControls/source/inc/framecontrol.hxx
.. because I can't work out how it causes fdo#67213 - I suspect my
changes might be interacting with UNO aggregation, which
is always tricky.
Change-Id: Icd14f9a7df98585393c5527a3817e05c26246de9
2013-07-24 14:44:57 +02:00
a25778abd8
fix warning
...
"-Werror=unused-macros" was firing on non-debug builds, fix by inlining
the relevant warning message macro.
Change-Id: If2fba2410bf985ec51faaa94c61b2e224fc65328
2013-07-18 13:08:53 +02:00
32eaa77db3
fdo#46808, Convert frame::FrameControl service to new style
...
Change-Id: I38fc91e70d99472a4336250acd5c7dc3457b21ab
2013-07-18 10:36:42 +02:00
95c0d568fd
use uno::Reference#clear() method...
...
...instead of assigning an empty value. Reduces code noise.
Change-Id: Ic95b081a41fb740a738c92b3407a9514ccb8b06e
2013-06-05 08:13:23 +02:00
0f200cc30e
fdo#63154: Change Min/Max/Abs for std::min/max/abs
...
Now all these usages were removed from LO.
Change-Id: I8a7233db20abdcdbb18428ad4004c78cc516a0e6
Reviewed-on: https://gerrit.libreoffice.org/3326
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2013-04-20 11:09:54 +00:00
b248624126
fdo#46808, Convert frame::Frame to new style
...
Change-Id: I74427d1e0059808f04960c648b93245b06c20f7f
2013-04-08 13:53:04 +02:00
