Commit Graph

1132 Commits

Author SHA1 Message Date
f5f0758080 Revert "hack for now"
This reverts commit f5792667cafef77cc4c142f4261f8b64280bc0fe.

it turns out it was the use of an intermediate GtkGrid which made a11y work
a little differently under gtk3. Clearly not intended to be pushed.

Change-Id: I6931163e07ea413acdd45ba1353f357d317fdfbd
2016-07-19 23:38:14 +01:00
f5792667ca hack for now
Change-Id: I62673e60ac8785c74fc4f97ad76bcb02c7e28941
2016-07-19 22:33:34 +01:00
b6b34d5383 Clarify calculation precedence tdf#39440
Use parentheses to clarify the code.

Change-Id: I864dc6dacadb5b9ba9dca8e0abd9fa4e6db1eddc
Reviewed-on: https://gerrit.libreoffice.org/25677
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-05 09:35:40 +00:00
8ad0fb82d4 bridges: [loplugin:staticanonymous]
Change-Id: I9d2c233c7060ea5c7a6bc028a8146ee8b2fd555b
2016-06-21 18:20:26 +02:00
67f3a9a48f bridges: [loplugin:nullptr]
Change-Id: I7386569030fc95553bfb423d23d291430388992b
2016-06-21 18:20:26 +02:00
371ddde018 bridges: [loplugin:salbool]
Change-Id: I1924f2b18763e42013c2b5ce80b664674e460fc7
2016-06-21 18:20:26 +02:00
d7777467a3 bridges: -Werror,-Wimplicit-fallthrough
Change-Id: I1ad51d4dc7e6bddfc5fa8d6252a7d6349bd5dfb7
2016-06-21 18:20:25 +02:00
3b197594d8 tdf#39440 Reduced the scope of the variable c
Change-Id: I14cf653a661664eeb31015bf8aa94f7c140dd87f
Reviewed-on: https://gerrit.libreoffice.org/26002
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-08 06:03:08 +00:00
e0849330bc Get rid of unnecessary directory levels $D/inc/$D
Change-Id: Ibf313b8948a493043006ebf3a8281487c1f67b48
Reviewed-on: https://gerrit.libreoffice.org/25532
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
2016-05-27 17:10:45 +00:00
a890e3189b SAL_FALLTRHOUGH in Windows-only code
Change-Id: If35da46c209746a86687e1c3f60f72f2f08aa681
2016-05-25 08:42:15 +02:00
81ad706b95 Replace comment with SAL_FALLTHROUGH
Change-Id: I9ccba0369453af3b4b3328b9fca94429369c6524
2016-05-12 11:20:14 +02:00
14cd5182c5 Replace fallthrough comments with new SAL_FALLTHROUGH macro
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in
preparation of enabling -Wimplicit-fallthrough.  (This is only relevant for
C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.)

Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but
that would require adding back in dependencies on boost_headers to many
libraries where we carefully removed any remaining Boost dependencies only
recently.  (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its
future evolution will not have any impact on the stable URE interface.)  C++17
will have a proper [[fallthroug]], eventually removing the need for a macro
altogether.

Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-10 16:42:16 +02:00
1269415560 tdf#97499 Fixed containers parameters clearing #7
Change-Id: Ieb9ab0f9c011a24ba329cfb063e3d7733dd1afcb
Reviewed-on: https://gerrit.libreoffice.org/24440
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-28 07:26:58 +00:00
6dbcebab6d tdf#97499 Fixed containers parameters clearing #6
Change-Id: I89ad45eacfffd3783687b158a45f3eda0b95dece
Reviewed-on: https://gerrit.libreoffice.org/24433
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-28 07:26:39 +00:00
8a09cd241c loplugin:salbool
Change-Id: I3a96fd12e6fa3a64bd1888373dfce0f8f621aad4
2016-04-22 09:30:16 +02:00
8762aa986d clang-tidy modernize-loop-convert in b*
Change-Id: I8ac6eb59e213eafa78e3dc4578738b53e8adef5b
2016-04-21 10:27:17 +02:00
9a978d62ad loplugin:salbool: Automatic rewrite of sal_False/True
Change-Id: Ideaafe1920c9e27de7ed9e9f4fe9fc7cb8c3b6aa
2016-04-20 17:25:36 +02:00
8c2f2e1dd7 tdf#94306 replace boost::noncopyable in ..
.. accessibility, avmedia, basctl, basic and bridges
remove boost from module if not needed anymore

Change-Id: I6177f8276766a0a7df1703e81bf1b448912df6e2
Reviewed-on: https://gerrit.libreoffice.org/23744
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-04 06:54:36 +00:00
2e73ae7a62 -Werror,-Wshadow
Change-Id: Ib20a02a846b745b65ffcf9ec1d45b39a6e0c50e4
2016-03-04 08:50:11 +01:00
1e161eb96e Use config_cxxabi.h to check for __*class_type_info
...as needed e.g. when building on Linux with clang -stdlib=libc++ against
libc++abi

Change-Id: I1f6f5ebcf5410c65453549ecea77581ccdaabc17
2016-02-26 08:57:09 +01:00
3d63d0c14b Adapt __cxxabiv1 for libc++abi
...where it has an additional nonstandard member, at least on Linux x86-64.  Not
sure whether

  #if defined _LIBCPPABI_VERSION

is the best way to distinguish libc++abi from other C++ runtimes, but

  #define _LIBCPPABI_VERSION 1002

is what it has in its cxxabi.h.

Change-Id: I9edbca27aa2bedbc5b2e996fd5ffcfc2e8eb42d9
2016-02-26 08:57:09 +01:00
0fef230f0f Declarations based on config_cxxabi.h should be unrelated to _LIBCPP_VERSION
Change-Id: I79049fefad8b626b5c58728b9c05c4952fb97f1a
2016-02-26 08:57:08 +01:00
069506bcb0 Use config_cxxabi.h to check for __cxa_eh_globals, __cxa_exception
Change-Id: I467341da4bccb3afb82518b444cd101b3cdaacc9
2016-02-26 08:57:08 +01:00
128deeae81 cxxabi.h is not specific to GCC
Change-Id: Icaf4d4d41a36ae469f826ac08ab641a554dff3c9
2016-02-26 08:57:07 +01:00
baad027bb7 Expect _Unwind_Exception to be defined in the compilers' unwind.h
Change-Id: Ie27018d21cf356ea5c6953958b466153f93f9a51
2016-02-26 08:57:07 +01:00
94f1950744 Add missing include
Change-Id: I454b39a76595aedbbe1ca64f9b1982e5c27623cd
Reviewed-on: https://gerrit.libreoffice.org/22708
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2016-02-26 07:50:47 +00:00
8d17a0f71b WaE: vs2015 shadow local
Change-Id: Ia1cb87653775bf9226bac46842b309d55fbaf084
Reviewed-on: https://gerrit.libreoffice.org/22598
Reviewed-by: David Ostrovsky <david@ostrovsky.org>
Tested-by: Jenkins <ci@libreoffice.org>
2016-02-22 02:31:27 +00:00
a238b1f8d3 Remove excess newlines
A ridiculously fast way of doing this is:

for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
  --exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
    perl -0777 -i -pe 's/^
{3,}/

/gm' $i
done

Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09 08:18:05 +00:00
538f276ae0 Formatting changes across all modules
+ Removed comment cruft
+ Tab formatting in number of files
+ Some commented out code removed
+ Tab characters replaced with spaces
+ Newline cleanup in quite a few files
+ Tweak header guard #endifs

Change-Id: I3208ff2f047da890edcc49b73389aca22442f5fc
Reviewed-on: https://gerrit.libreoffice.org/22221
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09 08:11:34 +00:00
ef99aad586 Quickfix for Win 64-bit C++ UNO bridge (more than 20 params)
See <https://wiki.documentfoundation.org/Development/msvc-x86_64#Broken_C.2B.2B-UNO_Bridge>,
increase the number of supported params to 32 to at least make the
ooo.vba.excel.XApplication.Intersect case (and thus CppunitTest_sc_macros_test)
work.  The true fix will be to abandon this simplistic approach, as elegant as
it may have appeared.

Change-Id: Ieeb17f682bd5ea8cb7a6188b89978698949461aa
2016-01-27 08:34:52 +01:00
5ee8e22a26 cppcheck: noExplicitConstructor
Change-Id: I94db78ca12e0f3389f00ea5c557f0b64d452f613
Reviewed-on: https://gerrit.libreoffice.org/21150
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-01-07 09:11:53 +00:00
0725bdfc30 Kill check for ancient FreeBSD version
along the lines of ...

commit cee2655445319133095b0f6b19fc5b31d321099f
Author: Baptiste Daroussin <bapt@FreeBSD.org>
Date:   Thu Dec 10 17:38:06 2015 +0100

    Kill check for ancient FreeBSD version

which removed the other uses of this

Change-Id: I56a4448b27683ff8a86e4d760fec4f6bfc2d0bd6
2015-12-19 21:09:26 +00:00
27f5679c84 tdf#95903: Fix return value handling in msvc_win32_x86-64 bridge
...where a return value was double-deleted if it was "complex" (i.e., generated
by callee into caller-provided memory) but not related to UNO interface types
(so doesn't need any mapping, like sequence<css.beans.Property> returned by
css.beans.XPropertySetInfo.getProperties).

Change-Id: I4cfc16ba63022686afd016ef5b64419e8dee53a4
2015-12-15 16:52:19 +01:00
cee2655445 Kill check for ancient FreeBSD version
Change-Id: Ia6f7d55d2d8d346695658549d2e86eef77215377
Reviewed-on: https://gerrit.libreoffice.org/20625
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-12-11 07:28:09 +00:00
4a1edf626a More loplugin:nullptr automatic rewrite (within templates)
Change-Id: I9bc06cfb5eeb38fd7ae7fb25f876ea9f96e4a65a
2015-12-10 17:34:31 +01:00
871b5abf11 Work around missing __CxxDetectRethrow in clang-cl
Change-Id: Ia42d39f04b22986d3fd873655b48dc31d834caee
2015-12-02 08:02:20 +01:00
0f54e537c6 missing namespace
Change-Id: Ib291151508756035fbfde1805ba48e746d96dd59
2015-11-19 16:46:13 +01:00
2b66862f22 ...and make it clear that RegParamKind /is/ used
...and will not erroneously be removed a third time

Change-Id: I7007dbd1d3a1762523c0ce54a04c37a5d2203a48
2015-11-19 14:08:00 +01:00
9124ab7422 REGPARAM_INT/FLT /are/ used
...broken with 53f16c39f5c4c69ab603bf9098daec71f7a0acb8 "remove unused typedefs
and inline use-once typedefs"

Change-Id: I4b1343b98733ae998c7f9c594a86d65348402d28
2015-11-19 13:58:59 +01:00
6b26ed763f -Werror,-Wunused-private-field
Change-Id: I590f8aa06b193e789de86435038d799cf219ffd6
2015-11-18 17:19:16 +01:00
4cc07334fd -Werror,-Wdynamic-class-memaccess
destination for this 'memcpy' call is a pointer to dynamic class '__type_info';
vtable pointer will be overwritten
source of this 'memcpy' call is a pointer to dynamic class 'type_info'; vtable
pointer will be copied
explicitly cast the pointer to silence this warning

Change-Id: Ic9a55dfa11643ac2c7ebc02332325a2f58516d04
2015-11-18 17:19:16 +01:00
6c8a5bcfe9 -Wmicrosoft-cast
Change-Id: Idc7b1c8c953634c26aad0923344457eae6fb1583
2015-11-18 17:19:16 +01:00
033d1acd16 -Werror,-Wmicrosoft-exception-spec
Change-Id: Icd92fe15c3534f440017709bcdbe9aadf1c83c6d
2015-11-18 17:19:16 +01:00
53f16c39f5 remove unused typedefs and inline use-once typedefs
and improve the script a little

Change-Id: I2792ea4dd5df3a50736fbe209225c3f16fb86b84
Reviewed-on: https://gerrit.libreoffice.org/20033
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-18 10:38:08 +00:00
520cd4e688 loplugin:nullptr (automatic rewrite; Mac-specific code)
Change-Id: If07e4116c43cbddefbf443c4cbd754dde48c90a0
2015-11-10 16:20:34 +01:00
655c2d5193 loplugin:nullptr (automatic rewrite)
Change-Id: Ib05cdd5a0f2a2e0f4c08504d89d0b6201cbcb429
2015-11-10 10:31:17 +01:00
5e04886917 Remove spurious vertical whitespace
Change-Id: I077a17eada47b9c1509c21c18a6e4cd06172de3b
2015-11-02 17:53:29 +01:00
3f7c8ce1dc Don't rely on __builtin_alloca when creating a call stack
...at least recent Clang trunk ASan+UBSan build apparently adds instrumentation
code that made that (arguably optimistic) setup fail

Change-Id: I186a7abdfe5cc69e624583b1281d3989cefd7d53
2015-11-02 17:21:55 +01:00
0b6a0d4c31 bridges: loplugin:cstylecast
Change-Id: I8613f1f7f2155aa972fa4f841ebfcf6e07e45821
2015-10-30 16:09:37 +01:00
0b018d202d tdf#39440: fix several warnings reported by cppcheck
Change-Id: I560d28b7cc67740c6479494d0e5aa62d2ac6ffae
Reviewed-on: https://gerrit.libreoffice.org/19587
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-10-25 22:31:44 +00:00