wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
395,083 Commits 5 Branches 0 Tags
8a6b2fb5b94de43316ab3ea95ff07cf5f46b6134
Commit Graph

1224 Commits

Author SHA1 Message Date
Noel Grandin
508c95f1b6 improve passstuffbyref return analysis 
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c
Reviewed-on: https://gerrit.libreoffice.org/27317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-27 06:48:25 +00:00
Caolán McNamara
a860df25dd masses of MessBoxes not being disposed promptly 
since...

commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f
Date:   Thu May 28 21:35:43 2015 +0100

    tdf#91702 - fix stack-based MessBox allocation.

There is no special ScopedVclPtr<X>::Create or
ScopedVclPtrInstance<X>::Create just
VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo
doesn't call dispose on the owned X

Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
 2016-07-26 11:26:52 +01:00
Noel Grandin
938821fb08 new loplugin overrideparam 
verify that parameters on override methods have the same set of default
values for their params as their parent/super-methods do.

Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2
Reviewed-on: https://gerrit.libreoffice.org/27437
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-25 06:09:17 +00:00
Jochen Nitschke
194d4a02b9 chart2: remove unused ContainerHelper.hxx includes 
remove using namespace :💹:ContainerHelper;
to match other uses

Change-Id: I343086a6b7d70c84499b209680973431c7317219
Reviewed-on: https://gerrit.libreoffice.org/27184
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jenkins <ci@libreoffice.org>
 2016-07-13 12:58:55 +00:00
Jochen Nitschke
5ce65d04fd chart2: cleanup local var assignments 
and remove comments about a gcc 3.3 workaround.
some comments went obsolete with other commits
like 367105e0248c7b80b60b2554d04f5f248b4259b3

Change-Id: I15fff464e2f71a6ade29c141bb17216770f54ced
Reviewed-on: https://gerrit.libreoffice.org/27127
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-13 07:26:45 +00:00
Stephan Bergmann
cd1e2f5cc3 Avoid global data with (non-constexpr) ctors/dtors 
Change-Id: I787ec685275d119dd4eea86f51b6dd85bc0260d1
 2016-07-12 09:43:56 +02:00
Jochen Nitschke
43bc09d6dd chart2: make m_aEntryMap a non member constant 
Change-Id: Ic45ba10808ea2ce6bc6520bb4222cd8b3ebd8ea6
Reviewed-on: https://gerrit.libreoffice.org/27098
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-12 06:31:08 +00:00
Stephan Bergmann
d956a5d29e loplugin:passstuffbyref also for {css::uno,rtl}::Reference 
Change-Id: I5c973d41381f2bfd39e7a8cf48fd5807852bdc72
 2016-07-07 18:59:55 +02:00
Noel Grandin
0f17e34330 loplugin:singlevalfields in chart2 
Change-Id: I8b8bf093736a191c90d765dce82b00e15bb398d6
Reviewed-on: https://gerrit.libreoffice.org/26708
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-28 08:35:03 +00:00
Muhammet Kara
6786842337 Move accessibility relations to .ui files, Part 8: tdf#87026 
By removing unnecessary variables/strings/function calls,
and making proper changes in the related .ui files.

Change-Id: I04244b360b4bb32ccbbe5bde4756a9166ae1fcaf
Reviewed-on: https://gerrit.libreoffice.org/26018
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
 2016-06-10 13:54:37 +00:00
Noel Grandin
11b4a6ddce Convert DeactivePage return code to scoped enum 
Change-Id: Idd5372ad20fc6676864b31b3796f8b9bc0ad73dd
Reviewed-on: https://gerrit.libreoffice.org/25918
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-06 07:02:20 +00:00
Muhammet Kara
3498fd9fe9 Remove SetAccessibleRelationLabeledBy calls tdf#87026 
And make proper changes in the related .ui files

Change-Id: Iea998b6de25831c08950a8afa725713288113bfa
Reviewed-on: https://gerrit.libreoffice.org/25807
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2016-06-02 10:36:59 +00:00
Jochen Nitschke
4ca9e85538 replace simple macros in chart2 
with static constantants or a named value (enum)

Change-Id: I8ef21bc3b9797ed9319e790fc12241d59f07b88c
Reviewed-on: https://gerrit.libreoffice.org/25760
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-02 07:31:39 +00:00
Jochen Nitschke
ef3585340e remove ENABLE_GL3D_BARCHART define 
enabled since commit dfb2ab0cee2ba04ce8816580447e7db8160ffac4

Change-Id: Ib260ff1ce4089ecf4778114d249d59af67c94c2c
Reviewed-on: https://gerrit.libreoffice.org/25759
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-02 07:29:05 +00:00
Noel Grandin
21a68e1745 convert TAB to scoped enum 
and rename the SID constant to something more meaningful

Change-Id: Ic07888936df3d537158fd2fb671b0df11350d676
Reviewed-on: https://gerrit.libreoffice.org/24986
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-18 10:13:57 +00:00
Noel Grandin
2c8fe2e737 update unusedmethods plugin to deal with constructors 
and fix the operator< implementations in some of the other
plugins too.

Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035
Reviewed-on: https://gerrit.libreoffice.org/25057
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-18 10:03:44 +00:00
Stephan Bergmann
14cd5182c5 Replace fallthrough comments with new SAL_FALLTHROUGH macro 
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in
preparation of enabling -Wimplicit-fallthrough.  (This is only relevant for
C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.)

Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but
that would require adding back in dependencies on boost_headers to many
libraries where we carefully removed any remaining Boost dependencies only
recently.  (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its
future evolution will not have any impact on the stable URE interface.)  C++17
will have a proper [[fallthroug]], eventually removing the need for a macro
altogether.

Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
 2016-05-10 16:42:16 +02:00
Andrea Gelmini
fc2590cfa1 Fix typos 
Change-Id: Id81b16ff26283611f0b84929d831c827f847ab73
Reviewed-on: https://gerrit.libreoffice.org/24317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2016-04-30 15:06:45 +00:00
Stephan Bergmann
81105d9534 -Werror,-Wvarargs 
"passing an object that undergoes default argument promotion to 'va_start' has
undefined behavior [-Werror,-Wvarargs]"

just drop the variadic overload and use the one taking a WizardPath (i.e., a vector)

Change-Id: I6e389f60f8b7cb0633bf173bde69af1c5af86048
 2016-04-27 13:47:30 +02:00
Laurent Balland-Poirier
fe2bf7b059 tdf#99518 Use correct decimal separator 
Change-Id: I39169e7c7344fcfd594a0e0d2ab0a762cc3d5829
Reviewed-on: https://gerrit.libreoffice.org/23961
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2016-04-27 00:29:42 +00:00
Stephan Bergmann
a82805f8f9 Kill comphelper::MakeMap 
Change-Id: I97e9e79ef51e3d78f01b831dd3eee91218058823
Reviewed-on: https://gerrit.libreoffice.org/24344
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2016-04-25 06:11:27 +00:00
Noel Grandin
e1af7f0c43 clang-tidy modernize-loop-convert in c* 
Change-Id: I77d2548f8be97792660761e6156cd24734a95aaf
 2016-04-21 11:03:55 +02:00
Noel Grandin
5abc669599 new plugin stylepolice 
check for local variables which follow our member field naming
convention, which is highly confusing

Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
 2016-04-21 08:32:47 +02:00
Stephan Bergmann
08bb436ff9 loplugin:salbool: Automatic rewrite of sal_False/True 
Change-Id: I1230a1785c61b8ef5dab97176e7c06600ac95a5b
 2016-04-20 17:25:36 +02:00
Jochen Nitschke
150ac9cf05 clean-up: unused using declarations and includes 
Searched source for using declarations.
Checked if those symbols reappear in the source file,
even in comments or dead code but not in #include statements.
If they don't reappear, remove the declaration.
Remove includes whose symbol got removed.

Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0
Reviewed-on: https://gerrit.libreoffice.org/24148
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-18 07:25:24 +00:00
Rohan Kumar
81c9d54db3 tdf#91794 removed OSL_DEBUG_LEVEL > 1 conditionals 
Removed OSL_DEBUG_LEVEL > 1 conditionals to reduce the
problem of multiple debug levels

Change-Id: I453f74198e08308c3891e923ebaee58a276e34ad
Reviewed-on: https://gerrit.libreoffice.org/22616
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2016-04-14 09:25:38 +00:00
Stephan Bergmann
7816dd1bbb Avoid reserved identifier 
Change-Id: I8590b2c145a536872d692afcaa50279c99b3f974
 2016-04-12 20:03:47 +02:00
Noel Grandin
9cfa0810bd clang-tidy performance-unnecessary-value-param in chart2 
Change-Id: Id33dce9714737dd28ce48c22f966c9747c2db20b
 2016-04-12 11:25:18 +02:00
Jochen Nitschke
4c7ec9f112 cleanup: remove unused com/sun/star/uno includes 
Sequence.h(xx), Any.h(xx) and Type.h(xx)
and remove unused using-declarations from these files.

Add a few missing includes provided by them.

Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4
Reviewed-on: https://gerrit.libreoffice.org/23805
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-12 06:38:26 +00:00
Noel Grandin
e5dd156a44 loplugin:constantparam 
Change-Id: Ie690088d7a7d568703afd22f544628fc8012a7e1
 2016-04-11 08:26:01 +02:00
Jochen Nitschke
f7a75a66fa cleanup: remove unused Reference.h(xx) includes 
and unused using-declarations from Reference.h

Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19
Reviewed-on: https://gerrit.libreoffice.org/23735
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2016-04-02 19:01:24 +00:00
Noel Grandin
ce66911720 loplugin:constantparam in svtools 
Change-Id: I1a3c4a36e29a6712c589ffd3aaada593880d978d
Reviewed-on: https://gerrit.libreoffice.org/23304
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-03-17 10:28:09 +00:00
Noel Grandin
8353667d35 com::sun::star->css in chart2 
Change-Id: I04320d32d6d5c54e461cfabef58645f8b772bc69
 2016-03-14 13:43:38 +02:00
Noel Grandin
f69585c354 loplugin:unuseddefaultparams in chart2 
Change-Id: I03a3580fdbd1f6cf08af329b07edcfe09ecbb9aa
 2016-03-02 07:57:38 +02:00
Noel Grandin
db8067145f loplugin:write only fields 
Change-Id: I44f249a17d0a510ec63a488b656d57a1a392f821
 2016-02-22 14:34:21 +02:00
Noel Grandin
1ef9f3988e unnecessary use of OUString constructor 
Change-Id: Idd31b0a53c8318af69bbcd32f6798721ec8eb8e1
Reviewed-on: https://gerrit.libreoffice.org/21945
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-01-31 12:04:02 +00:00
Chris Sherlock
cb20f46895 vcl: change Font::SetName() to Font::SetFamilyName() 
Change-Id: I9b7bd1ec25955981ebcb9085579cbb9fbaa802d5
Reviewed-on: https://gerrit.libreoffice.org/21560
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-01-18 05:24:46 +00:00
Norbert Thiebaud
45654a1d4d revert vcl patch series that brok Mac and Windows 
revert:
9bc2f3de8672e812f3a67541c6d7069b434a7e42
 vcl: add comment about ImplFontMetric::{Get|Set}LineHeight()
26371f105bc44e04469ec03fc5bb12505e651c6b
 vcl: FontAttributes::GetSlantType() -> FontAttributes::GetItalic()
2dd0b4317372b8022efe3911b38b4fa02956d8b9
 vcl: font.hxx and metric.hxx cleanup, make ctors explicit and the dtor virtual
5ab13bf3ead3539e4ad847656da81e7eb6029652
 vcl: tabify font.hxx
f99550dae55e40e49bf9c9875053fe2abb4c71ca
 vcl: change Font::SetName() to Font::SetFamilyName()
2b297116cb6bb1061c43e5714e2609c8ee9f57d2
 vcl: rename Font::GetName to Font::GetFamilyName

Change-Id: I23f38921187d66b970ca815eb30dda4222a2da62
 2016-01-16 12:20:45 -06:00
Chris Sherlock
f99550dae5 vcl: change Font::SetName() to Font::SetFamilyName() 
Change-Id: I54a4036544c680c4a49607677af776aa7a433fbc
Reviewed-on: https://gerrit.libreoffice.org/21510
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-01-16 16:12:14 +00:00
Noel Grandin
6fc3fd29a6 loplugin:unusedmethods unused return value in chart2 
Change-Id: Ibd8ae8ade2a1037deac1e29ce1b867c2847a9dff
 2016-01-11 10:49:24 +02:00
Noel Grandin
e3a31fcca7 loplugin:unusedfields 
Change-Id: I979592adb978c3757a1e54615021ee424a2e02bf
Reviewed-on: https://gerrit.libreoffice.org/20892
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-12-24 07:28:28 +00:00
Noel Grandin
c5458af905 loplugin:unusedfields in chart2 
Change-Id: I8203f84ad8b138932c990032e17ea5d2daf384bb
 2015-12-23 09:38:46 +02:00
Tor Lillqvist
7532317631 WaE: comparison between signed and unsigned integer expressions 
Change-Id: I051e2682bdff3bf88fecd726bd57652e5f9e8806
 2015-12-03 14:44:50 +02:00
Noel Grandin
e6721d2d17 uno::Sequence->std::vector in SfxIntegerListItem 
Change-Id: Icdbb361feea2ebee74f9d0a906bdd3c2882443e8
 2015-12-03 13:57:23 +02:00
Noel Grandin
2554efabb6 use comphelper::containerToSequence 
in chart2, we remove a local equivalent of the method

Change-Id: I25129a3d1ea1dd724eb9cd38a57be37a78b3d100
 2015-11-19 09:33:29 +02:00
Noel Grandin
96c26b0d9d use initialiser for Sequence<OUString> 
using variations of:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\;
\s*OUString\* pArray.*;
.*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g"

Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3
Reviewed-on: https://gerrit.libreoffice.org/19971
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-15 12:20:39 +00:00
Stephan Bergmann
40c4a08652 loplugin:nullptr (automatic rewrite) 
Change-Id: I71de514405bb9bcc746c1ab9633e7fe659888943
 2015-11-10 10:31:18 +01:00
Noel Grandin
6c80a8fe89 new loplugin: oncevar 
Change-Id: If57390510dde4d166be3141b9f658a7453755d3f
Reviewed-on: https://gerrit.libreoffice.org/19815
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-09 08:34:40 +00:00
Benjamin Ni
be729e7721 tdf#94269: Replace "n" prefix for bool variables with "b" 
Change-Id: I178545792c7354a362658ac7ef8b1d4cf0865797
Signed-off-by: Michael Stahl <mstahl@redhat.com>
 2015-11-02 23:40:57 +01:00
Stephan Bergmann
dedf0a28d5 loplugin:defaultparams 
Change-Id: I03541b984db147f8bd3ed35f83e297cf7eecd7f0
 2015-10-20 11:44:54 +02:00