Commit Graph

852 Commits

Author SHA1 Message Date
a860df25dd masses of MessBoxes not being disposed promptly
since...

commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f
Date:   Thu May 28 21:35:43 2015 +0100

    tdf#91702 - fix stack-based MessBox allocation.

There is no special ScopedVclPtr<X>::Create or
ScopedVclPtrInstance<X>::Create just
VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo
doesn't call dispose on the owned X

Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
2016-07-26 11:26:52 +01:00
8569cf1d91 loplugin:passstuffbyref
Change-Id: I0114bd98b92b9810d7d829ddce8461a2844e0506
2016-07-17 21:57:33 +02:00
bd9644249d tdf#100913 Remove tOID typedefs in ObjectHierarchy class
Replace use of toID with ObjectIdentifier in 'ObjectIdentifier.hxx'.

Change-Id: Ic0157974eca2992167319f7d19a0224056cc985e
Reviewed-on: https://gerrit.libreoffice.org/27243
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-17 12:20:42 +00:00
a980b6c8ae no need for this temporary OString
Change-Id: I8b5d69f7e64a83e52a41c285f5ef186a666ccd55
2016-07-16 18:27:14 +02:00
8781dbe099 uitest: provide all the children for charts
This now also includes legend entries and data points.

Change-Id: I0e4d1f21a20035cd632a7755dbbea17baec4b083
2016-07-16 18:27:13 +02:00
0f03a80131 uitest: some initial work on the chart selection
Change-Id: I3317eba5383206de6f619da548ee3047861eef07
2016-07-16 18:27:13 +02:00
b1e1b38349 uitest: add initial support for selecting chart elements
Change-Id: I3af11d44067618b5188f3dbf4abccc171dd98d0c
2016-07-16 18:27:13 +02:00
6e72f0251b new loplugin unnecessary override
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb
Reviewed-on: https://gerrit.libreoffice.org/27135
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-15 14:05:41 +00:00
5ce65d04fd chart2: cleanup local var assignments
and remove comments about a gcc 3.3 workaround.
some comments went obsolete with other commits
like 367105e0248c7b80b60b2554d04f5f248b4259b3

Change-Id: I15fff464e2f71a6ade29c141bb17216770f54ced
Reviewed-on: https://gerrit.libreoffice.org/27127
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-13 07:26:45 +00:00
7001ca25ec merge LineProperties with chart::ErrorBar
Change-Id: Ic3490a15339ff981e90a86cb69c206c231db9161
Reviewed-on: https://gerrit.libreoffice.org/26932
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-05 10:51:09 +00:00
0f17e34330 loplugin:singlevalfields in chart2
Change-Id: I8b8bf093736a191c90d765dce82b00e15bb398d6
Reviewed-on: https://gerrit.libreoffice.org/26708
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-28 08:35:03 +00:00
1df394503f GSoC notebookbar: switching tabs depending on context
+ sfx2::sidebar::EnumContext moved to the vcl module
+ TabPage contains vector with context values
+ vcl builder reads control's contexts from the "class" mark
+ ContextTabControl shows tabs depending on context

Change-Id: I661b0d3f35d46ace2a2e8eb1d374148f0c60017d
Reviewed-on: https://gerrit.libreoffice.org/26447
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-27 17:51:56 +00:00
c4a6f300f5 uitest: set id for chart window
Change-Id: I443dcccf6d560c252da38a0f0c63cc48a212c127
Reviewed-on: https://gerrit.libreoffice.org/26494
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-20 02:26:45 +00:00
bdd67652b6 Try to get rid of svt::ContextMenuHelper
Change-Id: I7b43e417607b20c300e3c18e7da76a6173a18b7d
Reviewed-on: https://gerrit.libreoffice.org/26098
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
Tested-by: Jenkins <ci@libreoffice.org>
2016-06-09 12:53:43 +00:00
78b100ec9c only init the OpenGL context if we need it
Change-Id: Ia88a1720d204b9933f1476bd703b99180e45abde
Reviewed-on: https://gerrit.libreoffice.org/26023
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-07 16:11:20 +00:00
4ca9e85538 replace simple macros in chart2
with static constantants or a named value (enum)

Change-Id: I8ef21bc3b9797ed9319e790fc12241d59f07b88c
Reviewed-on: https://gerrit.libreoffice.org/25760
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-02 07:31:39 +00:00
850a8d27ca Convert GRAPHIC to scoped enum
Change-Id: I1fd09a729cbda00f99841532e0dd3fa66bce7bea
Reviewed-on: https://gerrit.libreoffice.org/25534
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-27 12:59:23 +00:00
ca6c108caa Missing break in switch
First 749a0845500d69f99bf1901bab82361f67b5e4f6 "don't show area and line panel
in pie chart Chart selection, tdf#94320" added the case OBJECTTYPE_DIAGRAM
falling through to the default break case.  Then
14237c1678167da725fee079532c4669264d697f "use trendline context for trendlines,
tdf#94931, tdf#94934" added the case OBJECTTYPE_DATA_CURVE,
OBJECTTYPE_DATA_AVERAGE_LINE block in between.

Change-Id: I9d06b5054128c4a31381e33620f4a2b898e0e969
2016-05-10 17:39:13 +02:00
adff28271b the container document commands std::set can be static
Change-Id: I00558dad4b8206e5e2a7bf004e32196a15dba3cd
2016-04-25 09:21:44 +02:00
b2e2400736 no need to copy the list of available commands on every call
Change-Id: I131f34a94c998f3dd9fd7a457fb213778040c771
2016-04-25 09:18:12 +02:00
a82805f8f9 Kill comphelper::MakeMap
Change-Id: I97e9e79ef51e3d78f01b831dd3eee91218058823
Reviewed-on: https://gerrit.libreoffice.org/24344
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-25 06:11:27 +00:00
2b68383e44 Kill comphelper::MakeSet
Change-Id: I2e5f8c2cd67406d9d275960a37c4aa45e283eec3
Reviewed-on: https://gerrit.libreoffice.org/24343
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-25 06:11:10 +00:00
59dc694c9f C++11: disable ctors instead of not implementing them (chart2)
replace the old declare and don't implement pattern
with C++11 delete keyword

Change-Id: I10b14cece4ecaddc5f96ee098b5fa36a8782a0fc
Reviewed-on: https://gerrit.libreoffice.org/24340
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-24 21:27:04 +00:00
5abc669599 new plugin stylepolice
check for local variables which follow our member field naming
convention, which is highly confusing

Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-21 08:32:47 +02:00
08bb436ff9 loplugin:salbool: Automatic rewrite of sal_False/True
Change-Id: I1230a1785c61b8ef5dab97176e7c06600ac95a5b
2016-04-20 17:25:36 +02:00
150ac9cf05 clean-up: unused using declarations and includes
Searched source for using declarations.
Checked if those symbols reappear in the source file,
even in comments or dead code but not in #include statements.
If they don't reappear, remove the declaration.
Remove includes whose symbol got removed.

Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0
Reviewed-on: https://gerrit.libreoffice.org/24148
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18 07:25:24 +00:00
81c9d54db3 tdf#91794 removed OSL_DEBUG_LEVEL > 1 conditionals
Removed OSL_DEBUG_LEVEL > 1 conditionals to reduce the
problem of multiple debug levels

Change-Id: I453f74198e08308c3891e923ebaee58a276e34ad
Reviewed-on: https://gerrit.libreoffice.org/22616
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-14 09:25:38 +00:00
9cfa0810bd clang-tidy performance-unnecessary-value-param in chart2
Change-Id: Id33dce9714737dd28ce48c22f966c9747c2db20b
2016-04-12 11:25:18 +02:00
4c7ec9f112 cleanup: remove unused com/sun/star/uno includes
Sequence.h(xx), Any.h(xx) and Type.h(xx)
and remove unused using-declarations from these files.

Add a few missing includes provided by them.

Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4
Reviewed-on: https://gerrit.libreoffice.org/23805
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-12 06:38:26 +00:00
25934decf8 tdf#94306 replace boost::noncopyable in chart2
Replace with C++11 delete copy-constructur
and copy-assignment.
Delete default-constructors when comments suggested it.

Change-Id: Ieeaf6ca998a4165d6eacf5e900c6a09aafdcfbe6
Reviewed-on: https://gerrit.libreoffice.org/23903
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2016-04-08 17:40:14 +00:00
a7ec6c29aa loplugin:constantparam in chart2
Change-Id: I9adcf4516107aaa960463be13090c2ac15685e09
Reviewed-on: https://gerrit.libreoffice.org/23833
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-05 11:30:13 +00:00
f7a75a66fa cleanup: remove unused Reference.h(xx) includes
and unused using-declarations from Reference.h

Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19
Reviewed-on: https://gerrit.libreoffice.org/23735
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-02 19:01:24 +00:00
96c1ae1d8e fix headless build
disables OpenGL and glew usage, lets --without-gui do what
--without-x did before and disables X related test

Change-Id: I680b47c9962a0d43c8ece593db0b82e347ceebdb
Reviewed-on: https://gerrit.libreoffice.org/23474
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2016-03-25 11:05:47 +00:00
a112d3dc70 Move clipboard stuff to the top like in other modules
Change-Id: I0e07e58f058ce7dde57277868597a56273d3b5ce
2016-03-21 13:49:30 +02:00
2d4e9abc07 tdf#93837 chart2: Convert shape context menus to xml
Change-Id: Ie0589c576b26dd74b9bc16d78a37a01c9bb2985e
2016-03-21 13:48:16 +02:00
8353667d35 com::sun::star->css in chart2
Change-Id: I04320d32d6d5c54e461cfabef58645f8b772bc69
2016-03-14 13:43:38 +02:00
ff745fc0d9 loplugin:constantparam in svx
Change-Id: Ib2a432fc334898c75ab5e5cf629a21fd310bd467
2016-03-09 10:07:45 +02:00
a3c70e760f Fix missing iterator include on MSVC 14.0
Change-Id: I55de612aef52038fd9979426950d4ae4131ca586
Reviewed-on: https://gerrit.libreoffice.org/22448
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2016-02-17 23:43:45 +00:00
35f4c0d242 boost::cref->std::cref
Change-Id: I2a4d2052c48f35d69cea2aed2e98079ad8d98a02
Reviewed-on: https://gerrit.libreoffice.org/21982
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-01 11:00:17 +00:00
752cd07d08 InterfaceContainer2 with vector instead of Sequence
create an InterfaceContainer2 class to replace InterfaceContainer.
It uses a std::vector instead of a Sequence for the mutable listener
list, which provides far better performance.

Switch all our internal use-sites to the new class.

Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
2016-01-25 08:52:03 +02:00
5659b68be3 vcl: rename Font::GetFamily to Font::GetFamilyType
Change-Id: Ie427a43bd126dcdd89c6f66582736e67130f2254
Reviewed-on: https://gerrit.libreoffice.org/21633
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-21 06:22:01 +00:00
28c96fc255 vcl: rename Font::GetName to Font::GetFamilyName
Change-Id: Ie20871a3078bf875c1782b7761d60591a9c9704f
Reviewed-on: https://gerrit.libreoffice.org/21529
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-17 23:35:37 +00:00
45654a1d4d revert vcl patch series that brok Mac and Windows
revert:
9bc2f3de8672e812f3a67541c6d7069b434a7e42
 vcl: add comment about ImplFontMetric::{Get|Set}LineHeight()
26371f105bc44e04469ec03fc5bb12505e651c6b
 vcl: FontAttributes::GetSlantType() -> FontAttributes::GetItalic()
2dd0b4317372b8022efe3911b38b4fa02956d8b9
 vcl: font.hxx and metric.hxx cleanup, make ctors explicit and the dtor virtual
5ab13bf3ead3539e4ad847656da81e7eb6029652
 vcl: tabify font.hxx
f99550dae55e40e49bf9c9875053fe2abb4c71ca
 vcl: change Font::SetName() to Font::SetFamilyName()
2b297116cb6bb1061c43e5714e2609c8ee9f57d2
 vcl: rename Font::GetName to Font::GetFamilyName

Change-Id: I23f38921187d66b970ca815eb30dda4222a2da62
2016-01-16 12:20:45 -06:00
2b297116cb vcl: rename Font::GetName to Font::GetFamilyName
Change-Id: I83927e0992dfe0a2a79d139818a9f45d3761aae5
Reviewed-on: https://gerrit.libreoffice.org/21509
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-16 16:11:28 +00:00
608dee4f5f loplugin:privatebase: Make various derivations public
...assuming they were implicitly made private by accident rather than by design.
(And private derivation can cause unexpected failure of dynamic_cast, cf.
63b67ab5cab8cf7576a68cabe5fb1a42c6ad800c "Use public derivation, and remove
then-unnecessary downcasts.")

Change-Id: Id821afba34fd2f155e30fac903567707e46d1fde
2016-01-11 13:17:10 +01:00
64d624b651 Fix typos
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-10 14:17:20 +00:00
5e65c273c6 Fix typos
Change-Id: Ie0578dcca6cbf4edb62544109d616a081888f369
Reviewed-on: https://gerrit.libreoffice.org/21140
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-06 17:04:22 +00:00
e3a31fcca7 loplugin:unusedfields
Change-Id: I979592adb978c3757a1e54615021ee424a2e02bf
Reviewed-on: https://gerrit.libreoffice.org/20892
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-12-24 07:28:28 +00:00
c5458af905 loplugin:unusedfields in chart2
Change-Id: I8203f84ad8b138932c990032e17ea5d2daf384bb
2015-12-23 09:38:46 +02:00
07004a7e9c chart2: add DocumentBaseURL in ChartFrameLoader::load()
... as seen in JunitTest_chart2_unoapi

Change-Id: Ibe0cd210b8f2ddf730483705292e9027654b6fd4
2015-12-15 17:44:37 +01:00