a980b6c8ae
no need for this temporary OString
...
Change-Id: I8b5d69f7e64a83e52a41c285f5ef186a666ccd55
2016-07-16 18:27:14 +02:00
5ce65d04fd
chart2: cleanup local var assignments
...
and remove comments about a gcc 3.3 workaround.
some comments went obsolete with other commits
like 367105e0248c7b80b60b2554d04f5f248b4259b3
Change-Id: I15fff464e2f71a6ade29c141bb17216770f54ced
Reviewed-on: https://gerrit.libreoffice.org/27127
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-07-13 07:26:45 +00:00
0f17e34330
loplugin:singlevalfields in chart2
...
Change-Id: I8b8bf093736a191c90d765dce82b00e15bb398d6
Reviewed-on: https://gerrit.libreoffice.org/26708
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-06-28 08:35:03 +00:00
1df394503f
GSoC notebookbar: switching tabs depending on context
...
+ sfx2::sidebar::EnumContext moved to the vcl module
+ TabPage contains vector with context values
+ vcl builder reads control's contexts from the "class" mark
+ ContextTabControl shows tabs depending on context
Change-Id: I661b0d3f35d46ace2a2e8eb1d374148f0c60017d
Reviewed-on: https://gerrit.libreoffice.org/26447
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
2016-06-27 17:51:56 +00:00
ca6c108caa
Missing break in switch
...
First 749a0845500d69f99bf1901bab82361f67b5e4f6 "don't show area and line panel
in pie chart Chart selection, tdf#94320" added the case OBJECTTYPE_DIAGRAM
falling through to the default break case. Then
14237c1678167da725fee079532c4669264d697f "use trendline context for trendlines,
tdf#94931, tdf#94934" added the case OBJECTTYPE_DATA_CURVE,
OBJECTTYPE_DATA_AVERAGE_LINE block in between.
Change-Id: I9d06b5054128c4a31381e33620f4a2b898e0e969
2016-05-10 17:39:13 +02:00
b2e2400736
no need to copy the list of available commands on every call
...
Change-Id: I131f34a94c998f3dd9fd7a457fb213778040c771
2016-04-25 09:18:12 +02:00
2b68383e44
Kill comphelper::MakeSet
...
Change-Id: I2e5f8c2cd67406d9d275960a37c4aa45e283eec3
Reviewed-on: https://gerrit.libreoffice.org/24343
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
Tested-by: Stephan Bergmann <sbergman@redhat.com >
2016-04-25 06:11:10 +00:00
08bb436ff9
loplugin:salbool: Automatic rewrite of sal_False/True
...
Change-Id: I1230a1785c61b8ef5dab97176e7c06600ac95a5b
2016-04-20 17:25:36 +02:00
81c9d54db3
tdf#91794 removed OSL_DEBUG_LEVEL > 1 conditionals
...
Removed OSL_DEBUG_LEVEL > 1 conditionals to reduce the
problem of multiple debug levels
Change-Id: I453f74198e08308c3891e923ebaee58a276e34ad
Reviewed-on: https://gerrit.libreoffice.org/22616
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2016-04-14 09:25:38 +00:00
9cfa0810bd
clang-tidy performance-unnecessary-value-param in chart2
...
Change-Id: Id33dce9714737dd28ce48c22f966c9747c2db20b
2016-04-12 11:25:18 +02:00
4c7ec9f112
cleanup: remove unused com/sun/star/uno includes
...
Sequence.h(xx), Any.h(xx) and Type.h(xx)
and remove unused using-declarations from these files.
Add a few missing includes provided by them.
Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4
Reviewed-on: https://gerrit.libreoffice.org/23805
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-12 06:38:26 +00:00
a7ec6c29aa
loplugin:constantparam in chart2
...
Change-Id: I9adcf4516107aaa960463be13090c2ac15685e09
Reviewed-on: https://gerrit.libreoffice.org/23833
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-05 11:30:13 +00:00
8353667d35
com::sun::star->css in chart2
...
Change-Id: I04320d32d6d5c54e461cfabef58645f8b772bc69
2016-03-14 13:43:38 +02:00
5e65c273c6
Fix typos
...
Change-Id: Ie0578dcca6cbf4edb62544109d616a081888f369
Reviewed-on: https://gerrit.libreoffice.org/21140
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com >
2016-01-06 17:04:22 +00:00
e3a31fcca7
loplugin:unusedfields
...
Change-Id: I979592adb978c3757a1e54615021ee424a2e02bf
Reviewed-on: https://gerrit.libreoffice.org/20892
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-12-24 07:28:28 +00:00
c5458af905
loplugin:unusedfields in chart2
...
Change-Id: I8203f84ad8b138932c990032e17ea5d2daf384bb
2015-12-23 09:38:46 +02:00
8e234c5b7d
use initialiser syntax for Sequence<OUString>
...
replaced using the script:
git grep -lP 'Sequence.*OUString.*\(1\)'
| xargs perl -0777 -pi
-e "s/Sequence< OUString > (\w+)\(1\);
.*\[0\] = (\S+);/Sequence< OUString > \1 { \2 };/g"
Change-Id: I23688a91562051a8eed11fc2a85599545c285c34
Reviewed-on: https://gerrit.libreoffice.org/19967
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-15 10:13:08 +00:00
40c4a08652
loplugin:nullptr (automatic rewrite)
...
Change-Id: I71de514405bb9bcc746c1ab9633e7fe659888943
2015-11-10 10:31:18 +01:00
065c8b48a6
use uno::Reference::set method instead of assignment
...
Change-Id: I58410209f32f988f258a588364e0b037c2790211
2015-10-30 08:10:22 +02:00
13938d6de8
Replace boost::bind by lambdas in chart2 tree.
...
Change-Id: Ida56649f15b58b3b11b3d43c5017fd5ebd9a2cf1
Reviewed-on: https://gerrit.libreoffice.org/19606
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-27 05:40:46 +00:00
9facb8271d
coverity#1327446 Unchecked dynamic_cast
...
Change-Id: Ib409b7fe4244b89f8767b20adcfae060f121b2f2
2015-10-17 14:46:26 +01:00
14237c1678
use trendline context for trendlines, tdf#94931, tdf#94934
...
Change-Id: I0cb9cdec33924e560b24744cc78d632025a189fc
2015-10-10 15:24:50 +02:00
33972dea7d
correctly dispose the chart sidebar when leaving chart, tdf#94292
...
This is a much better approach than my old one that tried to use the
correct XModel with the chart sidebar. Now everytime we leave the chart
edit mdoe we destroy the chart sidebar panels and recreate them when we
go back to chart edit mode.
As a result we no longer need to have worry that much about using the
correct ChartModel and about the lifecycle of the ChartModel.
Change-Id: Ie85ad82968e20a81f059d4bd930a83a70da35fc9
2015-10-09 20:42:11 +02:00
2b57de8bb0
remove another custom refcounting base class
...
Change-Id: Icd8a8d79da0ada68e9ee869c3c2a7b93db5b2733
2015-10-07 08:27:25 +02:00
749a084550
don't show area and line panel in pie chart Chart selection, tdf#94320
...
Change-Id: I0eacedbb3d96a059278bab0ef98a66ed49b827fc
2015-10-03 16:00:21 +02:00
a6e622480f
Fix typos
...
Change-Id: Icf15b5ea2e5b9cd62645bab2f9ccaada948322a7
Reviewed-on: https://gerrit.libreoffice.org/18940
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
2015-09-30 06:00:42 +00:00
dfbf877856
gcc3 is not supported anymore, so remove that
...
Change-Id: Iddc481e13d40a6399a4a23a45c812b34a3a109f6
2015-09-27 07:54:45 +02:00
4248e89e4b
remove chart sidebar when leaving chart edit mode
...
Change-Id: Ie6fc01b2a610fb861ddade996ebb8480be217085
2015-09-15 01:54:05 +02:00
6f4e11a95b
convert Link<> to typed
...
Change-Id: I2aeda615e39db5a3cd39e168db34425e2912be8b
2015-09-09 10:06:12 +02:00
9022556453
small fix to reduce UnknownPropertyException in chart2
...
accidently introduced with f1531cdaaebe706d909dc6ddde439ccb5f4ad36d
Change-Id: I292097c5f61ecb32a28a90e9f5be48fcfd6bcd7b
2015-07-30 05:45:26 +02:00
b5c0f852b5
update gradients in sidebar as well
...
Change-Id: I0dc737c133e905d75fab23457fb86c8d2b724ce8
2015-07-26 00:26:59 +02:00
0635208edf
handle more than one chart with chart sidebar
...
Change-Id: I4998904a9273f2c67114a246d7f234843602573c
2015-07-26 00:26:55 +02:00
95b1491dac
add chart sidebar axis panel
...
Change-Id: Ia0f75c09f11c5751428a19fca33b39a54cdbb249
2015-07-17 21:12:50 +02:00
75d50b7189
generate correct sidebar context strings for charts
...
Change-Id: I92adf79c461f3536475da318e03b60f2e1adc08f
2015-07-16 22:18:09 +02:00
9ce5cfff0a
enable the chart sidebar again
...
Change-Id: I0ad9d962436562aa1026c50e5ec16f844f889eef
2015-07-16 08:15:20 +02:00
49d2400f8d
remove my accidently committed debug messages
...
Change-Id: Ia890837520b57291ae119de30dc7586b65e30b81
2015-07-16 08:15:18 +02:00
8de7d44f96
disable newly unused code since last disable
...
Change-Id: I9f0abc3963ac4687e29fc629f1b9e9bb1fffaf8a
2015-07-13 20:59:05 +01:00
f90307a937
disable that code for now
...
Change-Id: I9f65babd0314498145746c452180ccf4fab64720
Reviewed-on: https://gerrit.libreoffice.org/17020
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2015-07-13 18:20:05 +00:00
5b16fff9ac
loplugin:staticmethods
...
Change-Id: I8b57b7ce707438ad3c7c901b03c94d9045585ed8
2015-07-13 09:21:51 +02:00
efd13b27a4
finally manage to register chart2 in the ChartController
...
We need to do some jumps through pink hoops to connect the chart
controller with the host sidebar.
Would we use the chart window as parent for our sidebar the sidebar
would be directlz beside the chart and not at the border of the host
window.
Change-Id: Ica44ae370518882ef367999f57251b1256907016
2015-07-12 18:56:48 +02:00
04716cb9ac
add SidebarChangeHandler to chart2
...
I still need to wire the correct frame to the correct sidebar for it to
work.
Change-Id: I0fecc2be674d6b024bc39e707930a4c30f67cb81
2015-07-12 18:56:47 +02:00
4b4c23acc7
fix old GCC build
...
after my commit 10749bbf8247f0b17201b33f95a090dfc4fc3211
"remove the last of the OUString #defines in header files"
Change-Id: I592e918f7b718ddff99a8eaff04b11064fad65d9
2015-05-19 10:11:53 +02:00
e8b97a52c9
Merge remote-tracking branch 'origin/feature/vclptr'
...
Resolve several thousand lines of conflicts.
Conflicts:
accessibility/source/extended/accessiblelistbox.cxx
accessibility/source/standard/vclxaccessiblecombobox.cxx
accessibility/source/standard/vclxaccessibledropdowncombobox.cxx
accessibility/source/standard/vclxaccessibledropdownlistbox.cxx
accessibility/source/standard/vclxaccessiblelistbox.cxx
accessibility/source/standard/vclxaccessibletextfield.cxx
basctl/source/basicide/basidesh.cxx
cui/source/inc/chardlg.hxx
cui/source/tabpages/tpbitmap.cxx
dbaccess/source/ui/dlg/UserAdmin.cxx
dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx
extensions/source/propctrlr/propertyeditor.hxx
extensions/source/scanner/sanedlg.cxx
filter/source/pdf/impdialog.cxx
include/sfx2/mgetempl.hxx
include/sfx2/sidebar/SidebarToolBox.hxx
include/sfx2/viewsh.hxx
include/svtools/brwbox.hxx
include/svtools/filectrl.hxx
include/svtools/scrwin.hxx
include/svx/dlgctrl.hxx
include/svx/sidebar/Popup.hxx
include/svx/sidebar/PopupContainer.hxx
include/svx/sidebar/PopupControl.hxx
include/svx/sidebar/SidebarDialControl.hxx
include/svx/sidebar/ValueSetWithTextControl.hxx
sc/source/ui/condformat/condformatdlgentry.cxx
sc/source/ui/navipi/navipi.cxx
sc/source/ui/sidebar/CellBorderStyleControl.hxx
sd/source/ui/animations/CustomAnimationDialog.cxx
sd/source/ui/inc/DrawViewShell.hxx
sd/source/ui/inc/Ruler.hxx
sd/source/ui/inc/SlideSorter.hxx
sd/source/ui/inc/ViewTabBar.hxx
sd/source/ui/inc/Window.hxx
sd/source/ui/inc/morphdlg.hxx
sd/source/ui/inc/sdpreslt.hxx
sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx
sd/source/ui/sidebar/LayoutMenu.hxx
sd/source/ui/sidebar/MasterPagesSelector.hxx
sd/source/ui/sidebar/NavigatorWrapper.hxx
sd/source/ui/sidebar/PanelBase.hxx
sd/source/ui/sidebar/RecentMasterPagesSelector.cxx
sd/source/ui/sidebar/RecentMasterPagesSelector.hxx
sd/source/ui/slideshow/showwindow.hxx
sd/source/ui/slidesorter/view/SlsInsertAnimator.cxx
sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx
sd/source/ui/view/ViewShellBase.cxx
sd/source/ui/view/drviewsa.cxx
sfx2/source/appl/fileobj.hxx
sfx2/source/appl/opengrf.cxx
sfx2/source/control/thumbnailviewacc.hxx
sfx2/source/dialog/securitypage.cxx
sfx2/source/dialog/templdlg.cxx
sfx2/source/doc/docinsert.cxx
sfx2/source/doc/guisaveas.cxx
sfx2/source/inc/alienwarn.hxx
sfx2/source/sidebar/Deck.cxx
sfx2/source/sidebar/Deck.hxx
sfx2/source/sidebar/DeckTitleBar.cxx
sfx2/source/sidebar/DeckTitleBar.hxx
sfx2/source/sidebar/MenuButton.cxx
sfx2/source/sidebar/MenuButton.hxx
sfx2/source/sidebar/Panel.cxx
sfx2/source/sidebar/Panel.hxx
sfx2/source/sidebar/PanelTitleBar.hxx
sfx2/source/sidebar/SidebarDockingWindow.hxx
sfx2/source/sidebar/SidebarToolBox.cxx
sfx2/source/sidebar/TabBar.hxx
sfx2/source/sidebar/TabItem.cxx
sfx2/source/sidebar/TabItem.hxx
sfx2/source/sidebar/TitleBar.hxx
sfx2/source/toolbox/imgmgr.cxx
starmath/inc/edit.hxx
starmath/inc/smmod.hxx
starmath/qa/cppunit/test_starmath.cxx
starmath/source/edit.cxx
starmath/source/smmod.cxx
svtools/source/brwbox/brwbox1.cxx
svtools/source/brwbox/datwin.hxx
svtools/source/contnr/fileview.cxx
svtools/source/contnr/simptabl.cxx
svtools/source/control/filectrl.cxx
svtools/source/control/valueimp.hxx
svx/inc/GalleryControl.hxx
svx/source/dialog/dlgctrl.cxx
svx/source/dialog/swframeexample.cxx
svx/source/fmcomp/fmgridif.cxx
svx/source/gallery2/GalleryControl.cxx
svx/source/sidebar/EmptyPanel.hxx
svx/source/sidebar/area/AreaPropertyPanel.hxx
svx/source/sidebar/area/AreaTransparencyGradientControl.hxx
svx/source/sidebar/graphic/GraphicPropertyPanel.hxx
svx/source/sidebar/insert/InsertPropertyPanel.cxx
svx/source/sidebar/insert/InsertPropertyPanel.hxx
svx/source/sidebar/line/LinePropertyPanel.hxx
svx/source/sidebar/line/LineWidthControl.cxx
svx/source/sidebar/line/LineWidthControl.hxx
svx/source/sidebar/line/LineWidthValueSet.hxx
svx/source/sidebar/paragraph/ParaPropertyPanel.hxx
svx/source/sidebar/possize/SidebarDialControl.cxx
svx/source/sidebar/text/TextCharacterSpacingPopup.hxx
svx/source/sidebar/text/TextPropertyPanel.hxx
svx/source/sidebar/tools/PopupContainer.cxx
svx/source/sidebar/tools/PopupControl.cxx
svx/source/sidebar/tools/ValueSetWithTextControl.cxx
svx/source/svdraw/svdfmtf.hxx
svx/source/svdraw/svdibrow.cxx
svx/source/tbxctrls/colrctrl.cxx
svx/source/tbxctrls/tbcontrl.cxx
sw/source/ui/dbui/mmaddressblockpage.cxx
sw/source/ui/dialog/uiregionsw.cxx
sw/source/ui/index/cnttab.cxx
sw/source/uibase/inc/drpcps.hxx
sw/source/uibase/sidebar/PageColumnControl.hxx
sw/source/uibase/sidebar/PageMarginControl.hxx
sw/source/uibase/sidebar/PageOrientationControl.hxx
sw/source/uibase/sidebar/PagePropertyPanel.hxx
sw/source/uibase/sidebar/PageSizeControl.hxx
sw/source/uibase/uiview/view2.cxx
sw/source/uibase/utlui/navipi.cxx
vcl/inc/svdata.hxx
vcl/source/control/combobox.cxx
vcl/source/control/lstbox.cxx
vcl/source/window/dockwin.cxx
vcl/source/window/winproc.cxx
Change-Id: I056cf3026ff17d65cca0b6e6588bda4a88fa8d95
2015-04-28 15:08:48 +01:00
e19cd844be
Rephrase comparisons between bool and sal_Bool
...
...to cater for forthcoming loplugin:implicitboolconversion improvements
Change-Id: I801b6b73648715448198d582a087cc834f6e20c8
2015-04-28 10:21:01 +02:00
5ea025e637
chart2: convert new to ::Create.
...
Change-Id: I14887bab5ced6e5915a8ecbc277017cec37a82ca
2015-04-17 22:01:46 +01:00
8a65284fe3
Automated conversion of VclPtr construction to use Instance template.
...
Change-Id: I8be9141b9653e73ebd23a5a3d810f240c376f97e
2015-04-10 13:40:25 +01:00
61b224f392
vclwidget: fixup locally allocated vcl::Window objects
...
They need to be wrapped in ScopedVclPtr in order to be disposed properly.
Change-Id: Ib64dba353774f54711e4de7f5d15d859c6a4dc7e
2015-04-10 12:37:44 +01:00
00f2787a4a
vclwidgets: wrap all vcl::Window subclasses allocated on stack in VclPtr
...
Change-Id: Ia8b0d84bbf69f9d8f85505d019acdded14e25133
Conflicts:
sw/qa/tiledrendering/tiledrendering.cxx
2015-04-09 22:17:00 +01:00
ffe060e954
V668 no sense in testing the result of new against null
...
Change-Id: I7783d96e40de7a8df794f143d2c7830bf3314218
2015-03-11 01:16:33 +00:00
df15d179a0
Typo: relaese->release
...
Change-Id: I9e2e8f11c376fc808b12bc1db509babeac0ff7d8
2015-02-08 14:27:03 +01:00
