Commit Graph

3134 Commits

Author SHA1 Message Date
05676088e2 cui: fix Android build
Change-Id: I6396d7702de42ad2cec3843e919cca084e92c008
2016-07-28 10:33:53 +02:00
5e0b0de0af Bug fix: Fill bitmap item set only when bitmap tab is selected
Change-Id: I9bb7bdeecfcd51e8191f82c649585af8458f1001
Reviewed-on: https://gerrit.libreoffice.org/27578
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-27 14:00:39 +00:00
187044b5e8 loplugin:vclwidgets
Change-Id: Ie16efa4a66cc3ea1991878f20442f0c0bac79d10
2016-07-27 10:23:13 +02:00
702e26d656 loplugin:passstuffbyref
Change-Id: I37cc39974784e59aa793c2a2ca0dbc59d00e3cb4
2016-07-27 10:23:13 +02:00
7438bc1f0c [GSoC] Remove bitmap controls from area tab
Change-Id: Ie8d62b42c9b5ce9a4d087d809e7c395b8c71e667
Reviewed-on: https://gerrit.libreoffice.org/27024
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-26 19:31:28 +00:00
a44a0690da [GSoC] Add Bitmap tab to area dialog
Change-Id: I6549e7eb4efd24d035b0383a750698a4c3f16cf7
Reviewed-on: https://gerrit.libreoffice.org/27546
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-26 18:33:01 +00:00
a860df25dd masses of MessBoxes not being disposed promptly
since...

commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f
Date:   Thu May 28 21:35:43 2015 +0100

    tdf#91702 - fix stack-based MessBox allocation.

There is no special ScopedVclPtr<X>::Create or
ScopedVclPtrInstance<X>::Create just
VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo
doesn't call dispose on the owned X

Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
2016-07-26 11:26:52 +01:00
938821fb08 new loplugin overrideparam
verify that parameters on override methods have the same set of default
values for their params as their parent/super-methods do.

Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2
Reviewed-on: https://gerrit.libreoffice.org/27437
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-25 06:09:17 +00:00
c1bd3156cf Resolves: tdf#101054 crash on options->path with non-native file picker
regression from...

commit 3bbc0574d78d129359638b74612de2f93419eeb0
Author: Caolán McNamara <caolanm@redhat.com>
Date:   Tue Jul 5 10:16:51 2016 +0100

    Resolves: rhbz#1352835 path options doesn't promptly destroy folder picker

only clear the xFolderPicker immediately in the non-async case

Change-Id: Id6a411424d41262a9379ad3eb7976c8dd666a5cf
2016-07-21 21:45:29 +01:00
6f2b129a8e Minor UI changes for SvxPresetListBox
1. Reduced item icon size.
2. Add slider depending on the number of entries.

Change-Id: I1fad15861438952664c26666afe89fffa08051f6
Reviewed-on: https://gerrit.libreoffice.org/27389
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-21 19:46:22 +00:00
56823b52e5 compile fix
Change-Id: I1d1dc12b6c2ff3ea8d8ba4593bd94e02a87a9c35
2016-07-21 09:24:31 +02:00
2cdc10d66b loplugin:vclwidgets
Change-Id: I264644d1fb3582168879d47d0d538bef27902573
2016-07-21 09:22:24 +02:00
45e9ccb699 Remove PatternLB dead code
PatternLB is replaced by SvxPresetListBox in tppattern.cxx

Change-Id: Ie4ec100963b714e07807f8b600cca2e165fb4641
Reviewed-on: https://gerrit.libreoffice.org/27353
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-21 06:20:44 +00:00
74aa685bf3 [GSoC] Redesign of Pattern tab
1. New Pattern Listbox for presets.
2. Context menu for Rename and Delete.
3. Rearrangement of controls.
4. Remove Save and Load buttons.

Change-Id: I7edaf2496837443967711a307c01cdba284270d0
Reviewed-on: https://gerrit.libreoffice.org/27352
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-20 20:26:04 +00:00
b184c54a51 loplugin:vclwidgets
Change-Id: I0a762a0eaa6cc9dc2f3c41b456faf98b919181ba
2016-07-20 08:44:13 +01:00
ea96d97020 tdf#100907: Cannot set white background for hatching
Change-Id: Id10cb4d90a19717b44d02064eb69981c69a421de
Reviewed-on: https://gerrit.libreoffice.org/27258
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-19 18:32:47 +00:00
1d60208813 Fix regression : Automatic gradient steps in gradient tab
Adds a checkbox for enabling/disabling automatic gradient steps.

Change-Id: I223279ec0f23f20f3ff544072cc7fd8662946296
Reviewed-on: https://gerrit.libreoffice.org/27269
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-19 18:25:14 +00:00
da4c58551c [GSoC] Redesign of Gradient tab
1. New Gradient Listbox for presets.
2. Context menu for rename and delete.
3. Rearrangement of controls.
4. Remove Save and Load buttons.

Change-Id: Id6aa0daa7c9304bb6a383ce0db95a4a7a060695e
Reviewed-on: https://gerrit.libreoffice.org/26954
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-19 18:21:50 +00:00
36313d93ac improve unnecessaryoverride plugin
to ignore ImplicitCastExpr when calling superclass method

Change-Id: I76a3068446acfee85aa1baeb216e57f63c7099c1
Reviewed-on: https://gerrit.libreoffice.org/27279
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-19 05:39:46 +00:00
ea3f74ba0a Resolves: tdf#99963 line wrap very long checkbox content
Change-Id: I11ab52b8c6600d5d479ac3d4d2cd78d1957d8676
2016-07-18 16:12:40 +01:00
a268011a6f -fsanitize=signed-integer-overflow
Change-Id: I1a79d34dd25073de46bda47af1789fd7e69fe648
2016-07-18 14:46:38 +02:00
25ab24b4c4 Resolves: tdf#100896 crash in hyperlink dialog
regression from...

commit 98747742b20c82382ed16b193e7bec175e905978
Author: Noel Grandin <noel@peralex.com>
Date:   Fri Jun 24 13:12:25 2016 +0200

    loplugin:singlevalfields in cui

which cut too deep

Change-Id: I0e42eed48196c9e037ba343eea93c2c854c0991c
2016-07-18 09:00:06 +01:00
1bc9a5a909 odd SvxBitmapCtl is used in only one place
Change-Id: I82a4c8f2e36153b0bc59571ce39956637e278fcb
2016-07-18 09:00:06 +01:00
76258ecb71 SvxBitmapCtl::nLines is never read
Change-Id: Ib03eb766b1f45247204e64543dbf80c24f8608c7
2016-07-18 09:00:06 +01:00
6e72f0251b new loplugin unnecessary override
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb
Reviewed-on: https://gerrit.libreoffice.org/27135
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-15 14:05:41 +00:00
be95afad42 [GSoC] Avoid reload of preset list in hatch tab
Change-Id: If2acb6df3c046de63b6b4069474e19fb87222a11
Reviewed-on: https://gerrit.libreoffice.org/27167
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-07-14 09:12:23 +00:00
8b04b9f465 Remove wrong, needless downcast
...from SaveInData (which has a virtual dtor) to MenuSaveInData, while the data
could also be ContextMenuSaveInData (not derived from MenuSavaInData).

Change-Id: I4928fa97ed7738516699f8e57f354ef0f334c4f1
2016-07-13 17:56:18 +02:00
4ebbb996ac make sure that the thread has joined before disposing UI elements
See e.g.
http://crashreport.libreoffice.org/stats/crash_details/80884848-16e7-4512-be4a-74c53bfce34b#allthreads

The thread can run while the UI elements have already been disposed. The
StopExecute call is not enough to prevent that from happening.

Change-Id: Iab4209776e1403a6520c106f3521476ee50848a4
Reviewed-on: https://gerrit.libreoffice.org/27087
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-13 09:23:04 +00:00
cba5a9223a no need to create temporary OUString for comparison
Change-Id: I0a321e8ffbe379588a288084ec2e74e1a8c296b2
Reviewed-on: https://gerrit.libreoffice.org/27171
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-13 08:20:40 +00:00
f7b1cd6616 Moved SfxModule owner to SfxApplication
::GetAppData replaced with SfxApplication::GetModule
that now returns SfxModule*

SfxModule no longer registers self for ownership
instead it is now registered using SfxApplication::SetModule

Change-Id: Ifbbe1b2b4c5122da8e643b7926d47878d116c6c8
Reviewed-on: https://gerrit.libreoffice.org/26914
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-13 06:32:46 +00:00
3fa31e2248 removed deprecated FileDialogHelper::SetDisplayDirectory
and convert usage of it

Change-Id: I2e3a71ec94492e5482bdf720d256e67adaf3f095
Reviewed-on: https://gerrit.libreoffice.org/26951
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-11 07:31:26 +00:00
60362e62ad rename variable to reflect that it is not a reference
Change-Id: Ifcc15e2a500bdc77dd21e96eea3873c3e78e7e55
Reviewed-on: https://gerrit.libreoffice.org/27086
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-11 05:28:14 +00:00
435be8e8e1 Remove redundant SvxGet* wrappers around LinguMgr functions
Change-Id: Ic431ce4880d0c1277ddb411ca59b3c8e8ca36518
2016-07-10 22:08:12 +02:00
ec950f8ebb ditch the font/screen-scaling thing
its of limited utility wrt the vcl layout work and optimal size widgets,
and its confuses people looking for hidpi settings

Change-Id: I37d21b480446f9fe2845b3a2d9fd59cdeddf1a93
2016-07-10 19:12:39 +01:00
aae1018af6 SvxGetOrCreatePosDic parameter is unused
...ever since fd069bee7e57ad529c3c0974559fd2d84ec3151a "initial import", so kill
the equally old "TODO: remove argument or provide SvxGetIgnoreAllList with the
same one" comment for good now

Change-Id: Ie7b64306b8d06fc72d0bb49cc1e5fa3b00f59d6b
2016-07-08 18:20:39 +02:00
45755853b8 loplugin:redundantcast: redundant static_casts in cui
Change-Id: I97385a4fade4794f5aebd0b65eaf4c92ed06bd66
2016-07-08 16:47:31 +02:00
af69de6344 Use PageNumberListBox in cui
Change-Id: Id7e71ade1946b5f33701a71073f1cc5a7870af6a
Reviewed-on: https://gerrit.libreoffice.org/26564
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-07-08 14:09:01 +00:00
269a888905 loplugin:passstuffbyref also for {css::uno,rtl}::Reference
Change-Id: I51957af512cae8ec838fd9b14bd576356edd2611
2016-07-07 18:59:55 +02:00
c56974019c Reload the preset list after deletion
ValueSet assign Ids to entries when the list is loaded.
Ids are not changed after deleting entries.

Change-Id: Ia4442992561bf2cd82ff325abef8e34715851e1d
Reviewed-on: https://gerrit.libreoffice.org/26986
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Rishabh Kumar <kris.kr296@yahoo.in>
2016-07-06 22:01:26 +00:00
50ba4a079e Redesign of Hatch tab
1. New Hatch Listbox for presets.
2. Context menu for rename and delete.
3. Rearrangement of controls.
4. Remove Save and Load Buttons.

Change-Id: Iad2479bc418f7a257a410df7f11c23ed8dd7734c
Reviewed-on: https://gerrit.libreoffice.org/26869
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-07-06 09:39:34 +00:00
724e6762a5 loplugin:vclwidgets
Change-Id: Id276128a249aeac98ac3374b975bf1cd946d5aa7
2016-07-06 09:38:36 +02:00
716844c6ab restore loplugin:vclwidget checking for calling clear() on VclPtr fields
Change-Id: I85eda1c33016c1461d897fc0a3b70457209a7405
Reviewed-on: https://gerrit.libreoffice.org/26806
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-06 06:38:30 +00:00
2a23d9cc4d when disposing popup menus, don't leave dangling pointers
Change-Id: Ia1b49937ba0693a567097367b99b75a3011666bf
Reviewed-on: https://gerrit.libreoffice.org/26960
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-07-05 21:04:15 +00:00
adc3932dfc cui: add calculation mode to Help->About.
Change-Id: I4765436bed8a58c5097afcf7dce768d3ec325015
Reviewed-on: https://gerrit.libreoffice.org/26964
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-07-05 20:40:20 +00:00
3bbc0574d7 Resolves: rhbz#1352835 path options doesn't promptly destroy folder picker
Change-Id: I5133f63fd92f384221fa2812c6e2a0e7f3b37ac1
2016-07-05 10:17:22 +01:00
7855ea4830 remove comphelper::string::remove
and replace it with OUString/OString::replaceAll

Change-Id: I37b1c3b51251dfd9d749d6f1060c75b3a93d7f1a
Reviewed-on: https://gerrit.libreoffice.org/26850
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04 06:49:52 +00:00
cd71034b26 comphelper::OBaseMutex -> cppu::BaseMutex
convert usage of deprecated class, and remove the old class

Change-Id: I19fb9271090d19e5531622b58492e1a848d306e2
Reviewed-on: https://gerrit.libreoffice.org/26843
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04 06:49:07 +00:00
428e23f4f7 Fix some spelling errors in comments and strings
Change-Id: Iecd6b5e13d6be14651f77d8e37f01117ba15a11e
Reviewed-on: https://gerrit.libreoffice.org/26883
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-07-04 06:11:36 +00:00
68900bad94 tdf#57950: Replace chained OUStringBuffer::append() with operator+
Change-Id: I5e6cb493a5e742232cd312014d4b5b2820cf8314
Reviewed-on: https://gerrit.libreoffice.org/26878
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-03 15:48:42 +00:00
527b88efbd tdf#100728: Crash when area dialog is opened
Change-Id: I2246c5bf3a1d33e7a08fa9062e568a4c95fef571
Reviewed-on: https://gerrit.libreoffice.org/26875
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Rishabh Kumar <kris.kr296@yahoo.in>
2016-07-02 20:34:35 +00:00