Commit Graph

6926 Commits

Author SHA1 Message Date
508c95f1b6 improve passstuffbyref return analysis
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c
Reviewed-on: https://gerrit.libreoffice.org/27317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-27 06:48:25 +00:00
e6d2827fc3 tdf#62525 vcl: use cow_wrapper for PPTCharPropSet
Change-Id: I506688a495ac145a25d2094be48ea53497d1e8a8
Reviewed-on: https://gerrit.libreoffice.org/25914
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-15 07:26:48 +00:00
518d998e47 loplugin:passstuffbyref also for {css::uno,rtl}::Reference
Change-Id: I121d77de11705a4314b875374bf9f499a8afff47
2016-07-07 18:59:55 +02:00
fb04551753 crashtesting: assert on export of tdf99571-1.docx to docx
Change-Id: I2c8d82ac21451a2d2cc748dc28ac210c8e5ddf5f
2016-07-07 16:45:08 +01:00
716844c6ab restore loplugin:vclwidget checking for calling clear() on VclPtr fields
Change-Id: I85eda1c33016c1461d897fc0a3b70457209a7405
Reviewed-on: https://gerrit.libreoffice.org/26806
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-06 06:38:30 +00:00
b6b34d5383 Clarify calculation precedence tdf#39440
Use parentheses to clarify the code.

Change-Id: I864dc6dacadb5b9ba9dca8e0abd9fa4e6db1eddc
Reviewed-on: https://gerrit.libreoffice.org/25677
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-05 09:35:40 +00:00
add9a35ba6 merge CGMOutAct with CGMImpressOutAct
Change-Id: I4d3d59b6c34edef9cd5bfd460f6379e4d1afa460
Reviewed-on: https://gerrit.libreoffice.org/26930
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-05 08:24:18 +00:00
428e23f4f7 Fix some spelling errors in comments and strings
Change-Id: Iecd6b5e13d6be14651f77d8e37f01117ba15a11e
Reviewed-on: https://gerrit.libreoffice.org/26883
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-07-04 06:11:36 +00:00
d3f5800a96 svg-export - Removal of the SVG 1.1 path API in Chrome
On Chrome browser most of shape effects and slide transitions did not
work anymore: that was due to the fact that several animations exploit
the DOM api for handling path segments of the svg:path element.
Starting from version 48 such an api has been removed from Chrome:
https://bugs.chromium.org/p/chromium/issues/detail?id=539385 ;
Moreover Chrome does not yet provide an implementation for the new
svgpath api introduced in SVG 2.0 draft: so there is no native support
for handling path data directly.

The present patch adapts the JavaScript implementation of the old SVG
1.1 path api proposed here: https://github.com/progers/pathseg .

Change-Id: I536202291e0b8895f91d9e499a32fa57c110b2c1
Reviewed-on: https://gerrit.libreoffice.org/26839
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-07-01 11:55:32 +00:00
546c3469af bccu#1910 - better handling of not supported animation nodes.
Earlier, when a not supported animation node was hit all effects in
the same slide was ignored since the whole animation tree was
invalidated. This patch tries to minimize the impact of this issue by
removing only all children nodes of the direct parent container of the
not supported animation node.

Change-Id: I31896cf29d18e64ff44d7d4bcdc60392ac1c1ec3
Reviewed-on: https://gerrit.libreoffice.org/26838
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-07-01 09:53:44 +00:00
232541ef25 bccu#1900 - added support for discrete activities
Change-Id: Ib11f32faf50ba9616b0d5d517ae3820806ed42d2
Reviewed-on: https://gerrit.libreoffice.org/26837
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-07-01 09:53:07 +00:00
a3dae1ec55 bccu#1900 - additive and calc mode were not parsed correctly
Change-Id: I00c4af6a6c992fc41c4b993621cded59800b5e06
Reviewed-on: https://gerrit.libreoffice.org/26836
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-07-01 09:52:27 +00:00
14272dde34 bccu#1870 - added support for rotate attribute
Change-Id: I0b29fa65171c12c25122176af3c9b4e7a9c0826f
Reviewed-on: https://gerrit.libreoffice.org/26835
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-07-01 09:51:41 +00:00
e545a16689 avoid 'Compiler Error C2026 string too big, trailing characters truncated'
Change-Id: I57e74cbf7bf3a51f73f554c1f17b8c4420a1e386
Reviewed-on: https://gerrit.libreoffice.org/26834
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-07-01 09:51:04 +00:00
6b400cd64e bccu#1800 fix bogus loops in slide animations and transitions
Change-Id: Ic0b6a7b526f4ae09653d29f73bff7fde78a25cbf
Reviewed-on: https://gerrit.libreoffice.org/26833
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-07-01 09:50:27 +00:00
27b3bfbe31 loplugin:stringconstant
Change-Id: Ie5aee19517cff0c724f03f73c0e79a057ae9c2b6
2016-07-01 11:48:10 +02:00
3a944846a8 loplugin:defaultparams
Change-Id: I359b7c58fed6343f58a75bc2afedb78ff7c16719
2016-07-01 11:45:47 +02:00
880c6e40f6 bccu#1307 - svg filter - added support for clip region meta action
Change-Id: I90beea5e101a14f0dc9df8c7db0bb55782aba110
Reviewed-on: https://gerrit.libreoffice.org/26832
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-07-01 09:42:35 +00:00
0f95f4f99c svg filter - rewritten context handling
Change-Id: I9c18f6ca641de2957cbbf8fd57035f5aa2e5c294
Reviewed-on: https://gerrit.libreoffice.org/26831
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-07-01 09:41:58 +00:00
1085035078 svgfilter - polish code formatting
Change-Id: Ic63cfeb352326f3375ba664a775e58c566901320
Reviewed-on: https://gerrit.libreoffice.org/26830
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-07-01 09:41:20 +00:00
8dfeaeae47 lool - bccu#1307 - stop colors for background gradient was wrong
Change-Id: Ic5ddd4d3a3018c014a77b2e54d639b5589f9d477
Reviewed-on: https://gerrit.libreoffice.org/26829
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-07-01 09:40:40 +00:00
43e8c76321 lool - bccu#1307 - images must be scaled in a non-uniform way
Change-Id: I4093452d543ba45d8c1a2c1fc0811646e12c23a5
Reviewed-on: https://gerrit.libreoffice.org/26828
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-07-01 09:40:14 +00:00
2a4c68a6ff loplugin:singlevalfields in filter
Change-Id: I6f7220e54178ba9e2c25adda2c1e048d3a222d43
Reviewed-on: https://gerrit.libreoffice.org/26709
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-28 06:25:08 +00:00
eca4625cfd clang-analyzer-deadcode.DeadStores
Change-Id: I4715798922e1210babe93d861594d48bdd850bfd
2016-06-27 17:02:36 +02:00
7d76bb251e vcl: add graphic export-as-pdf filter
In case the metafile was imported from a PDF originally, then this
allows storing the PDF stream next to the graphic. This means that e.g.
in Writer choosing 'Save' from the context menu of the graphic can write
the original PDF stream, not the replacement metafile.

Change-Id: I4ab45d5af17fe46d7538df6d79d6b57ed163572a
Reviewed-on: https://gerrit.libreoffice.org/26628
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-06-24 11:51:01 +00:00
920d4463f6 loplugin:singlevalfields in vcl(part1)
Change-Id: I0031199937cc95793951a070c4b3d8910933e69f
Reviewed-on: https://gerrit.libreoffice.org/26595
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-24 10:51:45 +00:00
aaed6fe55a integrate libzmf
Change-Id: I0c7ea5b56ea4ed4839ff38798c0b915aaca81774
Reviewed-on: https://gerrit.libreoffice.org/26574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
2016-06-23 15:39:52 +00:00
878a860dff vcl: add initial PDF import-as-graphic filter
This allows Insert -> Image e.g. in Writer to read a PDF file, and
insert the metafile equivalent of the first page into the document.

Currently the original PDF document is lost on import (unlike when
inserting an SVG file).

Change-Id: Ib0472c5d9bd9a1da054353fa3a3a638a1052721e
Reviewed-on: https://gerrit.libreoffice.org/26586
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-06-23 15:25:07 +00:00
9b9e5cfd2f tdf#99589 - tolower / toupper - dangerous to Turks ...
Change-Id: I8b0fe9354232a7b60f3605fa6f90f6741f7bf683
Reviewed-on: https://gerrit.libreoffice.org/26537
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-23 09:59:49 +00:00
82da3d95c1 loplugin:salbool: Implicit conversions from non-Boolean fundamental types
Change-Id: I67eac95686678e6f5a2d60798535b2c65a9ba5d7
2016-06-19 21:29:43 +02:00
48b7176fc0 Remove the "using namespace std" from filter
Change-Id: Ied355374a0bf662a9be70d83615446cbac9ee0b2
Reviewed-on: https://gerrit.libreoffice.org/26373
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-17 07:41:32 +00:00
a00757e75b Move accessibility relations to .ui files, Part 9: tdf#87026
By removing unnecessary variables/strings/function calls,
and making proper changes in the related .ui files.

Change-Id: I52e3f2a16519aee13b06f0efc6beb3385bcb0f1c
Reviewed-on: https://gerrit.libreoffice.org/26066
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-15 20:26:35 +00:00
cef14b816a tdf#42949: clean up includes in include/filter with iwyu
Change-Id: Id08a999764bfeeff3bb3409b46f48b278009ccbe
Reviewed-on: https://gerrit.libreoffice.org/26238
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-15 09:32:21 +00:00
e2574399f7 loplugin:sallogareas
Change-Id: Ib28e76ed6947431c6466d11aaadca8d95abfc275
2016-06-13 08:51:57 +02:00
d3c96c9f82 Fix typos
Change-Id: Ic3efae53430fbb2c1eb7962c3cf69bf99315e55b
Reviewed-on: https://gerrit.libreoffice.org/26202
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-13 06:04:07 +00:00
272a8afa60 convert more DBG_ASSERT(false to SAL_WARN
Change-Id: Ie52f28f28c67a91c4d3d4517d5c6a466890c7a55
Reviewed-on: https://gerrit.libreoffice.org/26195
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-12 18:10:44 +00:00
ab10f9fc11 convert DBG_ASSERT(false, to SAL_WARN(
Change-Id: I400d728c5d99228c5ca52e369037395b4da2af5c
Reviewed-on: https://gerrit.libreoffice.org/26187
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-12 09:04:15 +00:00
c0d7dfa56c BASIC : Add SbModule::FindMethod
Change-Id: I3418c4a3d24b3b6630d6c80a6c8aa9d4ffb7e73a
Reviewed-on: https://gerrit.libreoffice.org/24346
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-12 07:43:03 +00:00
e4eb0f6ece Clean up uses of Any::getValue() in filter
Change-Id: I4cd1b554be56d4d43db4108925397a8498781491
2016-06-10 18:55:19 +02:00
7846169215 dispose of ImplEscherExSdr correctly
to remove the warnings messages, and turn the warn into an assert to
prevent it coming back

Change-Id: Ie754ac07f8bb505439a1194f843d09c396353aa6
2016-06-10 13:40:24 +02:00
a97b392879 tdf#94698 cleanup Makefiles. Get rid of udkapi and offapi
This patch changes occurences in makefiles
from
$(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \
	udkapi \
	offapi \
))

to
$(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config))

(corrected instead of abandon, jani)

Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e
Reviewed-on: https://gerrit.libreoffice.org/23426
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-09 09:47:11 +00:00
22fa9289fd tdf#96099 Remove various smart pointer typedefs
Change-Id: I76843139e43ca1c158a977e24d210d5af93e4d0f
Reviewed-on: https://gerrit.libreoffice.org/26014
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08 11:09:44 +00:00
f595e70cfe Simplify GfxLink using smart pointers
Uses std::shared_ptr for sharing graphic data

Changed constructor to std::unique_ptr<sal_uInt8[]> to ensure
the delete[] operator is called when GfxLink internals takes
ownership of the data

Change-Id: I4edd4634df8d6ba4d94953260c1a7ac560ccf04a
Reviewed-on: https://gerrit.libreoffice.org/25402
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08 11:05:30 +00:00
7a11763823 tdf#99589 tolower / toupper - dangerous to Turks ...
used 'toAsciiUpperCase()' and 'isAsciiUpperCase()' from rtl/character.hxx

Change-Id: Iafbf97c4e2f026443411cf080ba2f0872b726bbe
Reviewed-on: https://gerrit.libreoffice.org/25877
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-07 09:24:56 +00:00
62d270116b tools: rename SvStream::Read/Write to ReadBytes/WriteBytes
Change-Id: Ib788a30d413436aa03f813aa2fddcbc4d6cd2f9a
Reviewed-on: https://gerrit.libreoffice.org/25972
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-06 18:09:11 +00:00
da4f7d5d76 filter: "tga" import: fix some endian issues in ImplReadPalette
Change-Id: Ia8ec7b7e19cf9b6b19497cbd77ae5a4e2fdccee7
2016-06-06 14:49:31 +02:00
6325cdb735 filter: PPT import: PptPlaceholder is 1 byte large
The array of 8 bytes corresponds to 8 enum values and is read directly
in ReadPptSlideLayoutAto(); this was wrongly converted to enum.

(regression from e5a03da8eb02c333502d6b427625e7bf554ff203)

Change-Id: I5757e06459467b3c84c4a404493fa3be23e4e9a0
2016-06-06 14:49:30 +02:00
b2abb97a65 tdf#96099 Reduce number of typedefs used for trivial container types
Change-Id: Iecf8052d3f7ec5593205184622d53550e6a52161
Reviewed-on: https://gerrit.libreoffice.org/25836
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-06-04 00:17:00 +00:00
52225a3b7f Convert ComplexTextLayoutMode to scoped enum
Change-Id: I257f8e15fec92f0701235a6fe4b6a2272498c4f1
Reviewed-on: https://gerrit.libreoffice.org/25667
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03 11:34:23 +00:00
f3c1d240bd loplugin:constantparams
Change-Id: Ib162ba9297b9d900ea42c7e5216e152d3e58a361
Reviewed-on: https://gerrit.libreoffice.org/25769
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03 09:08:42 +00:00