wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
395,083 Commits 5 Branches 0 Tags
8a6b2fb5b94de43316ab3ea95ff07cf5f46b6134
Commit Graph

342 Commits

Author SHA1 Message Date
Noel Grandin
6e72f0251b new loplugin unnecessary override 
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb
Reviewed-on: https://gerrit.libreoffice.org/27135
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2016-07-15 14:05:41 +00:00
Noel Grandin
cd71034b26 comphelper::OBaseMutex -> cppu::BaseMutex 
convert usage of deprecated class, and remove the old class

Change-Id: I19fb9271090d19e5531622b58492e1a848d306e2
Reviewed-on: https://gerrit.libreoffice.org/26843
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-04 06:49:07 +00:00
Noel Grandin
6cd3882bec remove some manual ref-counting in forms 
Change-Id: I6334dca6e98bfd4531033bec203518ca27f64bc0
Reviewed-on: https://gerrit.libreoffice.org/26049
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-08 10:32:56 +00:00
Noel Grandin
4cad126dc1 split AddRemoveListener into two methods 
Change-Id: I247dc8a9033b39d5e49dc06e725f638644fcd02d
 2016-06-08 10:20:58 +02:00
Noel Grandin
1342818790 convert SFXWB file dialog flags to scoped enum 
Change-Id: I1ab5191dc582c46785da58d50b2e68c30b5cbc9b
Reviewed-on: https://gerrit.libreoffice.org/24881
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-12 06:57:19 +00:00
Noel Grandin
5e4fc95409 clang-tidy modernize-loop-convert in f* 
Change-Id: Id866aa244378758e3bdb9e99d02cdd2ae6104e16
 2016-04-27 15:03:40 +02:00
Stephan Bergmann
bfb185c408 loplugin:salbool: Automatic rewrite of sal_False/True 
Change-Id: I74cf43df85a878ee9af69901b2535f63461cb61e
 2016-04-20 17:25:41 +02:00
Jochen Nitschke
322eaf80a7 cppcheck: silence known condition warning in forms 
Change-Id: I191dc169eea01d49ee357716a6bcc249e91437ec
Reviewed-on: https://gerrit.libreoffice.org/24201
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2016-04-18 15:54:48 +00:00
Noel Grandin
62633dfe02 clang-tidy performance-unnecessary-value-param in various 
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907
Reviewed-on: https://gerrit.libreoffice.org/24019
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-14 11:37:19 +00:00
Wastack
20ba5d464a tdf#97966 Drop 'static' keywords 
Including no keywords from extern "C" blocks

Change-Id: I8bcd7e8a492ee4dbfa5141416c7c038a1391cf20
Reviewed-on: https://gerrit.libreoffice.org/23673
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2016-04-01 06:45:36 +00:00
Wastack
ce549d2a09 tdf#97966: Remove 'static' keywords 
Change-Id: Iced527f48afa828cc9acf5b6461674a2706cbcd7
Reviewed-on: https://gerrit.libreoffice.org/23135
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2016-03-11 08:59:30 +00:00
Noel Grandin
b0e18a68c8 loplugin:unuseddefaultparam in forms 
Change-Id: I5a2b50163acfda3878fe5625a605e3437a7cc700
 2016-03-02 07:57:38 +02:00
Chris Sherlock
a238b1f8d3 Remove excess newlines 
A ridiculously fast way of doing this is:

for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
  --exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
    perl -0777 -i -pe 's/^
{3,}/

/gm' $i
done

Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-02-09 08:18:05 +00:00
Chris Sherlock
697d445ed0 vcl: take into account the font width is the average font width 
I'm changing the Font class function names:

- SetSize       -> SetFontSize
- GetSize       -> GetFontSize
- SetHeight     -> SetFontHeight
- GetHeight     -> GetFontHeight
- SetWidth      -> SetAverageFontWidth
- GetWidth      -> GetAverageFontWidth

That's because it really makes no sense to say that there is a
single constant font width because obviously proportional fonts
don't have one - the best we can do is an average font width,
which is what folks like Microsoft sort of do already. On a fixed
font, the average is still accurate, for obvious reasons :-)

I'm also not a fan of GetSize/SetSize as I find it a might too
generic.

Change-Id: Ib80a604ba62d6883fd6cbc7994da763976be5c70
Reviewed-on: https://gerrit.libreoffice.org/22069
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-02-04 03:17:26 +00:00
Noel Grandin
752cd07d08 InterfaceContainer2 with vector instead of Sequence 
create an InterfaceContainer2 class to replace InterfaceContainer.
It uses a std::vector instead of a Sequence for the mutable listener
list, which provides far better performance.

Switch all our internal use-sites to the new class.

Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
 2016-01-25 08:52:03 +02:00
Chris Sherlock
5659b68be3 vcl: rename Font::GetFamily to Font::GetFamilyType 
Change-Id: Ie427a43bd126dcdd89c6f66582736e67130f2254
Reviewed-on: https://gerrit.libreoffice.org/21633
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-01-21 06:22:01 +00:00
Chris Sherlock
cb20f46895 vcl: change Font::SetName() to Font::SetFamilyName() 
Change-Id: I9b7bd1ec25955981ebcb9085579cbb9fbaa802d5
Reviewed-on: https://gerrit.libreoffice.org/21560
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-01-18 05:24:46 +00:00
Chris Sherlock
28c96fc255 vcl: rename Font::GetName to Font::GetFamilyName 
Change-Id: Ie20871a3078bf875c1782b7761d60591a9c9704f
Reviewed-on: https://gerrit.libreoffice.org/21529
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-01-17 23:35:37 +00:00
Norbert Thiebaud
45654a1d4d revert vcl patch series that brok Mac and Windows 
revert:
9bc2f3de8672e812f3a67541c6d7069b434a7e42
 vcl: add comment about ImplFontMetric::{Get|Set}LineHeight()
26371f105bc44e04469ec03fc5bb12505e651c6b
 vcl: FontAttributes::GetSlantType() -> FontAttributes::GetItalic()
2dd0b4317372b8022efe3911b38b4fa02956d8b9
 vcl: font.hxx and metric.hxx cleanup, make ctors explicit and the dtor virtual
5ab13bf3ead3539e4ad847656da81e7eb6029652
 vcl: tabify font.hxx
f99550dae55e40e49bf9c9875053fe2abb4c71ca
 vcl: change Font::SetName() to Font::SetFamilyName()
2b297116cb6bb1061c43e5714e2609c8ee9f57d2
 vcl: rename Font::GetName to Font::GetFamilyName

Change-Id: I23f38921187d66b970ca815eb30dda4222a2da62
 2016-01-16 12:20:45 -06:00
Chris Sherlock
f99550dae5 vcl: change Font::SetName() to Font::SetFamilyName() 
Change-Id: I54a4036544c680c4a49607677af776aa7a433fbc
Reviewed-on: https://gerrit.libreoffice.org/21510
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-01-16 16:12:14 +00:00
Chris Sherlock
2b297116cb vcl: rename Font::GetName to Font::GetFamilyName 
Change-Id: I83927e0992dfe0a2a79d139818a9f45d3761aae5
Reviewed-on: https://gerrit.libreoffice.org/21509
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-01-16 16:11:28 +00:00
Stephan Bergmann
11d3652418 loplugin:nullptr (automatic rewrite) 
Change-Id: Ic67c3138ca66c6b6d6fcf76b09d4581e23f51f8d
 2015-11-10 10:31:26 +01:00
Noel Grandin
59b072e22b yyyyy 
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
 2015-11-04 14:10:44 +02:00
Stephan Bergmann
10e1562565 loplugin:defaultparams 
Change-Id: I0a64398f49c8823327263aad0c79b182161177ea
 2015-10-20 11:45:39 +02:00
Stephan Bergmann
191e636b5a loplugin:defaultparams 
Change-Id: I0c2635092096cbacb120426d1d6805afdaac3503
 2015-10-19 17:50:06 +02:00
Noel Grandin
0e8a40e8b8 calling IsSet() before Call() on Link<> is unnecessary 
the Call() already does a check

Found with:
git grep -A 1 -w 'IsSet()'
    | grep -B 1 '.Call('
    | grep ':'
    | cut -d ':' -f 1

Change-Id: Ia7248f5d62640b75f705e539c3d1183e39c0d847
 2015-10-15 12:29:01 +02:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code 
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
 2015-10-12 17:52:29 +02:00
Stephan Bergmann
bff4c13475 Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY code 
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
 2015-10-12 17:52:26 +02:00
Noel Grandin
f8ba308cd7 loplugin:mergeclasses 
Change-Id: Id6e39c2c20ab3da5a8b8628f99a940b896feff78
 2015-10-12 09:13:33 +02:00
Caolán McNamara
7ba7a974f6 cppcheck: noExplicitConstructor 
Change-Id: I32c6728ce7423fd997cdbec66feb8a6ba39948d2
 2015-10-07 15:11:03 +01:00
Noel Grandin
de020fc9c3 com::sun::star->css in forms/ 
Change-Id: I1c09e88f839bdf11c6ff809ec95769e8f729c7cd
 2015-10-02 08:20:11 +02:00
Oliver Specht
ac9671f948 tdf#94559: second step to remove rtti.hxx 
replaced use of PTR_CAST, IS_TYPE, ISA in
    chart2, connectivity, editeng, extensions, filter, forms, framework, idl

Change-Id: I6a2f9d8bbccb07088413f7552af4b5af8f0cad99
Reviewed-on: https://gerrit.libreoffice.org/18920
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
 2015-09-30 06:07:57 +00:00
Stefan Heinemann
c50eb68af3 Renamed wrongly prefixed boolean variables 
Fixed tdf#94269

Change-Id: I63109cc4e095bad680d7637a065080ea368860ae
Reviewed-on: https://gerrit.libreoffice.org/18851
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2015-09-29 18:33:40 +00:00
Noel Grandin
146fe08382 convert Link<> to typed 
Change-Id: Ica5093e29630d6d6974ccba034609129887ac85b
Reviewed-on: https://gerrit.libreoffice.org/18802
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-09-23 13:07:27 +00:00
Caolán McNamara
3a00aaef2a boost->std 
Change-Id: Ie490bf2c6921f393bdeed96b1a8815996b701bf0
Reviewed-on: https://gerrit.libreoffice.org/18670
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-09-18 07:59:14 +00:00
Noel Grandin
81bec2e553 convert Link<> to typed 
Change-Id: I87d4697fe032e3095406becdda026447edd1d68a
 2015-09-17 08:19:32 +02:00
Noel Grandin
69a06ca6bf convert Link<> to typed 
Change-Id: I9ce05712af8300c8bcea6ea0f670b57cce1ca43d
 2015-09-16 08:38:55 +02:00
Noel Grandin
4ea70f87f7 convert Link<> to typed 
Change-Id: I2136c3db2742afcb4722f69297276bea1e0119f4
Reviewed-on: https://gerrit.libreoffice.org/18306
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-09-04 06:31:30 +00:00
Noel Grandin
8cf544cb3a convert Link<> to typed 
Change-Id: Ib0bf56a0e642720ff5daafdfc2dc12809be87e43
 2015-08-17 09:59:59 +02:00
Takeshi Abe
14bead7f42 forms: tdf#88206 replace cppu::WeakImplHelper* etc. 
with the variadic variants.

Change-Id: Ia4f56692c9beddda13ee948ab8bbc1ee95098fbf
Reviewed-on: https://gerrit.libreoffice.org/17648
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-08-11 13:30:17 +00:00
Noel Grandin
4eeeec899f convert RGCHK constants to scoped enum 
Change-Id: Iafeae0f85f751469900471cf8fccd5f763407890
 2015-07-28 08:35:34 +02:00
Noel Grandin
38ecca9b30 inline a bunch of use-once macros 
no point in having a macro unless it's actually going to reduce the
number of lines of code

Change-Id: Ic8760d6506cf272d7bd088f7b3b4dcbf288099fc
 2015-07-27 08:18:16 +02:00
Noel Grandin
771d9ef3f6 loplugin:unusedmethods forms 
Change-Id: I6b7938e948fb1422f83e2175fee5fcabe0a0b83f
 2015-07-17 11:07:13 +02:00
Stephan Bergmann
891c80e172 loplugin:simplifybool 
Change-Id: I8b704401233fa865c8ec4d4663d720a3d7d8de69
 2015-07-16 14:00:17 +02:00
Stephan Bergmann
8e1ad96626 Some missing SolarMutexGuard around VclPtr acquire/release 
At least OutputDevice::acquire/release use a plain unguarded int and ++, --, so
apparently rely on the SolarMutex being locked whenever they are called.  Fixed
those places that caused "make check" to fail for me when temporarily adding
DBG_TESTSOLARMUTEX() to OutputDevice::acquire/release.  (A recurring pattern is
that a class fails to ensure the SolarMutex is locked around the destruction of
non-null VclPtr members.)

Change-Id: I77cba6f3908f2de1b516ce28f1c3c43b3f57a9c5
 2015-06-17 15:24:19 +02:00
Noel Grandin
66854d697f convert WINDOW_DRAW flags to scoped enum 
Change-Id: I9400a286fab18d683b4c109007961685f01b6da3
 2015-05-27 11:14:26 +02:00
Tomaž Vajngerl
22fd5e0806 refactor forms classes to use RenderContext 
Change-Id: I18026eb4a3784afc84c68c4effdb0c267e31e5db
 2015-05-18 15:55:00 +09:00
Noel Grandin
82d68f9cbc convert COMMAND_ constants to scoped enum 
Change-Id: I88e67f89dbbab0646e8f106dfeb32c6ee1bb0b95
Reviewed-on: https://gerrit.libreoffice.org/15671
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-05-11 12:17:42 +00:00
Stephan Bergmann
6dc42c82ba Use IMPL_LINK_NOARG[_TYPED] where applicable 
Change-Id: I70598072c1d492e360ef46dd7b5ef5a2fa4be495
 2015-05-10 12:06:16 +02:00
Michael Stahl
8fca0c44e8 vcl: rename other members of StateChangedType for consistency 
Change-Id: Ifd3339813e5d3dfb54566fd226aaf2d2a199d59a
 2015-05-05 15:51:11 +02:00