wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
395,083 Commits 5 Branches 0 Tags
8a6b2fb5b94de43316ab3ea95ff07cf5f46b6134
Commit Graph

648 Commits

Author SHA1 Message Date
Noel Grandin
508c95f1b6 improve passstuffbyref return analysis 
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c
Reviewed-on: https://gerrit.libreoffice.org/27317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-27 06:48:25 +00:00
Stephan Bergmann
f7803b302a loplugin:commaoperator 
Change-Id: I7ba83b999b3b12411348c21cabcd47b8ad9c4034
 2016-07-15 10:53:25 +02:00
Eike Rathke
fc305bb6d6 strip second parameter from ISOWEEKNUM if literal double != 1.0 
For other arguments convert to WEEKNUM_OOO, which now can be saved as
ORG.LIBREOFFICE.WEEKNUM_OOO.

Change-Id: I63fd3df1ec4ccaa535a1437200854d8734544a2c
 2016-07-14 23:16:49 +02:00
Eike Rathke
77ccf8a9ca store WEEKNUM_OOO as ORG.LIBREOFFICE.WEEKNUM_OOO 
Now that the previous two releases can read it.

Change-Id: Ie04c7b0fd94f5906b678d738370e4fc0696da79c
 2016-07-14 23:13:41 +02:00
Eike Rathke
908449639b let FormulaTokenArray::RemoveToken() return the actual count of tokens removed 
Change-Id: Iebf654e7b4c682036b4ff334298948557b755eac
 2016-07-14 22:31:20 +02:00
Eike Rathke
f9021f7eea re-add FormulaTokenArray::ReplaceToken() that was removed as unused, grml.. 
with 4ff5a5558472beee85eb1234dcc2aa2ed9000f6c

Change-Id: Id99c3ae74515f24c55a3734698c560dcac8bacd9
 2016-07-14 22:26:25 +02:00
Eike Rathke
69a3f884a5 yet more functions to save with prefix and namespace to OOXML 
MULTIRANGE, GOALSEEK, EASTERSUNDAY, CURRENT and STYLE are LibreOffice /
OpenOffice.org only and need a _xlfn.ORG.OPENOFFICE. prefix and namespace when
saved to OOXML.

Change-Id: Ie5d4eb14b1ec958f9ebec5f149d0d1d7b4dd644e
 2016-07-14 20:25:36 +02:00
Eike Rathke
feef105196 save ERRORTYPE as _xlfn.ORG.OPENOFFICE.ERRORTYPE to OOXML 
Was wrongly saved as ERRORTYPE without _xlfn. prefix and namespace.
Be able to still read ERRORTYPE.

Change-Id: Ia028fe06d930f60b4260adf589ee3190b90ea099
 2016-07-14 18:19:00 +02:00
Noel Grandin
7855ea4830 remove comphelper::string::remove 
and replace it with OUString/OString::replaceAll

Change-Id: I37b1c3b51251dfd9d749d6f1060c75b3a93d7f1a
Reviewed-on: https://gerrit.libreoffice.org/26850
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-04 06:49:52 +00:00
Eike Rathke
2795cb694b add an isPODF() block to ScCompiler::IsOpCode(), tdf#100641 related 
... as we can't rename RID_STRLIST_FUNCTION_NAMES_ENGLISH names.

Should we need yet another resource block to differentiate between
PODF/API names and actual always available English names? Ugly but
maybe. A much better approach would be if Text[en-US] would be always
available, additionally to the current localized resource.

Change-Id: If8eaf18643f4e24c811149c52efff1097a3c1596
 2016-06-27 17:24:20 +02:00
Eike Rathke
d480e5c7f6 rename *effective to *effect, tdf#100641 related 
... to unify naming.

Change-Id: I0964822d53eafd69ea4ed0656dfdfcb3f5bfd561
 2016-06-27 16:03:23 +02:00
Eike Rathke
48f018ea9b tdf#100641 change UI name of EFFECTIVE to EFFECT 
... to be the same as in other implementations and ODFF and OOXML.

Change-Id: I754283b97e91c5e0f992d878096cf964a1244e04
 2016-06-27 14:49:27 +02:00
Eike Rathke
ed5bcef57b correct OOXML function name is EFFECT instead of EFFECTIVE 
Change-Id: Ieb7484afe210e378efd43ba3a181cd90d29619b9
 2016-06-27 13:03:43 +02:00
Markus Mohrhard
47b9dad797 remove unnecessary whitespace 
Change-Id: Ia9c9accf3c5509393c3e09692b6a7eae756907f9
 2016-06-22 18:19:32 +02:00
Jorenz Paragas
8a6bffd2fe tdf#42949: clean up includes in include/formula with iwyu 
Change-Id: Ieb601d98be80aeb2239d4f0a330d90e63f1abc43
Reviewed-on: https://gerrit.libreoffice.org/26398
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-21 07:58:59 +00:00
Muhammet Kara
a00757e75b Move accessibility relations to .ui files, Part 9: tdf#87026 
By removing unnecessary variables/strings/function calls,
and making proper changes in the related .ui files.

Change-Id: I52e3f2a16519aee13b06f0efc6beb3385bcb0f1c
Reviewed-on: https://gerrit.libreoffice.org/26066
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
 2016-06-15 20:26:35 +00:00
Eike Rathke
478613c550 explicit svl::SharedString(const OUString&) ctor 
... to prevent accidental surprises. Not interned shared strings
constructed from OUString have mpDataIgnoreCase=nullptr so can't be used
for case insensitive comparison.

Change-Id: I03323354298a73e93b18d2796ec447c072fdefa5
 2016-06-14 13:33:35 +02:00
Eike Rathke
189f2e52b8 assert on FormulaToken::GetDouble() virtual dummy 
Change-Id: Ic31c2b943dcc6dfdaaefe3daa120c91cf29ce0e7
 2016-06-10 14:12:59 +02:00
Eike Rathke
2b6710c2b5 check for svDouble when stripping DCOUNT/A argument, tdf#70806 follow-up 
Change-Id: Ic7897b5240f9f3f66eb71485ef9eed4fa8ce87e1
 2016-06-10 12:57:26 +02:00
Stephan Bergmann
a43529886f Fix ambiguous calls 
Change-Id: Ia115185b615f86a49004133e00211c197b61db7b
 2016-06-09 08:57:15 +02:00
Eike Rathke
333b644d11 assert on "forgot to add a jump" for OpCode 
Change-Id: I6c430b8a4079cd0d74e5c9e71a3f7b5b638d4ef5
 2016-06-08 22:49:03 +02:00
Eike Rathke
1ec01a340a introduce FormulaTypedDoubleToken to carry type information of a double 
Change-Id: I88b4964ca95eefa41d415ed66fc106c834a686b6
 2016-06-08 12:13:23 +02:00
Noel Grandin
9f138ffe9d remove unused constants in HRC files 
Change-Id: Ia034fb16ce75caeb69fd746d4a602cd5fcfef6d1
Reviewed-on: https://gerrit.libreoffice.org/25817
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-06 07:01:43 +00:00
Julien Nabet
7a2bca302f cid#1362174, 1362177: USE_AFTER_FREE+resource leak due to copypasta 
Change-Id: Icd903335fdef3921781e2f16e98a0e10bda31e3f
Reviewed-on: https://gerrit.libreoffice.org/25641
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2016-05-30 00:32:03 +00:00
Eike Rathke
3129b75fca strip 0 argument only if not part of an expression, tdf#70806 
Change-Id: Ia1f986a594194a1c564d815bbe2faa987eea971a
 2016-05-27 21:58:48 +02:00
Eike Rathke
a88ee01b86 omit DCOUNT or DCOUNTA 2nd argument if 0 when writing ODFF or OOXML, tdf#70806 
Change-Id: I2833a1005c6941e66a09172b337e23b0bf7f2002
 2016-05-27 18:09:21 +02:00
Noel Grandin
74713b34a3 loplugin:unusedmethods 
Change-Id: Ib36bc0e87d00abb638cbfec511cd13b6179eabda
Reviewed-on: https://gerrit.libreoffice.org/25431
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-26 07:50:33 +00:00
Caolán McNamara
07f1a39509 (nearly) nothing uses GetUniqueId anymore, so remove it. 
The odd one out is the usage in Formula, which attempts
to restore focus to a particular window identified by
an unique id. In this case restore focus by keeping a VclPtr
to the desired window.

Change-Id: I1dc335325c109d75745c6bba2e12662e6ae50638
 2016-05-25 14:24:20 +01:00
Noel Grandin
8a2149c105 clang-tidy misc-assign-operator-signature 
Change-Id: I2953a88d9e2f5923732865ef17615d5928ac5f5f
Reviewed-on: https://gerrit.libreoffice.org/25154
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-20 07:55:30 +00:00
Noel Grandin
d4d2fc2479 clang-tidy modernize-make-unique 
Change-Id: I550bb69ddcef69906027516ccde62cf8e87c295b
Reviewed-on: https://gerrit.libreoffice.org/25138
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-19 08:33:10 +00:00
Noel Grandin
2c8fe2e737 update unusedmethods plugin to deal with constructors 
and fix the operator< implementations in some of the other
plugins too.

Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035
Reviewed-on: https://gerrit.libreoffice.org/25057
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-18 10:03:44 +00:00
Winfried Donkers
c57dc741a6 tdf#97831 [part] Add Excel 2016 functions to Calc 
Functions MINIFS and MAXIFS

Change-Id: I4bd2e8b82f8377af81f4373d0c33ac286588b8df
Reviewed-on: https://gerrit.libreoffice.org/24619
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
 2016-05-04 21:54:01 +00:00
Winfried Donkers
29433c6496 tdf#97831 [part] Add Excel 2016 functions to Calc 
Functions IFS and SWITCH.

Change-Id: Ic43d42a933bcac883e9aa2213dd4ddeddf45abf0
Reviewed-on: https://gerrit.libreoffice.org/24424
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
 2016-05-03 16:10:12 +00:00
Eike Rathke
edd4370f5b check presence of token, tdf#96426 follow-up 
Change-Id: I4c368dfd113b02d208013b4ba79dff606769a150
 2016-05-02 20:39:45 +02:00
Eike Rathke
b79d226017 Revert "crashtesting: fix ooo123540-1.xlsx etc" 
This reverts commit bfca69eddd3d94e74d6b73f91476b79c8f72cce7.

Rather let the caller check for a valid token instead of checking it
twice for other places that already do, and we usually need two valid
tokens before even one call makes sens.
 2016-05-02 20:05:11 +02:00
Caolán McNamara
a2565e067b crashtesting: fix ooo123540-1.xlsx etc 
Change-Id: I178c3e5818f4538bc306694115bc3d1cbe95513e
 2016-04-30 21:16:43 +01:00
Andrea Gelmini
fc2590cfa1 Fix typos 
Change-Id: Id81b16ff26283611f0b84929d831c827f847ab73
Reviewed-on: https://gerrit.libreoffice.org/24317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2016-04-30 15:06:45 +00:00
Muhammet Kara
376c337d46 tdf#97087 Give comprehensible, unique names to idles 
Timers and idles should have programmer comprehensible, unique names

Change-Id: Id0f2c0a77cd28c3ec5473e8432569739b58d2101
Reviewed-on: https://gerrit.libreoffice.org/24388
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
 2016-04-28 09:34:30 +00:00
Noel Grandin
5e4fc95409 clang-tidy modernize-loop-convert in f* 
Change-Id: Id866aa244378758e3bdb9e99d02cdd2ae6104e16
 2016-04-27 15:03:40 +02:00
Winfried Donkers
a76c5e2137 tdf#97831 [part] Add Excel 2016-Office 365 functions to Calc 
Functions CONCAT and TEXTJOIN.

Change-Id: I38092f77df719d11f6746ac10fe14dc53b7e93e7
Reviewed-on: https://gerrit.libreoffice.org/23601
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
 2016-04-26 15:08:22 +00:00
Noel Grandin
e8fd5a07ec update loplugin stylepolice to check local pointers vars 
are actually pointer vars.

Also convert from regex to normal code, so we can enable this
plugin all the time.

Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1
Reviewed-on: https://gerrit.libreoffice.org/24391
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-26 10:55:58 +00:00
Eike Rathke
0c5663cfb1 first range can be anywhere before second at RPN end, tdf#96426 follow-up 
... not just adjacent to the one at the end. So we actually can handle
INDIRECT("A2:C2") INDIRECT("B1:B3")

Change-Id: Ie8030ebc13bb1ae2246611f5722da97970b8c544
 2016-04-24 00:11:08 +02:00
Eike Rathke
0f8a8332a5 more differentiated significant whitespace recognition, tdf#96426 follow-up 
Change-Id: I081409a82a9ff64f163115bf4597afbb9b2f5fa6
 2016-04-23 22:35:31 +02:00
Eike Rathke
e0875f8e34 narrow down where a space could be an intersection, tdf#96426 follow-up 
Change-Id: Ic53a4a0d19a11298895efb28e2786e48a071e72b
 2016-04-23 20:42:18 +02:00
Eike Rathke
b0992e1190 fully check for adjacent RPN end, tdf#96426 follow-up 
Change-Id: I886e559c6f6041bf4889fdd6d89c12a10be70e5f
 2016-04-23 20:24:46 +02:00
Eike Rathke
4f8d72d068 use FormulaToken::DeleteIfZeroRef() instead of Delete() at some places 
The array overflow detecting places that unconditionally deleted the
token in case of overflow should do so only if no reference is held,
i.e. the token was allocated with new and passed immediately without
being assigned to a FormulaTokenRef. Just to be on the safe side.

Change-Id: If2ccabec3725ac73fe82c23f51a291246847cfdb
 2016-04-23 17:28:27 +02:00
Eike Rathke
26adceb098 Resolves: tdf#96426 significant whitespace as intersection in Excel syntax 
Also when reading/writing OOXML, so change SC_OPCODE_INTERSECT of
RID_STRLIST_FUNCTION_NAMES_ENGLISH_OOXML accordingly to " ", where
previously "!" was expected and written, which was plain wrong.

Change-Id: Ic0cfd7afc657f07bfd8e37de61b3621cc68685ff
 2016-04-23 15:52:35 +02:00
Eike Rathke
f41257dc99 simplify the ReplaceToken() offset logic to absolute offsets 
Change-Id: I8d02fb63bc0c5cb48aabaf7a8800f5f9ac95cbf5
 2016-04-23 15:52:35 +02:00
Eike Rathke
9185f889ed newline shortage 
Change-Id: Id2487480270bb2be765495bb6d5982c85ae2117f
 2016-04-23 15:52:34 +02:00
Eike Rathke
737040e5db change multiple ifs to switch case 
... obtaining mpToken->GetOpCode() only once.

Change-Id: I909fef97540998a7f09115738fb76a1e963480bf
 2016-04-23 15:52:32 +02:00