508c95f1b6
improve passstuffbyref return analysis
...
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c
Reviewed-on: https://gerrit.libreoffice.org/27317
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-07-27 06:48:25 +00:00
6e72f0251b
new loplugin unnecessary override
...
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb
Reviewed-on: https://gerrit.libreoffice.org/27135
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
Tested-by: Stephan Bergmann <sbergman@redhat.com >
2016-07-15 14:05:41 +00:00
467887d3c9
Related: tdf#100713 fix more recent bug to try and see older bug...
...
at the moment AddonsOptions::Notify is called with a null this
which crashes during adding an extension
regression from...
commit 3bdc5063f942b9ea3b6e39e707926fbc516c19f9
Date: Wed Jun 22 02:30:43 2016 +0200
tdf#89329: use shared_ptr for pImpl in addonsoptions
Change-Id: Ic28951e56bb8beca2a01ef2a1864eadcf3864e5b
2016-07-08 09:22:46 +01:00
3bdc5063f9
tdf#89329: use shared_ptr for pImpl in addonsoptions
...
Change-Id: I159ba04fa70f324d2a7f5b3c592337b92c7f097d
Reviewed-on: https://gerrit.libreoffice.org/26560
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-06-28 06:28:19 +00:00
aa0d0536a4
tdf#97527 - vcl: reference-count Menu
...
some places are marked with "dodgy"- need to check those to see
what is going on, because they are leaving dangling pointers behind
in the Menu class
Change-Id: I41d5c7c0fec2f70ce9e3ffdc48cd03d26c0a869b
Reviewed-on: https://gerrit.libreoffice.org/26516
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-06-23 06:28:00 +00:00
ed467869d8
loplugin:salbool: Automatic rewrite of sal_False/True
...
Change-Id: Idf27ee5370f1fa24adf22908d9e801c7d40db935
2016-04-20 17:25:42 +02:00
789055bc2a
clang-tidy performance-unnecessary-copy-initialization
...
probably not much performance benefit, but it sure is good at
identifying leftover intermediate variables from previous
refactorings.
Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657
Reviewed-on: https://gerrit.libreoffice.org/24026
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-18 07:37:31 +00:00
f045c536db
clang-tidy performance-unnecessary-value-param in framework
...
Change-Id: I80987ea1bfac7478574de46ee30fc58fcc17eb68
2016-04-12 11:56:07 +02:00
c20cc7e79b
tdf#97499 Fixed containers parameters clearing #4
...
Change-Id: I7c96181399f4d7e62d4aceca404b22d68f903513
Reviewed-on: https://gerrit.libreoffice.org/23754
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-04 05:49:06 +00:00
3f7f497192
sequence->vector in framework
...
Change-Id: I457c3da4f4a31f58d688dcd96a2ccfc36518490d
Reviewed-on: https://gerrit.libreoffice.org/23692
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-01 07:33:45 +00:00
42d6a165b0
framework: Kill BmkMenu
...
Change-Id: I182e752f5602d946f27206a1bb744c5d2248bdf8
2016-03-11 00:53:21 +02:00
a7f6efc68b
loplugin: unused return values
...
Change-Id: I9c61a46c57894bc63a57740206c0bcb4a16553af
Reviewed-on: https://gerrit.libreoffice.org/21571
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-01-18 12:50:09 +00:00
5f3d9ba0cd
GetImageFromURL/SetImageProducer unused
...
looks like these have been abandoned recently in the toolbar manager
update
Change-Id: I5556833dfef0db5958a5779bdb32482c18a46a5f
2016-01-12 11:47:52 +02:00
13e894bb52
loplugin:unusedmethods unused return value in framework
...
Change-Id: I6e02f34702ba59a961c3fec3d025e775f4e26760
2016-01-11 13:14:08 +02:00
64d624b651
Fix typos
...
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com >
2016-01-10 14:17:20 +00:00
5c39b28a87
tdf#96059 Replaced imageproducer with CommandInfoProvider
...
Replaced all instances of framework::GetImageFromURL with vcl::CommandInfoProvider::Instance().GetImageForCommand
Change-Id: I895a4a80d0219a6523b62d90ca88ec67a433b01c
Reviewed-on: https://gerrit.libreoffice.org/21101
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: jan iversen <jani@documentfoundation.org >
2016-01-05 09:52:53 +00:00
7dd77a1271
Remove unused ToolPanel (aka TaskPane)
...
Superseded by the Sidebar
Change-Id: I54970d71cd9d42de4f47b223e50dd9474b40632a
Reviewed-on: https://gerrit.libreoffice.org/20724
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
2015-12-17 08:27:55 +00:00
b0339005b8
loplugin:sallogareas
...
Change-Id: I2220ab194384fb397716bf3227d38716ba54f537
2015-11-19 16:05:35 +01:00
8569c6d0ad
use initialiser list for Sequence<OUString>
...
Change-Id: Ia5e47261d1fc6fac2d046656c05a1c5eedb07e02
Reviewed-on: https://gerrit.libreoffice.org/19978
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-16 08:35:42 +00:00
25aec383f9
use initialiser for Sequence<OUString>
...
replaced using:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)'
| xargs perl -0777 -pi -e
"s/Sequence<\s*OUString\s*> (\w+)\(\s*1\s*\);
.*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g"
Change-Id: I20ad0489da887a9712982531c3b127339bb8b3b9
Reviewed-on: https://gerrit.libreoffice.org/19969
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-15 12:18:55 +00:00
06c5c63020
loplugin:nullptr (automatic rewrite)
...
Change-Id: Ie178c474921c1695927a9b01a9972baf09fbb73d
2015-11-10 10:31:27 +01:00
69ef5d40c2
loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)
...
Change-Id: Iff1f68969f0f044c59a92ab4c019c471511743f7
2015-11-06 09:36:08 +01:00
7408498de3
loplugin:stringconstant
...
Change-Id: I865efc1884b82d430fe7df2e432d43f5425a83d4
2015-11-02 14:50:33 +02:00
5797d29e9e
use uno::Reference::set method instead of assignment
...
Change-Id: Ic979f8a7734d0ef7a915d47a875cdcd460c0cc58
2015-11-02 12:23:16 +02:00
71b4afde11
loplugin:defaultparams
...
Change-Id: Icf92bef2685c507dd61416260f662dfdd24354d5
2015-10-19 17:50:20 +02:00
d191d1f9b6
com::sun::star->css in framework
...
Change-Id: If5a77db83fcbef5ed436f2043ddeb7c515a840dc
Reviewed-on: https://gerrit.libreoffice.org/19356
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-14 06:37:16 +00:00
b36963c0a6
Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
...
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
a18fc918d5
Fix typos
...
Change-Id: I051caee9ec6181074201ac4a8cb6fcec4fdf2293
Reviewed-on: https://gerrit.libreoffice.org/18951
Reviewed-by: Oliver Specht <oliver.specht@cib.de >
Tested-by: Oliver Specht <oliver.specht@cib.de >
2015-09-30 13:50:06 +00:00
e9b7506415
loplugin:stringconstant: OUStringBuffer: appendAscii -> append
...
Change-Id: Iadb6e16a7aca322a78a82ae1a52f5d085b300efc
2015-08-31 08:03:15 +02:00
bd8b93fdff
make PostUserEvent Link<> typed
...
Change-Id: I13f10bda985d55d419a5bff481130a456ae2db8a
2015-08-28 09:49:56 +02:00
9be8c4f212
sfx2: remove the global SidebarController::maSidebarControllerContainer
...
This global was crashing on exit, unsurprising as it contains UNO
services that reference VCL objects.
It turns out that there is already a UNO singleton
framework::ContextChangeEventMultiplexer that effectively contains this
mapping already, so try to hook that up without creating a public API of
it, which is made quite a bit harder by framework's inexplicable
multitude of libraries.
Change-Id: I4baf67b42c630191fa8879d650eeb62520c331a5
2015-07-14 11:50:44 +02:00
799cc41b53
Fix typos
...
Change-Id: I70b03c152f63e48341dc5629a99b0eeab7b497c0
Reviewed-on: https://gerrit.libreoffice.org/16834
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2015-07-08 05:48:18 +00:00
a1a5588b1b
loplugin:cstylecast: deal with remaining pointer casts
...
Change-Id: I4a72a60d621c65e63310ef70b991f9c86f00494d
2015-06-08 16:25:25 +02:00
10749bbf82
remove the last of the OUString #defines in header files
...
Change-Id: Id9e8ce7987e055e83b52c7024413570f262e6e8d
2015-05-19 09:42:41 +02:00
4f00dce2b3
Use IMPL_[STATIC_]LINK_NOARG where applicable
...
Change-Id: I1e24b032bdeea017b0e77c5446e55310899ce752
2015-05-10 11:25:48 +02:00
9bb254fc85
NOINSTANCE is implied now in IMPL_STATIC_LINK...
...
Change-Id: Ifb032457d6c1b279c4183282ef2b271c706dd71a
2015-05-10 11:25:47 +02:00
b13fbd19b7
convert BMP_SCALE constant to scoped enum
...
Change-Id: Ibc9f88d2588c028cd71aa86c26d970a73025ef22
2015-05-06 09:01:30 +02:00
e6c08b6b30
Remove unnecessary STATIC_LINK macro
...
Change-Id: I4788824667c8e0d1d4e0717b7ae7737bb0fd2c90
2015-04-29 18:29:59 +02:00
deb50a2a8a
remove some @author tags from suspiciously unidiomatic code
...
Change-Id: I3930420fe502978f8e14a688f2eb99c74d185f7b
2015-04-25 22:45:51 +02:00
5d950b3afd
Clean up C-style casts from pointers to void
...
Change-Id: Ide77480339e35a886f0d33c2a194244064c02488
2015-03-28 19:09:21 +01:00
465359c35f
do not call virtual Commit() from dtors of utl::ConfigItem subclasses
...
~SvtAppFilterOptions_Impl() demonstrates that this is a bad idea, by not
invoking its subclasses' ImplCommit() but its own.
Change-Id: Ic675e9cd3be1494c740a4f289be3bdbf0d1a122b
2015-03-11 16:50:03 +01:00
765f6211b1
utl::ConfigItem::Commit() should call ClearModified()
...
Rename the virtual function, and add a new non-virtual Commit() to do
that.
Change-Id: I09421df781ba965d6ff638b46cd8214fb3a00022
2015-03-11 16:50:00 +01:00
af6cd2356a
rename MenuConfiguration::Attributes->MenuAttributes
...
Change-Id: I2ada1394c4cbee7c27b02f241ee4a254597a5dd8
2015-02-04 20:49:59 +00:00
4904180247
fix leak from framework::AddonMenuManager::BuildMenu
...
provide a callback when a menu item gets deleted
Change-Id: I5b5f1a181fb10f53f6b1fe7b5637d385e1517530
2015-02-04 16:34:53 +00:00
d69fb68f30
Some more loplugin:cstylecast: framework
...
Change-Id: Iebd80b596bcc1f740ff9f3b0f168472144cacbed
2015-01-20 09:06:48 +01:00
2f69e16c72
override the overloading of "overload" to decrease cognitive (over-)load
...
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-09 00:00:47 +01:00
8e94c40f13
how about scope
...
Change-Id: I4c9e5f754974b6726fc86bc87775ba81832b3984
2015-01-06 11:59:53 +01:00
549b7fad48
workaround a weird gcc optimization werror bug
...
gcc (GCC) 4.9.2 20141101 (Red Hat 4.9.2-1)
framework/source/fwe/classes/addonsoptions.cxx: In member function ‘void framework::AddonsOptions_Impl::ReadAndAssociateImages(const rtl::OUString&, const rtl::OUString&)’:
framework/source/fwe/classes/addonsoptions.cxx:267:16: error: array subscript is above array bounds [-Werror=array-bounds]
struct ImageEntry
^
The combination of aScaled[2]; aImage[2]; aURL[2] in sequence apparently lead
to some overoptimization and/or alignment problem, already declaring aImage[3]
helped (but not aScaled[3]), but that's not what we want.
Change-Id: I82e28d4887ab8072a17d0a9341d322c1cf61aedc
2015-01-06 11:40:23 +01:00
fd1372ba8b
boost::unordered_map->std::unordered_map
...
you can get debug stl this way
Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2015-01-02 16:14:36 +00:00
b98352996c
framework: Use appropriate OUString functions on string constants
...
Change-Id: I5da5cd3254102c742021b3e7b4e1f907ca897ca5
2014-12-18 14:12:22 +01:00
