wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
395,083 Commits 5 Branches 0 Tags
8a6b2fb5b94de43316ab3ea95ff07cf5f46b6134
Commit Graph

1200 Commits

Author SHA1 Message Date
Caolán McNamara
2a66c02553 Resolves: tdf#84121 wrong password passed to xpdfimport 
regression from...

commit eb276d11a652601f743d69ada7a38016bd97d73e
Author: Fridrich Štrba <fridrich.strba@bluewin.ch>
Date:   Mon Jul 8 14:01:17 2013 +0200

    fdo#38878: Upgrading internal xpdf -> poppler

before this the hashed _OOO_pdfi_Credentials_ was used
in the removed OOoImportSecurityhandler::authorize

but after this the hashed password continued to be
passed through stdin, while the unhashed password
was the required data.

Change-Id: Iadc8a372abcfab514f724dd95f05776e5153d007
 2016-07-29 10:00:59 +01:00
Noel Grandin
508c95f1b6 improve passstuffbyref return analysis 
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c
Reviewed-on: https://gerrit.libreoffice.org/27317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-27 06:48:25 +00:00
Stephan Bergmann
768a6fc9c0 loplugin:passstuffbyref also for {css::uno,rtl}::Reference 
Change-Id: I3774f16c09b89fc6888bff3a388c290c32bb8a14
 2016-07-07 18:59:55 +02:00
Noel Grandin
fbd23182ee loplugin:unusedfields 
Change-Id: If06fffa8db050df0f9c1c7da6163575bf522382e
Reviewed-on: https://gerrit.libreoffice.org/26754
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-30 07:01:41 +00:00
Noel Grandin
48a8d6d843 loplugin:singlevalfields in various 
Change-Id: Ia0d8f463a4dba9ec63aa0159441e3e607dd3bf5e
Reviewed-on: https://gerrit.libreoffice.org/26738
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-28 11:21:17 +00:00
Noel Grandin
b1225d201f loplugin:singlevalfields in sdext 
Change-Id: I9bf194fb58b3bd37071647a83a629b6782836890
Reviewed-on: https://gerrit.libreoffice.org/26659
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-27 05:21:45 +00:00
Gökhan Gurbetoğlu
9b9e5cfd2f tdf#99589 - tolower / toupper - dangerous to Turks ... 
Change-Id: I8b0fe9354232a7b60f3605fa6f90f6741f7bf683
Reviewed-on: https://gerrit.libreoffice.org/26537
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
 2016-06-23 09:59:49 +00:00
Vort
b65f46127a tdf#96080 PDF Import: fix incorrect whitespace characters sequence 
Change-Id: I0f8e0217cb661be318af611216191def1b209ea1
Reviewed-on: https://gerrit.libreoffice.org/26426
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2016-06-20 22:29:33 +00:00
Stephan Bergmann
4d49c9601c Let loplugin:passstuffbyref also look at fn defn not preceded by any decl 
Change-Id: I752bc96d2d521d790e919283cabb14b6526626f4
 2016-06-08 17:14:34 +02:00
Jan Holesovsky
6aa46396f6 Reintroduce some code removed with "Remove unneeded Pane code in ..." 
This code was removed in 71cf1aefca1ecf10272308d7c75201bd39d3b0f6, but it was
guarded by an "ifndef", not by an "ifdef", so it should still stay (unless I'm
missing something).

Change-Id: Ib344e73d39d1fcd3b84784977769708726d8ed1e
 2016-06-06 09:44:11 +02:00
Bryan Quigley
71cf1aefca Remove unneeded Pane code in Presenter Console 
This code hasn't been touched (on purpose) in years, it appears
to have been used to resize part of the console. (It's prefed off)

Change-Id: Iaaeaa8a95c71ae91299bbeeea24869bf2a237b6b
Reviewed-on: https://gerrit.libreoffice.org/24663
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
 2016-06-06 05:55:03 +00:00
Noel Grandin
0b23eec200 teach refcounting clang plugin about uno::Reference 
uno::Reference is only allowed to used with classes that have a
::static_type member.
So convert all those places to rtl::Reference.

Maybe we need some LIBO_INTERNAL_ONLY constructors on rtl::Reference and
uno::Reference to make this a little smoother?

Change-Id: Icdcb35d71ca40a87b1dc474096776412adbfc7e3
Reviewed-on: https://gerrit.libreoffice.org/25516
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-31 06:25:45 +00:00
Noel Grandin
b73f45ef0b loplugin:unusedmethods in sd 
Change-Id: I27da3e7afd86217ec9f75958775da9c144d7a0a5
Reviewed-on: https://gerrit.libreoffice.org/25111
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-19 06:42:34 +00:00
Noel Grandin
d96c114171 clang-tidy modernize-make-shared 
Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a
Reviewed-on: https://gerrit.libreoffice.org/25056
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-18 06:58:44 +00:00
Michael Stahl
98f759bec1 sdext: replace boost::bind 
MSVC 2013 with non-debug runtime requires an additional assignment operator
in OUStringBufferAppender.

Change-Id: Ic93fc8d6b1d4760f0eb89e34beb1fcb18e783f73
Reviewed-on: https://gerrit.libreoffice.org/24980
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2016-05-13 21:22:08 +00:00
Stephan Bergmann
94b361b005 loplugin:stringconstant 
Change-Id: I5515f35871b23b67564d5eda52bf3323e7e047bb
 2016-05-12 11:44:12 +02:00
Michael Stahl
28159e91ba sdext: replace boost::bind with C++11 lambdas, part 2 
Change-Id: Ife5fbf7a7a41182de00dca339cba160e3bb0062f
 2016-05-12 11:08:24 +02:00
Tor Lillqvist
e1efe3359c loplugin:stringconstant 
Change-Id: I9eed9713a0d208e7aa4cdddc0cedb97edf831239
 2016-05-12 08:48:57 +03:00
Tor Lillqvist
f1fa4a58fc loplugin:defaultparams 
Change-Id: I4905e4c1dd72dabe2229d99742ee0012295a9742
 2016-05-12 08:48:56 +03:00
Michael Stahl
c7325f3903 sdext: replace boost::bind with C++11 lambdas 
Change-Id: I2a30e764b96530e21d5ff201b18f98d1cd334a6d
Reviewed-on: https://gerrit.libreoffice.org/24888
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2016-05-11 19:21:49 +00:00
Stephan Bergmann
0f3ac23d73 Insert explicit "break" when falling through to empty next case 
...which itself only contains a "break" (or nothing at all at the end of the
"switch"), as otherwise Clang -Wimplicit-fallthrough would warn about these.

Change-Id: I25c1cf2ca74dfeba7ca0385ca8f1c1bf30bbf91b
 2016-05-10 14:57:26 +02:00
Noel Grandin
00bfc137d3 fix Windows build 
Change-Id: Ib80cc10c259e26e997e3a548fbf267621c050e29
 2016-05-10 08:38:46 +02:00
Noel Grandin
f469309e26 clang-tidy modernize-loop-convert scaddins to sdext 
Change-Id: I63ccc56df1a1de8bc443abb95e520246c457912f
Reviewed-on: https://gerrit.libreoffice.org/24798
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-10 06:29:32 +00:00
Noel Grandin
f3d9aab841 teach passstuffbyref plugin to check for.. 
unnecessarily passing primitives by const ref.

Suggested by Tor Lillqvist

Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6
Reviewed-on: https://gerrit.libreoffice.org/24672
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-06 06:48:38 +00:00
Noel Grandin
58a32075ca use Any constructor instead of temporaries 
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
 2016-05-04 12:39:40 +02:00
Andrea Gelmini
fc2590cfa1 Fix typos 
Change-Id: Id81b16ff26283611f0b84929d831c827f847ab73
Reviewed-on: https://gerrit.libreoffice.org/24317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2016-04-30 15:06:45 +00:00
Noel Grandin
e8fd5a07ec update loplugin stylepolice to check local pointers vars 
are actually pointer vars.

Also convert from regex to normal code, so we can enable this
plugin all the time.

Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1
Reviewed-on: https://gerrit.libreoffice.org/24391
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-26 10:55:58 +00:00
Noel Grandin
5abc669599 new plugin stylepolice 
check for local variables which follow our member field naming
convention, which is highly confusing

Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
 2016-04-21 08:32:47 +02:00
Stephan Bergmann
259ece83e9 loplugin:salbool: Automatic rewrite of sal_False/True 
Change-Id: I0a24f0d6fa58407f9e365a5c812743151b88513b
 2016-04-20 17:25:50 +02:00
Noel Grandin
67d333c608 tdf#99352 - Some VclPtrs leak past DeInitVCL 
Change-Id: I74b27b1d8b662a644df580ae128643b8495355f8
Reviewed-on: https://gerrit.libreoffice.org/24204
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-18 10:51:54 +00:00
Noel Grandin
789055bc2a clang-tidy performance-unnecessary-copy-initialization 
probably not much performance benefit, but it sure is good at
identifying leftover intermediate variables from previous
refactorings.

Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657
Reviewed-on: https://gerrit.libreoffice.org/24026
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-18 07:37:31 +00:00
Noel Grandin
62633dfe02 clang-tidy performance-unnecessary-value-param in various 
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907
Reviewed-on: https://gerrit.libreoffice.org/24019
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-14 11:37:19 +00:00
Noel Grandin
cc2f103744 loplugin:passstuffbyref in sdext 
Change-Id: I954510b953dab133bcf7b37cf598757b7d8e5fca
 2016-04-14 09:21:40 +02:00
Stephan Bergmann
028dcd41ab Avoid reserved identifier 
Change-Id: I0d75653dcde39b0fbd8af723295262615978d903
 2016-04-12 20:03:42 +02:00
Jochen Nitschke
4c7ec9f112 cleanup: remove unused com/sun/star/uno includes 
Sequence.h(xx), Any.h(xx) and Type.h(xx)
and remove unused using-declarations from these files.

Add a few missing includes provided by them.

Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4
Reviewed-on: https://gerrit.libreoffice.org/23805
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-12 06:38:26 +00:00
Jochen Nitschke
c210bf4510 tdf#94306 replace boost::noncopyable r.. to sdext 
... in modules reportdesign to sdext
Replace with C++11 delete copy-constructur and
copy-assignment.
Remove boost/noncopyable.hpp includes.
Make some overloaded ctors explicit
(most in sd slidesorter).
Add deleted copy-assignment in sc/inc/chart2uno.hxx.

Change-Id: I21d4209f0ddb00063ca827474516a05ab4bb2f9a
Reviewed-on: https://gerrit.libreoffice.org/23970
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-11 07:15:35 +00:00
Stephan Bergmann
15421d71bf Avoid reserved identifier 
Change-Id: I3ded47656c4e0f1c3134337bddab5713f29be27e
 2016-04-06 14:56:11 +02:00
Jochen Nitschke
f7a75a66fa cleanup: remove unused Reference.h(xx) includes 
and unused using-declarations from Reference.h

Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19
Reviewed-on: https://gerrit.libreoffice.org/23735
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2016-04-02 19:01:24 +00:00
Noel Grandin
c09d0aa46c loplugin:constantparam in sd 
Change-Id: I1a7f4cab28a70c45e5232e1c44f6ca6f7b014bff
 2016-03-24 11:41:01 +02:00
Noel Grandin
50b39947cb loplugin:constantparam in sdext 
Change-Id: Ib349a856665776ef51524b3c6613774f739bbdfe
 2016-03-23 09:13:14 +02:00
David Tardon
0f0cea28c7 delete hidden pages before deleting unused masters 
Change-Id: I40b624c0e6e6cff2c88815f7d16e862f09d79d5c
 2016-03-22 09:05:26 +01:00
Douglas Mencken
be2c79c0fa sdext.presenter: change OSL_TRACE -> SAL_INFO 
Change-Id: I34724f28b96b00b8afe2b618d8d47561082987ca
Reviewed-on: https://gerrit.libreoffice.org/23311
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
 2016-03-17 07:40:41 +00:00
Wastack
018c6adf85 tdf#97966: Remove 'static' keywords 
Change-Id: I0d9837a7ccecd606e0d43b53f8b920547b0d0bcd
Reviewed-on: https://gerrit.libreoffice.org/23132
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2016-03-11 08:56:20 +00:00
Caolán McNamara
b20af8b684 coverity#1355499 Unchecked return value 
Change-Id: I0b9329d00bfcebb6e29db6786715b19a7697d087
 2016-03-10 22:14:59 +00:00
Stephan Bergmann
60b1c95cc4 Extract Directories from BootstrapFixtureBase 
(as some tests derive from the latter only for the Directories part, not for the
setUp/tearDown overrides: those tests will be cleaned up next)

Change-Id: Ib6b78eea868b8bc21d4cc6e8fd9e1d025deca05f
Reviewed-on: https://gerrit.libreoffice.org/23078
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2016-03-10 08:04:40 +00:00
Mike Kaganski
345d5b172c tdf#98421: properly import vertical mirroring of images from PDF 
Since commit ae0e830f9ace78b889713e7e74ce46f88fa21470, mirroring
is handled correctly in LO, so no need to handle it specially in
PDF import code. Commit 11c865031cffc170d3db6b00fb48c683fb4ff070
fixed import to Draw, this one fixes import to Writer.
Also, unit tests for both cases are provided.

Change-Id: I9ef9753a364af34f9e158052855c5dba1300c934
Reviewed-on: https://gerrit.libreoffice.org/23028
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2016-03-09 10:20:48 +00:00
Stephan Bergmann
b9a25b254b Various loplugin warnings 
Change-Id: I7a405bc22d6ff337d53ad2c187f2ae1726798bb5
 2016-03-08 17:08:34 +01:00
Tor Lillqvist
56f9a64899 Remove spurious \r from OSL_TRACE output 
Change-Id: I84f34f25a5d0deb6a23c233b981daacea4fe9d33
 2016-03-08 16:10:19 +02:00
Rohan Kumar
ea3151acb4 tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionals 
I replaced OSL_DEBUG_LEVEL > 1 to OSL_DEBUG_LEVEL > 0 in most of
the files as suggested in easy hack

Change-Id: I2c46dfd9de2ae965680494146120ea3c7530cc98
Reviewed-on: https://gerrit.libreoffice.org/23012
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
 2016-03-08 14:00:30 +00:00
Stephan Bergmann
f43e0fe4d6 Silence -Werror,-Wundef in external/poppler includes (clang-cl) 
Change-Id: I42ae8b5d1769eba3e5af68b3b183c77f40c35ca8
 2016-03-04 10:11:13 +01:00