Commit Graph

1845 Commits

Author SHA1 Message Date
97f1db8cdb Resolves: #i119999# Single ESC to leave Chart OLE mode after creation
Patch by: Tan Li
Review by: alg

(cherry picked from commit a3677e22a4c4ea24d2a66cefcae0872e94e1c1ea)

Conflicts:
	chart2/source/controller/main/ChartController.cxx

Change-Id: I2e87bd49ec750026ad74ca0256b63ba5f4228355
2013-05-11 20:26:43 +01:00
2ce25faffd fix typos (wich instead of which) 2013-05-06 20:07:23 +02:00
4a4bdc142a fix the remaining issues with the changed handling of ErrorBar props
Change-Id: I75c839cbfccbe84e7aa98aef6959bcd0c5390ab6
2013-04-22 13:57:31 +02:00
cd5c2c0c40 Remove a few unnecessary #includes
Change-Id: I47c0f097f91c7cac7af91a15326e73ca201952ad
Reviewed-on: https://gerrit.libreoffice.org/3448
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-04-18 18:09:59 +00:00
83828891e4 Delete unused code in one file.
Change-Id: Ib468dd87e1624bd02b4d190699cd864514664229
Reviewed-on: https://gerrit.libreoffice.org/3446
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-04-18 10:34:27 +00:00
8e528bd241 Remove unused code
Change-Id: Id4ce1d003db61374ba68f807090860595178b562
Reviewed-on: https://gerrit.libreoffice.org/3447
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-04-18 09:06:15 +00:00
edc3bfd558 Adding the dialog for setting stepped lines.
The UI changes still need some more tweaking:
- adjusting the vertical alignment in the splineresourcegroup
- put the images in the radio buttons instead of in front of them

Change-Id: I4bc5ebe5167eca9a5b1341d9328a7d74b62cf819
2013-04-13 02:34:29 +02:00
86fdce6011 fdo#46808, Convert svt::ToolboxController to XComponentContext
.. and all of it's friends

Change-Id: I408d9308d1d1a4f8ed0055ac5f4042d729c44d1e
2013-04-08 13:53:03 +02:00
3f3980ff24 Some cppcheck cleaning
Change-Id: I425ed98a721ded162c2ae08d145aaa9dbf548632
2013-04-07 22:18:57 +02:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
ff85b2c3d1 fdo#38838 : Replacement of String with OUString in core/chart2
Change-Id: I7abf9649a0c5997cebfe3463ce9b633ab59bf3b0
Reviewed-on: https://gerrit.libreoffice.org/3142
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-04-02 16:29:28 +00:00
63f00101c5 fix the build on non-C++11 platforms 2013-04-02 11:25:36 +02:00
641d8eaa98 move chart .ui files into existing schart dir
Change-Id: I72509b73778eb2887a4872016487e146a9384d2f
2013-04-02 10:27:58 +01:00
55f878d7ea various efforts to consistently apply HIG rules
Change-Id: I70c5cd5c8bd1104c717ee6d8ed6b5f43a079596a
2013-04-02 09:46:34 +01:00
cd5f047537 Converting Smooth Lines dialog to glade
Change-Id: I098267a4b11322df84f4a10e83f3c47a69418371
Reviewed-on: https://gerrit.libreoffice.org/3103
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-04-02 08:44:27 +00:00
2b7ee1db28 remove boilerplate comments
Change-Id: I44a476a9843816f70a7a4d84b8c35edeecd5daaf
2013-04-01 22:45:36 +02:00
bc2f2ab20a move the dialog to chart2
Change-Id: I9f6e967d52dd10072c57b4f55faedd4ed7f98094
2013-03-28 10:11:02 +01:00
a2c8ae13a1 Converting spline dialog box to glade.
Change-Id: I945445ab703b146b048cd45768d256d8b6a833d5
2013-03-28 10:11:01 +01:00
aa753f01ba -Wunused-macros
Change-Id: Ifaa1637122d6f9cae1e29b77ac36ca5d1f220aed
2013-03-27 09:36:53 +01:00
07b5102e7b There are many ships in the port of Hamburg but "ownership" is not one
Change-Id: I971390d084b08293b21fdc35beb74482a1560bb8
2013-03-25 23:58:12 +02:00
bbc96d45d4 Related coverity#704213/704214/704215 Logically dead code
Change-Id: I80c119b2287ff0c4f2e467943be6a7682914934a
2013-03-23 14:28:52 +01:00
b2f8318dbd simplify OUString assignments
Change-Id: Ieffd80aa84c9a041785bb81b3a904a32d00cb2bb
Reviewed-on: https://gerrit.libreoffice.org/2863
Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>
2013-03-20 10:28:58 +00:00
a066525b42 fdo#46808, Convert a bunch of comphelper::ComponentContext stuff
.. to Reference<XComponentContext>
mostly in the dbaccess module, but it also affected some other
modules.

Change-Id: I09b3f6fe7a9b33498b11d98b5521b5aeeb8882be
2013-03-20 07:32:53 +02:00
dc53c77ad5 Assume that these shall indeed check full string equality
...instead of prefix match as the use of
compareToAscii(RTL_CONSTASCII_STRINGPARAM(...)) prior to
b380744c205089aa0b480e059bec645631010444 "Remove some RTL_* and some rtl::
prefixes in chart2" would have suggested.  But the only two clients of
com.sun.star.comp.chart2.WizardDialog that I could find
(sc/source/ui/drawfunc/fuins2.cxx, sw/source/ui/table/chartins.cxx) indeed only
use "ChartModel" and "ParentWindow".

Change-Id: I0553c2c9648959ed558afb4f6cdea0e15a29cb9e
2013-03-19 17:46:51 +01:00
7e18e657c1 let us keep the gnumeric value handling in xmloff
Change-Id: I51c7ca53ec8b023dc06b43ec9cb1052d135d14d5
2013-03-19 02:36:46 +01:00
bf033461c5 fdo#61135 stepped lines graph: handle ods files
The boilerplate code for drawing the 4 types of stepped is in place (as
described in ODF1.3,
https://tools.oasis-open.org/issues/browse/OFFICE-3662).
We can also read the current attribute values used in Gnumeric. These values
are converted to ODF1.3 during save.

Change-Id: I0f04a779de4b65326ed7ce6de56191f11b51c596
2013-03-19 02:36:46 +01:00
38d3e115c1 vcl: make Region ctors explicit to prevent overloading desasters
Change-Id: Id36d125b4940418833bec31a4710d6cd545629e0
2013-03-13 22:29:46 +01:00
a0296296fb fdo#60691 add modelines to *.src and *.hrc files
use solenv/bin/add-modulelines script for the task
and remove all UTF bom from *.src and *.hrc files

svx/source/dialog/hdft.src

Change-Id: I745d4f0fe9b05436a142a03f8512970f91c41bd4
2013-03-08 21:02:26 +00:00
a6b9173005 fdo#60148 Clean up warnings from the Clang compiler plugin
Change-Id: I08d755677c46c476710ecbd067ed9f7e2f54a671
loplugin: clean warnings: unused variables, incorrect indentation and log area.
Reviewed-on: https://gerrit.libreoffice.org/2544
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-03-06 12:59:26 +00:00
c510281181 no need for the dynamic cast anymore
Change-Id: Ieef97a7c2bff0d5aaffb6034e057b33bc9c65a5b
2013-03-04 14:11:05 +01:00
d8105ab9f3 make this a real assert to find these problems earlier
Change-Id: Ie23de38f5f79a7a72b6ce8d4da7aa0f5e4dd2a93
2013-03-04 14:11:04 +01:00
1f810b3adf we need to use GetParentDialog nowadays, fdo#60253
Change-Id: I6317ce1f99af58439f7009cac5a4bc133e404dbf
2013-03-04 13:54:57 +01:00
fa878018de fdo#60724: fix resizeable -> resizable misspelling found by lintian
Change-Id: I07488c02277292f96c08be6155edf0158976cc0b
2013-03-03 12:45:21 +01:00
a0e717596d coverity#736939: swapped arguments
Change-Id: I66f44ba02855cb9e1f9a986b6f60aa9710e117bd
2013-03-02 06:51:50 +01:00
b93b23fe10 Replace rtl::O(U)String with O(U)String
Other changes include:
in bridges/test/testcomp.cxx duplicate 'using namespace ::test' removed,
'using namespace ::rtl' replaced with 'using ::rtl::OUString' and
'using ::rtl::OUStringToOString'

Change-Id: I67a5952afd305adeb07f728c9074620ecba8e9fc
Reviewed-on: https://gerrit.libreoffice.org/2475
Reviewed-by: Andras Timar <atimar@suse.com>
Tested-by: Andras Timar <atimar@suse.com>
2013-03-01 13:19:13 +00:00
a1b5e1bbed coverity#705132: add missing break
Change-Id: Id3a3c33854c677cbbcc835e09de3a297512d97eb
2013-03-01 05:27:15 +01:00
4f4e4e40f5 loplugin: improve indentation
Change-Id: Idb847766d93dc222d6c55889616da21eeac212ee
2013-02-25 17:59:40 +01:00
d05287a9f1 RTL_CONSTASCII_USTRINGPARAM removals
Removed all occurences of RTL_CONSTASCII_USTRINGPARAM in chart2.

Change-Id: I0ab188e2d67a5fc17a3653e5213031f6e2c2581d
Reviewed-on: https://gerrit.libreoffice.org/2244
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-02-20 22:58:20 +00:00
1aaf9a9b36 Renamed hard-to-remember 8-char headers in editeng.
Change-Id: If255802082890e1b1b4c5197a791fa79a011773e
2013-02-12 15:15:06 -05:00
5acf58bbde remove obsolete hidother.src files
Change-Id: Ieb30afd81d16d184e0276ce7699b848f26a00013
2013-02-06 14:51:42 +01:00
97eb8a6e0e Removed several useless macros: A2OU, A2S, C2U, C2S, OUSTR, OUSTRING
Change-Id: Ie859cb2dfdc7103c379fce56be88eef8fe390afd
Reviewed-on: https://gerrit.libreoffice.org/1924
Tested-by: Luboš Luňák <l.lunak@suse.cz>
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-30 12:54:40 +00:00
bd272cd3da rename SfxSingleTabDialog to SfxNoLayoutSingleTabDialog
Change-Id: I4922b719bf819879909e9949bf7946f20914d1e5
2013-01-24 14:29:46 +00:00
d71e8fb17b Unused #include
Change-Id: Ib6a4e79d539f79911840acf783b5b62fab27acfe
2013-01-24 09:57:35 +01:00
e3f11c10d8 Changed SetText() / GetText() to take/return OUString
replaced lots of Len() with isEmpty()

Change-Id: I6b82d48245ee2a0782e05a326f7934e9357227d0
Reviewed-on: https://gerrit.libreoffice.org/1795
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-01-21 20:48:35 +00:00
c5fc0af6f5 Remove GetAllMarkedModel() since all it does is call GetMarkedObjModel().
One less indirection makes the code a tad easier to follow.

Change-Id: I8e1113617c09f91c0cad32277ee4e32c78f9f058
2013-01-16 11:22:15 -05:00
aea18e985e fdo#57950: Remove some chained appends in chart2 and more
Removed a not needed variable;
Removed some rt:: prefixes

Change-Id: I24a7a0c5adcee17eab4c9d6442b472a5992f261e
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/1549
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-07 13:59:02 +00:00
b380744c20 Remove some RTL_* and some rtl:: prefixes in chart2
Change-Id: I47889319530d8f03bd7c78e937de55cf380d2d41
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/1550
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-07 13:57:43 +00:00
bb121c864c fdo#46808, Convert frame::Desktop to new style service.
I had to drop XEventBroadcaster from the merged interface
because it introduced method name conflicts (addEventListener).

Shouldn't be an issue since it was scheduled to be dropped anyhow,
and the service implementation still implements it, so existing clients
will be fine.

I dropped the interface XPropertySet from the combined IDL because nobody
seems to be using it, and it's primary purpose appears to be to set weird
flags.

I dropped the optional interfaces
   XStatusIndicatorFactory
   XDispatchInformationProvider
from the combined IDL because the service does not implement them, and
nobody seems to be using them. I suspect they were mistakenly copied
from XFrame.

I also did not convert the Title, UserDefinedAttributes and LayoutManager
properties to attributes, again because no-one is using them.

Change-Id: I678a00006ed2cca2d6c37c4e39465811442c33af
2012-12-21 10:57:09 +02:00
3e49d72847 Some cppcheck cleaning in chart2/
Change-Id: I1f8fcdd78029344c735cd4364c8b081d692e2f4e
2012-12-15 18:28:02 +01:00
6858182d24 bnc#791952: Setting properties for all data labels.
You can set different properties to individual data labels.  But setting
new properties to all data labels should overwrite the individual settings.

Change-Id: I934bad89326115aa83feb86275cf380d701a5686
2012-12-08 00:04:49 -05:00