Commit Graph

225 Commits

Author SHA1 Message Date
e2e2cc6114 remove usage of RTL_CONSTASCII_USTRINGPARAM
Mechanical removal of usage together with OUString ctor, done
by compiler plugin.

Change-Id: I554227f76df0dac620b1b46fca32516f78b462c5
2013-05-06 16:51:45 +02:00
99d851b3e2 Kill copy'n'paste.
Change-Id: I5e5b80f8d8efe91df806bb7ae9750fd84009c6be
2013-04-10 10:39:54 +02:00
2dc7318d84 Kill not necessasy OUString member variables.
Change-Id: I1bbfd19bc70fc12ac5dc5fdb18c556f4dc5300cb
2013-04-09 17:48:52 +02:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
a85c027936 Remove unused variables
The LayoutManager for some reason has both a ToolbarLayoutManager
pointer field, and a uno::Reference to an aspect (or whatever term one
should use) of the same ToolbarLayoutManager. (I.e. esssentially two
fields for the same thing. Why it doesn't create such variables where
needed instead I don't know.)

Anyway, for some reason there were lots of instances where a local
variable was initialised with this second field but then never used. I
removed those. (Surely just copying the field into a local variable
doesn't have any interesting side effect that would explain this
pattern?)

Change-Id: Ibdfbd9476c39d3e83b58e81469b94d9a87444ca8
2013-04-07 01:13:37 +03:00
4214ff23ad fdo#37758: Really set the toolbar as hidden.
Change-Id: If0cdf2fabb680f8dee811411f601b2954d29da58
2013-04-04 21:24:57 +02:00
4c0c23af21 Simplify equalsIgnoreAsciiCaseAscii[L] calls
Change-Id: If5201bd772aed245e8f7f8b900d76ffe4ca57b49
2013-03-19 11:32:20 +01:00
fd4380759d RTL_CONSTASCII_USTRINGPARAM and ::rtl:: removals
Change-Id: Ief6418425676d6943993513c4d05c8d22e4740cf
Reviewed-on: https://gerrit.libreoffice.org/2470
Tested-by: Thomas Arnhold <thomas@arnhold.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-08 02:45:23 +00:00
26e37ca4c7 doubled includes
Change-Id: I70ec796188e2388e1e4d699126f7ae817f5ff86e
2013-03-04 13:58:40 +01:00
e3f141323e Fix typos retreive/retrieve furture/future
Change-Id: I639c2970b2a88ca3d5aa1dcd2ad4ec047b4a369c
2013-02-23 16:51:36 +01:00
616c6924f1 s/the the/the/
Change-Id: Iadacffaad832c6ff06757e8567e24f929f24a4c3
2013-02-22 09:58:19 +02:00
e3f11c10d8 Changed SetText() / GetText() to take/return OUString
replaced lots of Len() with isEmpty()

Change-Id: I6b82d48245ee2a0782e05a326f7934e9357227d0
Reviewed-on: https://gerrit.libreoffice.org/1795
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-01-21 20:48:35 +00:00
dde234b695 fdo#46808, remove awt::DisplayAccess service.
This service was never documented in an IDL file.
All it did was provide a wrapper around some VCL module API.
Now that we can link the VCL stuff into SD and SDEXT, just
access the API directly.

Change-Id: Ic0ba34c2bca797baa7319878d98cfe3a4ec59d4d
2012-12-13 05:20:59 +02:00
b552f521f6 fdo#46808, Adapt ui::UIElementFactoryManager UNO service to new style
Required creating a new merged interface.

Change-Id: I12be54e7e4c0614a31a04715342aa244d1687c42
2012-12-13 05:20:58 +02:00
c1e42d60c5 fdo#46808, use service constructor for ui::WindowStateConfiguration
Change-Id: I0b7f773a7db47049d7df4138d07e7fc38c657a65
2012-12-13 05:20:58 +02:00
9779ae8bde fdo#46808, use service constructor for ui::
::ModuleUIConfigurationManagerSupplier

Change-Id: I06e8b3ef9b525da014a2bb7702587d360779aebc
2012-12-13 05:20:58 +02:00
17ff7b41d1 re-base on ALv2 code. Includes:
Patches contributed by: Armin Le Grand.
    #118558# Correcting OLE attributes of LO3.4 at load time by loading as OOo3.3, details see task.
    http://svn.apache.org/viewvc?view=revision&revision=1195906
    #118485# - Styles for OLEs are not saved.
    http://svn.apache.org/viewvc?view=revision&revision=1182166
    #118898# Adapted ImpGraphic::ImplGetBitmap to correctly convert metafiles
    http://svn.apache.org/viewvc?view=revision&revision=1293316
    #119337# Solves the wrong get/setPropertyValue calls in
    SvxShapeText (and thus in SvxOle2Shape)
    http://svn.apache.org/viewvc?view=revision&revision=1344156

    Patches contributed by Mathias Bauer (and others)
    gnumake4 work variously
    http://svn.apache.org/viewvc?view=revision&revision=1394707
    http://svn.apache.org/viewvc?view=revision&revision=1394326
    cws mba34issues01: #i117717#: remove wrong assertion
    http://svn.apache.org/viewvc?view=revision&revision=1172349

    Patch contributed by Herbert Duerr
    goodbye Registration and License dialogs, don't let the door hit you
    http://svn.apache.org/viewvc?view=revision&revision=1172613
    help gcc 4.6.0 on 32bit ubuntu 11.10"
    http://svn.apache.org/viewvc?view=revision&revision=1245357

    Do not add targets for junit tests when junit is disabled.
    Patch contributed by Andre Fischer
    http://svn.apache.org/viewvc?view=revision&revision=1241508

Revert "sb140: #i117082# avoid unncessary static class data members
    commit 21d97438e2944861e26e4984195f959a0cce1e41.
remove obsolete FreeBSD visibility special case.
retain consolidated BSD bridge code, remove OS/2 pieces.
2012-11-15 16:06:08 +00:00
dbf239ddda Revert "sb140: #i116786# use auto_ptr to track member lifetime"
This reverts commit 335f7fa8c2ef418df7010dd996a2a32bbbdff459.

Conflicts:
	framework/source/layoutmanager/toolbarlayoutmanager.cxx
2012-11-15 16:06:06 +00:00
0ac9a10d31 fdo#46808, Deprecate configuration::ConfigurationProvider old-style service
...in favor of existing new-style configuration::theDefaultProvider singleton.

Theoretically, ConfigurationProvider instances can be created with specific
Locale and EnableAsync arguments, but this is hardly used in practice, and thus
effectively all uses of the ConfigurationProvider service use the
theDefaultProvider instance, anyway.

theDefaultProvider is restricted to the XMultiServiceFactory interface, while
ConfigurationProvider also makes available XComponent.  However, dispose must
not be called manually on theDefaultProvider singleton anyway, and calls to
add-/removeEventListener are so few (and in dubious code that should better be
cleaned up) that requiring an explicit queryInterface does not really hurt
there.

This commit originated as a patch by Noel Grandin to "Adapt
configuration::ConfigurationProvider UNO service to new style [by creating] a
merged XConfigurationProvider interface for this service to implement."  It was
then modified by Stephan Bergmann by deprecating ConfigurationProvider instead
of adding XConfigurationProvider and by replacing calls to
ConfigurationProvider::create with calls to theDefaultProvider::get.

Change-Id: I9c16700afe0faff1ef6f20338a66bd7a9af990bd
2012-10-31 15:31:36 +01:00
b8abd03688 fdo#46808, use service constructor for frame::DispatchHelper 2012-10-24 17:59:30 +02:00
33a0f8ce65 fdo#46808, Adapt awt::Toolkit UNO service to new style
Create a merged XToolkit2 interface for this service to implement.
Which is backwards-compatible, but does not require creating a new service.

Also mark sub-interfaces as non-optional.

Change-Id: I278d0288e92be277033013302267cf93f7d70480
2012-10-24 16:49:49 +02:00
432c0f4917 fdo#46808, use service constructor for frame::ModuleManager
Change-Id: Iae2bd22a22213274d4a7697345b879f6573a30f0
2012-10-23 17:44:16 +02:00
2dd0712a12 loplugin: unused Strings
Change-Id: Ie9c888a48716e4bfd24ae78eef5f6e4a54dd1810
2012-10-12 09:22:23 +01:00
6f1bdda2d2 loplugin: more unused OUStrings and so forth
Change-Id: I4f3a51e1fd3ddca9442022a7134306fbf32e13ae
2012-10-11 15:01:47 +01:00
c2ca6fabd1 Use comphelper::getComponentContext
...and some further clean up.

Change-Id: Id294c0f38fe0041646fc86cacbd2e19734c746a9
2012-09-29 18:18:28 +02:00
03a9f139bd ComponentContext::getUnoContext -> getComponentContext simplification
...and some further clean-up.

Change-Id: If5dce53e382b56390c502d0d0d93fc06cbfe33ea
2012-09-19 13:16:38 +02:00
35c9ffb275 Fix off-by-one drawing problems of the bottom docking area.
Change-Id: Ic463f6829f7faa6d9667656f42f844a12d85518e
2012-08-23 17:54:00 +02:00
8a11858921 -Werror,-Wunused-private-field (Clang towards 3.2)
Change-Id: I57abfb3b3d659edcd130788d173c2df3b79101f0
2012-08-16 09:47:00 +02:00
88840a796e Remove unused local vars
Change-Id: I80bd0329e15cb365091ea6f5c7e1ef3559d681fc
2012-08-11 10:25:54 +02:00
2beba8f93e reduce ascii noise and useless comments
Change-Id: I317058e3b25cebb7c1d89361636261c5f16a84d4
2012-08-08 13:53:54 +02:00
49ad17e2b1 remove include comments and boxes
Change-Id: I9ccf664e8f75a68b1b87c2b29ae617a90d0741a7
2012-08-08 13:53:53 +02:00
4dd7c0369d Various Clang 3.1 -Wunsued-variable, -Wconstant-conversion
Change-Id: I0799f22685609201dfb524c373d065b6184ed53c
2012-07-18 08:23:28 +02:00
e45bb323ee Fix prefix ++/-- operators for non-primitive types
Change-Id: Ibb55fcedecaf66f0817d24d8f408ef69d273ffa2
2012-06-23 23:06:48 +02:00
0fcd1a73f0 fdo#46808, Adapt UNO services to new style, Part 7, updating ::create
Update code to use factory method URLTransformer::create

Change-Id: I3fd2e838497bcfd8fc949615c0e7d60a6ea47118
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, added some tweaks.
2012-06-06 10:53:34 +02:00
ca99673446 fdo#50651: update layout after toolbar destruction
plus update confusing comments

Change-Id: I9bdab918566548b576fd22389492216fc4aff7df
2012-06-06 11:29:56 +04:00
eeac114217 targeted string re-work
Change-Id: I3276836b76b69f04de38c2d36ae04b60c49d4873
2012-06-02 20:41:34 -05:00
dc0d009f10 targetted misc. minor cppcheck cleanups reversion
Change-Id: Ic7f91c035d3e7f0e792d2e9ab217e1fc4ebcf697
2012-05-31 14:58:05 +01:00
df34ccb01d remove unneeded include of boost/bind.hpp
Change-Id: I5a254459a491b9547530d8e312260dceed21f25c
2012-05-16 15:05:36 +01:00
7c5064d3bd resolved fdo#46160 query model only once whether it is a preview
Query a frame's model only once whether it is a preview model, instead of
doing it for each toolbar and menubar and statusbar and progressbar. Each call
via SfxBaseModel::getArgs() results in SfxObjectShell::GetVisArea() that at
least in Calc determines how far visible attributes extend, with several
toolbars requested on each cell edit.

getArgs() calls GetVisArea() still too many times when loading a document even
if the caller doesn't evaluate the WinExtent property, this is an opportunity
for further optimization.
2012-05-04 23:14:51 +02:00
135c63c8f9 fdo#48253 Expand SAL_STATIC_CAST and SAL_CONST_CAST
Change-Id: I50f0887ceb4517d7ef234f970ca2ba679d533382
2012-05-04 15:52:57 +02:00
3030a3a52f offapi: remove obsolete XInplaceLayout (2nd try)
This is related to 10e580c57b907420e8c6d816325445a40a720e4a
2012-04-12 11:39:13 +02:00
d6bc02f8c4 Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator 2012-04-06 20:03:42 +02:00
743f22045c Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator
Pattern used:

find . -name "*.cxx" -exec sed -i 's/\( *\)\(else if\|if\) *( *\([^!()|&]*\)\.equalsAsciiL( *RTL_CONSTASCII_STRINGPARAM *( *\([^)]*\)) *) *)$/\1\2 ( \3 == \4 )/' \{\} \;
2012-04-06 15:07:41 +02:00
bd205223ec New IMPL_LINK_NOARG to work around SAL_UNUSED_PARAMETER problem
...see ebe26f72e90337da2d14f3029de148904e3e30b6 "WaE: 'unused' attribute ignored when parsing type"
for the problem.
2012-03-01 18:00:32 +01:00
155f694da8 WaE: duplicateBranch 2012-02-21 20:56:58 +01:00
96cb767123 Prefer equalsIgnoreAsciiCaseAsciiL(RTL_CONSTASCII_STRINGPARAM("..."))
to equalsIgnoreAsciiCaseAscii("...")
2012-02-19 23:28:55 +09:00
10e580c57b Revert "offapi: remove obsolete XInplaceLayout"
This reverts commit 5ca858c01cb2e2aa93c8aca65fd271a900785e3f.

This change implicates some more changes in layoutmanager.hxx
see ::cppu::WeakImplHelper8. So keep it...
2012-02-18 22:16:30 +01:00
5ca858c01c offapi: remove obsolete XInplaceLayout 2012-02-18 21:33:05 +01:00
2b1758a2dc Prefer equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) to equalsAscii(...) 2012-02-10 23:01:07 +09:00
18692cc141 Fix for fdo43460 Part XX getLength() to isEmpty()
Part XX
Module
framework
2011-12-30 10:56:15 +01:00