56e6f0da83
new loplugin: badvectorinit
...
look for places calling the 1-argument vector fill constructor and then
immediately called push_back, which is generally a sign that its
leaving empty slots.
Change-Id: I34e69b8d09cc48c0d409499faaf192b9f86bc517
Reviewed-on: https://gerrit.libreoffice.org/17525
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
2015-10-20 11:35:31 +00:00
dedf0a28d5
loplugin:defaultparams
...
Change-Id: I03541b984db147f8bd3ed35f83e297cf7eecd7f0
2015-10-20 11:44:54 +02:00
1707c47de7
loplugin:defaultparams
...
Change-Id: I946e1970647d8005f54ac0362f5c2b04f867b22f
2015-10-19 17:49:17 +02:00
367105e024
cleanup some local var declarations
...
found with
git grep -nP '(\w+)\s+=\s+\g1\(' | lots-of-hand-filtering
Change-Id: I598b0cfa6607823eaef09d95e610e05145c727f7
2015-10-19 13:08:29 +02:00
51f10626e6
tdf#94960, Revert "it is insane to not map line and ..."
...
This reverts commit 84254268bf5902d2405815970218e1893a7a673e.
Change-Id: Id99bc1f44a4e23daaf2f12585981c0be66cbeda5
2015-10-18 14:52:12 +02:00
9facb8271d
coverity#1327446 Unchecked dynamic_cast
...
Change-Id: Ib409b7fe4244b89f8767b20adcfae060f121b2f2
2015-10-17 14:46:26 +01:00
945965e525
convert Link<> to typed
...
Change-Id: I51d39d9d1688c4c734cd132213ef654fdc7d9b8e
2015-10-16 14:12:51 +02:00
6f1313b3d4
convert Link<> to typed
...
Change-Id: Icbba339dac0be31e30dff021bba06a219f8aecd6
Reviewed-on: https://gerrit.libreoffice.org/19405
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-16 09:11:29 +00:00
cb7563e8ea
-Werror,-Wunused-private-field
...
Change-Id: I936ddbabb22e3dc16080ef0b11d585ea98442e57
2015-10-15 17:41:03 +02:00
0e8a40e8b8
calling IsSet() before Call() on Link<> is unnecessary
...
the Call() already does a check
Found with:
git grep -A 1 -w 'IsSet()'
| grep -B 1 '.Call('
| grep ':'
| cut -d ':' -f 1
Change-Id: Ia7248f5d62640b75f705e539c3d1183e39c0d847
2015-10-15 12:29:01 +02:00
1716b3a338
remove some useless comments
...
found with git grep '// /'
Change-Id: I948cf9ae61bbbf2ec706ca5b0572c4f27c58c745
2015-10-13 10:07:49 +02:00
af77042f62
disable arrow heads in chart sidebar, tdf#94971
...
Change-Id: I631f34faf2befeb7cc61027c8fd59ef7b3543785
2015-10-12 23:54:14 +02:00
01cc898aac
update the line panel for data points, related tdf#94969
...
Change-Id: Ieffdfd1cc0d6b5cc0dd8394896aeb49838096a6b
2015-10-12 23:54:14 +02:00
2753cd3087
update area panel for data points, tdf#94969
...
Change-Id: I700ae8ff591ef1ea82887b1ec2cd7b4be04978db
2015-10-12 23:54:14 +02:00
ba45d25420
Replace "SAL_FINAL" with "final" in LIBO_INTERNAL_ONLY code
...
Change-Id: Ifa5ba21308e32df44571fa2941370f2f11179580
2015-10-12 17:52:30 +02:00
b36963c0a6
Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
...
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
bff4c13475
Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY code
...
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-12 17:52:26 +02:00
3c99f8500f
convert Link<> to typed
...
Change-Id: Iec15042138e0715459b2c9e872a7464d75a6b1eb
Reviewed-on: https://gerrit.libreoffice.org/19305
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-12 10:48:13 +00:00
0f88736128
loplugin:mergeclasses
...
Change-Id: Icd01de71fe87e0bf17eba39f5b00fc9a46765509
2015-10-12 09:13:33 +02:00
82cf6c6737
also update line panel for axis, related tdf#94933
...
Change-Id: Ie280fa01dbe25287d01b7f36d152ee55ce5dbe07
2015-10-10 16:54:43 +02:00
3ddad211de
also update line panel for average and trend line, tdf#94933
...
Change-Id: I7ab991e94005665809ec52b8d4310209eb6ef75b
2015-10-10 16:44:51 +02:00
5f73eae61e
we need to take the SolarMutex when we change the UI
...
Change-Id: I6347a1466038afd625cf59ae2ee87cb4e2014aa0
2015-10-10 16:21:29 +02:00
14237c1678
use trendline context for trendlines, tdf#94931, tdf#94934
...
Change-Id: I0cb9cdec33924e560b24744cc78d632025a189fc
2015-10-10 15:24:50 +02:00
33972dea7d
correctly dispose the chart sidebar when leaving chart, tdf#94292
...
This is a much better approach than my old one that tried to use the
correct XModel with the chart sidebar. Now everytime we leave the chart
edit mdoe we destroy the chart sidebar panels and recreate them when we
go back to chart edit mode.
As a result we no longer need to have worry that much about using the
correct ChartModel and about the lifecycle of the ChartModel.
Change-Id: Ie85ad82968e20a81f059d4bd930a83a70da35fc9
2015-10-09 20:42:11 +02:00
bfa0c4c998
remove whitespace
...
Change-Id: I6390f16a6c2346c4c903a34d702277b931bc0079
2015-10-09 20:42:10 +02:00
c1df3a34dd
loplugin:literaltoboolconversion
...
Change-Id: Ie2d1b466f5773799347aac59d7b5dc25f283b920
2015-10-09 09:30:54 +02:00
32b2668f2f
Moving average trendline equation: remove initialisation
...
Change-Id: I3fa01a2d03e7de6438d0db0685e53e6b7ca6c25a
Reviewed-on: https://gerrit.libreoffice.org/19218
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-09 07:19:16 +00:00
9a94e06a36
tdf#70673 Improve exponential trend line equation
...
Use negative Y if there is only 1 positive Y
Skip some 0 or 1 in some corner case.
Add minus sign if intercept is missing
Simplify writing of equation
Change-Id: I4b164568c87c54934a38ff2d0cd72133f7fece26
Reviewed-on: https://gerrit.libreoffice.org/19033
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-09 07:19:00 +00:00
391f181c9f
chart2: replace for_each with range-based for
...
Replace complex uses of ::std::for_each with a range-based for-loop.
Change-Id: I6f3d8488a63a5bed271ab70ad6f024e9869906cc
Reviewed-on: https://gerrit.libreoffice.org/19143
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Jan Holesovsky <kendy@collabora.com >
Tested-by: Jan Holesovsky <kendy@collabora.com >
2015-10-08 09:06:46 +00:00
432ca61669
Improve polynomial trend line equation
...
Skip coefficient if its value is 1 (or near 1)
Change-Id: I39a5630cc76250ded1ab22709522344d42fcc0e9
Reviewed-on: https://gerrit.libreoffice.org/19037
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-07 10:47:57 +00:00
d52d448e7b
tdf#88154 workaround and unit test
...
Fixed 45-degree layout for axis labels, too.
Change-Id: I9764e281aeee0a439fa9eec1e3b0df840221b72f
Reviewed-on: https://gerrit.libreoffice.org/18889
Reviewed-by: Jan Holesovsky <kendy@collabora.com >
Tested-by: Jan Holesovsky <kendy@collabora.com >
2015-10-07 09:07:48 +00:00
9ed8ec510c
Improve Power trend line equation
...
Skip intercept value if it is near 1
Change-Id: Ie52b2ac06c53c2e85b3c465be28081f6dc0ad2cb
Reviewed-on: https://gerrit.libreoffice.org/19038
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-07 06:42:06 +00:00
ce9d48e5f5
Log trend line equation: Remove useless variable
...
Change-Id: I70e960742b4af2c1ab234b6d1c681254c0627b03
Reviewed-on: https://gerrit.libreoffice.org/19138
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-07 06:40:53 +00:00
05e61719e2
loplugin:mergeclasses
...
Change-Id: If918532fcc860e3deacd9c86dd7a2d554e4f748d
2015-10-07 08:27:25 +02:00
2b57de8bb0
remove another custom refcounting base class
...
Change-Id: Icd8a8d79da0ada68e9ee869c3c2a7b93db5b2733
2015-10-07 08:27:25 +02:00
9887118e19
tdf#90839: follow-up work
...
- Removed the data-label-wrap token and related code in xmloff module.
- Using the already present `fo:wrap-option` seems to be the preferred
solution: investigated to see how the token is imported exported: the
class `XMLWordWrapPropertyHdl` takes care of that, luckily it converts
the token to a boolean property.
- Fixed a minor issue in the code for the data label dialog.
Change-Id: Id050fdfeedd3af7fb79be96bfe157c61c4b44191
Reviewed-on: https://gerrit.libreoffice.org/19197
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Andras Timar <andras.timar@collabora.com >
2015-10-07 06:12:10 +00:00
a6b42f9138
clang-analyzer-deadcode.DeadStores
...
Change-Id: I96ab1c0683eadef1f7012b346705450e69ca5a65
2015-10-06 15:31:19 +02:00
0411b3477f
clang-analyzer-deadcode.DeadStores
...
Change-Id: Ibde6ee93edae124da52e2a03528a240d4066baa7
2015-10-06 15:31:18 +02:00
a4ef2e39e5
clang-analyzer-deadcode.DeadStores
...
Change-Id: I7243c1590384472bf40cdbdb5af0614fffcb253b
2015-10-06 15:31:18 +02:00
1888b37a83
clang-analyzer-deadcode.DeadStores
...
Change-Id: I3f34115b7d73e71441404866fc45894f78ab28f6
2015-10-06 15:31:17 +02:00
7b9b559035
clang-analyzer-deadcode.DeadStores
...
Change-Id: I09d518a81b392bef444d7e01aa08ce30a2aee984
2015-10-06 15:31:17 +02:00
338ef54e40
clang-analyzer-deadcode.DeadStores
...
Change-Id: I12efd66cdacbe73080855694fe397136ea59aabd
2015-10-06 15:31:16 +02:00
94ebb58443
clang-analyzer-deadcode.DeadStores
...
Change-Id: If852229c04eb5787fb017cf13f483d406d60bf07
2015-10-06 15:31:16 +02:00
cc75567406
Return rtl::Reference from ShapeTypeHandler::CreateAccessibleObject
...
...and handle related fallout
Change-Id: Ie82d853a9bf28b359d5aab9d0af01b728d68ed70
2015-10-05 16:55:15 +02:00
d7748842e9
hide grid and axes options in chart elements if not supported, tdf#94297
...
Change-Id: I358340bd1b17f0e2eb5a119a60b623e489044dd3
2015-10-03 16:22:02 +02:00
749a084550
don't show area and line panel in pie chart Chart selection, tdf#94320
...
Change-Id: I0eacedbb3d96a059278bab0ef98a66ed49b827fc
2015-10-03 16:00:21 +02:00
2957be02c5
Fix typos
...
Change-Id: I776c517ba87838c0c3391f79010a30fa7fe2abd3
Reviewed-on: https://gerrit.libreoffice.org/18939
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
2015-10-02 08:54:51 +00:00
58aea3f36c
loplugin:unusedmethods
...
- improvements to the plugin to find more method calls
- improvements to python script to remove more false+
- fix the FORCE_COMPILE_ALL build flag to include code in
the $WORKDIR
Change-Id: I4d6015dcb9b9d60c26f0bcee8abad807177a7836
Reviewed-on: https://gerrit.libreoffice.org/19064
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-01 10:43:24 +00:00
7704f81121
Trend line equation: remove useless defines
...
Change-Id: I9a2089f1f7e3b0e881d4136293d557efb3c1ef1c
Reviewed-on: https://gerrit.libreoffice.org/19001
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-09-30 06:50:07 +00:00
ac9671f948
tdf#94559: second step to remove rtti.hxx
...
replaced use of PTR_CAST, IS_TYPE, ISA in
chart2, connectivity, editeng, extensions, filter, forms, framework, idl
Change-Id: I6a2f9d8bbccb07088413f7552af4b5af8f0cad99
Reviewed-on: https://gerrit.libreoffice.org/18920
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Oliver Specht <oliver.specht@cib.de >
2015-09-30 06:07:57 +00:00