6f1313b3d4
convert Link<> to typed
...
Change-Id: Icbba339dac0be31e30dff021bba06a219f8aecd6
Reviewed-on: https://gerrit.libreoffice.org/19405
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-16 09:11:29 +00:00
0e8a40e8b8
calling IsSet() before Call() on Link<> is unnecessary
...
the Call() already does a check
Found with:
git grep -A 1 -w 'IsSet()'
| grep -B 1 '.Call('
| grep ':'
| cut -d ':' -f 1
Change-Id: Ia7248f5d62640b75f705e539c3d1183e39c0d847
2015-10-15 12:29:01 +02:00
b36963c0a6
Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
...
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
391f181c9f
chart2: replace for_each with range-based for
...
Replace complex uses of ::std::for_each with a range-based for-loop.
Change-Id: I6f3d8488a63a5bed271ab70ad6f024e9869906cc
Reviewed-on: https://gerrit.libreoffice.org/19143
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Jan Holesovsky <kendy@collabora.com >
Tested-by: Jan Holesovsky <kendy@collabora.com >
2015-10-08 09:06:46 +00:00
e85b2333bc
convert Link<> to typed
...
Change-Id: I59d325c3b051690303a5841907317122fa1ec98b
Reviewed-on: https://gerrit.libreoffice.org/18825
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-09-24 16:19:37 +00:00
33cddeea13
boost->std
...
Change-Id: Iff14f69c200217c5d868978e8ffc06962b99ac09
Reviewed-on: https://gerrit.libreoffice.org/18568
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-09-14 19:32:42 +00:00
f5ace6b29e
no need to set the help id twice
...
Change-Id: Idb903eaacf35d7b826086aae0b56fb1f496c25da
2015-08-12 17:00:56 +01:00
711b34d590
tdf#92997 obtain a date/time edit format according to field value
...
Bloody workaround hack for the fact that Chart does not handle
category/x-axis times internally and is not able to pass its own axis
numberformat to its own databrowser editor.
Change-Id: I016695ad0104366c0bb636b449a2014ade31aca3
2015-08-10 15:20:02 +02:00
7410217b7d
loplugin:unusedmethods chart2
...
Change-Id: Ib7e8824e9e7f912963fbf07111ee3aa97773ceca
Reviewed-on: https://gerrit.libreoffice.org/17167
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-20 06:34:23 +00:00
2b5ebcc45b
chart2: typed Link<>
...
Change-Id: I98c882d64cb4d6430390ac705f3f2208dd523598
2015-07-08 08:59:06 +02:00
0f71828a95
cppcheck: noExplicitConstructor
...
Change-Id: I8b03c27188b02c3c4a9a9fbbe0df1fb1ae1c5caf
2015-06-08 11:14:38 +01:00
ba81e5c6bd
tdf#91702 - fix stack-based MessBox allocation.
...
Change-Id: I62dd164e281911d9db3de453789a5badc7cd5fd7
Reviewed-on: https://gerrit.libreoffice.org/15954
Reviewed-by: Michael Meeks <michael.meeks@collabora.com >
Tested-by: Michael Meeks <michael.meeks@collabora.com >
2015-05-29 12:16:28 +00:00
cc7b8dab75
tdf#91633 - dispose chart data-table entries correctly.
...
Change-Id: Ia26df029888f47a0395ea3c8bd7e0e51a1706c2a
2015-05-26 17:54:28 +01:00
3ead3ad52f
Gradually typed Link
...
Turn the Link class into a template abstracting over the link's argument and
return types, but provide default template arguments that keep the generic,
unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the
Link class can be updated over time.
All the related macros are duplicated with ..._TYPED counterparts, that
additionally take the RetType (except for LINK_TYPED, which manages to infer the
relevant types from the supplied Member).
(It would have been attractive to change the "untyped" LinkStubs from taking a
void* to a properly typed ArgType parameter, too, but that would cause
-fsanitize=function to flag uses of "untyped" Link::Call.)
Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-30 10:20:00 +02:00
e8b97a52c9
Merge remote-tracking branch 'origin/feature/vclptr'
...
Resolve several thousand lines of conflicts.
Conflicts:
accessibility/source/extended/accessiblelistbox.cxx
accessibility/source/standard/vclxaccessiblecombobox.cxx
accessibility/source/standard/vclxaccessibledropdowncombobox.cxx
accessibility/source/standard/vclxaccessibledropdownlistbox.cxx
accessibility/source/standard/vclxaccessiblelistbox.cxx
accessibility/source/standard/vclxaccessibletextfield.cxx
basctl/source/basicide/basidesh.cxx
cui/source/inc/chardlg.hxx
cui/source/tabpages/tpbitmap.cxx
dbaccess/source/ui/dlg/UserAdmin.cxx
dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx
extensions/source/propctrlr/propertyeditor.hxx
extensions/source/scanner/sanedlg.cxx
filter/source/pdf/impdialog.cxx
include/sfx2/mgetempl.hxx
include/sfx2/sidebar/SidebarToolBox.hxx
include/sfx2/viewsh.hxx
include/svtools/brwbox.hxx
include/svtools/filectrl.hxx
include/svtools/scrwin.hxx
include/svx/dlgctrl.hxx
include/svx/sidebar/Popup.hxx
include/svx/sidebar/PopupContainer.hxx
include/svx/sidebar/PopupControl.hxx
include/svx/sidebar/SidebarDialControl.hxx
include/svx/sidebar/ValueSetWithTextControl.hxx
sc/source/ui/condformat/condformatdlgentry.cxx
sc/source/ui/navipi/navipi.cxx
sc/source/ui/sidebar/CellBorderStyleControl.hxx
sd/source/ui/animations/CustomAnimationDialog.cxx
sd/source/ui/inc/DrawViewShell.hxx
sd/source/ui/inc/Ruler.hxx
sd/source/ui/inc/SlideSorter.hxx
sd/source/ui/inc/ViewTabBar.hxx
sd/source/ui/inc/Window.hxx
sd/source/ui/inc/morphdlg.hxx
sd/source/ui/inc/sdpreslt.hxx
sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx
sd/source/ui/sidebar/LayoutMenu.hxx
sd/source/ui/sidebar/MasterPagesSelector.hxx
sd/source/ui/sidebar/NavigatorWrapper.hxx
sd/source/ui/sidebar/PanelBase.hxx
sd/source/ui/sidebar/RecentMasterPagesSelector.cxx
sd/source/ui/sidebar/RecentMasterPagesSelector.hxx
sd/source/ui/slideshow/showwindow.hxx
sd/source/ui/slidesorter/view/SlsInsertAnimator.cxx
sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx
sd/source/ui/view/ViewShellBase.cxx
sd/source/ui/view/drviewsa.cxx
sfx2/source/appl/fileobj.hxx
sfx2/source/appl/opengrf.cxx
sfx2/source/control/thumbnailviewacc.hxx
sfx2/source/dialog/securitypage.cxx
sfx2/source/dialog/templdlg.cxx
sfx2/source/doc/docinsert.cxx
sfx2/source/doc/guisaveas.cxx
sfx2/source/inc/alienwarn.hxx
sfx2/source/sidebar/Deck.cxx
sfx2/source/sidebar/Deck.hxx
sfx2/source/sidebar/DeckTitleBar.cxx
sfx2/source/sidebar/DeckTitleBar.hxx
sfx2/source/sidebar/MenuButton.cxx
sfx2/source/sidebar/MenuButton.hxx
sfx2/source/sidebar/Panel.cxx
sfx2/source/sidebar/Panel.hxx
sfx2/source/sidebar/PanelTitleBar.hxx
sfx2/source/sidebar/SidebarDockingWindow.hxx
sfx2/source/sidebar/SidebarToolBox.cxx
sfx2/source/sidebar/TabBar.hxx
sfx2/source/sidebar/TabItem.cxx
sfx2/source/sidebar/TabItem.hxx
sfx2/source/sidebar/TitleBar.hxx
sfx2/source/toolbox/imgmgr.cxx
starmath/inc/edit.hxx
starmath/inc/smmod.hxx
starmath/qa/cppunit/test_starmath.cxx
starmath/source/edit.cxx
starmath/source/smmod.cxx
svtools/source/brwbox/brwbox1.cxx
svtools/source/brwbox/datwin.hxx
svtools/source/contnr/fileview.cxx
svtools/source/contnr/simptabl.cxx
svtools/source/control/filectrl.cxx
svtools/source/control/valueimp.hxx
svx/inc/GalleryControl.hxx
svx/source/dialog/dlgctrl.cxx
svx/source/dialog/swframeexample.cxx
svx/source/fmcomp/fmgridif.cxx
svx/source/gallery2/GalleryControl.cxx
svx/source/sidebar/EmptyPanel.hxx
svx/source/sidebar/area/AreaPropertyPanel.hxx
svx/source/sidebar/area/AreaTransparencyGradientControl.hxx
svx/source/sidebar/graphic/GraphicPropertyPanel.hxx
svx/source/sidebar/insert/InsertPropertyPanel.cxx
svx/source/sidebar/insert/InsertPropertyPanel.hxx
svx/source/sidebar/line/LinePropertyPanel.hxx
svx/source/sidebar/line/LineWidthControl.cxx
svx/source/sidebar/line/LineWidthControl.hxx
svx/source/sidebar/line/LineWidthValueSet.hxx
svx/source/sidebar/paragraph/ParaPropertyPanel.hxx
svx/source/sidebar/possize/SidebarDialControl.cxx
svx/source/sidebar/text/TextCharacterSpacingPopup.hxx
svx/source/sidebar/text/TextPropertyPanel.hxx
svx/source/sidebar/tools/PopupContainer.cxx
svx/source/sidebar/tools/PopupControl.cxx
svx/source/sidebar/tools/ValueSetWithTextControl.cxx
svx/source/svdraw/svdfmtf.hxx
svx/source/svdraw/svdibrow.cxx
svx/source/tbxctrls/colrctrl.cxx
svx/source/tbxctrls/tbcontrl.cxx
sw/source/ui/dbui/mmaddressblockpage.cxx
sw/source/ui/dialog/uiregionsw.cxx
sw/source/ui/index/cnttab.cxx
sw/source/uibase/inc/drpcps.hxx
sw/source/uibase/sidebar/PageColumnControl.hxx
sw/source/uibase/sidebar/PageMarginControl.hxx
sw/source/uibase/sidebar/PageOrientationControl.hxx
sw/source/uibase/sidebar/PagePropertyPanel.hxx
sw/source/uibase/sidebar/PageSizeControl.hxx
sw/source/uibase/uiview/view2.cxx
sw/source/uibase/utlui/navipi.cxx
vcl/inc/svdata.hxx
vcl/source/control/combobox.cxx
vcl/source/control/lstbox.cxx
vcl/source/window/dockwin.cxx
vcl/source/window/winproc.cxx
Change-Id: I056cf3026ff17d65cca0b6e6588bda4a88fa8d95
2015-04-28 15:08:48 +01:00
7ab8b08b6c
loplugin:staticmethods
...
Change-Id: Iab2f10b000ef41fb090e0034785d4ed0bda4cf43
2015-04-23 13:08:48 +02:00
ed54799117
convert EBBF_ constants to scoped enum
...
Change-Id: I6f281001a96ebfbca20f3e8dd3423945e119eef0
2015-04-22 10:28:39 +02:00
0578aa4de2
convert BROWSER_ constants to scoped enum
...
and fix a couple of places where it was mixing these flags up with the
WinBits flags and calling the wrong constructor.
Change-Id: I65c66bdd5a263e2f1db179c853f3f00e9ac7659e
2015-04-22 10:28:39 +02:00
5ea025e637
chart2: convert new to ::Create.
...
Change-Id: I14887bab5ced6e5915a8ecbc277017cec37a82ca
2015-04-17 22:01:46 +01:00
23d833dd3f
Move OutputDevice members to VclPtr: chart2, sfx2, cui.
...
Change-Id: If9228f8777edd4532e9a167eae23095c5e232a6c
2015-04-10 12:22:44 +01:00
c72fac2696
vclwidget: convert lots more sites to use VclPtr
...
seems there was a lot of shared_ptr usage floating around...
Change-Id: Icd05243170eb8493709275fc36bf986fc194b781
2015-04-10 11:20:46 +01:00
d7a84ce840
vclwidget: only call dispose() once
...
by using a new utility method in vcl::Window
This means that we don't have to make all our dispose
methods safe to call more than once.
Change-Id: I2110c7de4a86c70fdc97dd8fd318c86b56865374
2015-04-10 10:55:36 +01:00
0a61ce1c8e
vcl: VclPtr conversion in chart2
...
Change-Id: Iae82331e812836ff4c97617227d316bfe15b23df
2015-04-09 21:23:20 +01:00
0339e648a8
loplugin:constantfunction: chart2
...
Change-Id: I2ec1eaf9faa23779fbdf53771dbba1936c6aa3f9
2015-03-23 09:42:23 +02:00
a8e6f0bea0
tdf#39440 - cppcheck cleanliness
...
Fixed some cppcheck defects
Change-Id: I25fd6aba9d76df98d20b9a1bb4c9d3c1bf6f84bb
Reviewed-on: https://gerrit.libreoffice.org/14487
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-02-17 06:15:54 +00:00
acb7ca4283
chart2: Use appropriate OUString functions on string constants
...
Change-Id: Ifc28920e69db410b00312e634caba33b0e286b7f
2014-12-18 14:12:23 +01:00
8dbde0845a
fdo#82577: Handle Region
...
Put the VCL Region class in the vcl namespace. Avoids clash with the X11
Region typedef.
Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
2014-09-30 09:58:23 +02:00
827c46e7d7
fdo#82577: Handle Window
...
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.
Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-23 14:11:39 +03:00
3575dba98d
remove whitespaces
...
Change-Id: I05ef3c1ffd4e2179e0142a21abf8a4578718102e
2014-07-02 23:03:07 +02:00
483a4b546c
Flush modified data to the model when pressing OK in the data table dialog.
...
This dialog used to have no OK / Cancel buttons, and the data would get
flushed when the dialog got dismissed. This behavior got lost during the
dialog conversion.
Also, SaveModified() does check whether or not the data table is modified.
No need to call IsModified() before calling SaveModified().
Change-Id: I5cea88cb52127cc5c7c1be67a5a592d87df92d0c
2014-06-27 11:35:11 -04:00
184a00b962
loplugin: inlinesimplememberfunctions
...
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
329332ba52
chart2: sal_Bool->bool
...
Change-Id: I85751b4e636596ef88ef02bc958abdc6abf98427
2014-04-15 15:23:29 +02:00
567ef6d578
Second batch of adding SAL_OVERRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
9604eb8758
svtools: sal_Bool->bool
...
Change-Id: I8f171f7f61ea06a79183e9bf9b15b8c35c98cc9b
2014-03-24 08:12:09 +02:00
f661ac03e0
svtools: sal_Bool->bool
...
Change-Id: I22d8869551f46d2a0607f670f937853f394b6acf
2014-03-24 08:12:09 +02:00
1a1fe47731
svtools: sal_Bool->bool
...
Change-Id: I0c2e9314d85860831b29db76c89c8776c1b071b9
2014-03-24 08:12:08 +02:00
236d6cd67e
chart2: prefer passing OUString by reference
...
Change-Id: I685b1dc3d7c735bc70be29252f55c082546f3cb1
2014-03-17 13:30:50 +02:00
5c3a6d383e
callcatcher: update unused code
...
Change-Id: Ie4df15ab292df51274d983d31ce8e21e0549de81
2014-02-21 09:05:21 +00:00
a18a1a4545
Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
...
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.
Conflicts:
sc/source/ui/dbgui/pvlaydlg.cxx
Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-20 16:22:17 +00:00
b0cf499b3e
convert chart data dialog to .ui
...
this one was a complete pig to convert with the
conflicting home-grown existing layout code.
Change-Id: I135bd486d10f7d972e143daae44d6b24a6e8fdb8
2014-02-20 13:50:01 +00:00
7be7824bbb
chart2: String to OUString
...
Change-Id: I8abc6a31a46bea404e9d8b0c8777e3400dbf928c
Reviewed-on: https://gerrit.libreoffice.org/5865
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2013-09-08 02:23:15 +00:00
64b993e046
finish deprecation of O(U)String::valueOf()
...
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.
Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
dd9c97d587
fdo#62475 removed pointless comments
...
Change-Id: I3f5e86dba2df950aeb12c895f52d99274c0959aa
Reviewed-on: https://gerrit.libreoffice.org/5148
Reviewed-by: Luboš Luňák <l.lunak@suse.cz >
Tested-by: Luboš Luňák <l.lunak@suse.cz >
2013-07-29 11:34:33 +00:00
5efc15f000
reduce use of UniString from ResID ctor
...
Change-Id: I8d7619e7807ff2d400ec5c7fd181375130245728
2013-07-28 16:45:48 +01:00
cf6a74af53
XubString->OUString
...
Change-Id: I1049249741f445ad7bd9c070f99812c4404597c9
2013-07-11 14:31:44 +01:00
ff85b2c3d1
fdo#38838 : Replacement of String with OUString in core/chart2
...
Change-Id: I7abf9649a0c5997cebfe3463ce9b633ab59bf3b0
Reviewed-on: https://gerrit.libreoffice.org/3142
Reviewed-by: Luboš Luňák <l.lunak@suse.cz >
Tested-by: Luboš Luňák <l.lunak@suse.cz >
2013-04-02 16:29:28 +00:00
38d3e115c1
vcl: make Region ctors explicit to prevent overloading desasters
...
Change-Id: Id36d125b4940418833bec31a4710d6cd545629e0
2013-03-13 22:29:46 +01:00
d812cee7cb
OUString cleanup in Chart2
...
Include C2U macro removal and rtl prefix
Change-Id: I3de75446e53618862e50c69382a7ddaf0d482fa7
2012-10-08 21:41:25 +05:30
63c508e3e8
re-base on ALv2 code. Includes:
...
118568: switch to using ucpp
Patch contributed by Juergen Schmidt
http://svn.apache.org/viewvc?view=revision&revision=1209396
2012-07-18 09:29:19 +01:00
8e1bffe7ff
Remove include guards
...
Change-Id: Ib4ba76d0083e5bd75cc589a55318089c004f591f
2012-06-29 15:59:53 +02:00
