367105e024
cleanup some local var declarations
...
found with
git grep -nP '(\w+)\s+=\s+\g1\(' | lots-of-hand-filtering
Change-Id: I598b0cfa6607823eaef09d95e610e05145c727f7
2015-10-19 13:08:29 +02:00
9facb8271d
coverity#1327446 Unchecked dynamic_cast
...
Change-Id: Ib409b7fe4244b89f8767b20adcfae060f121b2f2
2015-10-17 14:46:26 +01:00
1716b3a338
remove some useless comments
...
found with git grep '// /'
Change-Id: I948cf9ae61bbbf2ec706ca5b0572c4f27c58c745
2015-10-13 10:07:49 +02:00
b36963c0a6
Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
...
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
0f88736128
loplugin:mergeclasses
...
Change-Id: Icd01de71fe87e0bf17eba39f5b00fc9a46765509
2015-10-12 09:13:33 +02:00
14237c1678
use trendline context for trendlines, tdf#94931, tdf#94934
...
Change-Id: I0cb9cdec33924e560b24744cc78d632025a189fc
2015-10-10 15:24:50 +02:00
33972dea7d
correctly dispose the chart sidebar when leaving chart, tdf#94292
...
This is a much better approach than my old one that tried to use the
correct XModel with the chart sidebar. Now everytime we leave the chart
edit mdoe we destroy the chart sidebar panels and recreate them when we
go back to chart edit mode.
As a result we no longer need to have worry that much about using the
correct ChartModel and about the lifecycle of the ChartModel.
Change-Id: Ie85ad82968e20a81f059d4bd930a83a70da35fc9
2015-10-09 20:42:11 +02:00
391f181c9f
chart2: replace for_each with range-based for
...
Replace complex uses of ::std::for_each with a range-based for-loop.
Change-Id: I6f3d8488a63a5bed271ab70ad6f024e9869906cc
Reviewed-on: https://gerrit.libreoffice.org/19143
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Jan Holesovsky <kendy@collabora.com >
Tested-by: Jan Holesovsky <kendy@collabora.com >
2015-10-08 09:06:46 +00:00
05e61719e2
loplugin:mergeclasses
...
Change-Id: If918532fcc860e3deacd9c86dd7a2d554e4f748d
2015-10-07 08:27:25 +02:00
2b57de8bb0
remove another custom refcounting base class
...
Change-Id: Icd8a8d79da0ada68e9ee869c3c2a7b93db5b2733
2015-10-07 08:27:25 +02:00
749a084550
don't show area and line panel in pie chart Chart selection, tdf#94320
...
Change-Id: I0eacedbb3d96a059278bab0ef98a66ed49b827fc
2015-10-03 16:00:21 +02:00
ac9671f948
tdf#94559: second step to remove rtti.hxx
...
replaced use of PTR_CAST, IS_TYPE, ISA in
chart2, connectivity, editeng, extensions, filter, forms, framework, idl
Change-Id: I6a2f9d8bbccb07088413f7552af4b5af8f0cad99
Reviewed-on: https://gerrit.libreoffice.org/18920
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Oliver Specht <oliver.specht@cib.de >
2015-09-30 06:07:57 +00:00
a6e622480f
Fix typos
...
Change-Id: Icf15b5ea2e5b9cd62645bab2f9ccaada948322a7
Reviewed-on: https://gerrit.libreoffice.org/18940
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
2015-09-30 06:00:42 +00:00
c50eb68af3
Renamed wrongly prefixed boolean variables
...
Fixed tdf#94269
Change-Id: I63109cc4e095bad680d7637a065080ea368860ae
Reviewed-on: https://gerrit.libreoffice.org/18851
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2015-09-29 18:33:40 +00:00
dfbf877856
gcc3 is not supported anymore, so remove that
...
Change-Id: Iddc481e13d40a6399a4a23a45c812b34a3a109f6
2015-09-27 07:54:45 +02:00
f8a7c031f1
convert Link<> to typed
...
Change-Id: Ic39135b39f1389fdf94fb16746100209ee63f492
Reviewed-on: https://gerrit.libreoffice.org/18856
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-09-25 18:21:31 +00:00
4248e89e4b
remove chart sidebar when leaving chart edit mode
...
Change-Id: Ie6fc01b2a610fb861ddade996ebb8480be217085
2015-09-15 01:54:05 +02:00
33cddeea13
boost->std
...
Change-Id: Iff14f69c200217c5d868978e8ffc06962b99ac09
Reviewed-on: https://gerrit.libreoffice.org/18568
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-09-14 19:32:42 +00:00
c5909e2518
Update many ListBox users to its sal_Int32 interface
...
Change-Id: I6469ac5e2d17406bee9bc434930e2471cb3bae9f
2015-09-12 14:18:50 +02:00
f9f3e97ca8
SdrObjEditView::IsTextEditHit effectively ignores its nTol argument
...
...ever since
nTol=0; // Joe am 6.3.1997: Keine Hittoleranz mehr hier
had been added into it sometime prior to
fd069bee7e57ad529c3c0974559fd2d84ec3151a "initial import." So lets assume Joe
meant that as a permanent fix rather than a temporal hack (which would have
survived for longer than 18 years anyway).
Change-Id: Ib30ac8d578f70c861d4c0f5f71bf4c13e9281db8
2015-09-09 14:01:18 +02:00
6f4e11a95b
convert Link<> to typed
...
Change-Id: I2aeda615e39db5a3cd39e168db34425e2912be8b
2015-09-09 10:06:12 +02:00
70a30fd179
loplugin: defaultparams
...
Change-Id: I65c0ed65b20f606cf1409a3158ff1ef1e2d6cd9f
2015-08-14 10:52:46 +02:00
5a2a266d4b
support more command in chart sidebar
...
We now have a complete toolbar controller in chart2.
Change-Id: I007d9b058e3d6800204ac035cc2aef5e93c1208b
2015-08-05 23:17:24 +02:00
41d1b01a90
API CHANGE: remove update() from X3DChartWindowProvider
...
Revert the API change from e41c33b376d8b5776e400979eb8544db596c5bbe
and use the existing css::util::XUpdatable instead.
Change-Id: I3eba4c7def98c8765a970d54a7fe84a320d4313e
Reviewed-on: https://gerrit.libreoffice.org/17382
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2015-07-30 15:27:38 +00:00
9022556453
small fix to reduce UnknownPropertyException in chart2
...
accidently introduced with f1531cdaaebe706d909dc6ddde439ccb5f4ad36d
Change-Id: I292097c5f61ecb32a28a90e9f5be48fcfd6bcd7b
2015-07-30 05:45:26 +02:00
b5c0f852b5
update gradients in sidebar as well
...
Change-Id: I0dc737c133e905d75fab23457fb86c8d2b724ce8
2015-07-26 00:26:59 +02:00
0635208edf
handle more than one chart with chart sidebar
...
Change-Id: I4998904a9273f2c67114a246d7f234843602573c
2015-07-26 00:26:55 +02:00
7410217b7d
loplugin:unusedmethods chart2
...
Change-Id: Ib7e8824e9e7f912963fbf07111ee3aa97773ceca
Reviewed-on: https://gerrit.libreoffice.org/17167
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-20 06:34:23 +00:00
9f27e5b0e0
Fix typos
...
Change-Id: I52cbaad71560d73f5e24f3de3cd62b00d678dd6c
Reviewed-on: https://gerrit.libreoffice.org/17187
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2015-07-19 19:45:07 +00:00
95b1491dac
add chart sidebar axis panel
...
Change-Id: Ia0f75c09f11c5751428a19fca33b39a54cdbb249
2015-07-17 21:12:50 +02:00
5c420fcdf9
tdf#88206 replace cppu::WeakImplHelper* etc.
...
with the variadic variants, in chart2.
Change-Id: Ib145860cf757d932fd5710f92c7f9ce33904b619
2015-07-17 09:39:04 +02:00
75d50b7189
generate correct sidebar context strings for charts
...
Change-Id: I92adf79c461f3536475da318e03b60f2e1adc08f
2015-07-16 22:18:09 +02:00
9ce5cfff0a
enable the chart sidebar again
...
Change-Id: I0ad9d962436562aa1026c50e5ec16f844f889eef
2015-07-16 08:15:20 +02:00
49d2400f8d
remove my accidently committed debug messages
...
Change-Id: Ia890837520b57291ae119de30dc7586b65e30b81
2015-07-16 08:15:18 +02:00
1d0696a349
we need access to the chart model in the chart sidebar
...
Change-Id: I607b5ada047f84cd7a229640772a332702f93f1e
2015-07-16 08:15:17 +02:00
8de7d44f96
disable newly unused code since last disable
...
Change-Id: I9f0abc3963ac4687e29fc629f1b9e9bb1fffaf8a
2015-07-13 20:59:05 +01:00
f90307a937
disable that code for now
...
Change-Id: I9f65babd0314498145746c452180ccf4fab64720
Reviewed-on: https://gerrit.libreoffice.org/17020
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2015-07-13 18:20:05 +00:00
2aea9e37d6
Introduce generic sub toolbar controller
...
Currently many toolbar controllers are basically doing the
same thing - show some docked toolbar. So the idea here is
to have one generic controller that will handle all these
cases in a unified way. It will get the name of the toolbar
that it's supposed to show from the configuration, based on
the command it was registered for.
Right now it can handle both simple (i.e. with DROPDOWNONLY
bits) and split (i.e. with DROPDOWN bits) scenarios, where
for split kind it replaces the function (and the image) of
the main part of the button, with the last selected function,
for easy reusing. A button is considered to be a split one,
if the name of the initial default command was passed along
with the sub toolbar name, otherwise it will be a simple
button.
The core change is in framework/. Other parts are a usage
example, in form of converting the custom shapes buttons
to this new controller.
Change-Id: I087cc58c3db1889ca69a26546d4f00fe07e2a58d
Reviewed-on: https://gerrit.libreoffice.org/16967
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com >
2015-07-13 12:09:52 +00:00
5b16fff9ac
loplugin:staticmethods
...
Change-Id: I8b57b7ce707438ad3c7c901b03c94d9045585ed8
2015-07-13 09:21:51 +02:00
efd13b27a4
finally manage to register chart2 in the ChartController
...
We need to do some jumps through pink hoops to connect the chart
controller with the host sidebar.
Would we use the chart window as parent for our sidebar the sidebar
would be directlz beside the chart and not at the border of the host
window.
Change-Id: Ica44ae370518882ef367999f57251b1256907016
2015-07-12 18:56:48 +02:00
498e03c2a3
fix crash
...
Change-Id: Ic1bc31b68c4a2aafb1e40ebff84fbf052df7041f
2015-07-12 18:56:47 +02:00
04716cb9ac
add SidebarChangeHandler to chart2
...
I still need to wire the correct frame to the correct sidebar for it to
work.
Change-Id: I0fecc2be674d6b024bc39e707930a4c30f67cb81
2015-07-12 18:56:47 +02:00
bc14d27dd0
loplugin:cstylecast: deal with remaining pointer casts
...
Change-Id: If5ab427ab320e2623df182e6143c4e7123610eae
2015-06-08 16:23:25 +02:00
0f71828a95
cppcheck: noExplicitConstructor
...
Change-Id: I8b03c27188b02c3c4a9a9fbbe0df1fb1ae1c5caf
2015-06-08 11:14:38 +01:00
b9f9576949
WaE: ‘<::’ cannot begin a template-argument list
...
This is an internal include file deep inside chart2, so just use css::. The
file uses css:: already in a couple of places anyway. So maybe I should have
been brave and just changed all the ugly ::com::sun:⭐ : into css::?
Change-Id: I705db39ff55f3e47c7e9d2f79fee625d76a22ca0
2015-06-05 17:48:33 +03:00
9509ce6103
some whitespace clean-up
...
Change-Id: I80aa6692c528176e38b5414145b484a32a9906f6
2015-06-02 00:14:43 +02:00
ba81e5c6bd
tdf#91702 - fix stack-based MessBox allocation.
...
Change-Id: I62dd164e281911d9db3de453789a5badc7cd5fd7
Reviewed-on: https://gerrit.libreoffice.org/15954
Reviewed-by: Michael Meeks <michael.meeks@collabora.com >
Tested-by: Michael Meeks <michael.meeks@collabora.com >
2015-05-29 12:16:28 +00:00
e0b2e6e3f7
loplugin:loopvartoosmall
...
Change-Id: Icbe68b31d4ab04ca3cd9f572e3598413946a75c7
2015-05-29 08:48:41 +02:00
bb7ce3137d
convert INVALIDATE constants to scoped enum
...
fixing a bug in Window::ImplMoveAllInvalidateRegions, and improving the
IDL docs for XWindowPeer
Change-Id: Idb774ac913945db2ac7c492c11cf86c370624c3d
2015-05-26 08:30:18 +02:00
ac3802da9a
convert WINDOW_POSSIZE constants to scoped enum
...
Change-Id: Id85137ffc7309a66b04132d588d289db136117b9
2015-05-22 10:37:59 +02:00
