Commit Graph

865 Commits

Author SHA1 Message Date
51f10626e6 tdf#94960, Revert "it is insane to not map line and ..."
This reverts commit 84254268bf5902d2405815970218e1893a7a673e.

Change-Id: Id99bc1f44a4e23daaf2f12585981c0be66cbeda5
2015-10-18 14:52:12 +02:00
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
d52d448e7b tdf#88154 workaround and unit test
Fixed 45-degree layout for axis labels, too.

Change-Id: I9764e281aeee0a439fa9eec1e3b0df840221b72f
Reviewed-on: https://gerrit.libreoffice.org/18889
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2015-10-07 09:07:48 +00:00
33cddeea13 boost->std
Change-Id: Iff14f69c200217c5d868978e8ffc06962b99ac09
Reviewed-on: https://gerrit.libreoffice.org/18568
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-14 19:32:42 +00:00
9ed1dd01be tdf#90839: support for wrapped text in data labels and for centered data value
Now in a pie chart the text of a label can be wrapped, the wrapping is
automatic and the maximum text width is fixed to almost half the pie
radius. This feature is used to import correctly the relative text
wrapping property provided by MSO.

Moreover the data value and percent value of a label are now centered
horizontally, respect with the label text.

Conflicts:
	chart2/qa/extras/xshape/chart2xshape.cxx

Change-Id: Ie10d6184365436f763cd9693a5bbefcfa9b3862b
Reviewed-on: https://gerrit.libreoffice.org/17193
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-09-09 07:41:51 +00:00
5cabc2c06d make sure that LineColor is supported for data series
Change-Id: I1ae96c7b6adf5a90f96d7dddc20d7fb241e78445
2015-08-20 03:15:51 +02:00
ad1f0d1f1a o3tl: rename compat_functional header
After the cleanup, the stuff there really stands on its own (and the
remaining usage of select1st/2nd is more descriptive than lambdas).

Change-Id: I0aba131d5dc550189f8130d167dc94167e404540
Reviewed-on: https://gerrit.libreoffice.org/17806
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-17 16:38:30 +00:00
70a30fd179 loplugin: defaultparams
Change-Id: I65c0ed65b20f606cf1409a3158ff1ef1e2d6cd9f
2015-08-14 10:52:46 +02:00
87130a4e18 tdf#92459 Cleanup unclear lambdas
Replace lambdas used to select the first/second member of a pair with
the new simplified select1st/2nd from o3tl/compat_functional. There
should be no side effects due to this change.

Change-Id: I17f37796e0c4defe96a10aa491d192adb9eebb89
Reviewed-on: https://gerrit.libreoffice.org/17656
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-11 22:29:12 +00:00
5916d5866c tdf#92459 replace deprecated o3tl features
Replace all uses of deprecated features from o3tl/compat_functional.hxx
with lambda expressions.

Change-Id: I6370c80dbe675da517904e535e19bf63830c3e2c
Reviewed-on: https://gerrit.libreoffice.org/17450
Reviewed-by: David Ostrovsky <david@ostrovsky.org>
Tested-by: David Ostrovsky <david@ostrovsky.org>
2015-08-01 06:25:49 +00:00
84254268bf it is insane to not map line and border properties to the same id
Change-Id: I6f4eb2509dc731cb281350b2bb0cce94b66a8ad6
2015-07-30 05:45:24 +02:00
9bb03b4961 provide also LineTransparence for DataPointProperties
Change-Id: I9c3e547831d3d876c228c8b9b566f17a4d95ce5b
2015-07-30 05:45:22 +02:00
19ae187b32 chart2: fix duplicate entries at index 0
... introduced at 6949629e35f308ce7efc890319ecf9a46a5f154c.

Change-Id: Ifc5c2f92584aabe668eb8c87abdc5085d4a7b075
Reviewed-on: https://gerrit.libreoffice.org/17377
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-07-28 03:07:39 +00:00
6949629e35 reflect the property name changes also in the idl files
DataPoints now support the whole css::drawing::FillProperties properties
which makes handling fill properties in chart2 a lot easier. The new
names are just aliases for the old property names.

Change-Id: I5b85010fe2557eeb5376de71ff3605b3abbcd488
2015-07-28 01:10:33 +02:00
88f5d4ce86 use common fill property names in chart2
Change-Id: I9445344efc70d872fdb9c9a8cc49838210861a7b
2015-07-28 00:59:13 +02:00
7410217b7d loplugin:unusedmethods chart2
Change-Id: Ib7e8824e9e7f912963fbf07111ee3aa97773ceca
Reviewed-on: https://gerrit.libreoffice.org/17167
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-20 06:34:23 +00:00
5c420fcdf9 tdf#88206 replace cppu::WeakImplHelper* etc.
with the variadic variants, in chart2.

Change-Id: Ib145860cf757d932fd5710f92c7f9ce33904b619
2015-07-17 09:39:04 +02:00
701e21b25d tdf#91725: Use lighter default colour for minor grid lines
Change-Id: I4be2adac1004ad4ace474c9a271cf8e21986da07
Reviewed-on: https://gerrit.libreoffice.org/16819
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-07-09 22:46:40 +00:00
93e7870f31 s/Coordiante/Coordinate
Change-Id: Iac584b09844b5877586061e9a44b1f7473bffed4
2015-07-08 12:39:53 +03:00
b55166d266 Revert "return and use std::vector from OInterfaceContainerHelper"
This reverts commit e57314f61f67b093510c5a8a8f34a62126ba8734.
2015-06-29 10:11:53 +02:00
e57314f61f return and use std::vector from OInterfaceContainerHelper
since most of the time we don’t need a heavyweight uno::Sequence.
Adds a new method getElementsAsVector().

Change-Id: I9e72bef0c0c723ffd0dd7d4152db5baec6784a7a
Reviewed-on: https://gerrit.libreoffice.org/15747
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-29 07:25:22 +00:00
ae150c6a54 Fix typos
Change-Id: Ibfa971952cd330ddf430e7e951c5c235d2ae6bd8
Reviewed-on: https://gerrit.libreoffice.org/16314
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-18 11:44:56 +00:00
bc14d27dd0 loplugin:cstylecast: deal with remaining pointer casts
Change-Id: If5ab427ab320e2623df182e6143c4e7123610eae
2015-06-08 16:23:25 +02:00
0f71828a95 cppcheck: noExplicitConstructor
Change-Id: I8b03c27188b02c3c4a9a9fbbe0df1fb1ae1c5caf
2015-06-08 11:14:38 +01:00
81610561ed uno::Sequence provides now begin and end
use begin() and end() when calling std::copy on an uno::Sequence

Inspired by commit b34b648fc3262c5d9aa295f621e8fe9c97d4c6b2
"uno::Sequence provides now begin and end"

Change-Id: I08e8c3fd6144e77b95a26f85bc0daf6a9edeeb0b
Reviewed-on: https://gerrit.libreoffice.org/16057
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-04 06:35:44 +00:00
f4b4db10da fix old GCC build
after my commit 10749bbf8247f0b17201b33f95a090dfc4fc3211
"remove the last of the OUString #defines in header files"

Change-Id: I7666cfb28d8a28d541c9d7a51f014ebe53c50551
2015-05-19 10:06:19 +02:00
10749bbf82 remove the last of the OUString #defines in header files
Change-Id: Id9e8ce7987e055e83b52c7024413570f262e6e8d
2015-05-19 09:42:41 +02:00
5b1337f7b2 tdf#62475: partial handmade fixes
Change-Id: Ib9af202c43b916b9af4b4e18db35d470a8692fe4
Reviewed-on: https://gerrit.libreoffice.org/15712
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-05-15 17:55:15 +00:00
7ab8b08b6c loplugin:staticmethods
Change-Id: Iab2f10b000ef41fb090e0034785d4ed0bda4cf43
2015-04-23 13:08:48 +02:00
373a9b9bb6 loplugin:redundantcast: redundant const_cast followed by implicit upcast
Change-Id: I58297ba336d96358eb0683684bbd763870ef56cb
2015-04-13 12:36:36 +02:00
e9cb5577f4 loplugin:staticmethods
Change-Id: Ibf0c73ac17ec19ed672f66907db47057920babca
2015-04-02 09:38:29 +02:00
79451a0566 Replace remaining getCppuType et al with cppu::UnoType
Change-Id: I5bc47d62afa9cf43f4f1978e082bba43920eb10d
2015-04-01 08:35:38 +02:00
0339e648a8 loplugin:constantfunction: chart2
Change-Id: I2ec1eaf9faa23779fbdf53771dbba1936c6aa3f9
2015-03-23 09:42:23 +02:00
71dca358e3 Clean up
Change-Id: Id91be8ec8a97d8fad398d798cd2a9b77773a39e2
2015-02-19 11:07:50 +01:00
146461ea6e Add an overlooked constructor to chartcore.component.
com.sun.star.comp.chart2.report.XMLFilter was pointing to
com.sun.star.comp.chart2.XMLFilter by mistake.

Change-Id: Ia3c96cc98a4f81f2bb918200dc39eae1dbafdb58
2015-02-13 09:17:55 +01:00
917bd2350c Use constructors for services from chartcore.component.
Change-Id: I72227b45f305734060a669275044f6f9c8859bc5
2015-02-12 18:11:37 +01:00
5d8dc045f1 But then again, no need to go via UNO here anyway (cf. previous commit)
Change-Id: I2e5015b9c360fadb6747b5e2e0bd0a62b252312d
2015-02-12 16:01:55 +01:00
e47f9d0e8b Add missing registration of GL3DBarChartType in g_entries_chart2_charttypes
...looks like it just got forgotten in 05efb605b36ea340762ef1583b3aea6a6b5cdddb
"Add a new skeleton plotter for the GL3D bar chart."

Change-Id: I54b7164d3702de6bdbcc3c3e21ea5569ada0336b
2015-02-12 16:01:55 +01:00
5b736d96ba loplugin:deletedspecial
Change-Id: Ifdbeea8d4e49ae38b843675758fcc29aee974bdf
2015-02-07 12:35:56 +01:00
f61dbc3029 followup code removal after changing virtual methods to non-virtual
This cleanups up indentation and removes dead classes.

This is a followup patch to commit
272b1dd55797aacf511fb4342b0054e3697243f6
"new loplugin: change virtual methods to non-virtual"

Change-Id: I1c2139589cf8cb23bb9808defe22c51039d38de1
2015-01-26 08:42:29 +02:00
b44cbb26ef new loplugin: change virtual methods to non-virtual
Where we can prove that the virtual method is never overriden.

In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.

Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-26 08:42:28 +02:00
2f69e16c72 override the overloading of "overload" to decrease cognitive (over-)load
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-09 00:00:47 +01:00
df35af4168 fix build
Change-Id: I920227cd175dace306ebb16a8e476f483cf11a7a
2014-12-18 16:00:58 +00:00
acb7ca4283 chart2: Use appropriate OUString functions on string constants
Change-Id: Ifc28920e69db410b00312e634caba33b0e286b7f
2014-12-18 14:12:23 +01:00
cf4347aa51 bCategoriesUsed is always false at this point
Change-Id: I7e6851ce3f24ef3c5051eb7431b6aa1df845836d
2014-12-18 06:39:31 +01:00
9b307e64d6 fix build
Change-Id: Iaeb995ef4dad03babb5df1b034a476d90681768a
2014-12-09 11:41:53 +00:00
360f40544d fix build under gcc
after my commit feb92a5
"inline some strings, they don't need to be in a shared header file"

Change-Id: I60a6fa11d56f3d4648dbedeca062ab27206f2a02
2014-12-09 13:29:12 +02:00
feb92a5f3c inline some strings, they don't need to be in a shared header file
Change-Id: I058489d207510024ce722c4d03f9aac628b120b5
2014-12-09 12:55:38 +02:00
c227d963d8 inline UNO helper macros
Change-Id: Ia401dd2f51108d2f3b08cd3d6d433a12ac17ee74
2014-12-09 12:55:38 +02:00
13b6c147e5 inline UNO helper macro APPHELPER_SERVICE_FACTORY_HELPER
Change-Id: Ib416efb59ae166bb8d55dd7f3c84b7e5f72864e8
2014-12-09 12:55:37 +02:00