wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
382,235 Commits 5 Branches 0 Tags
8e4739b94de0bbc7ceb91705a7ba7946b8b70b94
Commit Graph

11278 Commits

Author SHA1 Message Date
Lionel Elie Mamane
17aaa3fed1 tdf#93724 KeySet insert: properly set default values: NULL & right type 
Change-Id: I933eed918e18b6923d4e0d24748297cf0dd0088d
 2015-10-20 19:15:52 +02:00
Noel Grandin
da88c8b784 convert Link<> to typed 
Change-Id: I9453beedfa059d4f260ca136c02a6104fc4d4829
 2015-10-20 16:16:45 +02:00
Noel Grandin
516b5115df convert Link<> to typed 
Change-Id: I822561725683231709343b80d7065c905226ebc1
 2015-10-20 16:16:45 +02:00
Noel Grandin
798d7bc09e convert Link<> to typed 
Change-Id: Id3ed50dc7fd4f783034797b2401ae05c96d002de
 2015-10-20 16:16:44 +02:00
Stephan Bergmann
28ecf84346 loplugin:defaultparams 
Change-Id: I9dccf0538389063648e97575ff4c3765f0b1256b
 2015-10-20 11:45:11 +02:00
Stephan Bergmann
578f267a38 loplugin:defaultparams 
Change-Id: I83d411adf8ef882618bd48ab73602f7cf1531078
 2015-10-19 17:49:41 +02:00
Noel Grandin
367105e024 cleanup some local var declarations 
found with
   git grep -nP '(\w+)\s+=\s+\g1\(' | lots-of-hand-filtering

Change-Id: I598b0cfa6607823eaef09d95e610e05145c727f7
 2015-10-19 13:08:29 +02:00
Noel Grandin
6aa90a44f2 remove dead Link<> code 
Change-Id: I01891cd34535ea08a07c3bb47976f6c9a70c3656
 2015-10-19 09:05:57 +02:00
Jan Holesovsky
2b5a48da59 sfx items: Kill the SFX_ITEMSET_GET macro. 
Change-Id: I110a4f25646eb3f0fa93673c84dc67cf64a3b7a0
 2015-10-19 07:20:33 +02:00
Caolán McNamara
e1bc0f42fa coverity#1327443 Division or modulo by zero 
Change-Id: Iefddcc2d66e77e3698dec9930898f63e0b7902f6
 2015-10-17 14:46:27 +01:00
Noel Grandin
6f1313b3d4 convert Link<> to typed 
Change-Id: Icbba339dac0be31e30dff021bba06a219f8aecd6
Reviewed-on: https://gerrit.libreoffice.org/19405
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-16 09:11:29 +00:00
Noel Grandin
74d686bc59 simplify the CellController modify Link<> handling 
in preparation for some more "make Link<> typed" work

Change-Id: Ifdf58cc697c7172102bf9e4cc63f869c522517e6
 2015-10-15 15:47:13 +02:00
Noel Grandin
0e8a40e8b8 calling IsSet() before Call() on Link<> is unnecessary 
the Call() already does a check

Found with:
git grep -A 1 -w 'IsSet()'
    | grep -B 1 '.Call('
    | grep ':'
    | cut -d ':' -f 1

Change-Id: Ia7248f5d62640b75f705e539c3d1183e39c0d847
 2015-10-15 12:29:01 +02:00
Noel Grandin
99b21cc9f3 convert Link<> to typed 
Change-Id: I6c55c74d47b13149c2fa210bb9de4e8c430c57cc
 2015-10-15 09:58:34 +02:00
Noel Grandin
4b55c28940 simplify the way we override behaviour here 
just send everything via callModifiedHdl()

Change-Id: I011df1d1c376deae962b465e4a27e98af968de6f
 2015-10-15 08:11:33 +02:00
Stephan Bergmann
7ea5ad6e46 Assumed fix of a clang-analyzer-deadcode.DeadStores 
...where the "bOk = false" from the leading "if" is always overwritten in the
following check of "bOk = sTableRange == _sUpdateTableName".  The code had been
effectively like that ever since it got introduced with
4ae41a466ad659524809c23c9086df70c5456a39 "INTEGRATION: CWS dba30," but it looks
broken.  I assume the two checks of "sTableRange == _sUpdateTableName" for
pNode->GetChild(0) and pNode->GetChild(2) shall only be done if the leading "if"
is not hit.  (And one remaining uncertainty is if really only one of those
"sTableRange == _sUpdateTableName" checks needs to be true or if both should be
true for bOk to be true.)

Change-Id: I453690d65326ed67d7a074d4e4783a743a60d454
 2015-10-13 17:40:33 +02:00
Stephan Bergmann
2c5f5976b2 clang-analyzer-deadcode.DeadStores 
In 8b9e4e393eff8b89a37a5932548700c0b50bcab8 "initial import" the assignment to
bCheck was in a for loop that used bCheck in its condition,

  sal_Int32 nPos = m_nStartPos+1;
  for(; aIter != m_pMatrix->end() && bCheck;)
  {
      if(!aIter->isValid())
          ...
      m_pCacheSet->fillValueRow(*aIter++,nPos++);
      bCheck = m_pCacheSet->next();
  }

that loop was then replaced with

  sal_Int32 nPos = m_nStartPos;
  bCheck = fill(aIter,m_pMatrix->end(),nPos,bCheck);

(without further use of bCheck) in 2facbebb88fe72614d566c3187c8f86c5c61f8bd
"MWS_SRX644: migrate branch mws_srx644 -> HEAD" (and the braces around

  {
      ORowSetMatrix::iterator aIter(aEnd);
      sal_Int32 nPos = m_nStartPos + 1;
      bCheck = fill(aIter, m_pMatrix->end(), nPos, bCheck);
  }

introduced in 1234d599d4ee67bd725f0513431b2d4c56c9e09d "ORowSetCache: overhaul
internals," presumably to limit the scope of that aIter introduced there).

Change-Id: I1cf4a22fbd1b76d524251a82c3ab4e6ca7a9eca1
 2015-10-13 17:40:33 +02:00
Noel Grandin
38b4b7590d loplugin:mergeclasses, merge OOdbcLibWrapper with OOdbcEnumeration 
Change-Id: I2e564e90c11bb46022a5e258ad013aeb2fe4ca2e
 2015-10-13 10:07:50 +02:00
Noel Grandin
ade2ba503f loplugin:mergeclasses, merge ILabelProvider with LabelProvider 
Change-Id: I8fb231b4189c09d8e049855d38b0f1eb518ac2b9
 2015-10-13 10:07:50 +02:00
Noel Grandin
3e5f9c0343 loplugin:mergeclasses, merge IImageProvider with ImageProvider 
Change-Id: I6af8b1ab9198439af60e38a9adc6bdd29d20ab52
 2015-10-13 10:07:49 +02:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code 
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
 2015-10-12 17:52:29 +02:00
Stephan Bergmann
bff4c13475 Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY code 
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
 2015-10-12 17:52:26 +02:00
Noel Grandin
3c99f8500f convert Link<> to typed 
Change-Id: Iec15042138e0715459b2c9e872a7464d75a6b1eb
Reviewed-on: https://gerrit.libreoffice.org/19305
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-12 10:48:13 +00:00
Noel Grandin
48532dfa60 loplugin:mergeclasses 
Change-Id: I1ce2e31e4dae780612e51b3806ee6044be9cf4bb
 2015-10-12 09:13:33 +02:00
Noel Grandin
fcddbf6fa3 formatting 
Change-Id: Id712e25efc6ea99c0979b48e6cbec068864f4c46
 2015-10-12 09:13:33 +02:00
Noel Grandin
d5434a2111 unnecessary and confusing typedef 
Change-Id: Id16013c3e12312608eba2eda378debf362da7013
 2015-10-12 09:13:33 +02:00
Julien Nabet
898aff0d19 Related tdf#45775: PgSQL new DB allow empty Datasource 
Declare PostgreSql in dsn stuff

Change-Id: I72343bff0d5e6a65a45fc47cc1d346155330f1e5
Reviewed-on: https://gerrit.libreoffice.org/19310
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
 2015-10-12 01:24:54 +00:00
Michael Meeks
c8a795c9a0 tdf#94709 - protect TableWindowTitle Command execution. 
Change-Id: I202a154e18c1fbffc31abcc7ccd7f500b67a4c13
 2015-10-07 17:18:54 +01:00
Noel Grandin
2e658321f5 loplugin:mergeclasses 
Change-Id: I84dee96b7a1f72db46e3330ec5195367dfce894a
 2015-10-07 08:27:25 +02:00
Andrea Gelmini
43d35f56ef Fix typos 
Change-Id: I54c32259750c0863a39f56fabaa1a0df7d208c9a
 2015-10-06 21:17:27 +02:00
Noel Grandin
7e776c0027 loplugin:unusedmethods 
Change-Id: I150baadc442e57ee604563bc52965daa9d2e41af
 2015-10-06 10:17:02 +02:00
Oliver Specht
89d39bc100 tdf#94559: 4th step to remove rtti.hxx 
replaced use of PTR_CAST, IS_TYPE, ISA in
    idl, editeng, sc, sd, sw, sfx2, sot, starmath

Change-Id: I4a5bba4fdc4829099618c09b690c83f876a3d653
Reviewed-on: https://gerrit.libreoffice.org/19132
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
 2015-10-06 07:29:37 +00:00
Caolán McNamara
56a5734b06 cppcheck: noExplicitConstructor 
Change-Id: I80950aaf1385bd76b012eab7866fd16848751f45
 2015-10-05 20:30:59 +01:00
Caolán McNamara
5e6d41ddcf coverity#735690 Unchecked dynamic_cast 
and

coverity#735689 Unchecked dynamic_cast

Change-Id: I1181e21146972c7c01b0a421d3c1c4ecc3d7e75a
 2015-10-01 14:41:33 +01:00
Stephan Bergmann
daf31b5e08 -Werror,-Wunused-private-field 
Change-Id: I24e4dde34993e4fc994a8dc4a318e7d17c357260
 2015-10-01 14:35:00 +02:00
Noel Grandin
58aea3f36c loplugin:unusedmethods 
- improvements to the plugin to find more method calls
- improvements to python script to remove more false+
- fix the FORCE_COMPILE_ALL build flag to include code in
  the $WORKDIR

Change-Id: I4d6015dcb9b9d60c26f0bcee8abad807177a7836
Reviewed-on: https://gerrit.libreoffice.org/19064
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-01 10:43:24 +00:00
Andrea Gelmini
4046f6d257 Fix typos 
Change-Id: Ia37c28bbb7a1b47ed4a6beffb3f03eb26742b653
Reviewed-on: https://gerrit.libreoffice.org/18944
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
 2015-09-30 08:42:52 +00:00
Stefan Heinemann
c50eb68af3 Renamed wrongly prefixed boolean variables 
Fixed tdf#94269

Change-Id: I63109cc4e095bad680d7637a065080ea368860ae
Reviewed-on: https://gerrit.libreoffice.org/18851
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2015-09-29 18:33:40 +00:00
Noel Grandin
34180700b2 loplugin:removeunusedmethods, remove unused stuff 
Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350
 2015-09-29 15:08:43 +02:00
Oliver Specht
d3c7c9ea81 tdf#94559: first step to remove rtti.hxx 
replaced use of PTR_CAST, IS_TYPE, ISA in
avmedia, basctl, basic, cui, dbaccess, vcl,xmloff

Change-Id: If4496762e82e896b6fbc362e6626502703c245f5
Reviewed-on: https://gerrit.libreoffice.org/18905
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
 2015-09-29 12:26:20 +00:00
Stephan Bergmann
d5b87dcce1 Return std::unique_ptr from SvTreeListBox::CreateContextMenu 
Change-Id: I1e4c32099ec9741c0cab246eb627a2eb3b933e1a
 2015-09-28 13:07:03 +02:00
Noel Grandin
73b158e001 convert Link<> to typed 
Change-Id: If1dcc5e50b08540623bb21067c5f74e47192ef9a
Reviewed-on: https://gerrit.libreoffice.org/18859
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-09-26 05:27:04 +00:00
Noel Grandin
14a5131658 convert Link<> to typed 
Change-Id: I7fd77490ab49a18f48e248ca277bc30b5a7d2071
Reviewed-on: https://gerrit.libreoffice.org/18858
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-09-25 18:23:14 +00:00
Noel Grandin
e85b2333bc convert Link<> to typed 
Change-Id: I59d325c3b051690303a5841907317122fa1ec98b
Reviewed-on: https://gerrit.libreoffice.org/18825
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-09-24 16:19:37 +00:00
Noel Grandin
efeb928153 convert Link<> to typed 
Change-Id: I12b3fdb443226a63786b94ce9836e9d2efa6a5c8
Reviewed-on: https://gerrit.libreoffice.org/18776
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-09-22 18:57:16 +00:00
Noel Grandin
1e67e94f1a convert Link<> to typed 
Change-Id: If3e2b00092440ebd42ae5b73ae2b0e44c3702683
 2015-09-21 08:03:52 +02:00
Stephan Bergmann
a12c083cad Some follow-up #include clean-up 
Change-Id: I4e91748701becfc92a379a490c08e9c7950007e3
 2015-09-18 07:51:35 +02:00
Lionel Elie Mamane
558b08d55f silence warning when not a warning 
Change-Id: I31d7835a5ed3053cd1a930b3fb922d689d6ddcbe
 2015-09-17 19:35:57 +02:00
Caolán McNamara
ddc2809202 boost->std 
Change-Id: Idfbcfa1e5ba7bff92e98693c33c4b33a6beda08f
 2015-09-17 14:12:07 +01:00
Noel Grandin
a609822d5e remove unused Link<> field 
Change-Id: I4d9f7d0fb1a2621121aa26f1ddff0a04116bc561
 2015-09-17 12:22:46 +02:00