6dd98f8b94
loplugin:defaultparams
...
Change-Id: Id5e399309144b99757e172e69e8e6dbc5fbff365
2015-10-20 11:45:21 +02:00
ad6e444a31
loplugin:defaultparams
...
Change-Id: I62e0ec63ff09c200e0b621c8b042a976e8ce630e
2015-10-19 17:49:51 +02:00
c8479bdc5b
convert DBG_ASSERTWARNING to SAL_WARN_IF
...
I know the comment in debug.hxx said to use SAL_INFO, but SAL_WARN makes
much more sense.
Change-Id: I3d81f9db89ef8cebe1e4f2983941d69b4c7e6b7d
2015-10-19 13:08:29 +02:00
39e63bfac5
convert remaing DBG_WARNING to SAL_INFO
...
and drop the macro
Change-Id: I452ca373d0c277166e94928c1bce78bf37e39d7c
2015-10-19 13:08:29 +02:00
1778ad2545
WaE: loplugin:defaultparams
...
Change-Id: I65f4cc10c4a3dc5ffc21b64d76dc32f1613a0062
2015-10-19 11:36:06 +03:00
c260c34be0
fix cppcheck:nullPointerRedundantCheck commit
...
fix my commit 2d64fcf4c8d3316ad9ae2232601678553dcad6a3
"cppcheck:nullPointerRedundantCheck"
Change-Id: I0875005d938b43a91e15c564a23d70cb097548a9
2015-10-19 09:44:30 +02:00
2d64fcf4c8
cppcheck:nullPointerRedundantCheck
...
Change-Id: I00a58a90f96e9eaf681239146213706e278ea5e1
Reviewed-on: https://gerrit.libreoffice.org/19421
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-19 06:48:51 +00:00
11754fd792
editeng tiled rendering: avoid selections callbacks in Paint()
...
Given that we emit selection callbacks on each logical operations (set
selection, deselect all, etc) already, it's not necessary to emit
callbacks in DrawSelection() when it's called from Paint().
Change-Id: I6781c71ee2f292de2a1c7d129fc49b514aca2be1
2015-10-16 11:25:50 +02:00
0e8a40e8b8
calling IsSet() before Call() on Link<> is unnecessary
...
the Call() already does a check
Found with:
git grep -A 1 -w 'IsSet()'
| grep -B 1 '.Call('
| grep ':'
| cut -d ':' -f 1
Change-Id: Ia7248f5d62640b75f705e539c3d1183e39c0d847
2015-10-15 12:29:01 +02:00
f7764214f2
editeng: add EditView::GetSelectionRectangles()
...
This gives sd access to the selection rectangles as well (as opposed
only to the document model positions of selections).
Change-Id: Icb903e91f9e868573403b360bbe839705ddf2916
2015-10-13 16:42:41 +02:00
1716b3a338
remove some useless comments
...
found with git grep '// /'
Change-Id: I948cf9ae61bbbf2ec706ca5b0572c4f27c58c745
2015-10-13 10:07:49 +02:00
b36963c0a6
Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
...
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
bff4c13475
Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY code
...
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-12 17:52:26 +02:00
1cb13d87b5
editeng, sw, sc: use comphelper::string::join()
...
Change-Id: I9b0a32271a965bc4089720ccb61b26b67ceab7b2
2015-10-08 08:37:58 +02:00
bb76b8f106
loplugin:mergeclasses
...
Change-Id: I8f5c2ae658f8784233db98f752b6f9fa53110195
2015-10-07 12:32:23 +02:00
5dbbb498b5
loplugin:mergeclasses
...
Change-Id: I0ac98a6fafb48b2be00973ae9fd34f4bc756cd7f
2015-10-07 12:32:23 +02:00
a3eacae95a
loplugin:mergeclasses
...
Change-Id: Icf1731dfbd16d85decd2aaf80be4841ac37007fd
2015-10-07 12:32:23 +02:00
205f85749d
Reduce variable scope
...
Change-Id: I6a8e4b8f132acff5d75859de570a969ad8c3fa4b
2015-10-07 11:32:43 +02:00
52e120a9e5
clang-analyzer-deadcode.DeadStores
...
Change-Id: Id6698ecef885e37412dc88f8bdbc25ff0da8af21
2015-10-06 16:33:30 +02:00
4f2dfb1828
clang-analyzer-deadcode.DeadStores
...
Change-Id: I211ff9c4f64e97f3b397fe2b384f06d18026e1e4
2015-10-06 16:33:30 +02:00
13f51daa02
clang-analyzer-deadcode.DeadStores
...
Change-Id: Ib184b06cbf83ec582aa50fded3795daac37c7869
2015-10-06 16:33:30 +02:00
da43c510e7
clang-analyzer-deadcode.DeadStores
...
Change-Id: Ic36598f30efd04b4084c0ffa1f4616687abf4d29
2015-10-06 16:33:29 +02:00
3f67e4975a
clang-analyzer-deadcode.DeadStores
...
Change-Id: Id2062ffd309f534f7c0dedf185569cfe5741c303
2015-10-06 16:33:29 +02:00
6eff4b6677
clang-analyzer-deadcode.DeadStores
...
Change-Id: Ibec716d78425d32b7341eb608c08202364b84ba4
2015-10-06 16:33:28 +02:00
7e776c0027
loplugin:unusedmethods
...
Change-Id: I150baadc442e57ee604563bc52965daa9d2e41af
2015-10-06 10:17:02 +02:00
89d39bc100
tdf#94559: 4th step to remove rtti.hxx
...
replaced use of PTR_CAST, IS_TYPE, ISA in
idl, editeng, sc, sd, sw, sfx2, sot, starmath
Change-Id: I4a5bba4fdc4829099618c09b690c83f876a3d653
Reviewed-on: https://gerrit.libreoffice.org/19132
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Oliver Specht <oliver.specht@cib.de >
2015-10-06 07:29:37 +00:00
a8a812997f
tdf#92341 Make Autocorrect entry actually work
...
Change-Id: I83e028428933e2153b639ca6b34fd69db88fb53f
2015-10-01 14:55:05 +02:00
d1ebfb5318
Correct title case usage
...
The last word of a title-cased text is always capitalized.
Change-Id: I3fba56ba43516f54146b765104a9a04a3ffa8482
2015-10-01 07:15:12 -05:00
58aea3f36c
loplugin:unusedmethods
...
- improvements to the plugin to find more method calls
- improvements to python script to remove more false+
- fix the FORCE_COMPILE_ALL build flag to include code in
the $WORKDIR
Change-Id: I4d6015dcb9b9d60c26f0bcee8abad807177a7836
Reviewed-on: https://gerrit.libreoffice.org/19064
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-01 10:43:24 +00:00
81f94235b0
tdf#92341 Add AutoCorrect entry in context menu for non-swriter
...
Change-Id: I415674da3edd94aba0e2b1452bb489f755f5753a
Reviewed-on: https://gerrit.libreoffice.org/18887
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-10-01 09:31:35 +00:00
e209d115d4
remove old standalone Sun bug numbers
...
Sun bug numbers without any accompanying text are completely useless.
Fixed with
git grep -lP '//\s*#\d+#\s*$'
| xargs perl -i -ne'/\/\/\s*#\d+#\s*$/d or print'
And then hand-checking the result to restore places where it deleted code.
And then some more grepping and hand-editing to kill the others.
Change-Id: Ia96ce4466db8bb8da363ebf41f0ae7f45f28bf29
Reviewed-on: https://gerrit.libreoffice.org/19023
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-01 06:57:19 +00:00
f891d8cf6b
Fix typos
...
Change-Id: I9dbe1e05cf73af20c25392e639a807854e87fc6e
Reviewed-on: https://gerrit.libreoffice.org/18946
Reviewed-by: Oliver Specht <oliver.specht@cib.de >
Tested-by: Oliver Specht <oliver.specht@cib.de >
2015-09-30 12:38:37 +00:00
00d2eeebc8
Fix typos
...
Change-Id: Iaa9dd3f02f21947742643349d3b878126017477d
Reviewed-on: https://gerrit.libreoffice.org/18947
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
2015-09-30 12:25:15 +00:00
ac9671f948
tdf#94559: second step to remove rtti.hxx
...
replaced use of PTR_CAST, IS_TYPE, ISA in
chart2, connectivity, editeng, extensions, filter, forms, framework, idl
Change-Id: I6a2f9d8bbccb07088413f7552af4b5af8f0cad99
Reviewed-on: https://gerrit.libreoffice.org/18920
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Oliver Specht <oliver.specht@cib.de >
2015-09-30 06:07:57 +00:00
c50eb68af3
Renamed wrongly prefixed boolean variables
...
Fixed tdf#94269
Change-Id: I63109cc4e095bad680d7637a065080ea368860ae
Reviewed-on: https://gerrit.libreoffice.org/18851
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2015-09-29 18:33:40 +00:00
d49430893e
coverity#1325077 Uninitialized pointer field
...
Change-Id: I74121c1cc94edf338cf40a3d186308491e1d2409
2015-09-29 11:10:34 +01:00
e2c8fbb535
coverity#1325068 Resource leak
...
Change-Id: I608140eb05703f6f0cf2920be7ed706ef30e2a7d
2015-09-29 11:10:32 +01:00
259fb99d34
coverity#1325050 Resource leak in object
...
Change-Id: Ifb049feb653d1c345b3d40226e9afb1db877e6a0
2015-09-29 11:10:28 +01:00
d7e7bf139a
tdf#93141 Calc/Impress: remove last colon of emoji short names
...
AutoCorrect Emoji replacements were incomplete in Calc cells and
Impress text boxes, keeping the terminating colon:
:omega: -> Ω:
Corrected by this patch:
:omega: -> Ω
Change-Id: I0d1f6f9ec9c31a7b37e0c9afaaad17dcee568dd5
2015-09-25 12:03:41 +02:00
92c8d74c54
CppCheck : reduce variables scope
...
Change-Id: Ief402017b693a4337f330fb07bb7a6dc6e749f72
Reviewed-on: https://gerrit.libreoffice.org/18753
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-09-23 07:29:33 +00:00
a829ba593c
convert Link<> to typed
...
Change-Id: I99710933b818ebb0e2d70262c3edd7937e5f03ca
Reviewed-on: https://gerrit.libreoffice.org/18772
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-09-22 18:55:43 +00:00
5645960113
convert Link<> to typed
...
Change-Id: I2d3ed4e04b19159bd847a925a7296e981a6d468a
Reviewed-on: https://gerrit.libreoffice.org/18771
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-09-22 18:55:17 +00:00
a19f981ea1
convert Link<> to typed
...
Change-Id: I684a72cc3eeff0caf27132ff641f0d3b20ff7c08
Reviewed-on: https://gerrit.libreoffice.org/18770
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-09-22 18:54:52 +00:00
c439d55042
remove unused Link<> field
...
Change-Id: If6c5719adf5240e12e798f72b25c5c19a09bc0f6
Reviewed-on: https://gerrit.libreoffice.org/18769
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-09-22 18:49:07 +00:00
cc3e899fab
WaE: this method can be declared static
...
Change-Id: I1b656cc53f00b866ed6e86d291149e7f1790f26f
2015-09-20 16:28:11 +03:00
711752a98a
WaE: rewrite as call of rtl::OUString::isEmpty
...
Change-Id: I7c172d26707d08a438be059648f64b5b5959bacc
2015-09-20 16:18:39 +03:00
0212c71959
WaE: implicit conversion of literal of type 'int' to 'bool'
...
Change-Id: I9b81f552d24c75eb08e383868293909d584850d2
2015-09-20 16:17:16 +03:00
3a3c68aeaf
chained editeng: Convert fprintf to SAL_INFO
...
Change-Id: I8e0cfedd34d7e0d70a30147a3bbf0f1cd8e6d3cc
2015-09-20 13:05:16 +02:00
04bc1bd40c
chained editeng: Handle chaining for cutting and pasting
...
Change-Id: Iec08e339a7f06c5fa56e67b42206b31c766f845b
2015-09-20 13:05:16 +02:00
0c0dedb9e4
chained editeng: Add primitive creation methods for chaining
...
Change-Id: I061009a6830c3590e30900b14b2d006f68d237c1
2015-09-20 13:05:14 +02:00
