56e6f0da83
new loplugin: badvectorinit
...
look for places calling the 1-argument vector fill constructor and then
immediately called push_back, which is generally a sign that its
leaving empty slots.
Change-Id: I34e69b8d09cc48c0d409499faaf192b9f86bc517
Reviewed-on: https://gerrit.libreoffice.org/17525
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
2015-10-20 11:35:31 +00:00
e5fbb9fec3
loplugin:defaultparams
...
Change-Id: I1b3ffd418fb4e63bb4369fbc187494a87569556e
2015-10-20 11:45:26 +02:00
cb02906338
loplugin:defaultparams
...
Change-Id: Ief9af764ce6e75a5f2cfdd33d836f007e0f52cd3
2015-10-19 17:49:57 +02:00
8460a4dcac
convert Link<> to typed
...
Change-Id: I760bd9ad3d0da20c0ad38aace765a42983e28531
2015-10-19 16:53:25 +03:00
39e63bfac5
convert remaing DBG_WARNING to SAL_INFO
...
and drop the macro
Change-Id: I452ca373d0c277166e94928c1bce78bf37e39d7c
2015-10-19 13:08:29 +02:00
59418d8eac
convert Link<> to typed
...
Change-Id: I66ad4562f33b68172557d759a26b9e19d19e2c0e
2015-10-19 09:05:57 +02:00
137208746e
convert Link<> to typed
...
Change-Id: I8c00bcdb718bcebbb15e24e1c1622cdc6b356787
2015-10-19 09:05:57 +02:00
e2a7cb31ed
cppcheck:noExplicitConstructor
...
Change-Id: I2b68ba9e8caf7971efbba094ef060e72541bdccf
Reviewed-on: https://gerrit.libreoffice.org/19426
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-18 06:12:13 +00:00
ffbb27d0d7
coverity#1327455 Uninitialized pointer field
...
Change-Id: Icc7405e5b68725e28447a1f2c1cbed2fbe6b8049
2015-10-17 14:46:26 +01:00
fdf9fa4fd2
coverity#1327456 Uninitialized pointer field
...
Change-Id: I0d116989bdbda07995cca1c8062ea5b0c4292b28
2015-10-17 14:46:25 +01:00
6f1313b3d4
convert Link<> to typed
...
Change-Id: Icbba339dac0be31e30dff021bba06a219f8aecd6
Reviewed-on: https://gerrit.libreoffice.org/19405
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-16 09:11:29 +00:00
0e8a40e8b8
calling IsSet() before Call() on Link<> is unnecessary
...
the Call() already does a check
Found with:
git grep -A 1 -w 'IsSet()'
| grep -B 1 '.Call('
| grep ':'
| cut -d ':' -f 1
Change-Id: Ia7248f5d62640b75f705e539c3d1183e39c0d847
2015-10-15 12:29:01 +02:00
99b21cc9f3
convert Link<> to typed
...
Change-Id: I6c55c74d47b13149c2fa210bb9de4e8c430c57cc
2015-10-15 09:58:34 +02:00
ec66ad5953
error C2666: 'operator ==' : 2 overloads have similar conversions
...
Change-Id: I7460e993851335db108a02afe2c147ee57736b0a
2015-10-13 14:18:09 +02:00
ec20e65469
loplugin:mergeclasses, merge IControlContext with OBrowserListBox
...
Change-Id: Ib3e54c9fe8d9445ad799e4b06c41443093af87fb
2015-10-13 10:07:50 +02:00
b36963c0a6
Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
...
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
bff4c13475
Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY code
...
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-12 17:52:26 +02:00
3c99f8500f
convert Link<> to typed
...
Change-Id: Iec15042138e0715459b2c9e872a7464d75a6b1eb
Reviewed-on: https://gerrit.libreoffice.org/19305
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-12 10:48:13 +00:00
257bbb558a
loplugin:stringconstant
...
Change-Id: I83078723ffc40bf16632df87da24ad2289867ed4
2015-10-12 09:27:35 +02:00
b6273d930e
some small cleanups
...
Change-Id: I03221fd5e618155dc093dd4dd7474f516d63761e
2015-10-12 09:13:35 +02:00
7912d5fb74
now we can get rid of the convoluted ControlWindow template
...
Change-Id: I4365e5819784a26f4a71eab8a64cc53ef35d9ad1
2015-10-12 09:13:34 +02:00
70254f61ea
now we can push the controlwindow down and lose some type-casting
...
Change-Id: I3bc5963bad29898bd104feddef1bc1d00a1325e1
2015-10-12 09:13:34 +02:00
42571e3d4e
reduce the web of class relationships here a little
...
make CommonBehaviourControlHelper a base-class of the
CommonBehaviourControl template, which allows us to dispense with the
IModifyListener callback interface
Change-Id: I3c02b864fa08fc50515c11af859477e0fdc035e3
2015-10-12 09:13:34 +02:00
a517b945e7
improve naming of template parameters
...
Change-Id: If62a86b914db634c662949a04396b95e3f44be2a
2015-10-12 09:13:34 +02:00
ccc5ea08d6
cppcheck:variableScope
...
Change-Id: I037feb335499629300309851dcda3bb661f03d4f
Reviewed-on: https://gerrit.libreoffice.org/19316
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-12 06:52:56 +00:00
61806cb983
clang-analyzer-deadcode.DeadStores
...
Change-Id: Id193a3fa8c3832da783f8647d6fc6db8375149f4
2015-10-07 12:49:40 +02:00
27ec6a8ef3
Sane::SetOptionValue return values are unused
...
Change-Id: Ie9310be6508fe828ca1ef36372d56596a02085aa
2015-10-07 12:49:40 +02:00
94b0c2203b
loplugin:mergeclasses
...
Change-Id: Ia19514d33fd025a1df9d26b94e2d39113d122392
2015-10-07 08:27:25 +02:00
7e776c0027
loplugin:unusedmethods
...
Change-Id: I150baadc442e57ee604563bc52965daa9d2e41af
2015-10-06 10:17:02 +02:00
58aea3f36c
loplugin:unusedmethods
...
- improvements to the plugin to find more method calls
- improvements to python script to remove more false+
- fix the FORCE_COMPILE_ALL build flag to include code in
the $WORKDIR
Change-Id: I4d6015dcb9b9d60c26f0bcee8abad807177a7836
Reviewed-on: https://gerrit.libreoffice.org/19064
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-01 10:43:24 +00:00
f1de3e14df
com::sun::star->css in extensions/
...
Change-Id: I64af9f5ae444e1f7bc6c0e8c29df383a9531dba9
2015-10-01 12:18:24 +02:00
e209d115d4
remove old standalone Sun bug numbers
...
Sun bug numbers without any accompanying text are completely useless.
Fixed with
git grep -lP '//\s*#\d+#\s*$'
| xargs perl -i -ne'/\/\/\s*#\d+#\s*$/d or print'
And then hand-checking the result to restore places where it deleted code.
And then some more grepping and hand-editing to kill the others.
Change-Id: Ia96ce4466db8bb8da363ebf41f0ae7f45f28bf29
Reviewed-on: https://gerrit.libreoffice.org/19023
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-01 06:57:19 +00:00
00d2eeebc8
Fix typos
...
Change-Id: Iaa9dd3f02f21947742643349d3b878126017477d
Reviewed-on: https://gerrit.libreoffice.org/18947
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
2015-09-30 12:25:15 +00:00
ac9671f948
tdf#94559: second step to remove rtti.hxx
...
replaced use of PTR_CAST, IS_TYPE, ISA in
chart2, connectivity, editeng, extensions, filter, forms, framework, idl
Change-Id: I6a2f9d8bbccb07088413f7552af4b5af8f0cad99
Reviewed-on: https://gerrit.libreoffice.org/18920
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Oliver Specht <oliver.specht@cib.de >
2015-09-30 06:07:57 +00:00
c50eb68af3
Renamed wrongly prefixed boolean variables
...
Fixed tdf#94269
Change-Id: I63109cc4e095bad680d7637a065080ea368860ae
Reviewed-on: https://gerrit.libreoffice.org/18851
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2015-09-29 18:33:40 +00:00
34180700b2
loplugin:removeunusedmethods, remove unused stuff
...
Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350
2015-09-29 15:08:43 +02:00
e85b2333bc
convert Link<> to typed
...
Change-Id: I59d325c3b051690303a5841907317122fa1ec98b
Reviewed-on: https://gerrit.libreoffice.org/18825
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-09-24 16:19:37 +00:00
1e67e94f1a
convert Link<> to typed
...
Change-Id: If3e2b00092440ebd42ae5b73ae2b0e44c3702683
2015-09-21 08:03:52 +02:00
99bfc363a6
convert Link<> to typed
...
Change-Id: I10b050dc4aae45e646761a82520caa96969bc511
Reviewed-on: https://gerrit.libreoffice.org/18700
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-09-20 06:37:36 +00:00
1de1b63c22
boost->std
...
Change-Id: Id55e334156628a916ce15fca8ec618eed0ae9366
Reviewed-on: https://gerrit.libreoffice.org/18683
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-09-18 14:27:53 +00:00
0619346216
convert Link<> to typed
...
Change-Id: Id600a5ee28440ee91c7089c8f7aa05f83bc0e63c
2015-09-17 12:22:47 +02:00
bd1da37163
convert Link<> to typed
...
Change-Id: I1ce46ea4784ecbd30a47d749d863173e0fe86fe6
2015-09-17 12:22:47 +02:00
4662def919
convert Link<> to typed
...
Change-Id: Iad25d514be71ea4d0f8d2b773197aa30371d776b
2015-09-17 12:22:47 +02:00
ac0eeb43aa
convert Link<> to typed
...
Change-Id: I2f59aec574ed2c5120c554bdff13a9efab6992df
2015-09-17 12:22:47 +02:00
1e2119fd02
convert Link<> to typed
...
Change-Id: I3d35a0bb75b6989dd13371543d1bdf3ef5f47641
2015-09-17 08:19:34 +02:00
44404a0c8a
convert Link<> to typed
...
Change-Id: If6334d32abbec379acbb9def98fdf6cb5144238b
2015-09-16 08:38:53 +02:00
c4fb1122b3
convert Link<> to typed
...
Change-Id: I628de57f87b4ba20a797d345bdf71cf10cf148fc
2015-09-16 08:38:53 +02:00
3c68751f6b
cppcheck: noExplicitConstructor
...
Change-Id: If00a2de2c23271baaee126230c6bf9e657666ff4
2015-09-15 10:44:00 +01:00
e0714ae393
convert Link<> to typed
...
Change-Id: I8f3e401afa27778678788b4ac90ea927a2fed1d7
2015-09-15 09:37:31 +02:00
3107b23762
sal_uInt16 and SAL_MAX_UINT16 to sal_Int32 and LISTBOX_APPEND
...
Change-Id: Id68a8369d0ca907d4afc0d8a22d31d1e4c24133c
2015-09-12 14:18:52 +02:00