Commit Graph

312 Commits

Author SHA1 Message Date
1579dcb11e Rename some "document name" params to "document URL"
...to match reality, cf. 7660e4dcecfb19ad8e9e21e5fe53637bd1b9dc6c
"tdf#89694 Password dialog for opening OOXML shows url-encoded path"

Change-Id: I9fdd204494374770186347e92aa0bd6e7093ffaa
2015-10-20 15:18:26 +02:00
1b62841b18 com::sun::star->css in include/comphelper
Change-Id: Ice569b724732da1fd67a18a4ccf2f92f530cd689
Reviewed-on: https://gerrit.libreoffice.org/19459
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-20 07:05:25 +00:00
25405f5ef5 coverity#1327458 Uninitialized scalar field
Change-Id: Iaa51be64ad0ed96e8ce805c7cf26e8a48215b2d1
2015-10-17 14:46:25 +01:00
866909c1db Improve performance by using the ScCalcOptions for OpenCL.
Use the new configurationlistener to track the relevant setting.

Change-Id: I9decea55df25f7eb34cd2fef94743d1907360d16
Reviewed-on: https://gerrit.libreoffice.org/19377
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-10-14 19:36:56 +00:00
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
bff4c13475 Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY code
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-12 17:52:26 +02:00
c0096b5b84 Hold the SolarMutex while updating properties; thanks to sberg.
Change-Id: Id9dc4c7e083da2a8d44c7295a8b605de81bca1ef
Reviewed-on: https://gerrit.libreoffice.org/19272
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-10-09 14:52:05 +00:00
f76b3dd039 Move SolarMutex down from tools to comphelper/ to make life easier.
Change-Id: I7dd21f30daa27e5de2848eb16aee9a610dd629d5
Reviewed-on: https://gerrit.libreoffice.org/19271
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-10-09 14:51:44 +00:00
83c5214889 loplugin:saloverride
Change-Id: I7b640ecf957ec2663c68a9548680a64c85470da5
2015-10-09 11:48:15 +02:00
ccf8bdcf92 Create a wrapper to make listening for configmgr changes easy.
Change-Id: Ib58d04f9e046e604b24e0e338796a7a60aa1d6fd
Reviewed-on: https://gerrit.libreoffice.org/19253
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-10-09 08:42:49 +00:00
fce720b3e4 comphelper: add string::join()
If there is a need for it, this could be extended later to work with uno
sequences and/or OUStrings as well.

Change-Id: Id0af8b1755c8e4b668720563d10a052337e1b2c9
2015-10-08 08:37:57 +02:00
4281599a04 loplugin:mergeclasses
Change-Id: If5da1527a048997aec1dbc07afbdddabd2c4168d
2015-10-07 08:27:25 +02:00
6ca355d281 tdf#94228 comphelper: replace BOOST_PP
Replace BOOST_PP macros in comphelper with variadic templates. The
client interface should not change. However, there are a few side
effects due to this change. The most important being 1) There is no
longer a maximum number of service declarations limmited by default
at 12 for unwrapArgs and component_getFactoryHelper. 2)
component_getFactoryHelper now terminates early as soon as pRet is not a
null pointer.

Change-Id: I016fd208d0e80f91d8669fff29d58b6189e946d3
Reviewed-on: https://gerrit.libreoffice.org/18891
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-10-06 19:29:43 +00:00
e209d115d4 remove old standalone Sun bug numbers
Sun bug numbers without any accompanying text are completely useless.

Fixed with
   git grep -lP '//\s*#\d+#\s*$'
       | xargs perl -i -ne'/\/\/\s*#\d+#\s*$/d or print'
And then hand-checking the result to restore places where it deleted code.
And then some more grepping and hand-editing to kill the others.

Change-Id: Ia96ce4466db8bb8da363ebf41f0ae7f45f28bf29
Reviewed-on: https://gerrit.libreoffice.org/19023
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-01 06:57:19 +00:00
b3ebda451f Fix typos
Change-Id: Ia8b2176a439742769e61fb6a981000f316033071
Reviewed-on: https://gerrit.libreoffice.org/18954
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Oliver Specht <oliver.specht@cib.de>
2015-09-30 12:36:37 +00:00
34180700b2 loplugin:removeunusedmethods, remove unused stuff
Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350
2015-09-29 15:08:43 +02:00
8b00ac9b46 tdf#94228 comphelper: replace BOOST_PP
Remove makeSequence.

Change-Id: If07dc8702d811111fc634c9c7eb4c9a331517ca5
Reviewed-on: https://gerrit.libreoffice.org/18647
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2015-09-25 21:13:17 +00:00
1704221067 comphelper: add LibreOfficeKit::set/isViewCallback()
Change-Id: Iad0b2ee419327daf478f3ddda2378effe0184067
2015-09-21 07:30:23 +02:00
22b80ac8e2 boost->std
Change-Id: I3fd9e1599c5ad812879a58cf1dabbcd393105e1c
Reviewed-on: https://gerrit.libreoffice.org/18564
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-14 12:54:25 +00:00
4f918cd5da comphelper: give up on the XPropertySetInfos for now
PropertySetInfo_Impl in ucb/source/core/ucbstore.cxx is sheer insanity,
persisting a PropertySetInfo into the configuration => throw up
hands in despair.

Change-Id: Ic341e453571072a9ed66c6bf51e96dbe39806566
2015-09-12 00:00:40 +02:00
013f84d06f comphelper: another WeakImplHelper duplicate
Change-Id: I8b5fad24857f434cab351bbbae42c4b09bc6613a
2015-09-11 22:31:53 +02:00
03be785efe framework: yet another WeakImplHelper<XPropertySetInfo> dupcliate
There's a very similar comphelper::PropertySetInfo, unfortunately with
an additional mnMemberId on its properties, so convert a little...

Change-Id: I2a5fc0bb0ff6d680d546192b9d09afee6348f218
2015-09-11 22:31:53 +02:00
6fcaaca6cf comphelper: fix MSVC --enable-mergedlibs build, OFOPXMLHelper
The OFOPXMLHelper class causes duplicate definition link errors
due to its WeakImplHelper base class.

It turns out that the OFOPXMLHelper class itself is only used by other
exported functions in comphelper itself so just hide the
implementation detail.

Change-Id: I3ac8c561af703193cc2609e2c799b630a0d43127
2015-09-01 18:25:47 +02:00
a01a0785e6 comphelper: fix MSVC --enable-mergedlibs build
Try not to export the WeakImplHelper symbols as that causes duplicate
definition errors with the class OSelfTerminateFileStream that
has the same WeakImplHelper base.

Change-Id: Id41bfed24617113de48c76ab6802b21a8892e66f
2015-09-01 18:25:47 +02:00
fe6c124da7 Remove demonstrated-useless comphelper::compare
Change-Id: Ifd1b38afb963255b76f0d821eb46e4c6a972128a
2015-08-21 10:34:04 +02:00
a4de770bab comphelper: reduce copypasta with UniquePtrValueLess functor
Change-Id: Ib93b818eeebc2f370535d1b061beabf7e8c65257
2015-08-19 19:32:18 +02:00
58c3bbfd46 comphelper: remove unnecessary include <stack>
Change-Id: I39295d69dd8a48f0f40275830cb6fda4ca0b69f3
2015-08-19 19:32:18 +02:00
39ce314c12 comphelper::isA(Type... -> Type == cppu::UnoType...
Change-Id: I1bfb99b1715a907a03af5a30df6c7a41f91fd2fb
2015-08-19 14:48:27 +02:00
884e970b8c Remove unused comphelper::isAReference
Change-Id: I7033e1e60f67e93a31d19ea08513982643dd61ae
2015-08-19 14:48:27 +02:00
d0f18382c5 comphelper::isA(Any... -> Any::has
Change-Id: I4fdc77c6fde93d9d1ee814f7614a1c4c81e18247
2015-08-19 14:48:27 +02:00
d21260cdb6 Remove two silly typedefs
Change-Id: Ia7de1cebf6009e770ca1b96bab6d5e121573ccc1
2015-08-19 13:34:43 +02:00
5da0dce19c Consolidate isFileUrl checks
Change-Id: I1b74fdfaa09c4d0d6c296253958e83e78b546a9a
2015-08-19 12:24:37 +02:00
94cdcaa4d8 Add a globally usable WindowsErrorString function
Is comphelper the right place for this? Is having it as "inline" the right
way?

Change-Id: I973dbde108f89b6cab17e5d88db2390d6f18a672
2015-08-13 13:24:54 +03:00
6a7de42a76 Properly init PropertyValue.Handle in InitPropertySequence
Change-Id: If00dc9330f0fd08057ac75510e1c2f3bb1e5b17c
2015-08-11 09:47:08 +02:00
a5b842f3aa remove unused SfxFilterFlags values
from both the code and the XCU files

Change-Id: I47f1f33c3ad4a37e346e3b8020dd9d3e284ccb77
Reviewed-on: https://gerrit.libreoffice.org/17522
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-05 11:08:25 +00:00
819fd24487 comphelper: replace boost::function with std::function
Change-Id: I042c97d8472c3afceffba36808687f382571e6c2
2015-07-31 21:24:24 +02:00
dd4befa992 fix crash in writer, thanks to my new assert in typed_flags_set
and clean up the duplication of constants between filter/ and
comphelper/ in the process

Change-Id: I0d1525b559c63a3d39deae51accff5dcdbb0aa82
Reviewed-on: https://gerrit.libreoffice.org/17446
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-07-31 09:55:17 +00:00
18110ca3bd comphelper, desktop: fix MSVC mergedlib link failure
Duplicate symbols are easily avoided by removing duplicate code.

Change-Id: I9b598a44156d6ff71b0691e69ab8163b15e2e26f
2015-07-27 21:22:07 +02:00
efac5fa06e remove some unused defines
Change-Id: Ib2d50e8c29ccbc5ffcb52cdff4ae3eaae9a62188
Reviewed-on: https://gerrit.libreoffice.org/17332
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-27 06:12:01 +00:00
bc9a8ddbb7 tdf#82744: fix WebDAV lock/unlock behaviour - part 2
Changes done to the code in framework, comphelper and unotools,
in no particular order

- add an interaction handler dedicated to WebDAV
The stock interaction handler can be missing depending on the need of
the framework performing its tasks, so a dedicated handler is
provided, this one is always present.

- force opening of a WebDAV file.
A WebDAV file sould be open r/o even if explicitly requested to open
as r/w.
This is a limitation of current WebDAV implementation, not of the
standard.
This change is needed in order to reopen correctly a file as
requested by a 'Edit Mode' GUI command.

Change-Id: I5368fa2c0511f1630e6d6139c6a986d33aa19082
Reviewed-on: https://gerrit.libreoffice.org/17182
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-07-22 16:17:04 +00:00
a890a7696f tdf#88206 replace cppu::WeakImplHelper* etc.
with the variadic variants, for comphelper.
This also includes extra changes in other modules
required accordingly.

Change-Id: Id1537f46f1c90f760a0d8987a6dafa0e1da03b8f
Reviewed-on: https://gerrit.libreoffice.org/16929
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-20 07:06:22 +00:00
9f27e5b0e0 Fix typos
Change-Id: I52cbaad71560d73f5e24f3de3cd62b00d678dd6c
Reviewed-on: https://gerrit.libreoffice.org/17187
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-07-19 19:45:07 +00:00
7aa9f04538 do not include boost/utility.hpp
It just includes a bunch of other boost headers; mostly we need
boost/noncopyable.hpp so include that directly.

This eliminates 831 MB(!) of boost/preprocessor/seq/fold_left.hpp
completely, which is the 2nd biggest header after ustring.hxx.

Change-Id: I3df55770adcb46e56f389af828e8ba80da2dc1f2
2015-07-10 23:25:22 +02:00
5b2f823194 add a SAL_RAND_REPEATABLE for repeatable random nums
merge the formula and comphelper ones together

Change-Id: I2e7e2cdb176afc6982e384fa1e007da5b914e6f0
2015-07-10 08:58:20 +01:00
e6a0ef5eee comphelper: remove boost::bind from headers
Change-Id: I40c504d086c8ae1fd825acdafaada283ad9db8d0
2015-07-09 10:18:05 +02:00
420923ba76 Fix typos
Change-Id: Ie2bbe020fc6e3a4a4f913208c245f395849bb9ee
Reviewed-on: https://gerrit.libreoffice.org/16708
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-07-03 09:32:26 +00:00
813f3436ea loplugin:unusedmethods comphelper
Change-Id: I704a1e777505dbad83d81857f09601c2887fb6a1
Reviewed-on: https://gerrit.libreoffice.org/16682
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-02 12:14:51 +00:00
10a7c828be coverity#1308587 Uncaught exception
Change-Id: I45e699ebf255e7d933a3b5d77717dcd7583d8383
2015-06-29 12:58:03 +01:00
2434f29838 loplugin:stringconstant: Flag more inefficiencies
Change-Id: I0e2e161a29b653cf16b2e3a6ddeb89567b5342c8
2015-06-25 12:38:33 +02:00
6390d2c52b Get rid of comphelper::string::is*Ascii functions
Change-Id: I99912112e5b009d7a143f9816d757cdf6ebb1783
2015-06-24 15:27:28 +02:00