Commit Graph

139 Commits

Author SHA1 Message Date
d6f97a2124 inline typedef
Change-Id: I6ec88fbdb9bc0e86f4e53eb765eabd5382a25b88
2015-10-13 10:07:49 +02:00
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
bff4c13475 Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY code
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-12 17:52:26 +02:00
7e776c0027 loplugin:unusedmethods
Change-Id: I150baadc442e57ee604563bc52965daa9d2e41af
2015-10-06 10:17:02 +02:00
e209d115d4 remove old standalone Sun bug numbers
Sun bug numbers without any accompanying text are completely useless.

Fixed with
   git grep -lP '//\s*#\d+#\s*$'
       | xargs perl -i -ne'/\/\/\s*#\d+#\s*$/d or print'
And then hand-checking the result to restore places where it deleted code.
And then some more grepping and hand-editing to kill the others.

Change-Id: Ia96ce4466db8bb8da363ebf41f0ae7f45f28bf29
Reviewed-on: https://gerrit.libreoffice.org/19023
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-01 06:57:19 +00:00
34180700b2 loplugin:removeunusedmethods, remove unused stuff
Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350
2015-09-29 15:08:43 +02:00
239c25ff95 check for error more frequently
Change-Id: I909c225dd9bd92763ae24b62854a9217fc2e2a0e
2015-09-01 09:40:20 +01:00
c249f93d96 extend seek, loop ending tests to ppt specific code
Change-Id: Id4419b6b902b742117e248870b6a663c9c58955f
2015-08-27 09:16:24 +01:00
334dba623d fix crash on loading certain ppts
Change-Id: I544a67e3706c7d12414cc075118ef2f0f5ddd0f6
2015-08-26 11:30:02 +01:00
a4de770bab comphelper: reduce copypasta with UniquePtrValueLess functor
Change-Id: Ib93b818eeebc2f370535d1b061beabf7e8c65257
2015-08-19 19:32:18 +02:00
ef46917ff3 Put Polygon from tools under tools:: namespace
Polygon is one of these names that Clash with some system objects
A similar work has been done earlier with PolyPolygon.

Change-Id: Icf2217cb2906292b7275760f1a16be0e150312f5
Reviewed-on: https://gerrit.libreoffice.org/17789
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-17 02:07:43 +00:00
b14c9d14a1 remove default value from DffPropSet::GetPropertyValue
more useful to make it explicit

Change-Id: Ic76fcc5ffa245b3eb3c99f3a5e4d0656b56c511e
2015-08-14 09:16:06 +02:00
678bb5135b tdf#88206 replace cppu::WeakImplHelper* etc.
with the variadic variants, for filter.

Change-Id: I30dcd7cfb3e484034f6cceceb1ff7cd9d3f4b7a6
Reviewed-on: https://gerrit.libreoffice.org/17585
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-11 07:06:51 +00:00
f17f89aadc include: inline some use-once typedefs
Change-Id: I064e95c72e5f67178cf2875f457adac241cee529
2015-08-04 08:55:57 +02:00
79ebd13ffa filter: MSVC wants to generate unnecessary copy assignment again
Change-Id: I273b47a6d30e6fcb597e43188f93e0e8f834c929
2015-07-24 11:14:41 +02:00
22fd35f598 filter: replace boost::ptr_vector with std::vector<std::unique_ptr>
Change-Id: I9aa0543edf3f0aef3a0a376aa0f82f51c6d93313
2015-07-24 10:58:57 +02:00
b772f02219 filter: convert boost::ptr_vector to std::vector
... and move it out of the header since it's only used in that class.

Change-Id: Icd5cc86428c97bdaaa07d56e17393846629721e5
2015-07-24 10:58:56 +02:00
355865211c filter: replace boost::ptr_set with std::set<std::unique_ptr>
Change-Id: I171fdb41bef4a7f3ef6418d81a1d99f123c0652c
2015-07-24 10:58:56 +02:00
9c959736ca filter: replace boost::ptr_vector with std::vector<std::unique_ptr>
Change-Id: I87f903c6a81b271847f072fa0608fae4669ac307
2015-07-24 10:58:55 +02:00
2ca3569e04 filter: replace boost::ptr_vector with std::vector<std::unique_ptr>
Change-Id: I2659fea1fb18c5b0a4ff5339643c7c28c0f5f458
2015-07-24 10:58:55 +02:00
88b992d0da filter: convert boost::ptr_vector to std::vector<std::unique_ptr>
Change-Id: I548f15466c695e4cbf5e505771d7c0baf8812198
2015-07-24 10:58:54 +02:00
e963a88912 formatting of public/private/protected section qualifiers
make it consistent across the codebase, no space between keyword
and the colon

Change-Id: Idca61ddfc74ad2460fb05fe417499324b05e5de5
Reviewed-on: https://gerrit.libreoffice.org/17148
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-17 09:49:35 +00:00
a90c6eb99c loplugin:unusedmethods filter
Change-Id: Ie33a5ebda9337cf123b39ae18a8d7b4ef12b6991
Reviewed-on: https://gerrit.libreoffice.org/17131
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-17 06:50:58 +00:00
92ca6ebebd coverity#1308592 Uncaught exception
Change-Id: I1a63116534430ebf8d203c21baf248a84a39b221
2015-06-29 12:58:05 +01:00
bb2d711998 filter: bestFitOpenSymbolToMSFont() parameter bDisableUnicodeSupport
... is obsolete

Change-Id: I644f80ac4bf265f2c669a9d1b87fecd012756be2
2015-06-20 11:42:36 +02:00
b04e1e79e6 Prop_pSegmentInfo is totally misunderstood apparently
digging into the crash on export of kde216114-1.odt
reveals various horrors

Change-Id: I0d24fe303d561a00a08098b306d10fd8273af928
2015-06-10 17:53:02 +01:00
b8f4b28cf6 Use delegating constructor
Change-Id: I793130bda833f4eb6ba5f2901adb2362ce666fe9
Reviewed-on: https://gerrit.libreoffice.org/15829
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2015-05-21 14:46:23 +00:00
ab465b90f6 bin/rename-sw-abbreviations.sh
renames the most annoying abbreviations in Writer (and partially
in the shared code too).

Change-Id: I9a62759138126c1537cc5c985ba05cf54d6132d9
2015-05-20 13:05:49 +02:00
5b1337f7b2 tdf#62475: partial handmade fixes
Change-Id: Ib9af202c43b916b9af4b4e18db35d470a8692fe4
Reviewed-on: https://gerrit.libreoffice.org/15712
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-05-15 17:55:15 +00:00
7df89ec7a2 Remove unnecessary includes of sot/storage.hxx from include/
Change-Id: I242cd126814bbebdb99ea38d9e66513189c313d9
2015-05-07 11:05:05 +02:00
dc47b2e513 Unwind SotStorageRef typedef
Change-Id: I8d5363bb2ad813ef29b4078848914f4b0989b9f1
2015-05-07 11:05:04 +02:00
d3b5038cbb loplugin:staticmethods
Change-Id: Iea68c4e466dd8e1cb7164959a680e5e52542166b
2015-05-05 09:30:39 +02:00
77fd72237c loplugin:simplifybool
Change-Id: Idf2ae6b0b2c3d111125ad91ea7d13eec67325f36
2015-04-24 12:36:21 +02:00
2240118177 Improved loplugin:literaltoboolconversion looking into cond. exprs.
...automatic rewriter fixes

Change-Id: I6b04ca80f08f8a71ff94e309fd52f44d736751ee
2015-04-23 18:39:07 +02:00
71b809959b remove unnecessary use of void in function declarations
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-15 11:47:12 +02:00
0eea902d18 const_cast: convert some C-style casts and remove some redundant ones
Change-Id: Idbae574e5d51d497fea7eadb6d80dec8f97d499a
2015-03-26 15:33:30 +01:00
9b0e09dedc SkipImages option for document import
This option allows images and drawings to be skipped while importing
DOC and DOCX, for text-only conversion or indexing.

Change-Id: Id4bfbbe48d8a8e970b1cb5922187768bf94dc918
Reviewed-on: https://gerrit.libreoffice.org/14733
Reviewed-by: Németh László <nemeth@numbertext.org>
Tested-by: Németh László <nemeth@numbertext.org>
2015-03-24 07:38:04 +00:00
3e03767906 Char highlight: convert LO character background to MSO highlighting
DOC export has a good approximating algorithm for that
so use it everywhere.
In RTF case use the default color table which is added
also by MSO Word. With that highlight colors are also added to
the table.

Change-Id: Ie4827a933c316d4dc0c0c7a32d8cf319477d1bf9
2015-03-21 16:19:11 +01:00
cfeeceab9e loplugin:constantfunction: filter
Change-Id: I11e616ec1e3249573797bd2a4bb2b52f11c115ee
2015-03-19 10:45:02 +02:00
c19c242ec0 boost->std
Change-Id: I412137e7e7b9b2b87f401bc140a9499d1fc012c6
2015-02-18 11:00:17 +00:00
3744d8506e boost->std
Change-Id: I8371b942d915f777a29ca01cd0aed674db0ca853
2015-02-17 16:24:05 +00:00
a1ceacc17e boost::foo_ptr->std::foo_ptr
Change-Id: I9219619b538b6530a89f5932ac51eb3b62eb396a
2015-02-16 12:54:44 +00:00
107d53ab88 loplugin:deletedspecial
Change-Id: Ifdd7a80704f4ccd093d58117131b83c74da8b029
2015-02-07 12:35:58 +01:00
fe480d8136 remove unused typedefs
found with some minor modifications to find/find-unused-defines.sh

Change-Id: I18cc479adedc7a0dada68a4aeef08300e62631dd
Reviewed-on: https://gerrit.libreoffice.org/14194
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-28 06:19:49 +00:00
b44cbb26ef new loplugin: change virtual methods to non-virtual
Where we can prove that the virtual method is never overriden.

In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.

Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-26 08:42:28 +02:00
45ec1d9b56 brute-force find-and-remove of unused #define constants.
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
2015-01-08 10:39:36 +02:00
fd1372ba8b boost::unordered_map->std::unordered_map
you can get debug stl this way

Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2015-01-02 16:14:36 +00:00
e5a03da8eb fdo#84938 replace PPT_PLACEHOLDER_ constants->enum
Change-Id: I4110fab17f42a747ec55b27445f28bdef873ef86
Reviewed-on: https://gerrit.libreoffice.org/13447
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-15 06:48:23 +00:00
f5c5bab09f fdo#84938 replace PPT_LAYOUT_ constants with enum
Change-Id: I3c77e7e551bd4b657cb58fdfeead73d50441e890
Reviewed-on: https://gerrit.libreoffice.org/13437
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-12 08:07:07 +00:00
e9a3d259c7 loplugin:cstylecast, involving pointer to incomplete type
Change-Id: If8d2be68a75e69226f2a5a1d2936a257fa032c23
2014-12-05 16:08:25 +01:00