b36963c0a6
Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
...
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
db34ab81ae
clang-analyzer-deadcode.DeadStores
...
Change-Id: I823aab2038eb08f4061e353b5fafc12b8e60e671
2015-10-07 15:43:44 +02:00
8a248d69cc
loplugin:mergeclasses
...
in this case, just rename the baseclass so that it matches the
other places we do this
Change-Id: I21704db7352f72e43636dde9e92c8bef61b7e251
2015-10-06 09:26:14 +02:00
3764f7435e
Fix typos
...
Change-Id: Id27f5a357c1333dec5c24c4f5e0fdaed7a775774
Reviewed-on: https://gerrit.libreoffice.org/18963
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
2015-09-30 10:59:35 +00:00
9f6cb675b0
Fix typos
...
Change-Id: I013414cf10e25acd5216643855aaa230258a1b5f
Reviewed-on: https://gerrit.libreoffice.org/18962
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
2015-09-30 07:03:18 +00:00
3a00aaef2a
boost->std
...
Change-Id: Ie490bf2c6921f393bdeed96b1a8815996b701bf0
Reviewed-on: https://gerrit.libreoffice.org/18670
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-09-18 07:59:14 +00:00
6fcaaca6cf
comphelper: fix MSVC --enable-mergedlibs build, OFOPXMLHelper
...
The OFOPXMLHelper class causes duplicate definition link errors
due to its WeakImplHelper base class.
It turns out that the OFOPXMLHelper class itself is only used by other
exported functions in comphelper itself so just hide the
implementation detail.
Change-Id: I3ac8c561af703193cc2609e2c799b630a0d43127
2015-09-01 18:25:47 +02:00
5ba6aafa20
package: tdf#88206 replace cppu::WeakImplHelper* etc.
...
with the variadic variants.
Change-Id: If88e1d741075e86997c91dc2c59eeebe45f67c1f
Reviewed-on: https://gerrit.libreoffice.org/17980
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-08-26 06:35:34 +00:00
5da0dce19c
Consolidate isFileUrl checks
...
Change-Id: I1b74fdfaa09c4d0d6c296253958e83e78b546a9a
2015-08-19 12:24:37 +02:00
0b9b5f833c
Simplify ZipPackage::isLocalFile check
...
(vnd.sun.star.wfs is long gone)
Change-Id: I3e25f1728504cbad07bb97187a7bac23b33695dc
2015-08-18 15:32:14 +02:00
a19e2064c0
avoid possible leak on exception
...
Change-Id: Id3c16e5fedc5e57c8daccafa25bdb2fbbd0131b0
2015-08-17 14:55:14 +01:00
ef698035aa
Related: tdf#88314 delete temp files
...
clear to close the inputstream before attempting to delete the temp file, which
is plausible as the windows-specific failure in earlier attempts at this
Change-Id: I751aa3a098dd960f56b77a5f5fc93783c1060556
Reviewed-on: https://gerrit.libreoffice.org/17531
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-08-07 07:53:18 +00:00
458bf08125
Resolves: tdf#88314 close temp file after each thread completed
...
Change-Id: Ic2eec30cfb5f61c53777eefeeb8bad6f552da2fc
Reviewed-on: https://gerrit.libreoffice.org/17355
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-08-05 22:15:54 +00:00
33a21d37f3
Revert "Resolves: tdf#88314 close temp file after each thread completes"
...
This reverts commit 738cf411e9315d17c7eb8be47ded643a00dfe5c5.
It brokes windows in https://gerrit.libreoffice.org/#/c/17289/
as per http://ci.libreoffice.org/job/lo_gerrit_master/4465/Gerrit=Gerrit,Platform=Windows/
was pushed despite that.. :-(
2015-07-26 00:23:50 -05:00
738cf411e9
Resolves: tdf#88314 close temp file after each thread completes
...
and reopen them when we need their data.
That way we don't have as many open files as substreams in the
package, so we don't run out of file handles
Change-Id: Ic124e275abf15f4578c77ee271d185f40cb844b1
Reviewed-on: https://gerrit.libreoffice.org/17289
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-07-24 13:24:55 +00:00
a792aa2c48
loplugin:unusedmethods toolkit,package
...
Change-Id: I83618cd2fd12fb0c1691dc7255fc7192e68649cd
Reviewed-on: https://gerrit.libreoffice.org/17031
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-14 09:28:14 +00:00
e546ed01e6
loplugin:unusedmethods package
...
Change-Id: I19d6bbb9288d72b99d1023b4983b1c3fff7570e8
Reviewed-on: https://gerrit.libreoffice.org/16811
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-07 11:01:11 +00:00
7f73bb5b44
Fix typos
...
Change-Id: I8e429d1f03aac7c7cdb7ff4b43b3f46d40292510
Reviewed-on: https://gerrit.libreoffice.org/16709
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com >
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com >
2015-07-03 08:19:04 +00:00
371200675c
drop yet another reimplementation of rtl::Reference (SotMutexHolderRef)
...
Change-Id: I57f9dff931242405420bd45fae7ec5f13718707f
2015-06-29 09:16:18 +02:00
69c88a32aa
Fix typos
...
Change-Id: Ifd126a535f18db79a18aaec61b76cdf26ab33dff
Reviewed-on: https://gerrit.libreoffice.org/16522
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
Tested-by: Julien Nabet <serval2412@yahoo.fr >
2015-06-28 12:28:31 +00:00
a77caf49cd
loplugin:stringconstant: handle OUString+=OUString(literal)
...
Change-Id: Ib9bf6e0919ee0cab02d826859317ea20cb64cabb
2015-06-26 13:55:33 +02:00
4729774b24
remove unnecessary check for null when calling delete
...
Idea originally from caolan.
Found using the following command:
find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;'
Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-15 14:46:41 +02:00
3754474cde
Typos
...
Change-Id: I21c352a63d668c174eef212dbfbe6346c678ce4d
2015-06-13 09:13:52 +02:00
8a3120ced5
cppcheck: noExplicitConstructor
...
Change-Id: Id6291335945a8f10cef3afd1a2b3bae65fdf4562
2015-06-11 14:56:14 +01:00
776a3f14f2
convert expressions like 'size() == 0' to 'empty()'
...
Change-Id: Ia5c8c0f38a347f398d587970a22e03f29ffd37af
2015-06-11 10:07:08 +02:00
d203948fdb
convert 'it.begin() == it.end()' to 'it.empty()'
...
Change-Id: I244a9eb6bce6b1c649653ec38ebb9a39f8b4c145
Reviewed-on: https://gerrit.libreoffice.org/16212
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-06-11 06:48:29 +00:00
430d760acd
loplugin:cstylecast: deal with remaining pointer casts
...
Change-Id: I1a3766bba2c157f20422d3ffb0c08f631b537724
2015-06-08 16:26:57 +02:00
525e514545
WaE: unreferenced local variable
...
Change-Id: Ie04966936a406fefbbcd1d96d7d3d299f98a31ae
2015-06-05 11:56:09 +01:00
05661623c7
uncaught exceptions in parallel deflate threads on re-export of HTB23106 odgs
...
Change-Id: Ib6aef478b8dcf1c7a7262ab60eef4d44da0de632
2015-06-05 11:46:47 +01:00
55bc128636
loplugin:loopvartoosmall
...
Change-Id: I86ff38a90018a2ddfb2db3babf67168b0e6257a5
2015-06-01 09:58:56 +02:00
1cb0b37ad0
Rephrase comparisons between bool and sal_Bool
...
...to cater for forthcoming loplugin:implicitboolconversion improvements
Change-Id: I88c0c4681137022005c3a4c418e91cb17bc17148
2015-05-08 09:49:01 +02:00
0a48e0fb4e
loplugin:simplifybool
...
Change-Id: Ia4177cf1a4b0c06ef614b54298fd6f9224956afc
2015-04-24 12:36:25 +02:00
2240118177
Improved loplugin:literaltoboolconversion looking into cond. exprs.
...
...automatic rewriter fixes
Change-Id: I6b04ca80f08f8a71ff94e309fd52f44d736751ee
2015-04-23 18:39:07 +02:00
71b809959b
remove unnecessary use of void in function declarations
...
ie.
void f(void);
becomes
void f();
I used the following command to make the changes:
git grep -lP '\(\s*void\s*\)' -- *.cxx \
| xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'
and ran it for both .cxx and .hxx files.
Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-15 11:47:12 +02:00
a0f2bb7042
unnecessary cast
...
Change-Id: I7c040b2539b9f7f923620a02d0a27e8e000fee4a
2015-04-12 21:17:58 +01:00
35163715ea
loplugin:staticmethods
...
Change-Id: Ie348778ea666c24e95e048386547f301083a0017
2015-04-09 10:13:18 +02:00
9222f5d065
A UNO Any can't contain an Any
...
...and css::uno::makeAny<css::uno::Any>() was never meant to be used. Introduce
css::uno::toAny for the (template-code) cases that shall return an Any for both
Any and non-Any inputs.
Change-Id: Ifa977d73f1da71b2fedde7e8140b19497c4a0257
2015-04-08 17:45:08 +02:00
c9c991a9af
Reduce to static_cast any reinterpret_cast from void pointers
...
Change-Id: I6979d9af3a97918593f0596df17c096bd3f4c4ad
2015-03-31 13:15:43 +02:00
b857703113
const_cast: convert some C-style casts and remove some redundant ones
...
Change-Id: I313d61fc6e7be3a5513da83d3de9202237306739
2015-03-26 15:33:33 +01:00
ca5ff45597
tdf#90010 Partially revert "package: Do not bother with deflating jpeg images"
...
This reverts commit 0843ade74e5848c0babad509b10c334b01847be2 for the case, when
the document is protected by password. Would be nice to fix properly later.
Change-Id: If159639d6f74de4e106e9dad382faac9d5de4a09
2015-03-25 22:32:40 +01:00
858e455634
loplugin:constantfunction: various
...
Change-Id: I6eddda9f4b31c7ce413c328b6a857a81bd222eed
2015-03-24 10:51:22 +02:00
0777231112
V803 decreased performance postfix increment
...
These are pretty silly anyway, but apparently it complains even about
integer variables which make this rather a waste of time.
Change-Id: I15e847d33d5decd2adcab04e4f1567d3997d28a2
2015-03-13 16:23:26 +01:00
ad62a2e1bd
package: PVS-Studio V595 'm_pData' pointer could be null
...
... so convert the last member of StorInternalData_Impl that needs
manual cleanup to rtl::Reference
Change-Id: Ie1549c1f52d50dc3c63715176c02821b63c7cab1
2015-03-12 20:22:14 +01:00
44177f0209
package: convert StorInternalData_Impl member to std::unique_ptr
...
Change-Id: If523dbd4596f4023bda6509c6dc09b8ab3d74874
2015-03-12 20:22:14 +01:00
c3e45f10e0
package: convert OStorage::m_pData to std::unique_ptr
...
Change-Id: I875432aeb98072882df1f228d9fcf43c6027e8d5
2015-03-12 20:22:13 +01:00
e43d5f26de
package: move WSInternalData_Impl out of header
...
Change-Id: Ie7c01b37e9a4eb2221d4b40fc6b13672d9b3a684
2015-03-12 20:22:12 +01:00
9ad17c2536
package: convert OWriteStream::m_pData to std::unique_ptr
...
Change-Id: I9e72325679b2758cd4297d2693cf49fd533f8baa
2015-03-12 20:22:12 +01:00
2877e5a9c7
package: PVS-Studio V595 'm_pData' pointer could be null
...
... just convert its explicitly deleted member to unique_ptr.
Change-Id: I826257ff512632a2aedd53a7ce5e4bedf49c3cfe
2015-03-12 20:22:11 +01:00
252a73ff22
redundant check
...
Change-Id: Id6b72a1a3133e47a07ee274f4082dde0e7032894
2015-03-11 14:08:36 +00:00
d22519f62b
V801: Decreased performance
...
Change-Id: Id8cd45d2844c121f63684734ab3546c24a1aab32
2015-03-09 22:04:31 +00:00
