8e4739b94d
afl-eventtesting + VclPtr: missing dispose on impress annotation window
...
regression from
commit c72fac269626cd4c2c3f62a6eed69e47b59256a4
Date: Mon Mar 16 12:17:44 2015 +0200
vclwidget: convert lots more sites to use VclPtr
Change-Id: Iac6a83003d9c395589acdc23fe511d2bb47e91ee
2015-10-20 21:18:38 +01:00
ecb79b9371
remove SlideSorterCache debug facility, and with it, the last Link<>
...
nobody has used it, or enabled it, in a very long time
Change-Id: Ic36ff45086f7f7c9098c618d21cb6fc7cd7a46df
2015-10-20 16:16:45 +02:00
d50e38686c
loplugin:defaultparams
...
Change-Id: Ibf07815fa1a113876730382b8d14960eb7a78a0b
2015-10-20 11:46:24 +02:00
2b942719d7
missing return
...
Change-Id: I84c37f4bffb51dbe05c0b8273c060851fd671659
2015-10-19 20:18:24 +02:00
34100b30c8
loplugin:defaultparams
...
Change-Id: I5f3b978823ec43519744f49739b9b4ee6ca1e1e9
2015-10-19 17:51:00 +02:00
4a1810b7d7
typo
...
Change-Id: Ifb4f8c039829ef326d81dd7a0e36b3b527451c21
2015-10-19 17:11:02 +02:00
6c39f7bba6
afl-eventtesting: pCursor is null
...
Change-Id: I24d29ffc3cfcb00e513a5267619e143b028355ce
2015-10-19 15:42:51 +01:00
4ec44fc1a8
afl-eventtesting: view is null
...
but docshell isn't and we're using the view apparently
to get the shell we already have
Change-Id: Ibc2021245191a75f65ec655a2d1929601a2611b5
2015-10-19 15:42:51 +01:00
cbe2b9cb69
afl-eventtesting: deref of null GetMainViewShell
...
Change-Id: Ie6863f446aa688bc1bb3f725ee31e9984dadc7a4
2015-10-19 15:42:50 +01:00
c8479bdc5b
convert DBG_ASSERTWARNING to SAL_WARN_IF
...
I know the comment in debug.hxx said to use SAL_INFO, but SAL_WARN makes
much more sense.
Change-Id: I3d81f9db89ef8cebe1e4f2983941d69b4c7e6b7d
2015-10-19 13:08:29 +02:00
39e63bfac5
convert remaing DBG_WARNING to SAL_INFO
...
and drop the macro
Change-Id: I452ca373d0c277166e94928c1bce78bf37e39d7c
2015-10-19 13:08:29 +02:00
367105e024
cleanup some local var declarations
...
found with
git grep -nP '(\w+)\s+=\s+\g1\(' | lots-of-hand-filtering
Change-Id: I598b0cfa6607823eaef09d95e610e05145c727f7
2015-10-19 13:08:29 +02:00
3ec7983495
loplugin:defaultparams
...
Change-Id: Ifb59fc408bdbbe7edcb78f1c48dc462422f21a71
2015-10-19 11:54:18 +02:00
bc437f3ba9
loplugin:defaultparams
...
Change-Id: Ia27922e630373d0520f25d259bb06aa25407089c
2015-10-19 11:43:40 +02:00
47d3575b86
loplugin:defaultparams
...
Change-Id: I8182e45dedfa70b41166b1d5fe5e152ae4b8c8ff
2015-10-19 11:37:49 +02:00
ac2c2c0688
loplugin:defaultparams
...
Change-Id: I6c032633eb36402aa9050587bedf9530d7e0ba71
2015-10-19 11:32:15 +02:00
1ff755309e
convert Link<> to typed
...
Change-Id: I178acd3bd0e16a6b6c84162269a3771d6b898b25
2015-10-19 09:05:56 +02:00
2d64fcf4c8
cppcheck:nullPointerRedundantCheck
...
Change-Id: I00a58a90f96e9eaf681239146213706e278ea5e1
Reviewed-on: https://gerrit.libreoffice.org/19421
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-19 06:48:51 +00:00
e08b49fa66
cppcheck: noExplicitConstructor
...
Change-Id: I187273e39759b3a3ef45b047f8cc36829a7f0b10
2015-10-18 21:23:15 +01:00
adeefc6295
sfx items: Kill the unreadable & misplaced SFX_ITEMSET_ARG too.
...
Change-Id: I1e0f96dce2b9cf9da32f4f577cf76e1d8824d37a
2015-10-16 12:12:28 +02:00
e5be07f516
sfx items: Kill the unreadable SFX_REQUEST_ARG, use a template param instead.
...
Change-Id: I7130f7a84077a63cdc0ca1e131a4d90469eac90d
2015-10-16 12:12:27 +02:00
427c5dc6e0
sfx items: The bDeep parameter of SFX_REQUEST_ARG is always false.
...
Change-Id: I6d4f4cd09c83f94b26dd90577bdc6bc3226f58ab
2015-10-16 12:12:27 +02:00
67fe420703
sfx items: The bDeep parameter of SFX_ITEMSET_ARG is always false.
...
Change-Id: Ifdffc82c9b4ec2e534204294575a78e34e0338c1
2015-10-16 12:12:26 +02:00
186f32f634
sd tiled rendering: emit CALLBACK_TEXT_SELECTION on multiple search results
...
Change-Id: Ib6be973bf7c911907c793571b84021dc317dcc80
2015-10-16 11:25:50 +02:00
6f1313b3d4
convert Link<> to typed
...
Change-Id: Icbba339dac0be31e30dff021bba06a219f8aecd6
Reviewed-on: https://gerrit.libreoffice.org/19405
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-16 09:11:29 +00:00
6a35a75a6b
sd tiled rendering: implement CALLBACK_SET_PART for find-all
...
Change-Id: I607b3719e0f508f9ae24db7482323847aa8e2491
2015-10-15 16:56:14 +02:00
cd4976988c
sd tiled rendering: let find-all at least select the first match physically
...
The LOK API can describe a multi-selection, so find-all can signal all
matches, editeng can have a single selection only. Instead of having no
selections after a find-all, select the first match, so e.g. copy works.
Change-Id: I0eab2565916f0c3cce5d77279c0d927ad4b7054c
2015-10-15 16:25:13 +02:00
aa8f218079
sd search: restore start selection if nothing was found
...
For one, if sd::Outliner::RememberStartPosition() cares about storing
the current selection in the DrawViewShell case in maStartSelection,
then sd::Outliner::RestoreStartPosition() should probably restore it.
For another, sd::Outliner::StartSearchAndReplace() returned true in the
"nothing was found" case, which restarted the spellchecking, which
killed the selection. If the selection has been restored already, then
at least don't kill it in the find case: find is read-only, so no need
to restart the spellchecker.
Change-Id: Idd886d449a9cfb164887fc6b1fde27b5e63e272b
2015-10-15 15:03:46 +02:00
0e8a40e8b8
calling IsSet() before Call() on Link<> is unnecessary
...
the Call() already does a check
Found with:
git grep -A 1 -w 'IsSet()'
| grep -B 1 '.Call('
| grep ':'
| cut -d ':' -f 1
Change-Id: Ia7248f5d62640b75f705e539c3d1183e39c0d847
2015-10-15 12:29:01 +02:00
99b21cc9f3
convert Link<> to typed
...
Change-Id: I6c55c74d47b13149c2fa210bb9de4e8c430c57cc
2015-10-15 09:58:34 +02:00
90992d512c
coverity#736798 Dereference before null check
...
Change-Id: I44402f7c644d60e2166956ca5f98955cc73e5bab
2015-10-14 15:02:43 +01:00
4920bbf768
coverity#736803 Dereference before null check
...
Change-Id: I0bdd28c1f43da999ae2bd35d45c1958061f90c07
2015-10-14 15:02:42 +01:00
84ca5c4c61
coverity#736804 Dereference before null check
...
Change-Id: If4b656ccea684fda64a3f93f5b6729c713be48b0
2015-10-14 15:02:42 +01:00
ad280b67f8
LOK: include part numbers in CALLBACK_SEARCH_RESULT_SELECTION payload
...
Without that, the result in Calc/Impress is ambiguous.
Change-Id: I8dfd8dafc996102ed583688fddd721c7600dc48c
2015-10-14 15:39:07 +02:00
dd1fc2242a
sd tiled rendering: search rectangle is part-specific
...
Change-Id: I88865db539779bc401550d7b4a3729b89d7e18b1
2015-10-14 15:39:02 +02:00
ea11587a75
tdf#95041 Fix more sidebar node names
...
Change-Id: I79e7755ecd6d4e1a331680337742629da52fed0c
2015-10-14 13:49:13 +02:00
64c8bf922d
tdf#95041 Fix sidebar node names
...
Change-Id: I3435de44e04268dc557faedba944c2c33385b89c
2015-10-14 12:42:25 +02:00
e7515cdae0
coverity#1326209 Dereference after null check
...
Change-Id: Ie8a10cb0f92758b45aff456f52331092e8a4e1df
2015-10-14 10:59:42 +01:00
32d573cdd1
sd tiled rendering: initial search all
...
Change-Id: Icee3a07103fad1bf70637fbf23299f50b7ad838d
2015-10-14 11:38:47 +02:00
ffbcf926cf
coverity#735838 Dereference after null check
...
Change-Id: I5a0a9cfdac0444beb049bf9e883ffced25500950
2015-10-13 22:38:36 +01:00
f353e7baaa
coverity#1326205 Unchecked dynamic_cast
...
Change-Id: I1fe77d041a281b14d6af15f25bd06ac78420c608
2015-10-13 22:38:35 +01:00
8d4088c23b
coverity#1326204 Unchecked dynamic_cast
...
Change-Id: I39c942e2ce35283761e3b8daa1ae41986a170ca8
2015-10-13 22:38:35 +01:00
5c90069d93
coverity#1326211 Unchecked dynamic_cast
...
Change-Id: I09892b8e17aacf32db51764d8fd766603a8542e1
2015-10-13 22:38:34 +01:00
395cfab057
sd tiled rendering: implement LOK_CALLBACK_SEARCH_RESULT_SELECTION
...
Given that sd doesn't support find-all yet, this works for normal find
only at the moment (so it may report multiple rectangles, but always a
single match).
Change-Id: I47bd0d0161b9d1dc843bb503f5521f311fc158c4
2015-10-13 16:42:41 +02:00
1631fa9a72
tdf#95002 sd tiled rendering: fix handling of images on page switch
...
It turns out a full invalidation is still needed to trigger the loading
of graphics on the new page, so instead of not invalidating just don't
emit the notification about it during page switch.
Change-Id: Ic99a3d4e268b3db61cf09c78ed0f310c9d365867
2015-10-13 10:47:00 +02:00
ed7361ef0b
cppcheck:variableScope
...
Change-Id: I7cbd5a9e9bb5417f754d4e2445df309140fd40af
Reviewed-on: https://gerrit.libreoffice.org/19329
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-13 06:22:33 +00:00
b36963c0a6
Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
...
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
bff4c13475
Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY code
...
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-12 17:52:26 +02:00
ca34367234
sd tiled rendering: make invalidation in DrawViewShell::SwitchPage() optional
...
In case of tiled rendering clients already get LOK_CALLBACK_SET_PART
when switching slides, so it's pointless to additionally invalidate
windows for help lines.
Change-Id: Ibc15c9862ae85bd72328161fa5f7e72d82fd2a97
2015-10-12 14:25:18 +02:00
3c99f8500f
convert Link<> to typed
...
Change-Id: Iec15042138e0715459b2c9e872a7464d75a6b1eb
Reviewed-on: https://gerrit.libreoffice.org/19305
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-12 10:48:13 +00:00
