Commit Graph

1714 Commits

Author SHA1 Message Date
7e5bada554 slideshow: remove unecessary boost/bind includes
All of the remaining includes of boost/bind.hpp may be removed from
slideshow, as last remaining uses of boost::bind have been removed from
the module. There should be no side effects due to this change.

Change-Id: I4e1855545fad69d09e594d0be139c09aad561b2d
Reviewed-on: https://gerrit.libreoffice.org/19395
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-19 06:52:58 +00:00
90d82f73b8 loplugin:unreffun
Change-Id: If9ca3e2d88d1b0dee57531ed954ba4895fb37fe3
2015-10-15 08:48:45 +02:00
39c7826c81 tdf#93243 slideshow: boost::bind -> C++11 lambdas
Replace boost::bind with C++11 lambdas. In addition, replace the use of
FuncT::result_type in ListenerOperations::notifyAllListeners with a less
type specific means of determining the return type of the function to be
applied in order to allow for the use of C++11 lambdas.

Change-Id: I1035be976e542d8b5bbd451c473a896d91ed66ca
Reviewed-on: https://gerrit.libreoffice.org/19314
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-15 06:23:24 +00:00
4038b27a0b tdf#93243 slideshow: boost::bind -> C++11 lambdas
Replace boost::bind with C++11 lambdas

Change-Id: I37e769c88d997eaecf46c07e510cef6a30fbce8e
Reviewed-on: https://gerrit.libreoffice.org/19334
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-13 08:05:18 +00:00
ed7361ef0b cppcheck:variableScope
Change-Id: I7cbd5a9e9bb5417f754d4e2445df309140fd40af
Reviewed-on: https://gerrit.libreoffice.org/19329
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-13 06:22:33 +00:00
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
91e0161dc5 tdf#93243 slideshow: replace boost::bind
Replace boost::bind with C++11 lambdas

Change-Id: I13c500d085e6b8e80b2c067139db4ed0fffb2c71
Reviewed-on: https://gerrit.libreoffice.org/19299
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-11 06:15:35 +00:00
b629728085 Replace simple while loops with range-based for
Replace simple while loops with range-based for-loops when apropriate.
There should be no side effects due to this change.

Change-Id: I0c39d4c10c991354248e864a09333144974c953c
Reviewed-on: https://gerrit.libreoffice.org/19281
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-11 06:13:15 +00:00
6e8f1a3bd1 slideshow: replace for_each with range-based for
Replace ::std::for_each for a more readable range-based for loop in
cases in which the function object to be applied by for_each is more
readable as the body of a for loop.

Change-Id: I5798293cdd0d784cc4c95c67e3fc6a0b930db8bb
Reviewed-on: https://gerrit.libreoffice.org/19261
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-09 07:09:22 +00:00
862bd36439 tdf#94222: Revert "slideshow: replace for_each with range-based loop"
This reverts commit ead5bc3cfb07a4e96e367e7904dc674ee5f5ccd6.

Change-Id: Icc2778cf904a71c4deaff4575d0de231acfc1335
2015-10-08 15:35:47 +02:00
d68a0fc050 loplugin:unusedmethods
Change-Id: Ie1603adf3908fd0668bcbe8f75c6bafa0d0bfd6c
Reviewed-on: https://gerrit.libreoffice.org/19072
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-02 06:20:35 +00:00
f45ac62a20 Fix typos
Change-Id: I89ff6d31662824d83961d6457b82db8d8031168c
Reviewed-on: https://gerrit.libreoffice.org/18977
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-30 10:34:17 +00:00
c50eb68af3 Renamed wrongly prefixed boolean variables
Fixed tdf#94269

Change-Id: I63109cc4e095bad680d7637a065080ea368860ae
Reviewed-on: https://gerrit.libreoffice.org/18851
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-09-29 18:33:40 +00:00
4c657f5a1a Properly #if these debug hooks
...moved here with 6fbab2ce87372bd98275d8239cd782d0ca6375e8 "loplugin:unreffun";
this file still indirectly includes boost/scoped_ptr.hpp via. boost/spirit

Change-Id: Ib2f251420950395f58415c1f7c944b7e8fd61476
2015-09-21 12:07:42 +02:00
6fbab2ce87 loplugin:unreffun
Change-Id: I526b9e1cff25a30c3f6b935c1a11ef571f7a12ea
2015-09-21 10:31:39 +02:00
64144c28fe boost->std
Change-Id: I787ff19fd41d5ecee56efa1aa7ee539f46650703
Reviewed-on: https://gerrit.libreoffice.org/18703
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-21 08:11:17 +00:00
afce2eee1d slideshow: fix mysterious crash with the gtk3 vclplug
For some reason with gtk3 events are handled a bit differently, and in
particular after the PresenterSlideShowView::Resize() sets the
mbIsForcedPaintPending = true, with gtk2 we get a
notifySlideAnimationsEnded event and then a notifyViewChanged event that
calls PresenterSlideShowView::clear() to reset the flag,
but with gtk3 the flag isn't reset and then
PresenterSlideShowView::ForceRepaint() destroys the SlideView,
while there are still events in the EventQueue with pointers to it.

Since i'm evidently too dumb to tell what of this event handling is
working correctly and what is buggy, avoid the crash by checking
that the SlideView is still alive in the event handlers.

Change-Id: Ib88e61536c21e9787cef8a436341bfbd89914f4b
2015-09-16 22:13:42 +02:00
625d83e430 tdf#94006 - need an explicit dispose for slideshow's GLContext.
Fixes crasher exiting slideshow.

Change-Id: I14b6a2c1abc946f590bf91cab19099753172fd95
2015-09-16 03:12:16 +01:00
22b80ac8e2 boost->std
Change-Id: I3fd9e1599c5ad812879a58cf1dabbcd393105e1c
Reviewed-on: https://gerrit.libreoffice.org/18564
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-14 12:54:25 +00:00
35fd0cf311 cppcheck: noExplicitConstructor
Change-Id: I39194062ba68c4cb1ccc9b93c629f005ccd02497
2015-09-13 22:42:35 +01:00
c5e3cf0f17 tdf#94031 - slideshow: bind correct GL context for prepareEnvironment
Change-Id: Ib139e81f770531f7d808764dd3a77c7ac8d6fa3c
2015-09-11 17:43:07 +01:00
d39630bb68 OpenGL: use CHECK_GL_ERROR() only when a context is bound.
Change-Id: I2cdc14defe5c4bd95776206df65fd57589d40429
2015-09-08 21:56:15 +01:00
a37d3b1c5c OpenGL: use CHECK_GL_ERROR() only when a context is bound.
Removes a large number of spurious GL errors left & right.

Change-Id: I0b5639478812982b39d3b88be2600dad5d3f1fd0
2015-09-08 21:27:29 +01:00
56900a441d tdf#94006 - fix OpenGLContext mis-use in several places.
gltf rendering, OpenGL canvas, GL transitions & GL capable (charts)
Avoid GLX operations on un-initialized contexts.

Change-Id: I7f523640f66ab656896181e5c865879234f6640e
2015-09-08 13:04:02 +01:00
ca7bab0561 slideshow: tdf#88206 replace cppu::WeakImplHelper* etc.
with the variadic variants.

Change-Id: I3160235d0e6253626a8facbfed33e3c252505cbf
Reviewed-on: https://gerrit.libreoffice.org/18336
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-07 07:37:07 +00:00
6900bf41e2 o3tl/cow_wrapper: remove boost dependency
Remove boost dependencies from ::o3tl::cow_wrapper, and add
the necessary includes to files including checked_delete and
noncopyable that do not already include the necessary files.

Change-Id: Iedae4232002792724226829a5d5cf9d16ffd0686
Reviewed-on: https://gerrit.libreoffice.org/18125
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-29 22:51:36 +00:00
ead5bc3cfb slideshow: replace for_each with range-based loop
Replace ::std::for_each for a more readable range-based for loop in
cases in which the function object to be applied by for_each is more
readable as the body of a for loop.

Change-Id: Ib0b488b36ed58c65c56357e04391b85096d043aa
Reviewed-on: https://gerrit.libreoffice.org/17930
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-24 21:20:13 +00:00
7d769f9df5 loplugin: defaultparams
Change-Id: Ibf0ea539d2a95073a12f84964759d9c7a94baa7b
2015-08-20 13:52:17 +02:00
a811d6efe4 slideshow: replace for_each with range-based for
Replace ::std::for_each for a more readable range-based for loop in
cases in which the function object to be applied by for_each is more
readable as the body of a for loop. In addition, replace while loops
with range-based for loops when possible and complex implementations
of boost::bind with lambda expressions.

Change-Id: I6adfb18197bd1b8627719adfca2e4c36d58a0e05
Reviewed-on: https://gerrit.libreoffice.org/17786
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-17 16:22:31 +00:00
1e4b29e1ad Range-based for-loops.
Change-Id: I6fb0d182dfccb3af42f0bbc60969c72df09b6ce6
2015-08-12 06:48:43 +02:00
2c587f08ed slideshow: prefer value_type over manual type generation
Change-Id: I3e088a10e7bc0da73e4fa20db15e71581661fe4b
Reviewed-on: https://gerrit.libreoffice.org/17641
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-11 09:17:16 +00:00
ff265a5f9b loplugin:unreffun
Change-Id: I130b4f1eca4cf07f17aac995c4a44a8fdf51a4df
2015-08-11 11:15:50 +02:00
28564f96e8 loplugin:cstylecast
Change-Id: Ie44d7b031b16647457cf08dc944526c720360f9d
2015-08-11 09:30:00 +02:00
7151a2a9ca -Werror,-Winconsistent-missing-override
Change-Id: I3597b5d5cd54e6ff5398bdb5075b9fa03f9b5819
2015-08-11 09:25:53 +02:00
e5ec630414 stop inclduing canvas/verbosetraces.hxx and canvas/debug.hxx
also clean-up and 'standardize' the include sections of canvas' source code

Change-Id: Ib437a41ea41ae2ea6528f755ae5b2828775aaf73
Reviewed-on: https://gerrit.libreoffice.org/17633
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-11 03:57:18 +00:00
7bdc6be9c2 slideshow: stop (mis)-using VERBOSE
converted the use of internal 'verbose' level tracing to SAL_INFO/SAL_WARN

Change-Id: Iab89d9b5c75fe476c6516718f1cee3d01d196858
Reviewed-on: https://gerrit.libreoffice.org/17632
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-11 03:31:47 +00:00
8a7b4d5bb5 Explicit capture annotations
Change-Id: I7be1a36196a07a80a7b7173c3869621f5d707204
2015-08-08 15:16:34 +02:00
717b23ef27 tdf#92459 replace deprecated o3tl features
Replace deprecated features from the o3tl including select1st and
select2nd with lambda expressions.

Change-Id: I0cb1aedc3e193c52d25e2837a47d9d90c898079e
Reviewed-on: https://gerrit.libreoffice.org/17459
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-08 12:27:55 +00:00
6343754e31 cppcheck:noExplicitConstructor
Change-Id: I2717d3d120df8af5b7e9af8d147a57b9f5b5ecbe
2015-08-07 07:20:24 +02:00
e8f8c32581 slideshow: dumb this down to hopefully make non-GCC compilers happy
Change-Id: If08a4f0c177abf38a381dcb9ba73a09265b2bcb5
2015-08-03 17:45:42 +02:00
c05bf5e494 slideshow: convert generateEvent args from boost::bind
Change-Id: I85d240989e41a45b62a4631bb847daccd1919f34
2015-08-03 17:32:25 +02:00
38a4b5ea2a slideshow: try to fix libc++/MSVC build by replacing boost::bind
Change-Id: I6418119f9d3e70ea89f7c8a094bbde42eeadec8c
2015-08-03 17:20:26 +02:00
34d2a07a23 slideshow: replace boost::function with std::function
Change-Id: Ibcb0f40d327e3086b6493cf2052caf135aa89e10
2015-08-03 14:47:44 +02:00
5a7bf1b32c loplugin:unusedmethods slideshow
Change-Id: I66b6cddb638a9fc1228d3ea9df5d112300a00eb3
Reviewed-on: https://gerrit.libreoffice.org/17128
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-17 06:49:23 +00:00
7aa9f04538 do not include boost/utility.hpp
It just includes a bunch of other boost headers; mostly we need
boost/noncopyable.hpp so include that directly.

This eliminates 831 MB(!) of boost/preprocessor/seq/fold_left.hpp
completely, which is the 2nd biggest header after ustring.hxx.

Change-Id: I3df55770adcb46e56f389af828e8ba80da2dc1f2
2015-07-10 23:25:22 +02:00
0b7d51df3b Fix typos
Change-Id: Ic6415423f46aaee7ba90239a617c318cf92ae222
Reviewed-on: https://gerrit.libreoffice.org/16711
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-07-04 10:21:01 +00:00
2a65bf32ec Revert "Typo: iff->if"
This reverts commit cf92da3d6e1de14756efe3f1ee79f393a2f3787d.

iff can mean "if and only if" so not a typo
2015-06-23 20:42:27 +02:00
cf92da3d6e Typo: iff->if
Change-Id: I3fc60856b5a56e71d70b55c89323be074bdec3b3
2015-06-23 20:30:11 +02:00
051bbb818f slideshow: [loplugin:unreffun]
Change-Id: I112e85d999a160b9b6393e924e981231d17f439d
2015-06-18 00:36:28 +02:00
0980095619 Replace boost::scoped_array<T> with std::unique_ptr<T[]>
This may reduce some degree of dependency on boost.
Done by running a script like:

git grep -l '#include  *.boost/scoped_array.hpp.' \
 | xargs sed -i -e 's@#include  *.boost/scoped_array.hpp.@#include <memory>@'
git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \
 | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/'

... and then killing duplicate or unnecessary includes,
while changing manually
m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx,
extensions/source/ole/unoconversionutilities.hxx, and
extensions/source/ole/oleobjw.cxx.

Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd
Reviewed-on: https://gerrit.libreoffice.org/16289
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-17 15:50:45 +00:00