e963a88912
formatting of public/private/protected section qualifiers
...
make it consistent across the codebase, no space between keyword
and the colon
Change-Id: Idca61ddfc74ad2460fb05fe417499324b05e5de5
Reviewed-on: https://gerrit.libreoffice.org/17148
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-17 09:49:35 +00:00
4bf8384d97
loplugin:simplifybool
...
Change-Id: I822967265cbe9f58641e2d9bd1260fd724df8ad1
2015-07-16 14:00:20 +02:00
18f3cefd50
warning C4101: unreferenced local variable
...
Change-Id: I3d2d46c7b722557f3dbfd95eb2b8649f8078d4df
2015-07-13 18:57:35 +02:00
67badfc9da
Code deliberately not linking against sal just can't use OSL_ENSURE
...
Change-Id: I20820ea382ac9933bf2c6118d466625120b49d67
2015-07-13 18:39:42 +02:00
cbce40e965
Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug builds
...
...to avoid lots of loplugin:staticmethods warnings. Also enables DBG_ASSERT
etc. also for --enable-debug builds in addition to --enable-dbgutil builds.
Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
2015-07-13 18:14:11 +02:00
e544f449ed
Fix typos
...
Change-Id: I020c7ce4d9aa93cb0292378a410cdb9f7788e920
Signed-off-by: Michael Stahl <mstahl@redhat.com >
2015-07-08 12:21:19 +02:00
04c0b70c9b
loplugin:unusedmethods sax,shell,stoc,basegfx
...
Change-Id: I8f3871fd4e82b6850718b6f2a8757f3043d00017
2015-07-06 10:10:02 +03:00
a6f5770b4a
Revert "loplugin:unusedmethods sax,shell,stoc,basegfx"
...
The basegfx changes appear to break Windows builds.
This reverts commit 3b32c5898ff4e744d3f18b00421b433500426d74.
2015-07-03 16:53:45 +02:00
3b32c5898f
loplugin:unusedmethods sax,shell,stoc,basegfx
...
Change-Id: Ia5d63f7153e4b02acc5e206739316264d6d1184e
2015-07-03 14:16:32 +02:00
2279f1f022
tdf#92269 fix Windows Explorer crash caused by shellextension
...
wcscpy_s is buffer size, not string length, so size must also account
for a terminating NULL
Change-Id: Ie69692e47c142f3b733b093d0b87fa4bb03db7b4
2015-07-01 12:34:46 +02:00
a023842a74
loplugin:stringconstant: handle OUString+=OUString(literal)
...
Change-Id: I4ba0f758304977825d44dd1e3c8f348a94546a38
2015-06-26 13:55:34 +02:00
ae150c6a54
Fix typos
...
Change-Id: Ibfa971952cd330ddf430e7e951c5c235d2ae6bd8
Reviewed-on: https://gerrit.libreoffice.org/16314
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2015-06-18 11:44:56 +00:00
4729774b24
remove unnecessary check for null when calling delete
...
Idea originally from caolan.
Found using the following command:
find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;'
Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-15 14:46:41 +02:00
dcf6abfcdf
cppcheck:unreadVariable
...
Change-Id: I03981ceba67280e8ed98a9add7f24b3bd958d522
2015-06-15 14:06:31 +02:00
1afb790a11
inline COMPHELPER_SERVICEDECL_ macro
...
it was not adding any value
Change-Id: I6a911aac81e883f9155ed0cf24bfb7904efb3f92
2015-06-15 09:46:14 +02:00
d8ba942b99
loplugin:cstylecast: deal with those that are (technically) const_cast
...
Change-Id: Id45e303225602e401a5c3b640185bf476c94a0bb
2015-06-02 11:28:05 +02:00
d5129a9dd6
new clang plugin: loopvartoosmall
...
Idea from bubli - look for loops where the index variable is of such
size that it cannot cover the range revealed by examining the length
part of the condition.
So far, I have only run the plugin up till the VCL module.
Also the plugin deliberately excludes anything more complicated than a
straightforward incrementing for loop.
Change-Id: Ifced18b01c03ea537c64168465ce0b8287a42015
2015-05-28 12:49:54 +02:00
2633a2a34e
boost::shared_ptr -> std::shared_ptr
...
Change-Id: Iff798bd2ae4fec97f0f1647ea33f6f6ff1f3b208
2015-05-18 12:16:32 +02:00
2527a4d5a7
Implement some more XModify methods
...
Change-Id: I1345d6a3d62f1e5c3353c5412024f6b47f824f7a
2015-05-13 16:45:09 +02:00
0bfc98e63b
loplugin:redundantcast: reinterpret_cast to void*
...
Change-Id: I947b49cfb15f0e7d6ddfaae386656c70e4bd48ba
2015-05-12 18:27:54 +02:00
d1ca0f4ed0
Bin some pointless comments and reduce some vertical whitespace
...
Bin pointless '// predeclarations' or '// forward declarations' comments. If
a programmer doesn't know what a forward declaration is, well, why read C++
source code?
Also bin some pointless '// end of namespace foo' comments after namespace
blocks just a handful of lines long, and some superfluous vertical whitespace.
Change-Id: I2a31c5d73d9b4de8825fb8eb9e7559dbd7303ef9
2015-04-30 06:14:12 +03:00
5eff55bfa8
Don't throw UnknownPropertyException for givenname/sn from KDE backends
...
Open TODO to actually obtain values for them, instead of returning an empty
css:🫘 :Optional representing "no value available."
Change-Id: Iceb286e9873216f7bc36bd88b09ac03bd3a2c895
2015-04-17 17:08:07 +02:00
71b809959b
remove unnecessary use of void in function declarations
...
ie.
void f(void);
becomes
void f();
I used the following command to make the changes:
git grep -lP '\(\s*void\s*\)' -- *.cxx \
| xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'
and ran it for both .cxx and .hxx files.
Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-15 11:47:12 +02:00
8840fd3226
tdf#82695 allow to build with system collada2gltf
...
Change-Id: I1179e20fd5fbdecd198633d5440621ed08a0465b
2015-04-13 16:43:35 +02:00
ee094bd46f
loplugin:staticmethods
...
Change-Id: If97f01a05294fa7efd59a8934c7b6f65cda5084a
2015-04-13 09:37:12 +02:00
65c3f29a96
Typo: wheter->whether
...
Change-Id: Iab5e7de499452924b4ac0d34cc604ee38395c813
2015-04-01 21:14:43 +02:00
1140d4c950
Reduce to static_cast any reinterpret_cast from void pointers
...
Change-Id: I443d86e9805dd994006d8bde6dabd72e14a2cff5
2015-03-31 13:16:31 +02:00
9e53fbd9a6
loplugin:cstylecast
...
Change-Id: I8bb20f4ce9c8cca3b70057cd8c4fb23819fa3b23
2015-03-29 22:26:59 +02:00
84676d50ca
Clean up C-style casts from pointers to void
...
Change-Id: Iaae87d77ea48207c3277e7107b339296f6a99772
2015-03-28 19:09:25 +01:00
09f83e1f40
Small fix for BSD.
...
Part of Code Review:
https://reviews.freebsd.org/D2055
Author: Don Lewis (truckman at FreeBSD)
(cherry picked from commit ecebe457c968bfd30a99a435210b0bdbb117faef)
2015-03-27 15:42:01 +00:00
b549220522
const_cast: convert some C-style casts and remove some redundant ones
...
Change-Id: I84b3843b32bbec6dfe5a9c627927b04122d50abd
2015-03-26 15:33:36 +01:00
25d3c618d8
Typo: formated->formatted
...
Change-Id: Iefd4d375a0dfb36732233852f906c6b85dccc2a5
2015-03-25 21:12:16 +01:00
3f6bfb4c0d
remove exit 0 at the end of a shell script
...
Change-Id: I6f9b6aa7abba6eadf4db93506bdd9a822afdf2fb
Reviewed-on: https://gerrit.libreoffice.org/14884
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-03-25 06:50:53 +00:00
c6dcd7b7f3
Fix various Windows-only XServiceInfo implementations
...
...to match what is recorded in the .component files
Change-Id: Ibc5bb0575f3869317e4d14614cf1dad0af728ddc
2015-03-24 18:08:39 +01:00
3099c70b11
Fix various XServiceInfo implementations
...
...to match what is recorded in the .component files
Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
2015-03-17 12:25:11 +01:00
6617505ee1
V512: we want the number of wide-chars here, not the number of bytes
...
Change-Id: I121cdfd586562b9ce298448f51d0b2e3b2a52c39
2015-03-11 17:14:13 +00:00
3aebfbc299
leak on short read
...
Change-Id: I5da7ec2992f9f0b20aa075ee33d0b882cdf91901
2015-03-11 14:08:36 +00:00
556373c41f
V668 no sense in testing the result of new against null
...
Change-Id: I4a33bd92fc8448638a4bfe1eab7e5041a4c5cc39
2015-03-11 09:58:36 +00:00
d22519f62b
V801: Decreased performance
...
Change-Id: Id8cd45d2844c121f63684734ab3546c24a1aab32
2015-03-09 22:04:31 +00:00
19bfe765a5
shell: warning C4996 function call with parameters that may be unsafe
...
Change-Id: Id70289b0c88dd203cac6301303fe7452088f60f9
2015-03-05 15:36:48 +01:00
32f95a3551
V813: Decreased performance
...
Change-Id: I8a7528366156b288dc422b09cff0d5a32cde3c91
2015-03-04 13:07:40 +00:00
ff8b9c4e59
unnecessary wstring -> char* -> wstring conversion
...
Change-Id: I21e6036a5156ed62f2c7bff6439c64d0178c96e4
2015-03-01 18:58:43 +01:00
ba233e87ef
remove unnecessary parenthesis in return statements
...
found with
$ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;'
Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-02-23 09:26:58 +02:00
f7db246129
Add kde4-open-url script
...
Adds a KDE4 specific URL processing script.
Change-Id: I0116fa95f076a5772e88c616e93de542fe4fe4e4
2015-02-16 21:30:32 +01:00
fe5644984a
loplugin:deletedspecial
...
Change-Id: I2a3d9deb9c71bb4dfe3ad9076d7202636001e0bb
2015-02-07 12:36:02 +01:00
7ce1e0e1ec
fdo#43368 Remove MapiLogon/Logoff calls so simplemail works with WLM
...
Signed-off-by: Michael Stahl <mstahl@redhat.com >
Conflicts:
shell/source/win32/simplemail/senddoc.cxx
Change-Id: I31cac063ffb4afbfde068558ebcf5f66ea34d1a8
2015-02-07 00:54:19 +01:00
fe480d8136
remove unused typedefs
...
found with some minor modifications to find/find-unused-defines.sh
Change-Id: I18cc479adedc7a0dada68a4aeef08300e62631dd
Reviewed-on: https://gerrit.libreoffice.org/14194
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-01-28 06:19:49 +00:00
ba68436e3f
Win SDK 8.1: apparently VersionHelpers.h needs to be included explicitly
...
http://ci.libreoffice.org/job/lo_gerrit_master/495/Gerrit=Gerrit,Platform=Windows/console
Change-Id: I0104d448906bd17857b3716856c544e632c1662c
2015-01-23 14:04:24 +01:00
dcfb17b805
Some more loplugin:cstylecast: shell
...
Change-Id: I8d9846dcfd8b0f686f7321a3e7b7b0d70428723d
2015-01-20 09:06:51 +01:00
4500afcc1b
try to fix GetVersionEx deprecation warnings from Windows SDK 8.1
...
Apparently GetVersionEx() is deprecated now, but the replacement header
"versionhelpers.h" does not exist in older SDKs (at least not in 8.0),
so try to determine the used SDK version by checking if the Windows 8.1
version constant _WIN32_WINNT_WINBLUE (0x0602) exists.
http://msdn.microsoft.com/en-us/library/windows/desktop/dn424972%28v=vs.85%29.aspx
Change-Id: Ia9224a8c76823ada7cb294a600046c6a0fc843ad
Reviewed-on: https://gerrit.libreoffice.org/14020
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2015-01-19 20:31:38 +00:00
