Commit Graph

122 Commits

Author SHA1 Message Date
3a68a7dcf4 Remove workarounds for no longer supported GCC 4.6
In bridges/source/cpp_uno/gcc3_macosx_x86-64/share.hxx, the #if also covered
Clang, which actually needs these declarations (for now; the right fix will
probably be to #include <cxxabi.h>).

Change-Id: I1eebd59e2371f3498d740ab78244927358c4f23f
2015-06-26 17:31:14 +02:00
6ff2d84ade Various #include <sal/log.hxx> fixups
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx>
(and don't make use of it themselves), but many other files happen to depend on
it.  Cleaned up some, but something like

  grep -FwL sal/log.hxx $(git grep -Elw \
    'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx)

shows lots more files that potentially need fixing before the include can be
removed from rtl/string.hxx and rtl/ustring.hxx.

Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
2015-04-22 09:57:47 +02:00
93b4ec39e2 loplugin:cstylecast, loplugin:redundantcast
Change-Id: If5d839b05c1babecc84b76d2bcdf47009d0f713c
2015-04-07 10:46:18 +02:00
fb088cdd8d Replace remaining getCppuType et al with cppu::UnoType
Change-Id: I37d1a939c1a98f77152ed90dfb201446101f3157
2015-04-01 08:35:33 +02:00
96f5b780f0 Use OUString::unacquired
found with

  git grep -E '\* *\<reinterpret_cast\>[^>]+\<OUString\>'

Change-Id: I9306d4ad8e3b1664f54cb7df86f2d79bfd3c6cb9
2015-03-31 17:45:27 +02:00
4a8d478ff2 loplugin:cstylecast (gcc3_linux_intel)
Change-Id: I89c3c2c63c1c1b7478d94c713341db1cd24f0ab8
2015-03-13 18:21:35 +01:00
c85e36bc85 loplugin:cstylecast,stringconstant
Change-Id: Iffc8cbf108310099318e37378c4b3033ea087cee
2015-01-08 14:19:29 +01:00
063a511583 Revert "Revert "boost::unordered_map->std::unordered_map""
This reverts commit 3976739f2378391fa09379c48844daf0e2790f5b,
the problem mentioned there was caused by a different commit, and
has meanwhile been fixed.
2015-01-07 14:41:11 +01:00
3976739f23 Revert "boost::unordered_map->std::unordered_map"
as an experiment to see if that's somehow the cause of

NEXT    An uncaught exception of type com.sun.star.sdbc.SQLException
NEXT    - General error: java.lang.UnsatisfiedLinkError: com.sun.star.sdbcx.comp.hsqldb.StorageFileAccess.isStreamElement(Ljava/lang/String;Ljava/lang/String;)Z

NEXT    ##Failure Location unknown## : Error
        Test name: HSQLDBTest::testEmptyDBConnection
NEXT    An uncaught exception of type com.sun.star.sdbc.SQLException
NEXT    - General error: java.lang.UnsatisfiedLinkError: com.sun.star.sdbcx.comp.hsqldb.StorageFileAccess.isStreamElement(Ljava/lang/String;Ljava/lang/String;)Z

under clang

This reverts commit ce7f442bd0b600c0acc74d4757e894a2ba382c53.

Change-Id: Ieed0be5721953b9644e4be411173e0ea73f33ed8
2015-01-06 09:15:14 +00:00
ce7f442bd0 boost::unordered_map->std::unordered_map
Change-Id: I3a16703727f1a421e0ed18079e14219a4feeb8c8
2015-01-05 12:37:48 +00:00
1276076ac8 ibridges: convert all legacy osl/diagnose.h assertions in source/cppu_uno
Change-Id: I4e78fac76b6bb4923e3b680d910afe5bb9640c33
2014-11-21 17:32:26 +01:00
8b50d6b176 bridges: get at least the x86 bridge to build
Change-Id: Idd2f223e0c83e0a6a19e70bd677058b6899bf766
2014-11-17 12:50:00 +01:00
b3e5b5941f bridges, vcl: turns out there is sal/alloca.h; replace #ifdefery
Change-Id: I2eda8dab51e66af7856b55f2d5f297620e07ccdb
2014-11-17 11:06:51 +01:00
0371a63365 remove unnecessary 'using namespace rtl' declarations
It turns out that almost none of them were necessary.

Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-29 11:28:54 +00:00
67a9ae4dd8 Improve debug output
Change-Id: Iba0c35a5bc07ac7b67186c3eeae1a2c926a6bc69
2014-09-29 23:18:26 +02:00
9c9f0ea2c3 Include RTTI in generated vtables for ubsan's vptr-based checks
...though only on gcc3_linux_x86-64 for now.

Change-Id: Id90554425e78b38a5a97149f2a7d3ac04cbe0c9b
2014-08-07 18:21:19 +02:00
6526881a0c loplugin:unreffun
Change-Id: Ie5608777b0bee002437117709d2c96062a39ff55
2014-08-05 17:01:36 +02:00
dac4ca5f68 new loplugin: externalandnotdefined
Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.

Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
2014-07-11 14:12:25 +02:00
14ab8c3f1d bridges: remove SAL_THROW macro
Change-Id: I2daafd711aedab17b6c13fde95c8af5f49d38a7c
2014-06-05 08:17:49 +02:00
ebc0a15515 remove more unnecesary OUString constructor use
when throwing exceptions

Change-Id: I6edfb6b6745499f802b0e3c0e096a36fb7c32aac
2014-05-29 09:01:40 +02:00
e7bc3cab01 remove boilerplate in UNO Exception constructor calls
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.

Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-23 15:06:00 +02:00
6660b9d2c5 Remove visual noise from bridges
Change-Id: I53fa23d335ff62795f09f9838d4064cea71aeb65
Reviewed-on: https://gerrit.libreoffice.org/8237
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-01 05:21:45 -06:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
9dc337e9d0 Adapt gcc3_linux_intel to Clang 3.4
...same as 5ba3d1740b03efa394b2d2bf34fb8a8d3db2331d "Clean up declaration of
__cxa_get_globals" plus c17f01753ce94e9f57d6e4a2763152240fbcd50a "...and
similarly for __cxa_allocate_exception and __cxa_throw."

Change-Id: I02361cfca260577ce13fb634b5637938daf0283d
2014-02-14 15:04:50 +01:00
82625bb98e remove unnecessary sal_Unicode casts in OUStringBuffer::append calls
Convert code like:
    buf.append( static_cast<sal_Unicode>('!') );
to:
    buf.append( '!' );

Change-Id: Iacb03a61de65a895540940953b49620677b3d051
2014-01-07 09:43:37 +02:00
e31a3abfc7 WaE: -Wunused-variable
Change-Id: I31bdce7f31185faebaf8a8a2162669b185def0c9
2013-10-05 01:47:20 +02:00
e036d4b706 Spell "indices" correctly
Change-Id: I63b1de195bf2f3f8bfd185181f48b1520cdd849f
2013-10-02 21:57:42 +03:00
6b83934749 fix gcc inline assembler operands usage
Apparently whoever did these didn't get the gcc docs and specified
every operand only as input, and then added volatile, explicit
initialization and what not until it worked. Specify output operands
correctly instead.
I couldn't verify all assembler variants, as I don't know them,
but the ones I don't know had at least some proper usage of output
operands, so I'll assume those are all correct.

Change-Id: I2910308b5e00cce8db756496df50ed26cfe35bb6
2013-06-05 16:01:43 +02:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
7dac241ca0 Remove RTL_CONSTASCII_(U)STRINGPARAM in bridges
Change-Id: Id8777ee7f587846399e95cf3b1b37d669a76bae5
Reviewed-on: https://gerrit.libreoffice.org/3139
Reviewed-by: Christina Roßmanith <ChrRossmanith@web.de>
Tested-by: Christina Roßmanith <ChrRossmanith@web.de>
2013-04-02 20:25:44 +00:00
39d45390f4 removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarations
s/(OUString\s+[a-zA-Z_][A-Za-z0-9_]*\s*)\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/$1\($2\)/gms

Change-Id: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b
Reviewed-on: https://gerrit.libreoffice.org/2835
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 10:48:30 +00:00
8b27d78b4a automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings
Done with a perl regex:

s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms

Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 09:00:26 +00:00
17ff7b41d1 re-base on ALv2 code. Includes:
Patches contributed by: Armin Le Grand.
    #118558# Correcting OLE attributes of LO3.4 at load time by loading as OOo3.3, details see task.
    http://svn.apache.org/viewvc?view=revision&revision=1195906
    #118485# - Styles for OLEs are not saved.
    http://svn.apache.org/viewvc?view=revision&revision=1182166
    #118898# Adapted ImpGraphic::ImplGetBitmap to correctly convert metafiles
    http://svn.apache.org/viewvc?view=revision&revision=1293316
    #119337# Solves the wrong get/setPropertyValue calls in
    SvxShapeText (and thus in SvxOle2Shape)
    http://svn.apache.org/viewvc?view=revision&revision=1344156

    Patches contributed by Mathias Bauer (and others)
    gnumake4 work variously
    http://svn.apache.org/viewvc?view=revision&revision=1394707
    http://svn.apache.org/viewvc?view=revision&revision=1394326
    cws mba34issues01: #i117717#: remove wrong assertion
    http://svn.apache.org/viewvc?view=revision&revision=1172349

    Patch contributed by Herbert Duerr
    goodbye Registration and License dialogs, don't let the door hit you
    http://svn.apache.org/viewvc?view=revision&revision=1172613
    help gcc 4.6.0 on 32bit ubuntu 11.10"
    http://svn.apache.org/viewvc?view=revision&revision=1245357

    Do not add targets for junit tests when junit is disabled.
    Patch contributed by Andre Fischer
    http://svn.apache.org/viewvc?view=revision&revision=1241508

Revert "sb140: #i117082# avoid unncessary static class data members
    commit 21d97438e2944861e26e4984195f959a0cce1e41.
remove obsolete FreeBSD visibility special case.
retain consolidated BSD bridge code, remove OS/2 pieces.
2012-11-15 16:06:08 +00:00
10511acd08 Revert "sb140: #i117295# use rtl::Static"
This reverts commit d3794d2d8ab2ee3f8118d61538bb753335b37f23.

Conflicts:
	bridges/source/cpp_uno/cc50_solaris_intel/except.cxx
	bridges/source/cpp_uno/cc50_solaris_sparc/except.cxx
	bridges/source/cpp_uno/gcc3_ios_arm/except.cxx
	bridges/source/cpp_uno/gcc3_linux_arm/except.cxx
	bridges/source/cpp_uno/gcc3_linux_x86-64/except.cxx
2012-11-15 16:06:07 +00:00
e9a09f9e4a dummy_can_throw_anything reportedly needed at least with GCC 4.5.1, too
...see
<http://lists.freedesktop.org/archives/libreoffice/2012-October/039995.html>
"RuntimeException while building"

Change-Id: I038806d4ca1d7a2a2518106ba722509fbe3a7843
2012-10-22 13:42:54 +02:00
dccddcc20b make gcc-uno bridge work with both gcc-4.7 and clang
It seems b0515ea5fa6c29faebed616ae3e0213c72d24904 and e2b7e28c12bb836fd7ab1dcbfc2460f807dd27f6
conflict, clang requires the extra call, gcc-4.7 crashes with it.
2012-09-26 16:55:37 +02:00
61c0a3a63d switch bridges to gbuild
Change-Id: Ia19ff61f1f7fb446298472acd6722b57ddaeddec
2012-09-22 08:15:30 +02:00
d3c4d9a0f8 android: x86 porting work. 2012-07-20 16:40:21 +01:00
bdc909b07d re-base on ALv2 code. 2012-06-19 18:00:37 +01:00
e2b7e28c12 adjust gcc3_linux_intel bridge to work with clang
Otherwise exception throwing seems to be broken.
This is a partial revert of b0515ea5fa6c29faebed616ae3e0213c72d24904.
2012-04-04 21:41:49 +02:00
932f5a4b1f Fixed include guard copy/paste error 2012-04-04 15:03:37 +02:00
b0515ea5fa Adapt cpp_uno/gcc3_linux_intel to GCC 4.7
...the same way cpp_uno/gcc3_linux_x86-64 was already adapted.
2012-04-04 13:02:44 +02:00
0439af27e1 Code cleanup: ( () ) replaced by (()) 2012-01-26 17:41:07 +00:00
4dc45a2854 remove include of pch header in bridge 2011-11-27 12:56:37 -06:00
e748b09663 Mark ecx register as clobbered
The inline assembly code executes a function call and functions are
free to use eax, ecx and edx without preservation. We must thus mark
ecx as a clobber register.
2011-10-17 08:13:54 +02:00
60ad74a87c sb140: #i117295# removed obsolete LEAK_STATIC_DATA defines 2011-09-12 22:47:47 +02:00
d3794d2d8a sb140: #i117295# use rtl::Static 2011-09-09 17:46:39 +02:00
5b759fd175 YES->TRUE 2011-08-04 17:05:22 +01:00
f8069fc858 Fix segmentation fault when linking -mavx on new CPUs is enabled by explicitly adding -mno-avx to CXXFLAGS. 2011-08-04 16:56:38 +01:00
e6c3cc8ade Revert adding -mno-avx to CXXFLAGS, not universally supported
This reverts commit bf85809783ba11c9018c03f5a26508fa856ff3f8.
2011-08-03 12:25:35 +01:00