Commit Graph

477 Commits

Author SHA1 Message Date
ce343470c3 Fix typos
Change-Id: Iaff7e38dd5beac48e1643e369e4240aa736c35ea
Reviewed-on: https://gerrit.libreoffice.org/18941
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-30 06:00:18 +00:00
5e86f24392 uno bridge: Prevent collision between cli::array and std::array
Change-Id: I23b0c0c6ec58dc2ff9ca266dd7f5ba00d1f8efab
Reviewed-on: https://gerrit.libreoffice.org/18519
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2015-09-13 05:35:12 +00:00
fd27553f38 climaker: Fix std::array and cli::array collision
Change-Id: I7b4815b4b7e8f016ce7a9047c77a6dde46b1ee0a
Reviewed-on: https://gerrit.libreoffice.org/18320
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2015-09-03 21:26:13 +00:00
cbce40e965 Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug builds
...to avoid lots of loplugin:staticmethods warnings.  Also enables DBG_ASSERT
etc. also for --enable-debug builds in addition to --enable-dbgutil builds.

Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
2015-07-13 18:14:11 +02:00
ffa8892c5a Fix typos
Change-Id: I75b4ad61785bf0ba1cb07735d938c0977356b8cc
Reviewed-on: https://gerrit.libreoffice.org/16705
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-07-04 10:23:17 +00:00
c3c45ff7ef Fix typos
Change-Id: Id05ea8cf8aed878bedfe73c274df3c67b64bad37
Reviewed-on: https://gerrit.libreoffice.org/16263
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-15 06:53:19 +00:00
5b1337f7b2 tdf#62475: partial handmade fixes
Change-Id: Ib9af202c43b916b9af4b4e18db35d470a8692fe4
Reviewed-on: https://gerrit.libreoffice.org/15712
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-05-15 17:55:15 +00:00
2fc4a8c811 Add support for cppu::UnoType<void>
Change-Id: I88259ffaffc73979c240721d2db166c79d3085f1
2015-04-01 12:48:44 +02:00
916f88f085 Replace remaining getCppuType et al with cppu::UnoType
Change-Id: Iadbbc005ee8bdbf3f33fd291deef376c8adab806
2015-04-01 08:35:48 +02:00
50b02731ca Replace scary reinterpret_casts with OUString::unacquired
...and actually fix some of them

Change-Id: I3493ceb65f305466d167304bd77058adb042067c
2015-03-30 12:55:22 +02:00
f863d2602f fdo#57950 Replace chained append() with operator+
Replaced all in cli_ure

Change-Id: I144542f386fe26444c290edd9e23b26cb07941a6
Reviewed-on: https://gerrit.libreoffice.org/15040
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-03-30 09:55:37 +00:00
b33788cb6b Typos
Change-Id: I665a56fcad10e136e949a10497f6ab8813af9968
2015-03-25 21:19:59 +01:00
a251fe4d48 We require MSVC2013 (_MSC_VER == 1800) now
Change-Id: Ice8504041f22e00f2e5010813d9dff1d2987c8d6
2015-03-19 10:57:17 +02:00
fe3feff8bb cli_ure: PVS-Studio V618 non-const format string
Change-Id: I54834111ce8aac91f2a6605473bef5eeaa4fb171
2015-03-12 11:28:26 +01:00
aec4088cd3 Typo: increse->increase
Change-Id: I4942a9ef4d3805865896c83cd9efa66437857ba1
2015-02-24 23:45:22 +01:00
60a64d1807 climaker: Fix handling incomplete types
The order in which the hash table of incomplete structure types is
iterated is non-deterministic. Make sure that the array fields are
complete types before they are assigned.

This fixed weird error on Windows 64 bit. The reason this bug wasn't
hitting on 32 bit Windows build is because the generation order was
different and by chance the referenced fields were already generated.

Change-Id: Ifc8622b420fc25fea5a0ac8c09d08f7804c9b77c
Reviewed-on: https://gerrit.libreoffice.org/13851
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2015-02-03 17:03:28 +00:00
df46ec0580 osl_getCommandArg always returns osl_Process_E_None
Change-Id: I0ff1e44f17976fd3a3060d8ee7fe15d77c918b79
2014-12-12 09:29:05 +01:00
54cbb57d4c fdo#39440 reduce scope of local variables
This addresses some cppcheck warnings.

Change-Id: Ib35eb591534c3f23adc3cb7b7fa9696dc5cbeabf
Reviewed-on: https://gerrit.libreoffice.org/13383
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-12-09 03:24:35 +00:00
827430c8c0 Fold URE: Windows
...assuming the delayLoadHook in cli_ure/source/native/native_bootstrap.cxx is
no longer necessary and loading of cppuhelper from the program dir cannot fail
regardless in whatever scenario the cli_cppuhelper library itself is loaded.

Change-Id: I13f32b327bca4cce9780864f5e57cdad3860afe5
2014-12-03 15:19:55 +01:00
0063cf2856 java: make fields final where possible
found by PMD

Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-18 12:44:28 +02:00
6a0fe37dec sal: clean up public headers with include-what-you-use
Sadly cannot forward declare "struct {...} TimeValue;".

rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...

Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17 11:06:53 +01:00
da40cac540 Fix common typos. No automatic tools. Handmade…
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12 11:04:11 +00:00
0371a63365 remove unnecessary 'using namespace rtl' declarations
It turns out that almost none of them were necessary.

Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-29 11:28:54 +00:00
04740cb7e2 cli_ure (Windows): std::auto_ptr -> std::unique_ptr
Change-Id: Ibe794daffa347d194ff8c66a44c7eec4bcc9b83d
2014-10-02 15:20:26 +02:00
25df8adbc0 cli_ure: adapt destructors in cli_uno library to "C++/CLI"
commit 4b56d82c7d20ba5897d87aaf7fc94da5356b8eec converted the cli_uno
library from "Managed C++" to "C++/CLI", but forgot one detail:

The destructors on "ref" classes were mapped to Finalize() methods in
the old syntax, but the new one maps them to Dispose() methods, which
are only invoked on stack-allocated objects.  Presumably this omission
results in leaking of native C++ UNO objects.

Reading the C++/CLI documentation i get the impression that:
1) the destructor should explicitly call the finalizer
2) the CLR will not call the finalizer itself iff the destructor is
   invoked

http://msdn.microsoft.com/en-us/library/ms235315.aspx
http://msdn.microsoft.com/en-us/library/ke3a209d%28v=vs.110%29.aspx

Change-Id: I509d9b69a399c3d7d6597060ab9b7c78c5916e11
Reviewed-on: https://gerrit.libreoffice.org/11132
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-08-27 05:06:32 -05:00
5f15f18859 warning C4189: local variable is initialized but not referenced
Change-Id: Ic8a76a9ab73a3466fe155e2ca8eecedeb6e810c9
2014-08-13 10:10:49 +02:00
da677dfd59 java: reduce scope, make fields private
found by UCDetector

Change-Id: I7f97e15667159cf8ee776e8f32fdcdec8ec00ed6
2014-08-13 08:49:22 +02:00
0477e6c39b java: add @Override annotation to overriding methods
Change-Id: I086964c6f6ce52c60c52b6dbc445d3c21d22c80a
2014-08-12 09:41:28 +02:00
608ebc6f01 Remove redundant inclusions of header "cppuhelper/shlib.h"
Change-Id: Iab402035613a6cc96b7b4ebd2981a1fd0f8bed23
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-08-08 12:02:16 +02:00
d07539ea5e java: use an empty block rather than an empty statement
Change-Id: I05e60964521d6ec3694483816d91359fb12c8e4b
2014-08-08 09:48:18 +02:00
e7a474b29a java: remove unused variables
Change-Id: I1b04fbf4d4562ff8e74f6ccdb2fd989d79cc869b
2014-08-08 09:48:16 +02:00
9bac4d413e typo: more then -> more than
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
2014-08-01 23:40:12 +09:00
a0233e6e03 Typo: habe->have
Change-Id: Ic76a399fc4073fcb713bb566f3fbee2077e20e52
2014-06-29 13:15:52 +02:00
b19db6b21d Typo: apend->append
Change-Id: I062c95ca8d478ba6c241723dda25c1dc4d7bb852
2014-06-29 13:15:51 +02:00
0d2542d67a gbuild, cli_ure: Win32 make issues with back and forward slashes
It looks like what works is to give the source file names with
backslashes but everything else with forward slashes?

Change-Id: Iaf910ab5fc41984d1315a30b164a334d28344c16
2014-06-09 17:05:53 +02:00
637b0ef1b5 cli_ure: Win32 make quoting problem, use sed to work around
Change-Id: Ide8a3c574a1904e08921684453256d1d3c98fd78
2014-06-09 17:05:52 +02:00
0e507ae031 various: remove SAL_THROW macro
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-06-05 08:17:52 +02:00
e7bc3cab01 remove boilerplate in UNO Exception constructor calls
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.

Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-23 15:06:00 +02:00
d0322208bc Combine unoidl::loadProvider and unoidl::Manager::addProvider
Change-Id: I1240656cc2a4d713c838eb80fa90ce3485aad614
2014-05-23 13:44:03 +02:00
2bd7767d01 Resolves fdo#70681: fixincludeguards.pl: all that's left
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-15 12:50:46 +00:00
acc04202e8 use css prefix consistently
Change-Id: Ia2f827381ec768a7867918d61d7afb2f68457832
2014-05-12 19:52:28 +02:00
49dff05943 cli_ure: fix dbglevel=2 build on windows
Some blocks are completely unused.

According to http://msdn.microsoft.com/de-de/library/ms235298.aspx

rtl_uString * __pin * pp_sInterfaces = &_sInterfaces;

should be

pin_ptr<rtl_uString *> pp_sInterfaces = &_sInterfaces;

Change-Id: I039e94649d542fb5b51231b2e0df0a4dc1170c19
Reviewed-on: https://gerrit.libreoffice.org/9318
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-12 14:53:26 +00:00
4f9b21248f simplify ternary conditions "xxx ? yyy : false"
Look for code like:
   xxx ? yyy : false;
Which can be simplified to:
   xxx && yyy

Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-05-05 12:47:48 +02:00
11b81c1026 Fix memory leaks
Change-Id: Id67d5375bedc6e6c10082d9c5ee69d6e932be158
2014-04-29 10:14:12 +02:00
da1425650b add missing modelines to idl files
Change-Id: If52651c70ee659c83ef127da4fe5e266cfe7eec2
2014-04-24 11:58:14 +02:00
b8239ac2f9 typo: noone -> no one 2014-04-14 12:32:54 +02:00
f7dca81251 cli_ure: simplify deprecated XTypeProvider.getImplementationId
Change-Id: If6f975bdc3d554828ff1ad3adc656579eda92a42
2014-03-10 17:39:53 +01:00
1712e6c614 Remove visual noise from cli_ure
Change-Id: I1ddada46767b2840c663a0a077e1b723f9645b56
Reviewed-on: https://gerrit.libreoffice.org/8240
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-27 06:15:25 -06:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
bbe3bec949 Drop unused #include
Change-Id: Id05440ffb8eb9990d2d08f721d6914f3dbc86cab
2014-02-14 18:44:05 +09:00