Commit Graph

503 Commits

Author SHA1 Message Date
3f6da86e9f Fix typos
Change-Id: I13c3dc33722f139582f27412d5d336264d3d15a3
Reviewed-on: https://gerrit.libreoffice.org/18942
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-30 13:05:20 +00:00
33cddeea13 boost->std
Change-Id: Iff14f69c200217c5d868978e8ffc06962b99ac09
Reviewed-on: https://gerrit.libreoffice.org/18568
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-14 19:32:42 +00:00
0e13c94ad3 Get rid of connectivity's diagnose_ex.h
...that rather trivially wrapped some osl/diagnose.h functionality

Change-Id: I4105708488114a9c87aa415affb997a783241248
2015-09-09 07:54:05 +02:00
32b6f11132 warning: nonterminal usesless in grammar
...ever since its use got removed in 17e1d9f46d7957b7ec54943122ddd5fbace19ab8
"INTEGRATION: CWS oj4"

Change-Id: I6494e11bb162d4c4bb880a6c4f9ece01331975dd
2015-09-03 10:10:20 +02:00
d8bf4491b1 warning: nonterminal usesless in grammar
Change-Id: I97f3fb5cf62a68460157b2302a84d56a1417d376
2015-09-03 10:05:37 +02:00
7bff36d45d loplugin:stringconstant: OUStringBuffer: appendAscii -> append
Change-Id: I68b02ad101c4c2165b4618ed5d97cbffc2c43d2d
2015-08-31 08:04:12 +02:00
4712396b3b loplugin: defaultparams
Change-Id: I906912f29448bfc72e8139546aa09525c959867f
2015-08-11 09:48:17 +02:00
615f4b23c6 loplugin:staticmethods
Change-Id: I22af41840410ee78aee739e0dec49bb43cda874b
2015-06-08 13:48:11 +02:00
15feadfb84 Revert "loplugin:staticmethods"
This reverts commit 81d82b78a107f2e6c14d6fbdf0d97c8e6cc8b0bd.
2015-06-08 13:11:19 +02:00
81d82b78a1 loplugin:staticmethods
Change-Id: I22af41840410ee78aee739e0dec49bb43cda874b
2015-06-08 12:55:36 +02:00
6140ca9f1d loplugin:loopvartoosmall
Change-Id: Icb31e51575f7fffd36be73bbd87a3c5e56c3aa26
2015-05-29 08:48:41 +02:00
5b1337f7b2 tdf#62475: partial handmade fixes
Change-Id: Ib9af202c43b916b9af4b4e18db35d470a8692fe4
Reviewed-on: https://gerrit.libreoffice.org/15712
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-05-15 17:55:15 +00:00
6d5ae48427 loplugin:staticmethods
Change-Id: I200fdb2e193127f0c9e8cec4859845d3ec19cea0
2015-04-23 13:08:47 +02:00
a1a25f4c6c tdf#88710 Cleanup after removing dbtoolsclient
Removes "virtualdbtools" and its implementation under "simpledbt", which are
mostly wrappers around various dbtools functions and classes, previously aiding
the now removed dynamic loading logic.

Removes IDataAccessTools, IDataAccessTypeConversion and IDataAccessToolsFactory
interfaces and their accompanying implementations which are completely unused.

Removes IDataAccessCharSet (implemented by ODataAccessCharSet) and moves the
implementation into a function which replaces ODataAccessCharsetHelper.

Removes ISQLParseNode and ISQLParser and their implementation in
OSimpleParseNode and OSimpleSQLParser, which simply wrap around OSQLParseNode
and OSQLParser respectively. To avoid including "sqlbison.hxx" unnecessarily,
includes to "sqlbison.hxx" are now only used where needed.

Change-Id: Id882dfbf43514d84a1eaffc1f916d627830c8cd6
Reviewed-on: https://gerrit.libreoffice.org/15450
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
2015-04-22 07:25:17 +00:00
17e74bf1a0 Replace remaining getCppuType et al with cppu::UnoType
Change-Id: Id2361bd7b50f4724211661b024583b8a3445500b
2015-04-01 08:36:20 +02:00
d3d34a289b const_cast: convert some C-style casts and remove some redundant ones
Change-Id: If7e4e3cae1021529819e0b43ef334020ff8b7a43
2015-03-26 15:33:29 +01:00
6106d99a90 boost->std
Change-Id: Ifa87783f68b0fab98f8a0f7cd6ed867202b4532f
2015-02-18 20:43:16 +00:00
4d6a509efe convert all remaining BOOST_STATIC_ASSERT to static_assert
and we can include a few less headers

Change-Id: Id742849ff4c1c37a2b861aa3d6ab823f00ea87f8
2015-02-05 22:21:49 +00:00
37ebeabd4d BOOST_STATIC_ASSERT->static_assert and drop some includes
Change-Id: I74955a05bf13f7b33650d11c5cf4b1388382da2a
2015-02-05 20:40:42 +00:00
2d292a95c3 janitorial
Change-Id: Ifb0a277a27613ea1a771a8bb3b8c784b9eca4f2f
2015-01-28 18:29:31 +01:00
d613f6e00c Query Design: use correct name for columns that come from another query.
Change-Id: I25b4ccdc2f50ba89687e1f4c871f286251a28e21
2015-01-28 18:29:30 +01:00
ecf24f3032 connectivity: Use appropriate OUString functions on string constants
Change-Id: I9ca72364cd57fd2da0c6f5f704a3fe494c0a1df5
2014-12-18 14:12:24 +01:00
da40cac540 Fix common typos. No automatic tools. Handmade…
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12 11:04:11 +00:00
fc0d57b7af Revert "use the new OUString::fromUtf8 method"
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498,
not all places that use e.g. OStringToOUString to convert potential UTF-8
are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and
some places like e.g. in codemaker are happy with the best-effort effect
of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06 17:24:13 +01:00
05050cdb23 use the new OUString::fromUtf8 method
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-06 13:51:10 +02:00
705c48d32e fdo#38835 strip out OUString globals
they are largely unnecessary these days, since our OUString infrastructure
gained optimised handling for static char constants.

Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-05 08:44:19 +02:00
c70f1545e2 Removed duplicated includes
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6
Reviewed-on: https://gerrit.libreoffice.org/12160
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-31 16:18:30 +00:00
6cbdfedde1 coverity#1249674 Missing break in switch
Change-Id: I1e957afe1dc35571128fac4432b54e8ae35aa9ab
2014-10-27 14:34:20 +00:00
d803c5e996 coverity#1202804 Explicit null dereferenced
Change-Id: Iff1ada702f57fba9ba979bc158412b0321921672
2014-10-25 14:38:11 +01:00
ee12e843c6 fdo#84073: change ODBC/JDBC escapes to lowercase
Change-Id: I19ce3acb9575fbef8273bbd84cb4dc322e101ac8
2014-10-09 18:22:15 +02:00
86cd29772e remove HAVE_GCC_PRAGMA_DIAGNOSTIC_MODIFY check and macro
This has been supported by GCC and clang for a very long time.

Change-Id: I410a2b39004c932003f8cbefe935aedb109b1163
2014-10-02 20:00:17 +02:00
fc04f76336 fdo#82577: Handle Time
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.

Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-01 07:34:23 +00:00
25a092869c connectivity: typo
Change-Id: Ic4c8637500c13d097f5b26222d7d4005f2251d1a
2014-09-26 16:58:04 +02:00
325ce86b56 fix build & better name for ERROR_INVALID_TABLE
Change-Id: Ic7253575859766f18869159e4a8dd6b3d715850d
2014-09-26 16:27:53 +02:00
ac10225762 implement --with-system-odbc on windows
Change-Id: I1757b9ce74277b1c11533f41caeafaf9b88658ef
2014-09-26 15:37:27 +02:00
a62a046df3 fdo#55703 automagically use IS NULL fo 'null' in query design.
Change-Id: I31bcec74a786df016d994834e6146fb7a76e72cb
2014-09-04 15:39:38 +02:00
3dd12b4a5c fdo#82427 disambiguate "NOT LIKE 'foo'"
Change-Id: Iab383639ea73cc87c03f4f42433bc9ccfcd988ef
2014-08-18 22:23:57 +02:00
32551a546c fdo#81336 bison priority increase with bigger number
Change-Id: Ib99f08c52379fd9df90c30b61cc246ee53022506
Reviewed-on: https://gerrit.libreoffice.org/10401
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-07-19 07:45:30 +00:00
a517898052 remove unnecessary "const &" qualifier from T* parameters
e.g. convert code like
    foo(X * const & p)
to
    foo(X * p)
since the "const &" part of it adds nothing useful.

Change-Id: Icf5f2041517259e7b6e055b75ed1e0e77c547da5
2014-07-18 14:24:19 +02:00
4e549156ef WaE: enumeration values not handled in switch
The previous commit to this file removed the default: case, so add it back
(even if doing nothing now).

Change-Id: Idc02818a30216dda0d64fddf21188de5766672e2
2014-07-07 13:21:56 +03:00
0d78ad871e DBG_ASSERT->assert when followed by dereference
Change-Id: Ic1c999ffdc391ea01be5711721e7c9e63179473e
2014-07-07 10:48:25 +01:00
b5997b9354 JOINs are left-associative
Change-Id: I24fdd2ce9bb87cc52a7c84ec8cd300bc13b11461
2014-07-03 15:44:11 +02:00
8871a650b9 SAL_WARN->assert
immediately dereferenced

Change-Id: I96a657973c219facbaa64dd079dcaaaa3c1c4dd8
2014-07-02 10:46:48 +01:00
0de1e3a015 remove spurious com::sun::chaos
Apparently some time before inital CVS import a global
search-and-replace went horribly wrong and added spurious namespace
prefixes everywhere.

Change-Id: I4009bc3ab4b1d4c80412f75ad0e4628a382f99f0
2014-06-25 15:04:46 +02:00
75838570c3 loplugin:staticcall
Change-Id: I7f22aa5576ca3c62fa363971f4fa5992b7711563
2014-06-13 17:54:24 +02:00
231ae9c77c coverity#1158175 Missing break in switch, assuming its intentional
Change-Id: Ia0f1951f1e3edcd858a37ea091550feb2b9fd451
2014-06-05 13:35:54 +01:00
a2db194ea0 connectivity: fix includes
Change-Id: I5d5dc6871789865189c78fe9135e7f8bff829489
2014-06-04 21:18:39 +02:00
b09b5f8f7c Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part19
Change-Id: Iab50c52a132c90389992ef68c2d31df95a193ab9
2014-05-22 23:21:18 +02:00
7339ab25ee fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFO
this is a continuation of the above bug, removing SAL_INFO's
that only mark function entry.

Change-Id: Idb0f72481415594e3f8b7a11ad6e4b8835f6fca0
Reviewed-on: https://gerrit.libreoffice.org/9343
Tested-by: Thomas Arnhold <thomas@arnhold.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-13 18:04:58 +00:00
199d333f13 connectivity: sal_Bool->bool
Change-Id: I96371121ce6697f153f4e973e65831ea2265eb56
2014-04-16 11:51:51 +02:00