Commit Graph

6150 Commits

Author SHA1 Message Date
a0649f316e Fix typos
Change-Id: Id94c03249b2752e88499628b3ad12936b361bb2f
Reviewed-on: https://gerrit.libreoffice.org/18950
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Oliver Specht <oliver.specht@cib.de>
2015-10-01 11:26:35 +00:00
58aea3f36c loplugin:unusedmethods
- improvements to the plugin to find more method calls
- improvements to python script to remove more false+
- fix the FORCE_COMPILE_ALL build flag to include code in
  the $WORKDIR

Change-Id: I4d6015dcb9b9d60c26f0bcee8abad807177a7836
Reviewed-on: https://gerrit.libreoffice.org/19064
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-01 10:43:24 +00:00
a18fc918d5 Fix typos
Change-Id: I051caee9ec6181074201ac4a8cb6fcec4fdf2293
Reviewed-on: https://gerrit.libreoffice.org/18951
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Oliver Specht <oliver.specht@cib.de>
2015-09-30 13:50:06 +00:00
a50539e2aa Fix typos
Change-Id: Iab78219aff60a7a45a319a96f326e27a6e8e25b8
Reviewed-on: https://gerrit.libreoffice.org/18953
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Oliver Specht <oliver.specht@cib.de>
2015-09-30 12:41:09 +00:00
eab0904f0e Fix typos
Change-Id: I81f6f356c1a6873fcc9a3bde487127b673fa9a61
Reviewed-on: https://gerrit.libreoffice.org/18952
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Oliver Specht <oliver.specht@cib.de>
2015-09-30 12:39:01 +00:00
ac9671f948 tdf#94559: second step to remove rtti.hxx
replaced use of PTR_CAST, IS_TYPE, ISA in
    chart2, connectivity, editeng, extensions, filter, forms, framework, idl

Change-Id: I6a2f9d8bbccb07088413f7552af4b5af8f0cad99
Reviewed-on: https://gerrit.libreoffice.org/18920
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-09-30 06:07:57 +00:00
c50eb68af3 Renamed wrongly prefixed boolean variables
Fixed tdf#94269

Change-Id: I63109cc4e095bad680d7637a065080ea368860ae
Reviewed-on: https://gerrit.libreoffice.org/18851
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-09-29 18:33:40 +00:00
34180700b2 loplugin:removeunusedmethods, remove unused stuff
Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350
2015-09-29 15:08:43 +02:00
e124cd5213 XFrame parameter to SetMenuBar() is actually never used.
Change-Id: I9413f575c0964d6cbf8a32d0b85c9f2c686bb8fc
2015-09-29 11:23:37 +02:00
cc5843daeb framework: remove obsolete Linux libc5 support
Change-Id: I42f7f961615f61002d6c0cce5b7eb44447ba5a64
2015-09-28 15:10:06 +02:00
c6726bdbd2 make gnumeric xml a real LibreOffice filter format
Change-Id: I502f4610718b5c1914a54346c46d4f998c4d370f
2015-09-27 07:38:47 +02:00
6d8124e30c convert Link<> to typed
and remove unused UserEvent class

Change-Id: Ic61c5eef75c36393dbbaa92d93163eab89021ee3
2015-09-22 20:21:55 +02:00
599fab44ad hide ScopedPtr::reset and add disposeAndClear
Change-Id: I55d6e789abd408b8478a2b9ae141d8899af2c309
Reviewed-on: https://gerrit.libreoffice.org/18745
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-21 19:34:16 +00:00
1e67e94f1a convert Link<> to typed
Change-Id: If3e2b00092440ebd42ae5b73ae2b0e44c3702683
2015-09-21 08:03:52 +02:00
1a83f30ebe sw: implement per-view LOK_CALLBACK_TEXT_SELECTION
Also:

- let the unit test set the global LOK flag, as sw code now depends on
  that
- in framework, don't return early after emitting the LOK status
  indicator callback, otherwise CppunitTest_sw_tiledrendering shows how
  sw LOK callbacks are missing

Change-Id: I0c4ac12f2ef5118d29afd131676bcb27d5db7746
2015-09-21 07:30:27 +02:00
99bfc363a6 convert Link<> to typed
Change-Id: I10b050dc4aae45e646761a82520caa96969bc511
Reviewed-on: https://gerrit.libreoffice.org/18700
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-20 06:37:36 +00:00
b1326ecbb7 tdf#76197 Make OfficeMenuBar work again in the start center
Regression of 46666a7720e18238b926531a7082dbb8bc524889.
The code in MenuBarManager::FillMenuManager merges the
addon menu before .uno:WindowList, which doesn't exist
in the start center since that commit.

As a last resort, let's also check for .uno:HelpMenu
(assuming that it's never placed before the Window menu).

Change-Id: If45eebe4351c40d8ed69daba527844ffc02e8458
2015-09-20 08:50:05 +03:00
3a00aaef2a boost->std
Change-Id: Ie490bf2c6921f393bdeed96b1a8815996b701bf0
Reviewed-on: https://gerrit.libreoffice.org/18670
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-18 07:59:14 +00:00
4890dd0c44 tdf#94198 Printer missing from tooltip
Need to update the tooltip also on state change.
This partially reverts the fix for tdf#83558, 1fb8724f9834dbc07b741eeed31b31347bc0c2a1
Verified that the fix for tdf#83558 still works.

Change-Id: I023a5e4b101dc91522f19b0d3ed2ed0c4a47e64b
2015-09-15 11:51:17 +02:00
98236528da convert Link<> to typed
Change-Id: I5c4021c9cb3fdeace7f7d99d580dc7fe2f7c354a
2015-09-15 09:37:32 +02:00
e0714ae393 convert Link<> to typed
Change-Id: I8f3e401afa27778678788b4ac90ea927a2fed1d7
2015-09-15 09:37:31 +02:00
9a1e22daae Replace snwprintf with _snwprintf
Change-Id: Ieb7009f6fbbd7ac6a3532cfa7b71eb0c1339d1ef
Reviewed-on: https://gerrit.libreoffice.org/18524
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2015-09-13 05:36:14 +00:00
0cfd6e73c8 Advertise GL rendering in frame titles in dbgutil mode.
Change-Id: I1883d137eb65a030c58e1e4ec11df3e63800339b
Reviewed-on: https://gerrit.libreoffice.org/18512
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2015-09-12 17:35:22 +00:00
03be785efe framework: yet another WeakImplHelper<XPropertySetInfo> dupcliate
There's a very similar comphelper::PropertySetInfo, unfortunately with
an additional mnMemberId on its properties, so convert a little...

Change-Id: I2a5fc0bb0ff6d680d546192b9d09afee6348f218
2015-09-11 22:31:53 +02:00
bf237ceccc valgrind: silence worrying invalid pthread lock/unlock warnings on exit
Invalid read of size 4
   at 0x57F48E0: __pthread_mutex_unlock_full (in /usr/lib64/libpthread-2.21.so)
   by 0x4E903F7: osl_releaseMutex (mutex.cxx:136)
   by 0xB3EECF0: osl::Mutex::release() (mutex.hxx:74)
   by 0xB3EF92C: osl::Guard<osl::Mutex>::~Guard() (mutex.hxx:135)
   by 0xB3F755A: SvtCommandOptions::~SvtCommandOptions() (cmdoptions.cxx:318)
   by 0xB3F75B3: SvtCommandOptions::~SvtCommandOptions() (cmdoptions.cxx:328)
   by 0x2B13BDE9: std::default_delete<SvtCommandOptions>::operator()(SvtCommandOptions*) const (unique_ptr.h:76)
   by 0x2B13A3C6: std::unique_ptr<SvtCommandOptions, std::default_delete<SvtCommandOptions> >::~unique_ptr() (unique_ptr.h:236)
   by 0x2B134063: framework::Desktop::~Desktop() (desktop.cxx:183)
   by 0x2B13418B: framework::Desktop::~Desktop() (desktop.cxx:187)
   by 0x79892AD: cppu::OWeakObject::release() (weak.cxx:205)
   by 0x2B1399B7: framework::Desktop::release() (desktop.hxx:133)
   by 0x2B13B860: rtl::Reference<framework::Desktop>::~Reference() (ref.hxx:81)
   by 0x2B13956B: (anonymous namespace)::Instance::~Instance() (desktop.cxx:1780)
   by 0x54635D7: __run_exit_handlers (in /usr/lib64/libc-2.21.so)
   by 0x5463624: exit (in /usr/lib64/libc-2.21.so)

Change-Id: I98e0e70567ab39a06813fd9b614ba1e04ec22bd1
2015-09-11 10:12:21 +01:00
9af27324f5 convert Link<> to typed
Change-Id: I38f2c15b4f8bb1d7187b019d26a2644b087898c1
Reviewed-on: https://gerrit.libreoffice.org/18357
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-07 06:56:57 +00:00
24d90b8aa8 convert Link<> to typed
Change-Id: I936606b6fdbb5db50661bde68fc8472bb9dd8861
Reviewed-on: https://gerrit.libreoffice.org/18317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-04 06:32:49 +00:00
37a6fdf890 loplugin:stringconstant also for cases using char const v[] = "..."
Change-Id: Iba38686620624178a7be39d703389402bbcea4cb
2015-09-03 09:34:00 +02:00
5beffcf3f1 convert Link<> to typed
Change-Id: Ic0482dc5ed26eb2fc6ccde73022eff8b4786de83
Reviewed-on: https://gerrit.libreoffice.org/18258
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-03 07:20:27 +00:00
e9b7506415 loplugin:stringconstant: OUStringBuffer: appendAscii -> append
Change-Id: Iadb6e16a7aca322a78a82ae1a52f5d085b300efc
2015-08-31 08:03:15 +02:00
6900bf41e2 o3tl/cow_wrapper: remove boost dependency
Remove boost dependencies from ::o3tl::cow_wrapper, and add
the necessary includes to files including checked_delete and
noncopyable that do not already include the necessary files.

Change-Id: Iedae4232002792724226829a5d5cf9d16ffd0686
Reviewed-on: https://gerrit.libreoffice.org/18125
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-29 22:51:36 +00:00
bd8b93fdff make PostUserEvent Link<> typed
Change-Id: I13f10bda985d55d419a5bff481130a456ae2db8a
2015-08-28 09:49:56 +02:00
6ae1b105e3 don't protect the gnumeric filter with the USE_ORCUS flag
Change-Id: Id91c7844879bea589bf97f999fd0c69669dfa7f6
2015-08-28 02:03:39 +02:00
b0a2cc695e remove crazy whitespaces
Conflicts:
	framework/source/loadenv/loadenv.cxx

Change-Id: Ia104e5dedbaf19dff5b0eaf4eb6f4c355570cc00
2015-08-28 02:03:34 +02:00
c427f2ee17 make experimental orcus import work again
Change-Id: I2e599331669c3018557835ab227395c54c247ac9
2015-08-28 02:03:33 +02:00
edebac799d cosmetic clean-up
Change-Id: I7e6689e07873dcb85c2bf1aac0db2ecddc01fe4b
2015-08-28 02:03:28 +02:00
9c8fd7d1c5 Clean up sEmpty
Change-Id: If1b2bfe308caa2bce92e73d2c5c86ee273faed93
2015-08-27 08:00:32 +02:00
a6050c32f3 Clean up aEmpty
Change-Id: I4c4294b7fb1cb537ba3ae3e6e7e747a3333b7469
2015-08-27 08:00:32 +02:00
25accda781 tdf#39440 reduce scope of local variables
This addresses some cppcheck warnings.

Change-Id: I6ab170c4426494ab9fc53017f88e47fbfdbd9aad
Reviewed-on: https://gerrit.libreoffice.org/17920
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-22 13:02:08 +00:00
af6daec72b more config skipping stuff and a tester tool
Change-Id: I5e93a4c84b3a0940239213766eb24d21fb5fd649
Reviewed-on: https://gerrit.libreoffice.org/17863
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-20 07:40:21 +00:00
f0e90c712b for testing allow disabling configmgr for time critical paths
Change-Id: I83396e7c90d3b182f353a77c9bdf06fd17af92a1
2015-08-19 20:28:35 +01:00
8894f3cfa0 Remove redundant check
...became redundant with previous commit
d3d7cb989b8d3c7d8e9947511bf78e9aefedc490 "Remove ConvertOSLtoUCBURL."

Change-Id: I08c436dec8ed661eae60a17723fc63e6aafb1f86
2015-08-19 11:20:52 +02:00
d3d7cb989b Remove ConvertOSLtoUCBURL
"Not all OSL URL's can be mapped to UCB URL's" might have been true in the days
of vnd.sun.star.wfs, but I can't see any good reason for this functionality
today.

Change-Id: Ia887531ee9fa70092766406cee1fc8962576a8ac
2015-08-19 11:15:52 +02:00
236714e86c Clean up remaining utl::LocalFileHelper::Convert...
together with 58d68a1bc9146334376206ae7ba8b1a6594a1040
"ConvertURLToSystemPath->getSystemPathFromFileURL" and
28f3464a571a23a2c16bd0980e9021b95d011511
"ConvertSystemPathToURL->getFileURLFromSystemPath," this replaces all those
Convert... functionality with direct calls to the corresponding osl::FileBase
functions.

Change-Id: I2876171cd337a5eb939d25d8cf1e0c1253ff73a7
2015-08-19 10:48:42 +02:00
431f2ce818 framework: tdf#88206 replace cppu::WeakImplHelper* etc.
with the variadic variants.

Change-Id: I6acff50f23bcbac58c689caf2a7f07dbd5404e57
Reviewed-on: https://gerrit.libreoffice.org/17734
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-14 10:46:14 +00:00
371a535afb loplugin: defaultparams
Change-Id: I0538bbb2e121d8feeff03535cb327c957e03de1b
2015-08-14 11:11:07 +02:00
0db25f68ab remove default value from SfxPoolItem::PutValue
more useful to make it explicit.

Specifically, otherwise my defaultvalue clang plugin would want to
remove lots of places that contains #define constants which, while
technically the same as the default value, convey semantic
information which is quite useful.

Change-Id: I918ad5b0e73ba279fa1b1489b62d900339ff71eb
2015-08-14 09:16:06 +02:00
26c106a5ae append '(Remote)' in the titlebar when remote file is opened
Change-Id: Idf0a9594406601154319ae17e42ece4bf2d56dc9
2015-08-14 08:45:20 +02:00
ded58e062c Related tdf#93404: Fix deadlock when joining WakeUpThread
...after 54f10a9654b617c4c993044e52e7bd40d0151c53 "tdf#93404: Forgot to launch
WakeUpThread," when the WakeUpThread blocks on locking
StatusIndicatorFactory::m_mutex in StatusIndicatorFactory::update() while the
joining thread blocks on StatusIndicatorFactory::impl_stopWakeUpThread() ->
WakeUpThread::stop() -> Thread::join().

Change-Id: I3480014b1f522901064ea9b71ffa2ebf5d74fef5
2015-08-13 15:16:38 +02:00
54f10a9654 tdf#93404: Forgot to launch WakeUpThread
...in 017f250764ec7b4ecb82ac19f5b3f68cadf1bf56 "Ensure WakeUpThread is joined
before exit"

Change-Id: Iaa5a5772f099b11229bd40c3cc10d863ef0ad5b3
2015-08-13 12:07:21 +02:00