a18fc918d5
Fix typos
...
Change-Id: I051caee9ec6181074201ac4a8cb6fcec4fdf2293
Reviewed-on: https://gerrit.libreoffice.org/18951
Reviewed-by: Oliver Specht <oliver.specht@cib.de >
Tested-by: Oliver Specht <oliver.specht@cib.de >
2015-09-30 13:50:06 +00:00
0cfd6e73c8
Advertise GL rendering in frame titles in dbgutil mode.
...
Change-Id: I1883d137eb65a030c58e1e4ec11df3e63800339b
Reviewed-on: https://gerrit.libreoffice.org/18512
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com >
2015-09-12 17:35:22 +00:00
37a6fdf890
loplugin:stringconstant also for cases using char const v[] = "..."
...
Change-Id: Iba38686620624178a7be39d703389402bbcea4cb
2015-09-03 09:34:00 +02:00
e9b7506415
loplugin:stringconstant: OUStringBuffer: appendAscii -> append
...
Change-Id: Iadb6e16a7aca322a78a82ae1a52f5d085b300efc
2015-08-31 08:03:15 +02:00
bd8b93fdff
make PostUserEvent Link<> typed
...
Change-Id: I13f10bda985d55d419a5bff481130a456ae2db8a
2015-08-28 09:49:56 +02:00
431f2ce818
framework: tdf#88206 replace cppu::WeakImplHelper* etc.
...
with the variadic variants.
Change-Id: I6acff50f23bcbac58c689caf2a7f07dbd5404e57
Reviewed-on: https://gerrit.libreoffice.org/17734
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-08-14 10:46:14 +00:00
26c106a5ae
append '(Remote)' in the titlebar when remote file is opened
...
Change-Id: Idf0a9594406601154319ae17e42ece4bf2d56dc9
2015-08-14 08:45:20 +02:00
f1639b2150
loplugin: defaultparams
...
Change-Id: I44772f7c26568353d02278486a8e960f40af6354
2015-08-11 09:48:17 +02:00
75a84417af
Whitespace.
...
Change-Id: Ifcccd6376a6a44bf6761e9fa451b46933adb6ce9
2015-08-01 02:23:22 +02:00
4cf0869b69
framework: replace boost::function with std::function
...
Change-Id: I9342bbdaa626c88592d3a7bdf12f150cc2a605b1
2015-07-31 21:54:27 +02:00
9be8c4f212
sfx2: remove the global SidebarController::maSidebarControllerContainer
...
This global was crashing on exit, unsurprising as it contains UNO
services that reference VCL objects.
It turns out that there is already a UNO singleton
framework::ContextChangeEventMultiplexer that effectively contains this
mapping already, so try to hook that up without creating a public API of
it, which is made quite a bit harder by framework's inexplicable
multitude of libraries.
Change-Id: I4baf67b42c630191fa8879d650eeb62520c331a5
2015-07-14 11:50:44 +02:00
e6a0ef5eee
comphelper: remove boost::bind from headers
...
Change-Id: I40c504d086c8ae1fd825acdafaada283ad9db8d0
2015-07-09 10:18:05 +02:00
799cc41b53
Fix typos
...
Change-Id: I70b03c152f63e48341dc5629a99b0eeab7b497c0
Reviewed-on: https://gerrit.libreoffice.org/16834
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2015-07-08 05:48:18 +00:00
032c0ec6b1
loplugin:unusedmethods svl
...
Change-Id: Ic136cce6abef44291b7236a6d709f0eee391f311
Reviewed-on: https://gerrit.libreoffice.org/16784
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-06 13:14:08 +00:00
3e9a13f16c
coverity#1308570 Uncaught exception
...
Change-Id: I9009a96e09943b5339c6ef6995d9a28c3e4b596c
2015-06-29 09:43:32 +01:00
4c15726253
coverity#1308516 Uncaught exception
...
Change-Id: If5dcf42448f87888e9f6bab2209bc1f9dd1d525c
2015-06-28 17:55:50 +01:00
0b60670850
loplugin:stringconstant: handle OUString+=OUString(literal)
...
Change-Id: Ie17c1d6c7664b3d3ad0255094b26ba433c2c1921
2015-06-26 13:55:32 +02:00
a1a5588b1b
loplugin:cstylecast: deal with remaining pointer casts
...
Change-Id: I4a72a60d621c65e63310ef70b991f9c86f00494d
2015-06-08 16:25:25 +02:00
10749bbf82
remove the last of the OUString #defines in header files
...
Change-Id: Id9e8ce7987e055e83b52c7024413570f262e6e8d
2015-05-19 09:42:41 +02:00
4f00dce2b3
Use IMPL_[STATIC_]LINK_NOARG where applicable
...
Change-Id: I1e24b032bdeea017b0e77c5446e55310899ce752
2015-05-10 11:25:48 +02:00
9bb254fc85
NOINSTANCE is implied now in IMPL_STATIC_LINK...
...
Change-Id: Ifb032457d6c1b279c4183282ef2b271c706dd71a
2015-05-10 11:25:47 +02:00
b13fbd19b7
convert BMP_SCALE constant to scoped enum
...
Change-Id: Ibc9f88d2588c028cd71aa86c26d970a73025ef22
2015-05-06 09:01:30 +02:00
e6c08b6b30
Remove unnecessary STATIC_LINK macro
...
Change-Id: I4788824667c8e0d1d4e0717b7ae7737bb0fd2c90
2015-04-29 18:29:59 +02:00
deb50a2a8a
remove some @author tags from suspiciously unidiomatic code
...
Change-Id: I3930420fe502978f8e14a688f2eb99c74d185f7b
2015-04-25 22:45:51 +02:00
ba150afb07
Update to XDocumentEventBroadcaster et al
...
Change-Id: I27904a961a30042608ae4facae9772d30b86696b
2015-04-22 15:38:44 +02:00
71b809959b
remove unnecessary use of void in function declarations
...
ie.
void f(void);
becomes
void f();
I used the following command to make the changes:
git grep -lP '\(\s*void\s*\)' -- *.cxx \
| xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'
and ran it for both .cxx and .hxx files.
Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-15 11:47:12 +02:00
54e87df11f
Change INetProtocol enumerators to CamelCase
...
...to avoid clashes with macros and poor warnings about hiding global FILE
Change-Id: I444e8b958f029201b228937e088efabc4b6d3050
2015-04-02 18:33:37 +02:00
44b3e56bb4
Change INetProtocol to scoped enumeration
...
...and fix o3tl::enumarray::operator [] const overload
Change-Id: I749b1b9d68686b03a97074253478d9d2d9d32b0b
2015-04-02 16:30:34 +02:00
e9cb5577f4
loplugin:staticmethods
...
Change-Id: Ibf0c73ac17ec19ed672f66907db47057920babca
2015-04-02 09:38:29 +02:00
5d950b3afd
Clean up C-style casts from pointers to void
...
Change-Id: Ide77480339e35a886f0d33c2a194244064c02488
2015-03-28 19:09:21 +01:00
465359c35f
do not call virtual Commit() from dtors of utl::ConfigItem subclasses
...
~SvtAppFilterOptions_Impl() demonstrates that this is a bad idea, by not
invoking its subclasses' ImplCommit() but its own.
Change-Id: Ic675e9cd3be1494c740a4f289be3bdbf0d1a122b
2015-03-11 16:50:03 +01:00
765f6211b1
utl::ConfigItem::Commit() should call ClearModified()
...
Rename the virtual function, and add a new non-virtual Commit() to do
that.
Change-Id: I09421df781ba965d6ff638b46cd8214fb3a00022
2015-03-11 16:50:00 +01:00
f2cb2c6f67
Typos
...
Change-Id: I70b8249827c799610a0466ebd5559169c4fac6ec
2015-03-02 22:15:01 +01:00
e3e95f9763
Typo: embeded->embedded
...
Change-Id: I27d0cdac158a674274647fe0081a8d8c046fe0ea
2015-03-01 00:50:51 +01:00
a1ceacc17e
boost::foo_ptr->std::foo_ptr
...
Change-Id: I9219619b538b6530a89f5932ac51eb3b62eb396a
2015-02-16 12:54:44 +00:00
af6cd2356a
rename MenuConfiguration::Attributes->MenuAttributes
...
Change-Id: I2ada1394c4cbee7c27b02f241ee4a254597a5dd8
2015-02-04 20:49:59 +00:00
4904180247
fix leak from framework::AddonMenuManager::BuildMenu
...
provide a callback when a menu item gets deleted
Change-Id: I5b5f1a181fb10f53f6b1fe7b5637d385e1517530
2015-02-04 16:34:53 +00:00
d69fb68f30
Some more loplugin:cstylecast: framework
...
Change-Id: Iebd80b596bcc1f740ff9f3b0f168472144cacbed
2015-01-20 09:06:48 +01:00
2f69e16c72
override the overloading of "overload" to decrease cognitive (over-)load
...
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-09 00:00:47 +01:00
7f8f277b94
fdo#84938: convert STREAM_ #defines to 'enum class'
...
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-07 11:20:44 +02:00
8e94c40f13
how about scope
...
Change-Id: I4c9e5f754974b6726fc86bc87775ba81832b3984
2015-01-06 11:59:53 +01:00
549b7fad48
workaround a weird gcc optimization werror bug
...
gcc (GCC) 4.9.2 20141101 (Red Hat 4.9.2-1)
framework/source/fwe/classes/addonsoptions.cxx: In member function ‘void framework::AddonsOptions_Impl::ReadAndAssociateImages(const rtl::OUString&, const rtl::OUString&)’:
framework/source/fwe/classes/addonsoptions.cxx:267:16: error: array subscript is above array bounds [-Werror=array-bounds]
struct ImageEntry
^
The combination of aScaled[2]; aImage[2]; aURL[2] in sequence apparently lead
to some overoptimization and/or alignment problem, already declaring aImage[3]
helped (but not aScaled[3]), but that's not what we want.
Change-Id: I82e28d4887ab8072a17d0a9341d322c1cf61aedc
2015-01-06 11:40:23 +01:00
fd1372ba8b
boost::unordered_map->std::unordered_map
...
you can get debug stl this way
Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2015-01-02 16:14:36 +00:00
b98352996c
framework: Use appropriate OUString functions on string constants
...
Change-Id: I5da5cd3254102c742021b3e7b4e1f907ca897ca5
2014-12-18 14:12:22 +01:00
38b8c1e880
fdo#39440 reduce scope of local variables
...
This addresses some cppcheck warnings.
Change-Id: I57f336c6ab3c418eac82397edeadecb4c1b168a7
Reviewed-on: https://gerrit.libreoffice.org/13495
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-12-16 20:42:30 +00:00
b733f5c4f4
framework: Use appropriate OUString functions on string constants
...
Change-Id: I72bb5ff2ab8a55061072fde567fcc1c4a8e20a2f
2014-12-12 17:52:18 +01:00
179810cdf2
Further clean-up
...
Change-Id: I20049b482c831e4ac2221fddfe80deb9847e72c3
2014-12-03 20:30:18 +01:00
9de4fe9853
Code clean-up/consolidation task.
...
Removing the duplicate code,and consolidating changes
by using method "getExpandedFilePath" of comphelper.
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >: adapted to recent change
from comphelper::getExpandedFilePath to comphelper::getExpandedUri; fixed the
two changes in framework to actually modify the by--non-const--ref argument;
fixed a loplugin:unreffun. More clean-up to follow.
Change-Id: Ie8875bcb61b616385bd64151f0a915bf7cce04e5
2014-12-03 20:30:18 +01:00
15b4ab8d19
cppuhelper: clean up public headers with include-what-you-use
...
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18 18:51:49 +01:00
6a0fe37dec
sal: clean up public headers with include-what-you-use
...
Sadly cannot forward declare "struct {...} TimeValue;".
rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...
Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17 11:06:53 +01:00
