89d39bc100
tdf#94559: 4th step to remove rtti.hxx
...
replaced use of PTR_CAST, IS_TYPE, ISA in
idl, editeng, sc, sd, sw, sfx2, sot, starmath
Change-Id: I4a5bba4fdc4829099618c09b690c83f876a3d653
Reviewed-on: https://gerrit.libreoffice.org/19132
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Oliver Specht <oliver.specht@cib.de >
2015-10-06 07:29:37 +00:00
8ea85c264f
Add isSchemeEqualTo(), isAnyKnownWebDAVScheme() to INetURLObject
...
...which will be used when rebasing
<https://gerrit.libreoffice.org/#/c/17189 >
"tdf#82744: fix WebDAV lock/unlock behaviour - part 3" on top of
d3de490437df4c9093f32e97fc185066d64c0f46
"Add vnd.sun.star.webdavs URL scheme."
Change-Id: I19bd715d755a6f070b95ce897d8a1bbb4910d537
Reviewed-on: https://gerrit.libreoffice.org/18151
Reviewed-by: Jan Holesovsky <kendy@collabora.com >
Tested-by: Jan Holesovsky <kendy@collabora.com >
2015-10-05 11:11:24 +00:00
85f93697de
tdf#94559: third step to remove rtti.hxx
...
replaced use of PTR_CAST, IS_TYPE, ISA in
oox, reportdesign, svl, svtools, svx, tools
Change-Id: I1f85ff92267a0668eba625fa61b4f07feb8f3d4e
Reviewed-on: https://gerrit.libreoffice.org/19002
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Oliver Specht <oliver.specht@cib.de >
2015-10-01 08:32:26 +00:00
638b6d7e0b
Fix typos
...
Change-Id: I8e9c6c72c89411d8de04e5edd9317cd54f7c472a
Reviewed-on: https://gerrit.libreoffice.org/18958
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
2015-09-30 11:03:34 +00:00
34180700b2
loplugin:removeunusedmethods, remove unused stuff
...
Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350
2015-09-29 15:08:43 +02:00
a12c083cad
Some follow-up #include clean-up
...
Change-Id: I4e91748701becfc92a379a490c08e9c7950007e3
2015-09-18 07:51:35 +02:00
9ce08dcc2e
writeHeaderFieldBody is only called with bInitialSpace = false
...
Change-Id: Ib7fe0bee6339bfad0f63794fec3dfb3f24333ff4
2015-09-17 22:22:34 +02:00
7a2a02163b
Make various INetMIME members local to inetmime.cxx
...
(and remove those that are then identified as unused)
Change-Id: I5be9d306705837b995b91a13922bc1fb9fed4902
2015-09-17 22:22:33 +02:00
266805f6a4
Make createPreferredCharsetList local to inetmime.cxx
...
Change-Id: Idce9983135d7856b74b1cc548aed668fc9910f46
2015-09-17 22:22:33 +02:00
f4fb4c531d
Make INetMIMEEncodedWordOutputSink local to inetmime.cxx
...
Change-Id: I779bde650b7fc21af93b573a55fab5b6fff03790
2015-09-17 22:22:32 +02:00
984780243c
HEADER_FIELD_TEXT is the only used HeaderFieldType
...
Change-Id: Ia4e5554e1aaed9e821bdea18b9b3acff001dd6e7
2015-09-17 22:19:23 +02:00
50ea351929
INetMIMEOutputSink line length limit is unused
...
Change-Id: Ib9da396d0669bfd89dbbff17821b8303f20d61aa
2015-09-17 16:57:37 +02:00
ade5624f31
All INetMIMEOutputSink instances use same fixed ctor arg values
...
Change-Id: I49126732be307b80270843c147d9cce4b3fdd2a3
2015-09-17 16:57:37 +02:00
54ddc13bd2
Fold INetMIMEStringOutputSink into INetMIMEOutputSink base
...
Change-Id: I675e656b57fca90e42be2d924c102a995168984d
2015-09-17 16:57:36 +02:00
717de02367
INetMIMEOutputSink ctor args are always given explicitly
...
Change-Id: Iacb01ac77ef4419f7428ecb397e91ab8d666a8f3
2015-09-17 16:57:35 +02:00
f7dc03f666
Remove unused HARD_LINE_LENGTH_LIMIT
...
Change-Id: Iae65de5a71f8a0b8ad80138ae310db9a84736878
2015-09-17 16:57:35 +02:00
149384846b
No need for user-prov. INetContentTypeParameter ctor, use list-initialization
...
Change-Id: Ie116def9e5e90a59a82c3e8a4821eecd68eee64c
2015-09-17 16:57:35 +02:00
63e7b7afa7
Don't violate unordered container hash+pred requirements
...
"Two values k1 and k2 of type Key are considered equivalent if the container's
key equality predicate returns true when passed those values. If k1 and k2 are
equivalent, the container's hash function shall return the same value for both."
[unord.req]
But for INetContentTypeParameterList, all inserted keys are already lower-case
by construction, and all queries happen to be done with (literal) lower-case
keys, so just document the requirement here that insertion and query needs to be
done with lower-case keys.
Change-Id: Ic46845b7bb0376e995e7736b57fa80c777d1c263
2015-09-17 14:47:14 +02:00
1a9293242b
Remove unused INetMIMEMessage parts
...
Change-Id: Ica7d3e7e52ccdfe833ac10567c6f5f7bb7085dee
2015-09-10 23:04:35 +02:00
9371a5f0a0
More INetMIMEMessageStream clean up
...
Change-Id: Ibb2b93261e2d8ef370ac106766e39685a03a6ef3
2015-09-10 23:04:35 +02:00
82285ab5c9
Merge INetMessageIStream into INetMIMEMessageStream
...
Change-Id: Ic3d9cd117b3f911a7cb1317fc9d1d2e9d8f1ff42
2015-09-10 23:04:35 +02:00
4464e5dbca
No need for INetMIMEMessageStream encoding
...
...in the only use case in ODatabaseForm
Change-Id: I0282a9f60b05f279a11dcf1990e68b7e017ea3aa
2015-09-10 23:04:34 +02:00
40bcf53b5d
Remove unused INetMessageOStream functionality
...
Change-Id: I34ee4750f30635809b8e23cbf1bd0e16f269f549
2015-09-10 23:04:34 +02:00
e871b6a31a
Reduce INetMIMEMessage::EnableAttachChild to its only use case
...
Change-Id: I67221408d6b9d2aee942ca8bd39ca51da0209551
2015-09-10 23:04:33 +02:00
71d8cfc13a
convert Link<> to typed, and introduce LinkParamNone
...
as a marker type for unused Link#Call(T) param
Change-Id: Ife9149052a52b27fefd4f810309a5004a0f1771b
2015-09-10 08:30:11 +02:00
da260fbb18
Remove unused "#ifndef ENUM_*_DECLARED" wrapping
...
Change-Id: I6f207a1692e4fcd2fbecd0420f5ed798e4504667
2015-09-10 07:57:53 +02:00
2beeeea4ea
Get rid of OSL_UNUSED
...
In many cases it was originally used to silence warnings about variables used
only in OSL_ENSURE etc., but that's no longer necessary since OSL_ENSURE is
based on SAL_WARN etc. In some other cases it was apparently used as a
speculative debugging aid, to have a value assigned to a variable to be easily
able to view the value in a debugger. And in some cases it was used with
(otherwise ignored) return values of (typically SQL-related) function calls, but
it is probably better to eventually find and fix all the problematic ones among
such calls via function declarations annotated SAL_WARN_UNUSED_RESULT.
Change-Id: Ib925b38da70073b546fdcd00fa8524dc302accbf
2015-09-09 07:54:04 +02:00
8ab005af96
Avoid pain when using selective debuginfo
...
Compile in the DbgUnhandledException function always.
Change-Id: I302954598e599e8db71967974b18ade54ca2de13
2015-09-08 19:37:58 +03:00
43691a15b3
tdf#93794 - spin buttons not rendered in gtk2/gtk3
...
for penance, introduce a unit test
Change-Id: I2c40285732be665e179c477e6e7603aa6f8be5d7
2015-08-31 13:59:55 +02:00
c1a9d01391
tdf#62525: use cow_wrapper for SvGlobalName
...
Convert the pimpled copy-on-write SvGlobalName class to use the
::o3tl::cow_wrapper using the default reference counting policy.
Change-Id: I7bceb06ddfb31ca5901e5e7d5d93dda494db945f
Reviewed-on: https://gerrit.libreoffice.org/18070
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de >
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de >
2015-08-30 12:55:17 +00:00
1e8b7cdbbd
this farcical staroffice 5.0 related junk can at least be const
...
Change-Id: I096d98f6e0cb61cacd9cd82a623f832b88ded1e6
2015-08-27 11:59:21 +01:00
a0ab7c31a2
Again add ability to change tint/shade of a color + unit test
...
Change-Id: I4c06290f09e5bfecd2c1de896e19cb5036a3a0e9
2015-08-27 08:30:49 +09:00
139b32b84c
Bin the fairly useless DbgDialog stuff and handle fallout
...
See (short) discussion on the mailing list, "How was it again, is the
DbgDialog useful?".
Change-Id: Ibde1eb13f16edf94f1f7aebd0befd1b0b171d5c4
2015-08-26 10:33:30 +03:00
2a0f9f0891
simplify some declarations
...
Change-Id: I348e7f984e5e8b4b915d11de8182da07a6356f8d
2015-08-25 09:58:32 +02:00
258643235c
add some comments to Rectangle mutation methods
...
Change-Id: I7e1d737fc1e7a431afd3cde74c2c974e0cbef9ef
2015-08-25 09:58:31 +02:00
27dec7c2b1
afl-clang-fast apparently miscompiles this
...
leading to the delete not getting called,
which results in temp files leaking and eventually
filling tmp
I wonder if generic clang suffers from this ?
Change-Id: Iecc266544b3c779026593a16e96bb1a2dfbe8328
2015-08-20 16:10:35 +01:00
885418c0d7
remove dead comment
...
Change-Id: I244e52ec494546383dcb1981c41f2d388ae7d85a
2015-08-20 13:19:16 +02:00
5109114856
Put Line under tools namespace
...
Change-Id: I7442848951c0d4579fb2a2a3eef3bfed7135aac4
Reviewed-on: https://gerrit.libreoffice.org/17791
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com >
2015-08-17 06:30:01 +00:00
ef46917ff3
Put Polygon from tools under tools:: namespace
...
Polygon is one of these names that Clash with some system objects
A similar work has been done earlier with PolyPolygon.
Change-Id: Icf2217cb2906292b7275760f1a16be0e150312f5
Reviewed-on: https://gerrit.libreoffice.org/17789
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com >
2015-08-17 02:07:43 +00:00
403c13487c
loplugin:unusedmethods
...
Change-Id: I6801618efb5a66d24156fa429e026acb6ca03aba
Reviewed-on: https://gerrit.libreoffice.org/17506
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-08-05 09:39:22 +00:00
f17f89aadc
include: inline some use-once typedefs
...
Change-Id: I064e95c72e5f67178cf2875f457adac241cee529
2015-08-04 08:55:57 +02:00
aedd003086
tools: prefix members of SvStream
...
Change-Id: Iba845749d645bc1cf9eb6d6c41829717831bc487
2015-07-31 14:45:38 +02:00
a45827b230
loplugin:unusedmethods
...
Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971
Reviewed-on: https://gerrit.libreoffice.org/17378
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-30 06:23:00 +00:00
029fa6477b
solar.h: avoid some Wconversion warnings
...
Change-Id: Id41bd4e759dea72b37db5f329e29ff5c18c75a66
Reviewed-on: https://gerrit.libreoffice.org/17306
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Eike Rathke <erack@redhat.com >
Tested-by: Eike Rathke <erack@redhat.com >
2015-07-29 09:12:35 +00:00
5e6ec5bb14
errcode.hxx: avoid some Wconversion warnings
...
Change-Id: I48bb49c7eb472fa493fca71736acc358151e87ac
Reviewed-on: https://gerrit.libreoffice.org/17308
Reviewed-by: Eike Rathke <erack@redhat.com >
Tested-by: Eike Rathke <erack@redhat.com >
2015-07-29 08:56:36 +00:00
38ecca9b30
inline a bunch of use-once macros
...
no point in having a macro unless it's actually going to reduce the
number of lines of code
Change-Id: Ic8760d6506cf272d7bd088f7b3b4dcbf288099fc
2015-07-27 08:18:16 +02:00
efac5fa06e
remove some unused defines
...
Change-Id: Ib2d50e8c29ccbc5ffcb52cdff4ae3eaae9a62188
Reviewed-on: https://gerrit.libreoffice.org/17332
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-27 06:12:01 +00:00
93774f29ec
remove unused URL_PREFIX_PRIV constants
...
Change-Id: I4d49ebec2867e4c53661c20b277bfdbf4fd222a2
2015-07-24 12:36:53 +02:00
9582380ebc
convert ImageAlign to enum class
...
Change-Id: I22e2e66a1f0b230403ad1d9c1f5b7f34a6ee6ea5
2015-07-24 09:52:08 +02:00
9e28cc8ca7
convert WindowAlign to scoped enum
...
Change-Id: I028d108b3a83bd5541d873c4d03b87339cd3be52
2015-07-24 09:52:08 +02:00
