Commit Graph

1107 Commits

Author SHA1 Message Date
b1a6a99b9a presenter console: add 'Restart Timer' button
Use case is that the presentation is started a few minutes in advance,
so the audience can check if they are at the correct room, seeing the
title side. Then previously the presentation had to be stopped and
started again, so the presenter had an idea how much time the talk took
so far. The side effect of this workaround was that the audience saw a
short flash while the presentation was not running.

Fix this by adding a button to just restart the timer, then it's not
needed to stop/start the presentation manually.

The two icons are just placeholders for now, real design is still
needed.

Change-Id: Id67e7e53a339ea5672dfb1c261f63d43466e9eff
2015-10-06 07:47:54 +02:00
3ad8f409d7 Prefer getSelectedFiles to getFiles (sdext+qadevOOo)
Change-Id: I4827e47b7d67b0112c0f9023c0db4ce8975f06e1
Reviewed-on: https://gerrit.libreoffice.org/19126
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-10-04 14:32:30 +00:00
185f207ef1 Fix typos
Change-Id: I3ea8a90f0ec917b4e26335fcd31a5f7e0888589e
Reviewed-on: https://gerrit.libreoffice.org/18972
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-30 06:30:53 +00:00
5c26f79467 cppcheck: noExplicitConstructor
Change-Id: Ibb94d40706fced3c1c053fd58ef4e2af2d849587
2015-09-27 21:05:19 +01:00
335704695d boost->std
Change-Id: I21ca18c23277423d106d990fd537d58108bd1084
Reviewed-on: https://gerrit.libreoffice.org/18679
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-18 13:46:27 +00:00
8ac129a59b Handle IOException during filter detection
Change-Id: Ie2b8b65f0f2b7b34efbba478a7ccda7ef3719bd6
2015-09-10 16:39:24 +02:00
55b077ca4a Work around bogus warning C4701: potentially uninitialized local variable
Change-Id: I9c5d9c53785828b3535c960f826ccd3720b2e4c3
2015-09-07 17:03:45 +02:00
419abc4ffd clang-analyzer-deadcode.DeadStores
...the computation of nTop, nBottom was done in this curious way ever since its
inception with 108632dc97a720639df495de3b5d966ee286be95 "CWS-TOOLING: integrate
CWS impressaccessibility3"

Change-Id: Ib516e944d96dc10ff12d0a82c0d8c921b57b0466
2015-09-07 16:48:29 +02:00
5670937747 clang-analyzer-deadcode.DeadStores
Change-Id: I7c19ce1bde1eb405fe64aba7504fc511c0ab646e
2015-09-07 16:37:25 +02:00
e15d4b8ee9 sdext: tdf#88206 replace cppu::WeakImplHelper* etc.
with the variadic variants.

Change-Id: I663029b736489b81ed4ccb5f7bd657fbaf091bdf
Reviewed-on: https://gerrit.libreoffice.org/18206
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-01 07:59:50 +00:00
c71c419c63 loplugin:stringconstant: OUStringBuffer: appendAscii -> append
Change-Id: I82330271362a428b2850d0f561770d35de1ee6b0
2015-08-31 08:02:03 +02:00
6900bf41e2 o3tl/cow_wrapper: remove boost dependency
Remove boost dependencies from ::o3tl::cow_wrapper, and add
the necessary includes to files including checked_delete and
noncopyable that do not already include the necessary files.

Change-Id: Iedae4232002792724226829a5d5cf9d16ffd0686
Reviewed-on: https://gerrit.libreoffice.org/18125
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-29 22:51:36 +00:00
7d769f9df5 loplugin: defaultparams
Change-Id: Ibf0ea539d2a95073a12f84964759d9c7a94baa7b
2015-08-20 13:52:17 +02:00
5da0dce19c Consolidate isFileUrl checks
Change-Id: I1b74fdfaa09c4d0d6c296253958e83e78b546a9a
2015-08-19 12:24:37 +02:00
a5b842f3aa remove unused SfxFilterFlags values
from both the code and the XCU files

Change-Id: I47f1f33c3ad4a37e346e3b8020dd9d3e284ccb77
Reviewed-on: https://gerrit.libreoffice.org/17522
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-05 11:08:25 +00:00
902d61bc7f sdext: replace boost::function with std::function
This one is a bit odd, wonder if that was a bug:

-        aAction(aPredicate);
+        aAction(aPredicate());

Change-Id: I0ddd565b65fe4778a297486805fa7f7a12702224
2015-08-03 14:47:45 +02:00
2660d24a07 new loplugin: refcounting
This was a feature requested by mmeeks, as a result of
tdf#92611.

It validates that things that extend XInterface are not
directly heap/stack-allocated, but have their lifecycle managed
via css::uno::Reference or rtl::Reference.

Change-Id: I28e3b8b236f6a4a56d0a6d6f26ad54e44b36e692
Reviewed-on: https://gerrit.libreoffice.org/16924
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-03 06:37:16 +00:00
a45827b230 loplugin:unusedmethods
Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971
Reviewed-on: https://gerrit.libreoffice.org/17378
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-30 06:23:00 +00:00
e963a88912 formatting of public/private/protected section qualifiers
make it consistent across the codebase, no space between keyword
and the colon

Change-Id: Idca61ddfc74ad2460fb05fe417499324b05e5de5
Reviewed-on: https://gerrit.libreoffice.org/17148
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-17 09:49:35 +00:00
e544f449ed Fix typos
Change-Id: I020c7ce4d9aa93cb0292378a410cdb9f7788e920
Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-07-08 12:21:19 +02:00
0c8dd8f503 loplugin:unusedmethods sdext
Change-Id: I9119e612a92d05f587a1f1e19ca21b2f95102891
Reviewed-on: https://gerrit.libreoffice.org/16809
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-07 09:09:03 +00:00
3dfdd18707 Fix typos
Change-Id: Iddcc22f62ea134ea797292daa02e47042d52d0d1
Reviewed-on: https://gerrit.libreoffice.org/16710
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-07-04 10:22:11 +00:00
b51ba9e383 Work around const-ness issues in the GooString API
cf. <https://gerrit.libreoffice.org/#/c/16357> "Revert the removal of cast to
build on old poppler"

Change-Id: I75184cec64b4f32e0cf9adedeb84c8591be4fc73
2015-07-01 09:20:18 +02:00
aade27554d Fix typos
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b
Reviewed-on: https://gerrit.libreoffice.org/16408
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-22 12:36:21 +00:00
0032fc0385 Fix check for broken standard library
The compiler's __GNUC__ etc. need not match the libstdc++ version used (esp.
when using Clang as compiler), and libstdc++'s __GLIBCXX__ macro doesn't inrease
monotonically with version numbers, so resort to a configure check.

Change-Id: I06de6b68324169863f6f5c31ae5d855e8b04cd6b
2015-06-19 15:25:53 +02:00
cbe944e323 Catch inadvertent uses of OUString(sal_Unicode) ctor
...with numeric values that are not meant to be characters.  Inspired by
<https://gerrit.libreoffice.org/#/c/16339/> "OUString: add constructor from
single Unicode code point" and ecaf1cb3861c1b519a1495487fc796884cf37b92 "seems
to be what was meant."  Found e46e8d19458fd64ff20b1013e5eeabd07e62379c "Shall
this produce a string representation of a number?" and
f2a0e4032734d6be635f14ade3dea499c29ec6c2 "Don't truncate a UTF-32 code point to
a UTF-16 code unit."

(LIBO_INTERNAL_ONLY mostly because it uses a C++11 delegating ctor for
simplicity, but also because it requires mild modifications to client code, see
additional changes in this commit and some other recent commits.)

Change-Id: I8a156f01d1b772c6052d7afaa088ae13ed234e2b
2015-06-19 13:26:09 +02:00
a99f068fa0 once more unto the breech dear fellows
workaround GCC4.8 issue

Change-Id: Iea4d10a02a114ce94e0219e8b89acf48db5411d0
2015-06-19 13:23:52 +02:00
1352d16674 workaround older compilers that do not have std::list::erase(const_iterator)
Change-Id: Iaa1164904febd8e97d4962e4004ec4719a1f4a42
2015-06-19 13:12:53 +02:00
9bc57ae766 fix older compiler
after my commit e0f3e7c007e9eeced888b491ec2698acba4bc588
"tdf#42374 some small optimisations for opening this PDF file"

Change-Id: I908770ca618581ffe26ebb2205b804d1abcae5a7
2015-06-19 11:26:02 +02:00
34761d98c5 add comment
Change-Id: I336e6ea9b08edaa7e9718f8af9c112b983eeaa58
2015-06-19 10:57:11 +02:00
7d69c94104 fix older compiler
after my commit e0f3e7c007e9eeced888b491ec2698acba4bc588
"tdf#42374 some small optimisations for opening this PDF file"

Change-Id: Ib9dc0aaf3ad2afca272160a934049d89bbd54175
2015-06-19 10:56:11 +02:00
4f1587965e tdf#42374 - read PDF in larger chunks
Optimise the reading of the imported PDF file by reading in larger chunks.
Eliminates roughly 10% of the time on my box

Change-Id: I48fff325076850a4ccd32ad85a3092621a923034
2015-06-19 10:56:11 +02:00
1497dd9745 tdf#42374, improve perf by fixing bug in pdfi::HashedStyle::hashCode()
which was rendering it largely useless for hashing purposes

Change-Id: Ie94457ea0a6e53fd9ceed9461656e2d3b0840d58
2015-06-19 10:07:21 +02:00
e0f3e7c007 tdf#42374 some small optimisations for opening this PDF file
makes it about 10% faster

Change-Id: I145faed5aa7c312372f08cc651df5afcf10c70ab
2015-06-19 09:55:07 +02:00
4c1926f34e the ElementTreeVisitable interface is doing nothing useful
Change-Id: I89e8fb90de8aadce89a8f5e353a923c972e1569f
2015-06-19 09:52:04 +02:00
ae150c6a54 Fix typos
Change-Id: Ibfa971952cd330ddf430e7e951c5c235d2ae6bd8
Reviewed-on: https://gerrit.libreoffice.org/16314
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-18 11:44:56 +00:00
4729774b24 remove unnecessary check for null when calling delete
Idea originally from caolan.
Found using the following command:
find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;'

Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-15 14:46:41 +02:00
1f408db497 Fix typos
Change-Id: Ifaa52b49b717d893846fc1e7ae4ac50735f824ac
Reviewed-on: https://gerrit.libreoffice.org/16260
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2015-06-13 14:51:15 +00:00
7c874dede6 loplugin:cstylecast: deal with remaining pointer casts
Change-Id: I8bd47784ae34ecd57f43b1e680ab863a6272c32f
2015-06-08 16:27:52 +02:00
6ef9f7e202 loplugin:loopvartoosmall
Change-Id: Ib4def3435eab4625645c5afe3b151f9f430564ac
2015-06-02 12:09:56 +02:00
609707dd21 loplugin:cstylecast: deal with those that are (technically) const_cast
Change-Id: Ie77fdb078c9c8f8ed01dfd6c5dd583c6535803b2
2015-06-02 11:27:54 +02:00
1df4114245 loplugin:loopvartoosmall
Change-Id: I809e408c994222cfa95ba8f56e4db7bd96be7080
2015-06-02 09:45:16 +02:00
f849d96463 tdf#91416 - fix some incorrectly allocated VirtualDevices.
Change-Id: I9ebed313827986473c60e77b7e218b4c1b2487fe
2015-05-26 17:54:27 +01:00
fa4071bb52 tdf#63054: pdf_string_parser incorrectly handles escapes
This patch fixes the escapes handling by avoiding boost built-in
functions that skip whitespaces behind the scenes.

Change-Id: I9607ecd9e2e052aadcba69cf30ec25c981743c49
Reviewed-on: https://gerrit.libreoffice.org/15562
Tested-by: Jenkins <ci@libreoffice.org>
Tested-by: David Tardon <dtardon@redhat.com>
Reviewed-by: David Tardon <dtardon@redhat.com>
2015-04-29 07:43:19 +00:00
c82515eb6b More loplugin:simplifybool
Change-Id: I4ea5c7e9f807dfd5242c8e87a87d9ad604ebd035
2015-04-27 15:31:00 +02:00
f88a1b8d55 loplugin:simplifybool
Change-Id: If5f4042642364424f8d7e1e13b6285503df1d381
2015-04-24 12:36:27 +02:00
79ed057b95 loplugin:staticmethods
Change-Id: I6207b475127099872c6f3764331006688129b673
2015-04-23 13:08:48 +02:00
da36fc8c95 No more need for PartialWeakComponentImplHelper here
...since 70626249cd247d9acdad417b8eaf252bae22c059 "API CHANGE a11y unpublishing
and add/removeListener rename."

Change-Id: I89d81326d97712abcac94c3436a13905954c55cf
2015-04-21 22:48:02 +02:00
697804f48f Make cpp/poppler-version.h header optional
Older popler (SLE11) does not have this header yet.
With the code simply if the header not found define version to oldest
possible working candidate and also raise the .pc check to the same.

Change-Id: I039c879879188fe2eb90cd119b80a1d6354a6a9c
Reviewed-on: https://gerrit.libreoffice.org/15339
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-04-21 13:07:16 +00:00
71b809959b remove unnecessary use of void in function declarations
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-15 11:47:12 +02:00