8ea85c264f
Add isSchemeEqualTo(), isAnyKnownWebDAVScheme() to INetURLObject
...
...which will be used when rebasing
<https://gerrit.libreoffice.org/#/c/17189 >
"tdf#82744: fix WebDAV lock/unlock behaviour - part 3" on top of
d3de490437df4c9093f32e97fc185066d64c0f46
"Add vnd.sun.star.webdavs URL scheme."
Change-Id: I19bd715d755a6f070b95ce897d8a1bbb4910d537
Reviewed-on: https://gerrit.libreoffice.org/18151
Reviewed-by: Jan Holesovsky <kendy@collabora.com >
Tested-by: Jan Holesovsky <kendy@collabora.com >
2015-10-05 11:11:24 +00:00
39a097f52e
clang-analyzer-deadcode.DeadStores
...
Change-Id: Ic4aba87fa750824a366fba18fcfa46fa11d31e78
2015-10-05 10:00:09 +02:00
f7cee96168
clang-analyzer-deadcode.DeadStores
...
Change-Id: Iec5a5fe5f14a9dcdbd7644bf67d4a985e42cd957
2015-10-05 10:00:09 +02:00
946cf1b7a2
clang-analyzer-deadcode.DeadStores
...
Change-Id: Ia1f6433000fe48ec6249b1cfb26668b665b2d15a
2015-10-05 09:47:52 +02:00
85f93697de
tdf#94559: third step to remove rtti.hxx
...
replaced use of PTR_CAST, IS_TYPE, ISA in
oox, reportdesign, svl, svtools, svx, tools
Change-Id: I1f85ff92267a0668eba625fa61b4f07feb8f3d4e
Reviewed-on: https://gerrit.libreoffice.org/19002
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Oliver Specht <oliver.specht@cib.de >
2015-10-01 08:32:26 +00:00
82f0a4f930
Fix typos
...
Change-Id: I3926eca56ac9f54f9ddbf88610888ce97cf00b34
Reviewed-on: https://gerrit.libreoffice.org/18990
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-09-30 10:41:48 +00:00
a2a5187a8f
Fix typos
...
Change-Id: Ifddd2533b767924791338555031b848c59980c52
Reviewed-on: https://gerrit.libreoffice.org/18989
Reviewed-by: Joren De Cuyper <jorendc@libreoffice.org >
Tested-by: Joren De Cuyper <jorendc@libreoffice.org >
2015-09-29 22:19:19 +00:00
34180700b2
loplugin:removeunusedmethods, remove unused stuff
...
Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350
2015-09-29 15:08:43 +02:00
b72eea1dbf
coverity#1325052 Logically dead code
...
since
commit 984780243c9a1ab1242f3af719c6dca3ddacf67a
Author: Stephan Bergmann <sbergman@redhat.com >
Date: Thu Sep 17 19:15:26 2015 +0200
HEADER_FIELD_TEXT is the only used HeaderFieldType
Change-Id: Ia4e5554e1aaed9e821bdea18b9b3acff001dd6e7
Change-Id: Id56790fd5c953d4d7f4a235c7d016c807ff37038
2015-09-29 11:10:28 +01:00
1f1b160902
coverity#1325051 Logically dead code
...
since
commit 984780243c9a1ab1242f3af719c6dca3ddacf67a
Author: Stephan Bergmann <sbergman@redhat.com >
Date: Thu Sep 17 19:15:26 2015 +0200
HEADER_FIELD_TEXT is the only used HeaderFieldType
Change-Id: Ia4e5554e1aaed9e821bdea18b9b3acff001dd6e7
Change-Id: I94a1cba6e9813b7192a03ea59948bb40438c341b
2015-09-29 11:10:28 +01:00
d66d6d7059
valgrind: use of uninit data in sw_globalfilter test
...
Change-Id: I4d327d1e65c8ef5b9dede18ac55f1658d8e3569a
2015-09-21 10:12:18 +01:00
a12c083cad
Some follow-up #include clean-up
...
Change-Id: I4e91748701becfc92a379a490c08e9c7950007e3
2015-09-18 07:51:35 +02:00
9ce08dcc2e
writeHeaderFieldBody is only called with bInitialSpace = false
...
Change-Id: Ib7fe0bee6339bfad0f63794fec3dfb3f24333ff4
2015-09-17 22:22:34 +02:00
a68b0ef5c1
CODING_QUOTED has become unused
...
Change-Id: I012b7d407cb50ba01fcc3b98ea2fe1968ec74a28
2015-09-17 22:22:33 +02:00
8fdd280930
CONTEXT_TEXT is the only unused Context
...
Change-Id: Ibacc88a60a313fd503935deef93881236cd8ec7f
2015-09-17 22:22:33 +02:00
7a2a02163b
Make various INetMIME members local to inetmime.cxx
...
(and remove those that are then identified as unused)
Change-Id: I5be9d306705837b995b91a13922bc1fb9fed4902
2015-09-17 22:22:33 +02:00
266805f6a4
Make createPreferredCharsetList local to inetmime.cxx
...
Change-Id: Idce9983135d7856b74b1cc548aed668fc9910f46
2015-09-17 22:22:33 +02:00
68bcfd067a
SPACE_ENCODED has become unused
...
Change-Id: I878bd07981686cab58906ccc1db1c4b3f47f8190
2015-09-17 22:22:33 +02:00
f4fb4c531d
Make INetMIMEEncodedWordOutputSink local to inetmime.cxx
...
Change-Id: I779bde650b7fc21af93b573a55fab5b6fff03790
2015-09-17 22:22:32 +02:00
984780243c
HEADER_FIELD_TEXT is the only used HeaderFieldType
...
Change-Id: Ia4e5554e1aaed9e821bdea18b9b3acff001dd6e7
2015-09-17 22:19:23 +02:00
74efa4f0e8
WaE: variable set but not used
...
Change-Id: I6b50ca1b23bd81521b2e94a2f16d63c4cef027ce
2015-09-17 16:52:45 +01:00
50ea351929
INetMIMEOutputSink line length limit is unused
...
Change-Id: Ib9da396d0669bfd89dbbff17821b8303f20d61aa
2015-09-17 16:57:37 +02:00
ade5624f31
All INetMIMEOutputSink instances use same fixed ctor arg values
...
Change-Id: I49126732be307b80270843c147d9cce4b3fdd2a3
2015-09-17 16:57:37 +02:00
bfff96fec8
Odd that this started out as STRING_MAXLEN
...
...rather than as NO_LINE_LENGTH_LIMIT, in
8ab086b6cc054501bfbf7ef6fa509c393691e860 "initial import"
Change-Id: I8772236e4ce1576f2d0d4d6c02800c4d569520a4
2015-09-17 16:57:36 +02:00
54ddc13bd2
Fold INetMIMEStringOutputSink into INetMIMEOutputSink base
...
Change-Id: I675e656b57fca90e42be2d924c102a995168984d
2015-09-17 16:57:36 +02:00
149384846b
No need for user-prov. INetContentTypeParameter ctor, use list-initialization
...
Change-Id: Ie116def9e5e90a59a82c3e8a4821eecd68eee64c
2015-09-17 16:57:35 +02:00
01d0f0f6ad
"unnamed namespaces don't work well yet" is no longer true
...
Change-Id: I7a04c2d04e3fc52982d83119755e0b349d232a47
2015-09-17 14:31:07 +02:00
1a9293242b
Remove unused INetMIMEMessage parts
...
Change-Id: Ica7d3e7e52ccdfe833ac10567c6f5f7bb7085dee
2015-09-10 23:04:35 +02:00
9371a5f0a0
More INetMIMEMessageStream clean up
...
Change-Id: Ibb2b93261e2d8ef370ac106766e39685a03a6ef3
2015-09-10 23:04:35 +02:00
82285ab5c9
Merge INetMessageIStream into INetMIMEMessageStream
...
Change-Id: Ic3d9cd117b3f911a7cb1317fc9d1d2e9d8f1ff42
2015-09-10 23:04:35 +02:00
4464e5dbca
No need for INetMIMEMessageStream encoding
...
...in the only use case in ODatabaseForm
Change-Id: I0282a9f60b05f279a11dcf1990e68b7e017ea3aa
2015-09-10 23:04:34 +02:00
40bcf53b5d
Remove unused INetMessageOStream functionality
...
Change-Id: I34ee4750f30635809b8e23cbf1bd0e16f269f549
2015-09-10 23:04:34 +02:00
e871b6a31a
Reduce INetMIMEMessage::EnableAttachChild to its only use case
...
Change-Id: I67221408d6b9d2aee942ca8bd39ca51da0209551
2015-09-10 23:04:33 +02:00
a7b38dcf93
Check for "multipart/" prefix
...
...instead of full-string compare; regression introduced with
c4927a1b76b728b2208c29d09dbf54e70bb26e13 "ByteString->rtl::OString[Buffer]"
erroneously replacing a call to ByteString::CompareIgnoreCaseToAscii(s,n) with a
call to OString::equalsIgnoreAsciiCase(s,n).
Change-Id: I473e3403910e22e43d7350afa88f9a8e103ebf1d
2015-09-10 23:04:33 +02:00
8ab005af96
Avoid pain when using selective debuginfo
...
Compile in the DbgUnhandledException function always.
Change-Id: I302954598e599e8db71967974b18ade54ca2de13
2015-09-08 19:37:58 +03:00
6a223b9acf
sot: don't leak uninitialized memory into temp file
...
Both valgrind and drmemory complain about this in
SdExportTest::testSwappedOutImageExport() via
SfxOleThumbnailProperty::ImplSave().
Syscall param pwrite64(buf) points to uninitialised byte(s)
UNINITIALIZED READ: reading 0x0455b1b4-0x0455b1c8 20 byte(s) within...
It appears that the stream writes out everything up to the seek position
anyway (otherwise the size check wouldn't work, with sparse files)
so make sure it's all zeroed.
Also fix SvMemoryStream::ReAllocateMemory() to zero it.
Change-Id: Id86dfa65ef6f7d1bba4810f121e01473c5fcf4c7
2015-08-31 16:37:17 +02:00
54644d657d
loplugin:stringconstant: OUStringBuffer: appendAscii -> append
...
Change-Id: Id44fa2989d13e8a8f98efa29d8ba093812adbd60
2015-08-31 08:01:01 +02:00
c1a9d01391
tdf#62525: use cow_wrapper for SvGlobalName
...
Convert the pimpled copy-on-write SvGlobalName class to use the
::o3tl::cow_wrapper using the default reference counting policy.
Change-Id: I7bceb06ddfb31ca5901e5e7d5d93dda494db945f
Reviewed-on: https://gerrit.libreoffice.org/18070
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de >
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de >
2015-08-30 12:55:17 +00:00
1e8b7cdbbd
this farcical staroffice 5.0 related junk can at least be const
...
Change-Id: I096d98f6e0cb61cacd9cd82a623f832b88ded1e6
2015-08-27 11:59:21 +01:00
475cbbb259
Remove redundant if (zero is already handled earlier)
...
Change-Id: Iaab5763d4fbde431bac6f7ecbf4527ad889b6891
2015-08-27 08:16:29 +02:00
01ed4bf52d
Avoid slightly silly warnings from Clang
...
Clang (at least the one from newest Xcode 7 Beta) warn both that
fResult "is used uninitialized whenever 'if' condition is false" *and*
that the very same "condition is always true".
Change-Id: I9e2424e7323046edbfe1af3c9f960df49e0809dd
2015-08-27 08:40:20 +03:00
a0ab7c31a2
Again add ability to change tint/shade of a color + unit test
...
Change-Id: I4c06290f09e5bfecd2c1de896e19cb5036a3a0e9
2015-08-27 08:30:49 +09:00
139b32b84c
Bin the fairly useless DbgDialog stuff and handle fallout
...
See (short) discussion on the mailing list, "How was it again, is the
DbgDialog useful?".
Change-Id: Ibde1eb13f16edf94f1f7aebd0befd1b0b171d5c4
2015-08-26 10:33:30 +03:00
5109114856
Put Line under tools namespace
...
Change-Id: I7442848951c0d4579fb2a2a3eef3bfed7135aac4
Reviewed-on: https://gerrit.libreoffice.org/17791
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com >
2015-08-17 06:30:01 +00:00
ef46917ff3
Put Polygon from tools under tools:: namespace
...
Polygon is one of these names that Clash with some system objects
A similar work has been done earlier with PolyPolygon.
Change-Id: Icf2217cb2906292b7275760f1a16be0e150312f5
Reviewed-on: https://gerrit.libreoffice.org/17789
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com >
2015-08-17 02:07:43 +00:00
286dfc2a72
loplugin: defaultparams
...
Change-Id: I50ba6a836473961d952ed88e56532501469c5368
2015-08-11 09:48:18 +02:00
aedd003086
tools: prefix members of SvStream
...
Change-Id: Iba845749d645bc1cf9eb6d6c41829717831bc487
2015-07-31 14:45:38 +02:00
a45827b230
loplugin:unusedmethods
...
Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971
Reviewed-on: https://gerrit.libreoffice.org/17378
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-30 06:23:00 +00:00
6a1f31898d
in remainingSize consider that its is possible to seek past the end
...
Change-Id: I1652244d5515629f1cd8f15f4c5b15f139dba0aa
2015-07-17 11:22:12 +01:00
21834f14c9
tools: replace boost::ptr_vector with std::unordered_map
...
Change-Id: I530c5f95dda9aa80654e3a2a20a2e236221e7305
2015-07-16 13:42:11 +02:00
