fc2590cfa1
Fix typos
...
Change-Id: Id81b16ff26283611f0b84929d831c827f847ab73
Reviewed-on: https://gerrit.libreoffice.org/24317
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2016-04-30 15:06:45 +00:00
43b4903db3
teach stylepolice plugin about ref-counted-pointer naming
...
Change-Id: I6e91d22fc1826038c05ddb6fc065563c6a250752
Reviewed-on: https://gerrit.libreoffice.org/24459
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-28 09:31:16 +00:00
81105d9534
-Werror,-Wvarargs
...
"passing an object that undergoes default argument promotion to 'va_start' has
undefined behavior [-Werror,-Wvarargs]"
just drop the variadic overload and use the one taking a WizardPath (i.e., a vector)
Change-Id: I6e389f60f8b7cb0633bf173bde69af1c5af86048
2016-04-27 13:47:30 +02:00
fe2bf7b059
tdf#99518 Use correct decimal separator
...
Change-Id: I39169e7c7344fcfd594a0e0d2ab0a762cc3d5829
Reviewed-on: https://gerrit.libreoffice.org/23961
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2016-04-27 00:29:42 +00:00
279f050554
Some more sal_Bool -> bool
...
Change-Id: I4df1afecfe4c554fa98060e6ba1507911323656c
2016-04-25 16:40:05 +02:00
adff28271b
the container document commands std::set can be static
...
Change-Id: I00558dad4b8206e5e2a7bf004e32196a15dba3cd
2016-04-25 09:21:44 +02:00
b2e2400736
no need to copy the list of available commands on every call
...
Change-Id: I131f34a94c998f3dd9fd7a457fb213778040c771
2016-04-25 09:18:12 +02:00
a82805f8f9
Kill comphelper::MakeMap
...
Change-Id: I97e9e79ef51e3d78f01b831dd3eee91218058823
Reviewed-on: https://gerrit.libreoffice.org/24344
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
Tested-by: Stephan Bergmann <sbergman@redhat.com >
2016-04-25 06:11:27 +00:00
2b68383e44
Kill comphelper::MakeSet
...
Change-Id: I2e5f8c2cd67406d9d275960a37c4aa45e283eec3
Reviewed-on: https://gerrit.libreoffice.org/24343
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
Tested-by: Stephan Bergmann <sbergman@redhat.com >
2016-04-25 06:11:10 +00:00
59dc694c9f
C++11: disable ctors instead of not implementing them (chart2)
...
replace the old declare and don't implement pattern
with C++11 delete keyword
Change-Id: I10b14cece4ecaddc5f96ee098b5fa36a8782a0fc
Reviewed-on: https://gerrit.libreoffice.org/24340
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2016-04-24 21:27:04 +00:00
e1af7f0c43
clang-tidy modernize-loop-convert in c*
...
Change-Id: I77d2548f8be97792660761e6156cd24734a95aaf
2016-04-21 11:03:55 +02:00
5abc669599
new plugin stylepolice
...
check for local variables which follow our member field naming
convention, which is highly confusing
Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-21 08:32:47 +02:00
08bb436ff9
loplugin:salbool: Automatic rewrite of sal_False/True
...
Change-Id: I1230a1785c61b8ef5dab97176e7c06600ac95a5b
2016-04-20 17:25:36 +02:00
79bffab708
Remove redundant comparison against sal_False
...
Change-Id: I6e5e5d730a8e7e3efc50472db08d0ed258ffbb3a
2016-04-20 17:25:33 +02:00
150ac9cf05
clean-up: unused using declarations and includes
...
Searched source for using declarations.
Checked if those symbols reappear in the source file,
even in comments or dead code but not in #include statements.
If they don't reappear, remove the declaration.
Remove includes whose symbol got removed.
Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0
Reviewed-on: https://gerrit.libreoffice.org/24148
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-18 07:25:24 +00:00
81c9d54db3
tdf#91794 removed OSL_DEBUG_LEVEL > 1 conditionals
...
Removed OSL_DEBUG_LEVEL > 1 conditionals to reduce the
problem of multiple debug levels
Change-Id: I453f74198e08308c3891e923ebaee58a276e34ad
Reviewed-on: https://gerrit.libreoffice.org/22616
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2016-04-14 09:25:38 +00:00
e7d3fa5804
loplugin:passstuffbyref in chart2
...
Change-Id: Id14015b1a02047c4d2e9d4ed4a9edfd0cb409c59
2016-04-14 09:21:41 +02:00
7816dd1bbb
Avoid reserved identifier
...
Change-Id: I8590b2c145a536872d692afcaa50279c99b3f974
2016-04-12 20:03:47 +02:00
9cfa0810bd
clang-tidy performance-unnecessary-value-param in chart2
...
Change-Id: Id33dce9714737dd28ce48c22f966c9747c2db20b
2016-04-12 11:25:18 +02:00
4c7ec9f112
cleanup: remove unused com/sun/star/uno includes
...
Sequence.h(xx), Any.h(xx) and Type.h(xx)
and remove unused using-declarations from these files.
Add a few missing includes provided by them.
Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4
Reviewed-on: https://gerrit.libreoffice.org/23805
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-12 06:38:26 +00:00
b8cd2221bc
cppcheck: noExplicitConstructor
...
Change-Id: Ie25240030fd848a5b30526746206bfd5fe543091
2016-04-11 10:07:06 +01:00
e5dd156a44
loplugin:constantparam
...
Change-Id: Ie690088d7a7d568703afd22f544628fc8012a7e1
2016-04-11 08:26:01 +02:00
25934decf8
tdf#94306 replace boost::noncopyable in chart2
...
Replace with C++11 delete copy-constructur
and copy-assignment.
Delete default-constructors when comments suggested it.
Change-Id: Ieeaf6ca998a4165d6eacf5e900c6a09aafdcfbe6
Reviewed-on: https://gerrit.libreoffice.org/23903
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de >
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2016-04-08 17:40:14 +00:00
a7ec6c29aa
loplugin:constantparam in chart2
...
Change-Id: I9adcf4516107aaa960463be13090c2ac15685e09
Reviewed-on: https://gerrit.libreoffice.org/23833
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-05 11:30:13 +00:00
3ada44f631
tdf99069: lock the solar mutex before updating sidebar
...
Change-Id: I55808b72bcebab95ead3e140c9da94596826c27d
Reviewed-on: https://gerrit.libreoffice.org/23811
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2016-04-04 17:09:55 +00:00
f7a75a66fa
cleanup: remove unused Reference.h(xx) includes
...
and unused using-declarations from Reference.h
Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19
Reviewed-on: https://gerrit.libreoffice.org/23735
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2016-04-02 19:01:24 +00:00
96c1ae1d8e
fix headless build
...
disables OpenGL and glew usage, lets --without-gui do what
--without-x did before and disables X related test
Change-Id: I680b47c9962a0d43c8ece593db0b82e347ceebdb
Reviewed-on: https://gerrit.libreoffice.org/23474
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Oliver Specht <oliver.specht@cib.de >
2016-03-25 11:05:47 +00:00
a112d3dc70
Move clipboard stuff to the top like in other modules
...
Change-Id: I0e07e58f058ce7dde57277868597a56273d3b5ce
2016-03-21 13:49:30 +02:00
2d4e9abc07
tdf#93837 chart2: Convert shape context menus to xml
...
Change-Id: Ie0589c576b26dd74b9bc16d78a37a01c9bb2985e
2016-03-21 13:48:16 +02:00
ce66911720
loplugin:constantparam in svtools
...
Change-Id: I1a3c4a36e29a6712c589ffd3aaada593880d978d
Reviewed-on: https://gerrit.libreoffice.org/23304
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2016-03-17 10:28:09 +00:00
8353667d35
com::sun::star->css in chart2
...
Change-Id: I04320d32d6d5c54e461cfabef58645f8b772bc69
2016-03-14 13:43:38 +02:00
9048e7f587
Resolves: tdf#98390 ChartAreaPanel throw during ctor
...
after a ChartSidebarModifyListener pointing to it has been created and added to
the model, so ChartSidebarModifyListeners exist which point to a dead
ChartAreaPanel which has never even completed its ctor
workaround this by checking that properties it querys for exist
before accessing them and triggering the IllegalProperty throw
Change-Id: I0c251360714592c78132c0867903216f3866489a
2016-03-11 12:19:37 +00:00
ff745fc0d9
loplugin:constantparam in svx
...
Change-Id: Ib2a432fc334898c75ab5e5cf629a21fd310bd467
2016-03-09 10:07:45 +02:00
5f33f600f9
-Werror=unused-but-set-variable
...
since b2fb84499e1f75735e8fd90bc2eece3fed9af5f6 "loplugin:write only fields"
Change-Id: I610e88373ebca576e5607b224ad648c1d3e47bab
2016-03-07 14:04:45 +01:00
b2fb84499e
loplugin:write only fields
...
Change-Id: Ia0fb487c5590e096659b81f76c4dc543e184c59c
2016-03-07 14:55:55 +02:00
f69585c354
loplugin:unuseddefaultparams in chart2
...
Change-Id: I03a3580fdbd1f6cf08af329b07edcfe09ecbb9aa
2016-03-02 07:57:38 +02:00
db8067145f
loplugin:write only fields
...
Change-Id: I44f249a17d0a510ec63a488b656d57a1a392f821
2016-02-22 14:34:21 +02:00
a3c70e760f
Fix missing iterator include on MSVC 14.0
...
Change-Id: I55de612aef52038fd9979426950d4ae4131ca586
Reviewed-on: https://gerrit.libreoffice.org/22448
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: David Ostrovsky <david@ostrovsky.org >
2016-02-17 23:43:45 +00:00
0f8ec3036f
[API CHANGE] add operator==/!= to UNO structs
...
this is useful now that we are storing UNO structs in std::vector
Change-Id: Ic558bcd669bd2b3cdf9eb8393269eb906ac52369
Reviewed-on: https://gerrit.libreoffice.org/22257
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-02-11 06:22:28 +00:00
35f4c0d242
boost::cref->std::cref
...
Change-Id: I2a4d2052c48f35d69cea2aed2e98079ad8d98a02
Reviewed-on: https://gerrit.libreoffice.org/21982
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-02-01 11:00:17 +00:00
1ef9f3988e
unnecessary use of OUString constructor
...
Change-Id: Idd31b0a53c8318af69bbcd32f6798721ec8eb8e1
Reviewed-on: https://gerrit.libreoffice.org/21945
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-01-31 12:04:02 +00:00
3187193a61
tools: rename FontUnderline to FontLineStyle
...
Change-Id: I4750ad8569a1003b2f8c29052f3e25003ee433ca
Reviewed-on: https://gerrit.libreoffice.org/21892
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com >
2016-01-31 04:31:13 +00:00
752cd07d08
InterfaceContainer2 with vector instead of Sequence
...
create an InterfaceContainer2 class to replace InterfaceContainer.
It uses a std::vector instead of a Sequence for the mutable listener
list, which provides far better performance.
Switch all our internal use-sites to the new class.
Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
2016-01-25 08:52:03 +02:00
5659b68be3
vcl: rename Font::GetFamily to Font::GetFamilyType
...
Change-Id: Ie427a43bd126dcdd89c6f66582736e67130f2254
Reviewed-on: https://gerrit.libreoffice.org/21633
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com >
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com >
2016-01-21 06:22:01 +00:00
cb20f46895
vcl: change Font::SetName() to Font::SetFamilyName()
...
Change-Id: I9b7bd1ec25955981ebcb9085579cbb9fbaa802d5
Reviewed-on: https://gerrit.libreoffice.org/21560
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com >
2016-01-18 05:24:46 +00:00
28c96fc255
vcl: rename Font::GetName to Font::GetFamilyName
...
Change-Id: Ie20871a3078bf875c1782b7761d60591a9c9704f
Reviewed-on: https://gerrit.libreoffice.org/21529
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com >
2016-01-17 23:35:37 +00:00
45654a1d4d
revert vcl patch series that brok Mac and Windows
...
revert:
9bc2f3de8672e812f3a67541c6d7069b434a7e42
vcl: add comment about ImplFontMetric::{Get|Set}LineHeight()
26371f105bc44e04469ec03fc5bb12505e651c6b
vcl: FontAttributes::GetSlantType() -> FontAttributes::GetItalic()
2dd0b4317372b8022efe3911b38b4fa02956d8b9
vcl: font.hxx and metric.hxx cleanup, make ctors explicit and the dtor virtual
5ab13bf3ead3539e4ad847656da81e7eb6029652
vcl: tabify font.hxx
f99550dae55e40e49bf9c9875053fe2abb4c71ca
vcl: change Font::SetName() to Font::SetFamilyName()
2b297116cb6bb1061c43e5714e2609c8ee9f57d2
vcl: rename Font::GetName to Font::GetFamilyName
Change-Id: I23f38921187d66b970ca815eb30dda4222a2da62
2016-01-16 12:20:45 -06:00
f99550dae5
vcl: change Font::SetName() to Font::SetFamilyName()
...
Change-Id: I54a4036544c680c4a49607677af776aa7a433fbc
Reviewed-on: https://gerrit.libreoffice.org/21510
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com >
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com >
2016-01-16 16:12:14 +00:00
2b297116cb
vcl: rename Font::GetName to Font::GetFamilyName
...
Change-Id: I83927e0992dfe0a2a79d139818a9f45d3761aae5
Reviewed-on: https://gerrit.libreoffice.org/21509
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com >
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com >
2016-01-16 16:11:28 +00:00
608dee4f5f
loplugin:privatebase: Make various derivations public
...
...assuming they were implicitly made private by accident rather than by design.
(And private derivation can cause unexpected failure of dynamic_cast, cf.
63b67ab5cab8cf7576a68cabe5fb1a42c6ad800c "Use public derivation, and remove
then-unnecessary downcasts.")
Change-Id: Id821afba34fd2f155e30fac903567707e46d1fde
2016-01-11 13:17:10 +01:00
