a05ab9ef5e
Remove unnecessary setBOOL, makeBoolAny
...
Change-Id: Id82c3f352fcc2d4dafad877517098cb6f5d046d4
2016-05-03 11:20:51 +02:00
506c929a0a
Fix typos
...
Change-Id: Ifb7c33d6052efe5ea8a1e0e10b3178073cd29ca0
Reviewed-on: https://gerrit.libreoffice.org/24536
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2016-05-01 09:51:41 +00:00
715d4d803a
Avoid reserved identifiers
...
Change-Id: Icc658a3adce2e93c3cc4e8a88689f462b1c7c8a1
2016-04-22 10:22:00 +02:00
bfb185c408
loplugin:salbool: Automatic rewrite of sal_False/True
...
Change-Id: I74cf43df85a878ee9af69901b2535f63461cb61e
2016-04-20 17:25:41 +02:00
150ac9cf05
clean-up: unused using declarations and includes
...
Searched source for using declarations.
Checked if those symbols reappear in the source file,
even in comments or dead code but not in #include statements.
If they don't reappear, remove the declaration.
Remove includes whose symbol got removed.
Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0
Reviewed-on: https://gerrit.libreoffice.org/24148
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-18 07:25:24 +00:00
62633dfe02
clang-tidy performance-unnecessary-value-param in various
...
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907
Reviewed-on: https://gerrit.libreoffice.org/24019
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-14 11:37:19 +00:00
b8eb294651
loplugin:passstuffbyref in various
...
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
2016-04-14 10:24:47 +02:00
c03a11b8f0
tdf#97087 Give comprehensible names to timers
...
Timers and idles should have programmer comprehensible, unique names
Change-Id: I837d1890c687936f8a31278c0102391e6f87212d
Reviewed-on: https://gerrit.libreoffice.org/23917
Reviewed-by: Michael Meeks <michael.meeks@collabora.com >
Tested-by: Michael Meeks <michael.meeks@collabora.com >
Tested-by: Jenkins <ci@libreoffice.org >
2016-04-13 08:06:29 +00:00
4c7ec9f112
cleanup: remove unused com/sun/star/uno includes
...
Sequence.h(xx), Any.h(xx) and Type.h(xx)
and remove unused using-declarations from these files.
Add a few missing includes provided by them.
Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4
Reviewed-on: https://gerrit.libreoffice.org/23805
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-12 06:38:26 +00:00
9866efe3e5
loplugin:constantparam
...
Change-Id: I821ed77a6c6014c9a82d31a4b117ed6f1b4abf18
Reviewed-on: https://gerrit.libreoffice.org/23832
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-05 11:29:54 +00:00
f7a75a66fa
cleanup: remove unused Reference.h(xx) includes
...
and unused using-declarations from Reference.h
Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19
Reviewed-on: https://gerrit.libreoffice.org/23735
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2016-04-02 19:01:24 +00:00
929eab2164
sequence->vector in forms
...
Change-Id: Iea09367a51af8d0003a3ae58f8e7e0e825906367
Reviewed-on: https://gerrit.libreoffice.org/23691
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-01 07:33:50 +00:00
20ba5d464a
tdf#97966 Drop 'static' keywords
...
Including no keywords from extern "C" blocks
Change-Id: I8bcd7e8a492ee4dbfa5141416c7c038a1391cf20
Reviewed-on: https://gerrit.libreoffice.org/23673
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
Tested-by: Stephan Bergmann <sbergman@redhat.com >
2016-04-01 06:45:36 +00:00
aec2477b41
loplugin:constantparam in forms
...
Change-Id: Iebce160fd6c3de63ba179d747768fd4cf420baec
2016-03-23 10:19:43 +02:00
218cd09611
inline some use-once macros
...
Change-Id: I7ebd8fe70b083a772118a1aab8cdfbf795d6f1e5
Reviewed-on: https://gerrit.libreoffice.org/23235
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-03-14 11:06:48 +00:00
b0e18a68c8
loplugin:unuseddefaultparam in forms
...
Change-Id: I5a2b50163acfda3878fe5625a605e3437a7cc700
2016-03-02 07:57:38 +02:00
ccb8b83070
convert FilterComponent to scoped enum
...
and simplify the overly-general logic in FilterManager
Change-Id: I2cbd9db6a53894cd13713a5cc0d1807cec456848
2016-02-25 13:50:25 +02:00
bf7690bc1b
convert EComposeRule to scoped enum
...
Change-Id: I5a2e4f6f6f0f353c75dff85e865608b12c2104f9
2016-02-25 13:50:25 +02:00
c45d3badc9
new loplugin: commaoperator
...
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
2016-02-23 08:08:56 +02:00
a238b1f8d3
Remove excess newlines
...
A ridiculously fast way of doing this is:
for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
--exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
perl -0777 -i -pe 's/^
{3,}/
/gm' $i
done
Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com >
2016-02-09 08:18:05 +00:00
538f276ae0
Formatting changes across all modules
...
+ Removed comment cruft
+ Tab formatting in number of files
+ Some commented out code removed
+ Tab characters replaced with spaces
+ Newline cleanup in quite a few files
+ Tweak header guard #endifs
Change-Id: I3208ff2f047da890edcc49b73389aca22442f5fc
Reviewed-on: https://gerrit.libreoffice.org/22221
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com >
2016-02-09 08:11:34 +00:00
88730cdae3
vcl: bmpacc.hxx -> bitmapaccess.hxx
...
Change-Id: I4bb19d6103c4a6a902d86b62a857e3478493924c
2016-02-06 21:04:09 +11:00
534b2a4b58
Fix typos
...
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3
Reviewed-on: https://gerrit.libreoffice.org/21797
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com >
2016-02-05 06:48:38 +00:00
752cd07d08
InterfaceContainer2 with vector instead of Sequence
...
create an InterfaceContainer2 class to replace InterfaceContainer.
It uses a std::vector instead of a Sequence for the mutable listener
list, which provides far better performance.
Switch all our internal use-sites to the new class.
Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
2016-01-25 08:52:03 +02:00
aa4dc89352
loplugin:unusedmethods unused return value in forms
...
Change-Id: I9da3e72ca12e040e7fb5bea7ccaa071edfd34f27
2016-01-11 13:14:08 +02:00
64d624b651
Fix typos
...
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com >
2016-01-10 14:17:20 +00:00
5b339db1ab
loplugin:unusedfields in forms
...
Change-Id: I875c07dcfc9fd9537ced1facd88ac712a7dacbbd
2015-12-23 08:13:53 +02:00
ea297dd202
use comphelper::containerToSequence()
...
Change-Id: Ic4d3bcec7bda300bca6911a7472cafafdf12f5bd
2015-12-03 13:57:23 +02:00
d2df035740
loplugin:unusedfields
...
Change-Id: Ife94d488ead512abc6d137a0df74298bac67185d
2015-11-30 10:34:38 +02:00
fafac0d248
loplugin:unusedfields forms,formula,fpicker,framework
...
Change-Id: Ic7af56ac801c1e5b3fcf3c4e8413656e96220279
2015-11-20 15:07:05 +02:00
2554efabb6
use comphelper::containerToSequence
...
in chart2, we remove a local equivalent of the method
Change-Id: I25129a3d1ea1dd724eb9cd38a57be37a78b3d100
2015-11-19 09:33:29 +02:00
96c26b0d9d
use initialiser for Sequence<OUString>
...
using variations of:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\;
\s*OUString\* pArray.*;
.*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g"
Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3
Reviewed-on: https://gerrit.libreoffice.org/19971
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-15 12:20:39 +00:00
11d3652418
loplugin:nullptr (automatic rewrite)
...
Change-Id: Ic67c3138ca66c6b6d6fcf76b09d4581e23f51f8d
2015-11-10 10:31:26 +01:00
abf49c259b
coverity#1338244 Uncaught exception
...
Change-Id: If46689d2b9cf8f6cb76d61296332444d4c3fb5fd
2015-11-06 12:15:49 +00:00
b2d54b09c6
loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)
...
Change-Id: I5b543edcae47c9ae4c90dba8082127fcb2b9b938
2015-11-06 09:36:00 +01:00
1b41208608
use uno::Reference::set method instead of assignment
...
Change-Id: I3d94c94a9829161663a7ed18421ace38ce95a659
Reviewed-on: https://gerrit.libreoffice.org/19733
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-02 06:17:21 +00:00
b5db48ada1
no need to use OUString constructor in call to createInstance
...
Change-Id: Iaf3d83ba1490cb1d97a5bd4d1f7cd6943d4a7296
Reviewed-on: https://gerrit.libreoffice.org/19704
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-01 15:25:43 +00:00
e25669fced
don't allocate uno::Reference on the heap
...
There is no point, since it's the size of a pointer anyway
(found by temporarily making the new operator in uno::Reference
deleted).
Change-Id: I62a8b957fef9184f65d705600acfdab4116dcb34
Reviewed-on: https://gerrit.libreoffice.org/19603
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-27 12:48:50 +00:00
3d784c4af6
remove extra spaces around ::
...
just makes it harder to grep for methods
Change-Id: I0925db2f9284972fcf7e1e3adf90cbe21f69eb15
2015-10-26 09:12:05 +02:00
2f3ea8dfbc
refactor out some com::sun::star typedefs
...
which mostly serve to make the code harder to read
Change-Id: Ia2a83fee9f850ab6f0bea6305ce8600d6b785fe8
2015-10-21 14:17:56 +02:00
0e8a40e8b8
calling IsSet() before Call() on Link<> is unnecessary
...
the Call() already does a check
Found with:
git grep -A 1 -w 'IsSet()'
| grep -B 1 '.Call('
| grep ':'
| cut -d ':' -f 1
Change-Id: Ia7248f5d62640b75f705e539c3d1183e39c0d847
2015-10-15 12:29:01 +02:00
b36963c0a6
Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
...
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
bff4c13475
Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY code
...
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-12 17:52:26 +02:00
7ba7a974f6
cppcheck: noExplicitConstructor
...
Change-Id: I32c6728ce7423fd997cdbec66feb8a6ba39948d2
2015-10-07 15:11:03 +01:00
56a5734b06
cppcheck: noExplicitConstructor
...
Change-Id: I80950aaf1385bd76b012eab7866fd16848751f45
2015-10-05 20:30:59 +01:00
19b85e90ab
Fix typos
...
Change-Id: Ib30f4e5f16518cbbe71cf03998513ebd8c2a4d1a
Reviewed-on: https://gerrit.libreoffice.org/18949
Reviewed-by: Oliver Specht <oliver.specht@cib.de >
Tested-by: Oliver Specht <oliver.specht@cib.de >
2015-10-02 07:55:15 +00:00
de020fc9c3
com::sun::star->css in forms/
...
Change-Id: I1c09e88f839bdf11c6ff809ec95769e8f729c7cd
2015-10-02 08:20:11 +02:00
3a00aaef2a
boost->std
...
Change-Id: Ie490bf2c6921f393bdeed96b1a8815996b701bf0
Reviewed-on: https://gerrit.libreoffice.org/18670
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-09-18 07:59:14 +00:00
0535f42e5f
convert Link<> to typed
...
Change-Id: Ic3ce7783614d90a34f9c4414bbc7df9774091805
2015-09-17 12:22:47 +02:00
82285ab5c9
Merge INetMessageIStream into INetMIMEMessageStream
...
Change-Id: Ic3d9cd117b3f911a7cb1317fc9d1d2e9d8f1ff42
2015-09-10 23:04:35 +02:00