Commit Graph

1852 Commits

Author SHA1 Message Date
43cd14d317 Fix the Windows build breakage by reorganizing svtools headers.
Also removed a fair amount of implicit inline methods to promote use
of more forward declaration.

Change-Id: I5ad21f0d7abc85281708b7e87f1036b02a053627
2012-11-16 16:18:37 -05:00
d2f6a87ac7 fdo#46808, use service constructor for i18n::NumberFormatMapper
Also create a utility constructor for LocaleDataWrapper, which
simplifies many of the calling sites.

Change-Id: Ic8510b51c4201fa17fc0620e18d3e258e43636ba
2012-11-15 08:28:44 +01:00
5837402fb1 fdo#46808, use service constructor for ucb::SimpleFileAccess
I upgraded the service to return XSimpleFileAccess3, since it
already implemented that interface, and it's backwards
compatible.

Change-Id: I40001a46048bd21a23b6a2f58a95376f06fc634b
2012-11-15 08:28:44 +01:00
27239ad230 basic: String -> OUString
Change-Id: I42479b4bade5111e38d69f04c889c166f340d5ba
2012-11-07 02:14:53 -06:00
0666e43c45 fdo#46808, use service constructor for i18n::CharacterClassification
Change-Id: I0499ad7de27b1539e97f01ab8aa0ef2d6713ae76
2012-11-05 18:05:00 +01:00
be968802f2 convert basic dialog to .ui
Change-Id: I1ed45e5990aca4be8b499fe300d7d43fda16bd6a
2012-11-05 10:36:28 +00:00
d92814f462 basic: preliminary cosmetic clean-up
parsing 1000s of line of code is hard enough without having to fight
with weird indentation and irregular formatting.

So as the review progress, in order to follow the code, cosmetic changes
were made...

In order to minimize the task of the reviewers and allow them to
concentrate on what matter, an effort is made to collect these
cosmetic changes into this separate commit.

Change-Id: I3c9b04a0150d0d0a048c2e976fe24de4f2b6b98a
2012-11-03 20:24:28 -05:00
4a11a47103 trivial empty-init String::Fill -> comphelper::padToLength
Change-Id: I6c41b8f4d3ad739eff545063bd1f8fe8f4fba65e
2012-10-30 00:05:59 +00:00
b596ce9bb1 OUString cleanup finished in basctl
Change-Id: I6d18f5cde7866828ca95ccff702eb86d2e40c58d
Reviewed-on: https://gerrit.libreoffice.org/925
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2012-10-27 15:48:27 +00:00
fe6913b968 OUString cleanup and some identation
Change-Id: Id222047750b7527e35977b73213ceeb12a53b57a
Reviewed-on: https://gerrit.libreoffice.org/924
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2012-10-27 15:42:31 +00:00
a4b822e5e3 ::rtl::OUString -> OUString in basctl
Change-Id: Ief0083c0274c573fce62c32dfae35a647804b20e
Reviewed-on: https://gerrit.libreoffice.org/900
Reviewed-by: Petr Mladek <pmladek@suse.cz>
Tested-by: Petr Mladek <pmladek@suse.cz>
2012-10-26 10:57:12 +00:00
008c0732ba More ::rtl::OUString -> OUString in basctl
Change-Id: Ia68b74d06ffe533bcc302fb5094267e0efae6faa
Reviewed-on: https://gerrit.libreoffice.org/901
Reviewed-by: Petr Mladek <pmladek@suse.cz>
Tested-by: Petr Mladek <pmladek@suse.cz>
2012-10-26 10:49:40 +00:00
c7bac4da02 XubString->OUString
Change-Id: I5835696a3246b4d8f401a1617d2b53ec8c7c5626
2012-10-25 12:04:26 +01:00
8aa5946afe fdo#46808, Adapt packages::manifest::ManifestWriter UNO service to new style
The service already existed, it just did not have an IDL file

Change-Id: I04c617a97262e9cc96af17fcae9cc084245c0149
2012-10-23 14:16:09 +02:00
5aa2cd1d3f fdo#46808, use service constructor for uri::UriReferenceFactory
Change-Id: I4e72bf5880fa28cb96d93ede7730a63220af7fa6
2012-10-23 11:45:47 +02:00
c988da288e fdo#46808, Adapt ui::dialogs::FolderPicker UNO service to new style
Create a merged XFolderPicker2 interface for this service to implement.
Which is backwards-compatible, but does not require creating a new service.

Change-Id: I4a2c2a8d491a8d5633c19ddcea547f0efe75b91d
2012-10-23 10:26:40 +02:00
0397c4b02d Some ::rtl::OUString to OUString in basctl
Change-Id: Ifbc60c2e6f2906cc0b7a3ea3fb9dfa1a8421d6a2
Reviewed-on: https://gerrit.libreoffice.org/896
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2012-10-22 20:01:51 +00:00
41145f51c9 OUString cleanup in basctl
Change-Id: I9644427f6d3bb4b2f488325eb520b365115a8e82
Reviewed-on: https://gerrit.libreoffice.org/892
Reviewed-by: Ivan Timofeev <timofeev.i.s@gmail.com>
Tested-by: Ivan Timofeev <timofeev.i.s@gmail.com>
2012-10-22 17:43:35 +00:00
49e5e750b5 Merge SvLBoxTreeList and SvTreeList.
Change-Id: I318ff6f1009b1aaa7d0bd3abb250f92fb51a21cd
2012-10-19 15:25:28 +02:00
4b313fd566 Merge SvListEntry and SvLBoxEntry into SvTreeListEntry.
Change-Id: I89cfc8c1288c00674fe64e791c149743d377d5ee
2012-10-19 11:45:36 +02:00
7841730416 more explicit char* => OUString conversion in basctl
it will hopefully fix build on the Windows tinderbox
2012-10-18 11:39:10 +02:00
e6b28a09f4 More rtl::OUString cleanup in basctl
Change-Id: Ife2754b17e111c0e129670b95bd2e16d81ad906c
Reviewed-on: https://gerrit.libreoffice.org/873
Reviewed-by: Petr Mladek <pmladek@suse.cz>
Tested-by: Petr Mladek <pmladek@suse.cz>
2012-10-16 14:18:09 +00:00
20e7a9bda9 rtl::OUString cleanup in basctl
Change-Id: If57c184b355224f31fdf7872ab1f52c034e5c7f0
Reviewed-on: https://gerrit.libreoffice.org/872
Reviewed-by: Olivier Hallot <olivier.hallot@alta.org.br>
Tested-by: Olivier Hallot <olivier.hallot@alta.org.br>
2012-10-16 07:59:27 +00:00
5ad86ef1ca Use isEmpty().
Change-Id: I0b2a30384cbbe3f05d25968c4e7e19e84c23e267
2012-10-15 13:29:12 +02:00
08ec85d064 fix String->OUString conversion
Change-Id: Icc21b8998f205b635a21275ea4355824eca83a60
2012-10-13 13:54:29 +04:00
f50f9c4341 Review corrections in basctl/.../basobj3.cxx
Change-Id: I905e85ce9d754047ad287c9dd3caa92427b25b0d
2012-10-13 14:11:43 +05:30
ceb06a8f09 766 gerrit patch, fix appendAscii in bastype2.cxx
Change-Id: I4409d1b0585a8c52cba14d1e67ccf776c6070c8a
Reviewed-on: https://gerrit.libreoffice.org/854
Reviewed-by: Olivier Hallot <olivier.hallot@alta.org.br>
Tested-by: Olivier Hallot <olivier.hallot@alta.org.br>
2012-10-12 14:50:13 +00:00
ac7acb0ab1 Merged SvTreeListBox and SvLBox.
There is no reason to keep SvLBox separate.

Change-Id: I0b34aa8f8ca539d4f4f0f9cea9fa9b8faec241e8
2012-10-11 23:35:15 -04:00
7b34748b1b Some OUString and RTL_CONST refactoring
Change-Id: I27709f12ef6e3448ed457bd0e9f2056979ba0291
2012-10-09 20:05:31 +05:30
9c6c53db83 ::rtl::OUString to OUString in basctl
Change-Id: If6a53fd69f8a99bafc7fc324911132dd51e67266
2012-10-09 20:04:09 +05:30
d3e08f2574 More ::rtl::OUString to OUString in basctl
Change-Id: Ie27a55e933462c644f315d0123978082054d79af
2012-10-09 20:02:31 +05:30
bb414e9eee rtl::OUString to OUString in basctl
Change-Id: Iaa56c5f8a15032c3102ad58011c80e3c86fe287c
2012-10-09 20:00:24 +05:30
b29ecc914b More ::rtl::OUString cleanup in basctl
Change-Id: If7cefe8d2e188e65a465a25a5d5f77e6daebcd17
Reviewed-on: https://gerrit.libreoffice.org/760
Reviewed-by: Olivier Hallot <olivier.hallot@alta.org.br>
Tested-by: Olivier Hallot <olivier.hallot@alta.org.br>
2012-10-05 00:58:00 +00:00
554a45f266 ::rtl::OUString to OUString in basctl
Change-Id: I34228049e15ee8a899a4c5e1484d7ed3bc541dd4
Reviewed-on: https://gerrit.libreoffice.org/748
Reviewed-by: Olivier Hallot <olivier.hallot@alta.org.br>
Tested-by: Olivier Hallot <olivier.hallot@alta.org.br>
2012-10-05 00:54:07 +00:00
dd11a1e57a Fixes/improvements on previous commit
* UUIInteractionHandler still needs to implement XInitialization.

* Moved ambiguating InteractionHandler typedef out of the way.

* Removed InteractionHandler.createDefault, as it was originally stated that "it
  is strongly recommended that [the "Parent"] property is supplied."

* Added back documentation about Parent and Context.

* Simplified some call-sites to directly use XInteractionHandler2.

Change-Id: I1029b8f3cf079171c75920cafaaa44b5bbada883
2012-10-04 14:42:52 +02:00
c25cb8a641 fdo#46808, Adapt task::InteractionHandler UNO service to new style
Since we don't need to expose XInitialisation, we can make the new-style
service implement XInteractionHandler2.

Change-Id: Ib27beed1c12df17592c6472d6f58c233d2c41558
2012-10-04 14:42:52 +02:00
db1af9a434 OUString and RTL_CONSTASCII_US... cleanup in basctl
Change-Id: I440d245d013873ec2830280ad01a4d0625fc4c1a
Reviewed-on: https://gerrit.libreoffice.org/741
Reviewed-by: Olivier Hallot <olivier.hallot@alta.org.br>
Tested-by: Olivier Hallot <olivier.hallot@alta.org.br>
2012-10-03 23:10:01 +00:00
7b089e2ccc Use prefix
Change-Id: Ide081f18af82e68b55d6d48168a0a567e5e64f04
2012-10-01 21:54:57 +03:00
36a2db3722 Replace usage of rtl_*Memory with equivalent from string.h
Change-Id: I50ffc10f007f03c3252ef0196b59b881429cc159
Reviewed-on: https://gerrit.libreoffice.org/734
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-10-01 18:48:05 +00:00
c2ca6fabd1 Use comphelper::getComponentContext
...and some further clean up.

Change-Id: Id294c0f38fe0041646fc86cacbd2e19734c746a9
2012-09-29 18:18:28 +02:00
6cb080ff91 ::rtl::OUString to OUString in basctl
Change-Id: I7be699102eab9cbf7184a5777a4b161db885adec
Reviewed-on: https://gerrit.libreoffice.org/711
Reviewed-by: Olivier Hallot <olivier.hallot@alta.org.br>
Tested-by: Olivier Hallot <olivier.hallot@alta.org.br>
2012-09-28 10:47:07 +00:00
87b5cdd5ed convert writer, draw, impress, calc and starmath printer dialogs
to new-style widget layout mostly described in .ui format

Change-Id: I8ead53a246a8ac3e2d446d158f06d7e2e436ce60
2012-09-28 08:48:44 +01:00
1a42e2458b ::rtl::OUString cleanup in basctl
Change-Id: Icb6f04d6ad22f1652abbb399beb08645daf8b9c9
Reviewed-on: https://gerrit.libreoffice.org/705
Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>
2012-09-27 12:53:49 +00:00
f25adb4954 String to OUString in basctl
Change-Id: I52ce4fcf4b02746df898c7fbbf57a58b274dd0b2
Reviewed-on: https://gerrit.libreoffice.org/706
Tested-by: Noel Power <noel.power@suse.com>
Reviewed-by: Noel Power <noel.power@suse.com>
2012-09-27 12:53:26 +00:00
cd693ff598 fdo#46808, Adapt frame::GlobalEventBroadcaster UNO service to new style
Create a merged XGlobalEventBroadcaster interface for this service to implement.
Which is backwards-compatible, but does not require creating a new service.

Also add two interfaces to the IDL, which the service already implemented,
and existing client code already used.

Change-Id: Ib7a9a30c0e50146ef621f3fe5227f8aad3190516
2012-09-27 10:30:42 +02:00
750fc20611 replace remaining InterlockedCount() with inlined version
Change-Id: Ifcfa48fc87f905a91470a5b0fd597b02f220784c
Reviewed-on: https://gerrit.libreoffice.org/671
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-09-25 01:55:38 +00:00
7528e11e37 callcatcher: update unused code lists
Change-Id: I58bad0806354eff2e91370ab3395199fa8691764
2012-09-24 16:35:21 +01:00
57d2f9b774 ::rtl::OUString to OUString in basctl
Change-Id: I3fc3d463fbaefe31b3541502c9f3dfbd4d1db4f9
Reviewed-on: https://gerrit.libreoffice.org/678
Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>
2012-09-24 10:51:42 +00:00
03a9f139bd ComponentContext::getUnoContext -> getComponentContext simplification
...and some further clean-up.

Change-Id: If5dce53e382b56390c502d0d0d93fc06cbfe33ea
2012-09-19 13:16:38 +02:00
9ac86f484b Improvement on previous commit, UCB clean up
* As UCB is only ever initialized with "Local"/"Office", remove this
  configuration vector completely.  The "create" ctor creates an instance
  internally initialized with those "Local"/"Office" keys.  Special (test) code
  can still instantiate an uninitialized one via plain createInstance.  And for
  backwards compatilibity process startup still ensures to create an initialized
  instance early, in case there is still code out there (in extensions) that
  later calls plain createInstance and expects to get the already-initialized
  (single) instance.

* XInitialization is an "implementation detail" of the UniversalContentBroker
  service, do not expose in XUniversalContentBroker.

* ucbhelper/configurationkeys.hxx is no longer needed and is removed.

* ucbhelper/contentbroker.hxx is an empty wrapper and is removed; however, that
  requires ucbhelper::Content constructors to take explicit XComponentContext
  arguments now.

* The only remaining code in ucbhelper/source/client/contentbroker.cxx is
  Android-only InitUCBHelper.  Is that relevant still?

Change-Id: I3f7bddd0456bffbcd13590c66d9011915c760f28
2012-09-14 18:24:49 +02:00