Commit Graph

3009 Commits

Author SHA1 Message Date
160cfb5e5e Bin the HACK() sillyness
Change-Id: Ieeebc4098404fa006d66bb8b656172a4348b1dc1
2012-11-19 21:23:27 +02:00
cc63555fd0 PutEntry familly of functions use consistent pairing OUString/sal_Int32
Change-Id: I23ae9d3e8bf71ef9ece75ea013d18c36ab2e69d4
2012-11-18 19:57:23 -06:00
e3e7dfa011 basic: fix OUString copy overrun in Mid()
Change-Id: I91cdd3a52917b89ab2a452e0eeb7a9e00dc35e8b
Reported-by: vmiklos@suse.cz
2012-11-18 02:50:14 -06:00
5837402fb1 fdo#46808, use service constructor for ucb::SimpleFileAccess
I upgraded the service to return XSimpleFileAccess3, since it
already implemented that interface, and it's backwards
compatible.

Change-Id: I40001a46048bd21a23b6a2f58a95376f06fc634b
2012-11-15 08:28:44 +01:00
fc5bb7d477 Clean up
Also, avoid global static data in sb lib, so that gengal.bin now also works well
on Mac OS X, cf. 12fa9ece663f24eff44197befe546a92e6c90724 "Avoid global static
data."

Change-Id: I23f2a7abc0c06a752ded1c1c64619b3aab009190
2012-11-14 13:32:28 +01:00
c3edb00e13 Report errors for invalid DateAdd/Diff/Part Add parameter values
...so that e.g.,

  DateAdd("x", 1, "1/31/2004")

(where "x" is not in the list of valid values for the Add parameter, "yyyy",
"q", "m", etc.) leads to a Basic runtime error rather than going into a
seemingly endless while(nNewMonth>nTargetMonth) loop at the end of
RTLFUNC(DateAdd) (basic/source/runtime/methods.cxx).

Change-Id: I15c3bdb62723ffddf36ff2396ffb294369d93ff8
2012-11-14 13:32:27 +01:00
af452fda33 fix more warning C4804 unsafe use of type bool
... from commit bbf1bcd9ad9cc0368aef4a4de41e9538f6ad91b0

Change-Id: Ic8e52f6848e09a274133f2d8fd1c4044cae4b039
2012-11-08 18:54:01 +01:00
d6a21d8761 BasicScriptListener_Impl::firing_impl: actually this is the default
Change-Id: I0fdb522a1119da4a75094db86217449e9d940d19
2012-11-07 18:37:16 +01:00
a166418b48 basic: fix String -> OUString conversion in BasicScriptListener_Impl
Regression from commit ac476e78848ad02fd399633acbe9cb72e40d1235, the
second parameter of OUString::copy() is not the end position, but the
length. In practice this makes xray usable again.

Change-Id: I9f345648c851b61e2e3c581bc605af7df4c12c87
2012-11-07 18:25:14 +01:00
f0e797a351 basic: adapt dllmgr-x64.cxx to OUString changes
Change-Id: I9e5ff5be1f001a9f55953fd516fb5ef7fe94bf44
2012-11-07 12:18:39 +01:00
7aa973919d Fix String -> OUString fallout
Change-Id: I038848aed0c64c39ca93da89b4a78bd3a1f6d7d0
2012-11-07 11:43:02 +02:00
27239ad230 basic: String -> OUString
Change-Id: I42479b4bade5111e38d69f04c889c166f340d5ba
2012-11-07 02:14:53 -06:00
d2c45d0460 fdo#46808, Adapt i18n::Transliteration UNO service to new style
Simply make the service implement XExtendedTransliteration, since all
of the implementatins already do that.

Change-Id: If03bf56a8d33931ad0230743a4603e2ae9b104ac
2012-11-05 16:43:15 +01:00
99ddd57693 Fix .Len -> getLength
Change-Id: Ibe3e97a6fa59098b9234e4aae04118abc4e37eea
2012-11-04 11:12:48 +01:00
b68a0f6595 basic add a generic unit test fixture
basic_coverage is a generic unit test that scan
qa/basic_coverage/*

each file there is supposed to be a well formed Basic script
that define as least a Function doUnitTest as Integer
that return 1 if OK, 0 if not OK

Change-Id: I6c3cfac1e7ce4748f46c04344102a0eff69b6a49
2012-11-03 20:24:28 -05:00
d92814f462 basic: preliminary cosmetic clean-up
parsing 1000s of line of code is hard enough without having to fight
with weird indentation and irregular formatting.

So as the review progress, in order to follow the code, cosmetic changes
were made...

In order to minimize the task of the reviewers and allow them to
concentrate on what matter, an effort is made to collect these
cosmetic changes into this separate commit.

Change-Id: I3c9b04a0150d0d0a048c2e976fe24de4f2b6b98a
2012-11-03 20:24:28 -05:00
a884fe58a1 basic: OUStringification of ddectrl
Change-Id: I2af40d7c8117aff8ce62a8ea0eec579664f8bdeb
2012-11-03 20:24:27 -05:00
c5b7d8f9d9 basic migration to OUString
Change-Id: I1f9403174b3779801d91ba20d846191ed9a09eed
2012-11-03 20:24:27 -05:00
6702bc37d4 basic: convert StepPAD to OUString
Change-Id: I19d05f455767c973a47d0233b3af20af1ac3a20a
2012-11-03 20:24:27 -05:00
8ce4050497 simplify and use OUString for StepLOADNC
Change-Id: I92c86f672cc79506c2c7c56bb3402b4436f71c98
2012-11-03 20:24:27 -05:00
c1435d9ea6 basic: use OUString in DimAsNewRecoverItem
Change-Id: Icfecff549161c3c429524549b65752671792a94f
2012-11-03 20:24:27 -05:00
973d061839 basic: unnecessary round-trip via String
Change-Id: I691a59b8ab9e6352a9257dac35b8e378e6ef9666
2012-11-03 20:24:26 -05:00
5120d8c59d basic: avoid String<>OUString issue by by-passing them completely
Change-Id: If741661f1151950a2180fa5c6504957b44a7e998
2012-11-03 20:24:26 -05:00
ac476e7884 basic: clean-up String from eventatt.cxx
Change-Id: I78f39310dbb0a024af4268f503a6150451f12778
2012-11-03 20:24:26 -05:00
bbf1bcd9ad basic: String -> OUString in basicmanager
Change-Id: I6607bfe8b6bf4d29ffd01cd88a19af5e53d616b5
2012-11-03 20:24:26 -05:00
c5e5699c80 svformatter already accept OUString input
Change-Id: Icca8c40db4a4449876e115a0746319f3f893e846
2012-11-03 20:24:26 -05:00
6f978fa977 basic: use OUString internaly for error messages
Change-Id: I9ea243f93b7477814037deca2f332c3359ce527d
2012-11-03 20:24:25 -05:00
dcdac24cd6 cosmetic prep-work
Change-Id: I732a8506a25f48c89cd0dc590e7305d355aa0762
2012-11-03 20:24:25 -05:00
363d2c6f8b use OUString for intermediary result in PrepareNumberFormatter
Change-Id: I9435d926beb2fd7ebe350f61634673eed7228fbe
2012-11-03 20:24:25 -05:00
de8d81b157 cosmetic clean-up
Change-Id: Ie9569fba8b03656b9a50e9add06c8e13d0026624
2012-11-03 20:24:25 -05:00
cf38d7f7a8 basic: implement RIGHT with OUString
Change-Id: Iff2150cf45569ca3d95f461495f49c455178cb5e
2012-11-03 20:24:25 -05:00
4a11a47103 trivial empty-init String::Fill -> comphelper::padToLength
Change-Id: I6c41b8f4d3ad739eff545063bd1f8fe8f4fba65e
2012-10-30 00:05:59 +00:00
ee582e991a Missing #include
Change-Id: I63e68bd37b46f339d09d97a6bf6edfeaa6a7df1d
2012-10-29 23:07:24 +01:00
8fff6bf6bd fdo#46808, Adapt i18n::LocaleCalendar UNO service to new style
Did not need to create a new interface, because XCalendar3
already covers the whole service interface.

Change-Id: Iaf094014c16e872d2003ca6e8e7588abd081d882
2012-10-29 17:32:57 +01:00
0dd085f8f3 UniString->rtl::OUStringBuffer
Change-Id: I9938d7c4ab5594baeb10f405f0aa0964ef84d6c5
2012-10-28 23:09:32 +00:00
b30ee83058 fdo#46808, use service constructor for beans::Introspection
Change-Id: Ieb49277020d31779979d8eb508391d6f8b97bf94
2012-10-23 13:06:14 +02:00
fb741b5e1e fdo#46808, Adapt xml::sax::XWriter UNO service to new style
Create a merged XWriter interface for the service.
The xml.sax.Writer service already existed, it just did not have
an IDL file.

Change-Id: I4e6d3f3c68f9282a55fc7aa19778f97632fd8ad5
2012-10-22 17:01:11 +02:00
8eb5db8997 replace sxub_Unicode by sal_Unicode
Change-Id: Icf4b434a1961cc4964ee6e362491868e898a1831
Reviewed-on: https://gerrit.libreoffice.org/887
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-10-19 10:55:56 +00:00
f7a24eff2d mark lcl_ functions static or rename them if they are not local at all
http://lists.freedesktop.org/archives/libreoffice/2012-October/039639.html

Change-Id: I231f0b367bf0b513c6c1ce4c4cfdb7c3dc8660d5
2012-10-12 13:34:47 +02:00
38968e2963 WaE [loplugin]: statement alignment
Change-Id: Ia09c74e02d261de5946e6d7e0530a7913e0bcb8d
2012-10-10 14:59:24 +03:00
a20f9a410f fdo#46808, Adapt xml::sax::XParser UNO service to new style
The xml.sax.Parser service already existed, it just did not have
a new-style service to create it.

Change-Id: I6f145a7504ff9e149c802f723991954a2801cbc9
2012-10-04 16:29:53 +02:00
af4df7ac08 fdo#48257 collect function prototypes from basic/ into single header file
Change-Id: I1666e64b2b611054e1a713a76575e2f06781f80a
2012-10-04 10:35:48 +01:00
36a2db3722 Replace usage of rtl_*Memory with equivalent from string.h
Change-Id: I50ffc10f007f03c3252ef0196b59b881429cc159
Reviewed-on: https://gerrit.libreoffice.org/734
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-10-01 18:48:05 +00:00
c2ca6fabd1 Use comphelper::getComponentContext
...and some further clean up.

Change-Id: Id294c0f38fe0041646fc86cacbd2e19734c746a9
2012-09-29 18:18:28 +02:00
93a118d728 fix WNT build: missed one oleaut32
Change-Id: Ic079200f6a3f1a1e7ac38f971e4da40a8dd39dd0
2012-09-28 17:57:58 +02:00
5032dc0fc3 gbuild: invert handling of standard system libraries:
Always link in gb_STDLIBS, except when the library explicitly opts out
with gb_LinkTarget_disable_standard_system_libs.

Change-Id: I489a99114fbfa46d0421a27cf6c7b899dc268a4a
2012-09-28 16:49:08 +02:00
dc397aae70 gbuild: gb_Library_PLAINLIBS_NONE cleanup for WNT:
add a new gb_LinkTarget_use_system_win32_libs to abstract different
linker options on MSVC and GCC.

Change-Id: Ic9bf2545f59bf7871e6fc06b290c486ddfbec03d
2012-09-28 16:49:08 +02:00
b85c349783 gbuild: replace direct gb_STDLIBS use with ...
... new gb_LinkTarget_add_standard_system_libs

Change-Id: Ib2bc843098db3d8c6822b45a3d21724e67f57d69
2012-09-28 16:49:06 +02:00
2e677c3981 gbuild: split uwinapi out of gb_STDLIBS
Change-Id: I53316e0b9369d806197bccb42cf22d3497af43e7
2012-09-28 16:49:05 +02:00
eebc9748d2 Fix MSVC build: #undef EXPLICIT (which gets defined as 'explicit' somewhere)
Change-Id: I83f6dff2a01d6d7806b2d2f4e6415aee10933e14
2012-09-25 11:50:56 +03:00