wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
362,282 Commits 5 Branches 0 Tags
a43ba14c532f7abb5cef243065d64a1283cf94de
Commit Graph

326 Commits

Author SHA1 Message Date
Caolán McNamara
f5b1b266bc coverity#1247646 Uncaught exception 
Change-Id: I332fb602466613e9e79ba4510879411e0bee9da6
 2014-10-17 15:19:54 +01:00
Caolán McNamara
d4cdaa2ad6 coverity#1247644 Uncaught exception 
Change-Id: Idbaef5c196c29a2e066f667e6bd50189a7b1834c
 2014-10-17 15:19:53 +01:00
David Tardon
582ef22d3e fdo#84854 it seems long is not enough on 32 bit 
Fraction used BigInt internally for computations, rational does nothing
like that.

Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
 2014-10-16 17:44:44 +02:00
Stephan Bergmann
ad9498f8b8 More -Werror,-Wunused-private-field 
...detected with a modified trunk Clang with

> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp	(revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp	(working copy)
> @@ -1917,9 +1917,10 @@
>    const Type *T = FD.getType()->getBaseElementTypeUnsafe();
>    // FIXME: Destruction of ObjC lifetime types has side-effects.
>    if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> -    return !RD->isCompleteDefinition() ||
> -           !RD->hasTrivialDefaultConstructor() ||
> -           !RD->hasTrivialDestructor();
> +    return !RD->hasAttr<WarnUnusedAttr>() &&
> +           (!RD->isCompleteDefinition() ||
> +            !RD->hasTrivialDefaultConstructor() ||
> +            !RD->hasTrivialDestructor());
>    return false;
>  }
>
> @@ -3517,9 +3518,11 @@
>    bool addFieldInitializer(CXXCtorInitializer *Init) {
>      AllToInit.push_back(Init);
>
> +#if 0
>      // Check whether this initializer makes the field "used".
>      if (Init->getInit()->HasSideEffects(S.Context))
>        S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
>      return false;
>    }

to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").

Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
 2014-10-15 15:58:56 +02:00
Juan Picca
47a2d7642d fdo#81356: convert Fraction to boost::rational<long> - wip 
* Added rational util functions used by Fraction class not
  available in the boost::rational class.
* Replaced usage of Fraction by boost::rational<long>
* Removed code that relies on:
  1. fraction.IsValid() -- rational only allow valid values, ie
     denominator() != 0
  2. rational.denominator() == 0 -- always false
  3. rational.denominator() < 0 -- always false but implementation
     detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation
* Simplified code that relies on:
  1. rational.denominator() != 0 -- always true
* BUGS EXIST because Fraction allows the creation of invalid values but
  boost::rational throws the exception boost::bad_rational

Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9
Reviewed-on: https://gerrit.libreoffice.org/11551
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
 2014-10-09 11:33:33 +00:00
Noel Grandin
827c46e7d7 fdo#82577: Handle Window 
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.

Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
 2014-09-23 14:11:39 +03:00
Noel Grandin
5bce329040 SfxHint: convert home-grown RTTI to normal C++ RTTI 
Also note that I fixed a bug in SvxFontMenuControl::Notify
where the if statement had the check the wrong way around.

Change-Id: I611e8929c65818191e36bd80f2b985820ada4411
Reviewed-on: https://gerrit.libreoffice.org/11147
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
 2014-09-06 15:47:44 -05:00
Caolán McNamara
d3cd290491 coverity#1233508 Uncaught exception 
Change-Id: Ia77a94a486b8e5203617eb00cb5189359798482f
 2014-09-02 12:14:46 +01:00
Caolán McNamara
b6d25be2d7 convert RID_QRYBOX_LANGUAGE with custom title to .ui 
Change-Id: I007820c7717a437414bc43936e3138f7e63d090e
 2014-08-25 16:45:24 +01:00
Matteo Casalin
47e2fd0dc8 Consistently use size_t and SAL_MAX_SIZE 
Change-Id: Ibab89984ec94556ec368653b6db50c6c2e380dec
 2014-08-16 21:52:32 +02:00
Tobias Lippert
6a873638fa Renamed brdcst.[hc]xx to SfxBroadcaster.[hc]xx 
- Remove includes from files where they are not needed.
- Update pch files

Change-Id: I0188e3934ef429008c1ef495ab1d5b27f38664d5
Reviewed-on: https://gerrit.libreoffice.org/10342
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2014-07-17 08:47:58 +00:00
Noel Grandin
dac4ca5f68 new loplugin: externalandnotdefined 
Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.

Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
 2014-07-11 14:12:25 +02:00
Stephan Bergmann
e48a233960 loplugin:unreffun: also warn about redundant redeclarations 
Change-Id: I9a812220b58cf6da00d854e65794f7c673ab239d
 2014-06-27 15:27:39 +02:00
Noel Grandin
184a00b962 loplugin: inlinesimplememberfunctions 
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
 2014-06-09 10:10:13 +02:00
Noel Grandin
0e507ae031 various: remove SAL_THROW macro 
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
 2014-06-05 08:17:52 +02:00
Thomas Arnhold
3db8d606d5 hrc and src files: squeeze multiple newlines 
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done

Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
 2014-05-19 20:04:22 +02:00
Thomas Arnhold
70895b691e remove legacy svheader.hxx 
none of the corresponding headers is included...

Change-Id: I85061dc159ace0fd727e3d32e52b14c123690584
 2014-05-15 17:47:39 +02:00
Noel Grandin
248145f99e Find places where uno::Sequence is passed by value. 
Implement a clang plugin to find them, and clean up existing code
to pass them by reference.

Change-Id: If642d87407c73346d9c0164b9fc77c5c3c4354b8
Reviewed-on: https://gerrit.libreoffice.org/9351
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-05-14 08:10:22 +00:00
Noel Grandin
883481fd20 Improve TabBar return types 
DeactivatePage() goes from returning long to returning bool.
StartRenaming goes from returning long to returning bool.
AllowRenaming goes from returning long to returning a
constant from a new enum.

Change-Id: Ib87e8d7ceb4e23846547257b358ca4dfd41eb6ca
Reviewed-on: https://gerrit.libreoffice.org/9161
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-04-28 11:37:37 +00:00
Caolán McNamara
0eb160ef13 coverity#736993 Uncaught exception 
Change-Id: Ib8e5d13da0e26f67da16edf0eb55341208ec2337
 2014-04-25 20:19:11 +01:00
Caolán McNamara
7f49f4227b coverity#736992 Uncaught exception 
Change-Id: Ia074dc867cc068fccb2d4eb613d04b945b8711e7
 2014-04-25 20:19:11 +01:00
Caolán McNamara
2d4c90e82e coverity#736990 Uncaught exception 
Change-Id: I3b7f4c732a5a3369c05c75ede1580b32837be671
 2014-04-25 20:19:11 +01:00
Thomas Arnhold
5973c2d34a fixincludeguards.sh: basctl 2014-04-19 11:10:07 +02:00
Jan Holesovsky
29d5ce2d88 sfx2: Move InitInterface_Impl() out of SFX_DECL_INTERFACE too. 
Change-Id: Ib737e0d1b5888986b308aa60d4140f65e4e90243
 2014-04-18 22:51:06 +02:00
Noel Grandin
23dc4e1a00 basctl: sal_Bool->bool 
Change-Id: I85e1e94557a238f629151d9ce46a502efed3696d
 2014-04-15 15:23:28 +02:00
Stephan Bergmann
362d4f0cd4 Explicitly mark overriding destructors as "virtual" 
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
 2014-04-01 19:22:54 +02:00
Stephan Bergmann
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations 
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
 2014-03-27 18:12:18 +01:00
Stephan Bergmann
5fb78604c1 Split TYPEINFO into plain and TYPEINFO_OVERRIDE 
...where the latter contains SAL_OVERRIDE annotations

Change-Id: Id64794b388d83dfe7026440e8b20a5b5efd412d1
 2014-03-26 11:54:55 +01:00
Noel Grandin
9278df2c21 sfx2: sal_Bool->bool 
Change-Id: I73acb3a150b01114d32274a6842f6db9654b3e63
 2014-03-19 09:21:24 +02:00
Noel Grandin
c3e3f46657 sfx2: sal_Bool->bool 
Change-Id: I375a72c34e46778385a9fdc24c9ebd0f0a3f3c9b
 2014-03-18 11:27:39 +02:00
Noel Grandin
7e8af4b249 basct: prefer passing OUString by reference 
Change-Id: Ide803f793e829767fad89ab2aef776ef24fedb37
 2014-03-17 13:30:51 +02:00
Stephan Bergmann
d47ca30f1c No need for implGetBounds to be SAL_CALL 
Change-Id: I4eb1f998de57a4ceeb7990c6e4a964ce0d07ea88
 2014-03-11 15:35:52 +01:00
Chris Sherlock
381f8a5673 sal_Bool -> bool in mostly vcl module 
Conflicts:
	include/vcl/settings.hxx
	svtools/source/table/tablecontrol_impl.cxx
	sw/source/core/frmedt/fecopy.cxx
	vcl/inc/canvasbitmap.hxx
	vcl/inc/headless/svpframe.hxx
	vcl/inc/unx/salframe.h
	vcl/inc/win/salframe.h
	vcl/inc/win/salprn.h
	vcl/inc/win/salvd.h
	vcl/osx/DragSource.cxx
	vcl/osx/DragSource.hxx
	vcl/osx/DropTarget.cxx
	vcl/osx/DropTarget.hxx
	vcl/osx/OSXTransferable.cxx
	vcl/osx/OSXTransferable.hxx
	vcl/osx/clipboard.cxx
	vcl/osx/clipboard.hxx
	vcl/osx/salprn.cxx
	vcl/qa/cppunit/canvasbitmaptest.cxx
	vcl/source/components/fontident.cxx
	vcl/source/control/edit.cxx
	vcl/source/control/spinfld.cxx
	vcl/source/gdi/gdimtf.cxx
	vcl/source/gdi/virdev.cxx
	vcl/source/helper/canvasbitmap.cxx
	vcl/source/window/dockwin.cxx
	vcl/unx/generic/dtrans/X11_selection.hxx
	vcl/unx/kde/UnxFilePicker.cxx
	vcl/unx/kde/UnxFilePicker.hxx
	vcl/unx/kde4/KDE4FilePicker.cxx
	vcl/unx/kde4/KDE4FilePicker.hxx
	vcl/unx/kde4/KDESalFrame.hxx

Change-Id: I9866d985da86dea2a56feff23f91c1467a1636b0
Reviewed-on: https://gerrit.libreoffice.org/8219
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-28 03:19:47 -06:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Alexander Wilms
2fbd9825bc Remove visual noise from basctl 
Change-Id: I3e6a238a0bafbb70a7c22bde1f2258b8014ed2d2
Reviewed-on: https://gerrit.libreoffice.org/8232
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-25 17:01:07 +00:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments 
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-23 03:38:49 +00:00
Stephan Bergmann
e8f8f24c84 vcl: sal_Bool -> bool 
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
 2014-02-21 12:53:51 +01:00
Caolán McNamara
281bdaaa0b convert manage languages dialog to .ui 
Change-Id: I1a50f8715040e64758cf18bee8ca6ac1d04652c8
 2014-02-11 12:11:44 +00:00
Caolán McNamara
6b44c30bcb coverity#736985 Uncaught exception 
Change-Id: I58f2bc50a87ed07340caa148b4ade07062d730fc
 2014-01-27 14:38:39 +00:00
Stephan Bergmann
5c3eca5e84 bool improvements 
Change-Id: Ia5ab74b8a8b367ea92f29eb6269ef0ede47f09bb
 2014-01-17 18:45:13 +01:00
Stephan Bergmann
04683f1488 Window::Notify should return bool 
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
 2014-01-17 16:42:29 +01:00
Stephan Bergmann
62951cdd17 Introduce com.sun.star.frame.theGlobalEventBroadcaster singleton 
...to supersede com.sun.star.frame.GlobalEventBroadcaster single-instance
service.

Change-Id: I74ecaadadb4c600d39979aa7c13b6389bed38fd7
 2014-01-16 18:40:05 +01:00
Stephan Bergmann
7c1415e06f Remove unused bForBrowsing parameter 
Change-Id: I32b458390130e9ed83af0831069329ac8f672d67
 2014-01-14 11:21:10 +01:00
Stephan Bergmann
0d0fd7b4fb PrepareClose should probably return bool 
Change-Id: Ie62a6c1197594102bc68e246ae6059a9442ce314
 2014-01-14 09:31:58 +01:00
Stephan Bergmann
d1043892df SfxPoolItem::operator ==, != should return bool 
...and SfxEnumItemInterface::HasBoolValue, too.

Change-Id: Ia032e3d35a4c3b4c1efdc515ca36e466be03fc0a
 2014-01-10 17:11:51 +01:00
Caolán McNamara
75137e6e9f convert default language dialog to .ui 
Change-Id: Ia4d5b983168d6645fce8e2549db2b6c3fd410690
 2014-01-03 21:27:09 +00:00
Stephan Bergmann
075a0b30c8 No need for DlgEdObj::supportsService to be virtual 
Change-Id: Ib324adb4bc894f16c051fe956c25e37b0502006c
 2013-12-18 14:14:53 +01:00
Stephan Bergmann
07ab0d43b5 Get rid of DECLARE_STL_VECTOR 
Change-Id: If4588034fc09e4663b5217669c71f26c0a3b8c8a
 2013-12-06 08:04:23 +01:00
Norbert Thiebaud
cde4fdb2d0 basctl: include <> for external includes 
Change-Id: I1897c587c02c5b50e6e8a7bf70467233be871878
 2013-11-11 22:37:25 -06:00
Noel Grandin
6f2adb1a04 convert basctl/source/inc/basobj.hxx from String to OUString 
Change-Id: Ied011ae19ef850826f52f4ebd5a22dba0caf5d2b
 2013-09-17 09:06:16 +02:00