582ef22d3e
fdo#84854 it seems long is not enough on 32 bit
...
Fraction used BigInt internally for computations, rational does nothing
like that.
Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-16 17:44:44 +02:00
ad9498f8b8
More -Werror,-Wunused-private-field
...
...detected with a modified trunk Clang with
> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp (revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp (working copy)
> @@ -1917,9 +1917,10 @@
> const Type *T = FD.getType()->getBaseElementTypeUnsafe();
> // FIXME: Destruction of ObjC lifetime types has side-effects.
> if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> - return !RD->isCompleteDefinition() ||
> - !RD->hasTrivialDefaultConstructor() ||
> - !RD->hasTrivialDestructor();
> + return !RD->hasAttr<WarnUnusedAttr>() &&
> + (!RD->isCompleteDefinition() ||
> + !RD->hasTrivialDefaultConstructor() ||
> + !RD->hasTrivialDestructor());
> return false;
> }
>
> @@ -3517,9 +3518,11 @@
> bool addFieldInitializer(CXXCtorInitializer *Init) {
> AllToInit.push_back(Init);
>
> +#if 0
> // Check whether this initializer makes the field "used".
> if (Init->getInit()->HasSideEffects(S.Context))
> S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
> return false;
> }
to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html >
"-Wunused-private-field distracted by side effects").
Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15 15:58:56 +02:00
4c12951a03
Typo: compatability->compatibility
...
Change-Id: If0b98a30452a9d1fcc340173deb6856755926471
2014-10-12 13:00:46 +02:00
47a2d7642d
fdo#81356: convert Fraction to boost::rational<long> - wip
...
* Added rational util functions used by Fraction class not
available in the boost::rational class.
* Replaced usage of Fraction by boost::rational<long>
* Removed code that relies on:
1. fraction.IsValid() -- rational only allow valid values, ie
denominator() != 0
2. rational.denominator() == 0 -- always false
3. rational.denominator() < 0 -- always false but implementation
detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation
* Simplified code that relies on:
1. rational.denominator() != 0 -- always true
* BUGS EXIST because Fraction allows the creation of invalid values but
boost::rational throws the exception boost::bad_rational
Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9
Reviewed-on: https://gerrit.libreoffice.org/11551
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-10-09 11:33:33 +00:00
fca62934f4
basic: use SolarMutex to lock SfxLibraryContainer
...
Originally this used both SolarMutex and an own mutex, then a deadlock
was resolved in 2fe6a4a34b38c05e252c71f4d2f18e4a90e61b29 by not locking
SolarMutex.
Since the class will call event listeners without dropping the mutex
e.g. in insertNoCheck(), using the SolarMutex appears better anyway.
With this, installing a BASIC extension no longer triggers SolarMutex
asserts in SfxBroadcaster.
Change-Id: Ib9a2ee491ef53b1a53855af0fc22e863c5e7cb91
2014-10-08 15:46:06 +02:00
26b79470ca
basic::ImplRepository: use SolarMutex instead of own mutex
...
The locking strategy in the basic module is totally unclear to me, there
does not appear to be a dedicated mutex for the core stuff callable via
StarBASIC, just a bunch of SolarMutexGuards at random locations;
let's try to use SolarMutex at the UNO entry points...
Change-Id: Ia9c45fdcfb5ffd0a4acc77ef5d2fabfb8743ad38
2014-10-08 15:46:05 +02:00
f84dac9b1f
back out even more wrong tools::Time changes, geez..
...
Change-Id: I52eb3400769999d7f554c3bdb8746f65b7990388
2014-10-08 14:35:36 +02:00
04a810cee4
back out more wrong and confusing tools::Time comment changes
...
Apparently fc04f76336fdf8c96e35382cdeb497e2f939705c used some sed script
to change all ...
Change-Id: Ie609bd02a2c5d70109fc6185cf4440480f29d8f5
2014-10-08 14:24:21 +02:00
fbf3aa391b
spelling: instanciated -> instantiated
...
Change-Id: I99f3010e30f81786b938dc11736ea1597cd5530d
2014-10-08 11:02:55 +02:00
8f436d3de7
use comphelper::rng::uniform_*_distribution everywhere
...
and automatically seed from time on first use
coverity#1242393 Don't call rand
coverity#1242404 Don't call rand
coverity#1242410 Don't call rand and additionally allow 0xFF as a value
coverity#1242409 Don't call rand
coverity#1242399 Don't call rand
coverity#1242372 Don't call rand
coverity#1242377 Don't call rand
coverity#1242378 Don't call rand
coverity#1242379 Don't call rand
coverity#1242382 Don't call rand
coverity#1242383 Don't call rand
coverity#1242402 Don't call rand
coverity#1242397 Don't call rand
coverity#1242390 Don't call rand
coverity#1242389 Don't call rand
coverity#1242388 Don't call rand
coverity#1242386 Don't call rand
coverity#1242384 Don't call rand
coverity#1242394 Don't call rand
Change-Id: I241feab9cb370e091fd6ccaba2af941eb95bc7cf
2014-10-06 14:13:27 +01:00
0f6c6baf61
coverity#1242481 Dereference null return value
...
Change-Id: I21e6bdd643d898a3515a96e4c9c17c2d6f98b0e4
2014-10-03 16:30:32 +01:00
c625525ddc
rename SvRef::AddRef to AddFirstRef
...
to make it's intended purpose clearly distinguishable from AddNextRef
Change-Id: I5da780b48b19fd873667b648031bc394113f953b
Reviewed-on: https://gerrit.libreoffice.org/11763
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-03 05:25:41 +00:00
059f5a95b2
loplugin: cstylecast
...
Change-Id: Ic7c9c978baf5602a508aff5976220a02ed03a680
2014-10-02 07:37:19 +02:00
fa537124ac
loplugin: cstylecast
...
Change-Id: Ie3d13eccdf444d569cbe40befb45eb86941160b6
2014-10-01 13:08:41 +02:00
dc7ca91a04
avoid calling OUString::copy() with length being -1
...
Which asserts in dbgutil build.
Change-Id: I0f8205ae98c5a57c430b7d8a574e4c0019855841
2014-10-01 11:45:01 +02:00
fc04f76336
fdo#82577: Handle Time
...
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.
Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-01 07:34:23 +00:00
4e26b91568
remove unnecessary casts in misc calls to SvStream.Write*
...
left over from our conversion of the SvStream output operators
to more specific methods
Change-Id: Ib80032e8626f5476a89b958f590441994594f4e4
2014-09-26 15:27:18 +02:00
5cefde06ea
remove unnecessary casts in calls to SvStream.WriteUInt32
...
left over from our conversion of the SvStream output operators
to more specific methods
Change-Id: I1d848f19f82783e6eabf2da37dbde78fe36ea1e0
2014-09-26 15:27:17 +02:00
04fd62096f
remove unnecessary casts in calls to SvStream.WriteInt32
...
left over from our conversion of the SvStream output operators
to more specific methods
Change-Id: I0c0172519479be0535a447e41a592fbf782751bd
2014-09-26 15:27:17 +02:00
5501c8d222
remove unnecessary casts in calls to SvStream.WriteUInt16
...
left over from our conversion of the SvStream output operators
to more specific methods
Change-Id: I482ca7abb84613971e7e8f839f7aa67a65cd71ff
2014-09-26 15:26:48 +02:00
dedfa972bc
remove unnecessary casts in calls to SvStream.WriteInt16
...
left over from our conversion of the SvStream output operators
to more specific methods
Change-Id: Ie44bec6b988f3e46fe78d14b740818c9141f5df0
2014-09-26 15:26:48 +02:00
bec72dd34f
remove unnecessary casts in calls to SvStream.WriteUChar
...
left over from our conversion of the SvStream output operators
to more specific methods
Change-Id: I2ea4c7d97e745b3e6a3834f41ac7bfefa4883c7a
2014-09-26 15:26:19 +02:00
c476a84abd
remove pointless comments
...
Change-Id: I8edfe830b8f6ca7f1809332870e06d1d286b90e8
2014-09-26 15:25:40 +02:00
8f684e21de
remove unnecessary static_cast's
...
left over from our conversion of the SvStream output operators
to more specific methods
e Please enter the commit message for your changes. Lines starting
Change-Id: Ibfe7635451ef7b8813d7a59c78c5223092a17ad5
2014-09-26 15:25:40 +02:00
827c46e7d7
fdo#82577: Handle Window
...
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.
Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-23 14:11:39 +03:00
764e3016b6
fdo#84086 Fix assorted use-after-free bugs
...
Change-Id: Iec004fffdb0afbe27bd69f379db90f6d904a8a65
Reviewed-on: https://gerrit.libreoffice.org/11553
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-09-22 05:15:53 +00:00
234b5de79f
vba: calm down bool -> long casting concerns.
...
Change-Id: Ib32a66d891242701d2f5c55519e5c52a6dd3df3c
2014-09-19 20:15:09 +01:00
857f72dfe3
vba - disable Currency test / invocation on master.
...
We're missing an effective SbxCURRENCY conversion here.
Change-Id: Id6530ed3a93623b31089304f3451d9693ab4f3af
2014-09-19 15:31:07 +01:00
01e14011e5
vba: add a different variant of the same compatibility function.
...
Change-Id: I92bc1dbceea2f10cbb055d97f68b33e575d9be11
2014-09-19 15:31:07 +01:00
19ee058a21
vba: initial impl. of compatibility methods.
...
Change-Id: Iebc25f1730766e96d2ad6921a8b4d2ea880c63f3
2014-09-19 15:31:06 +01:00
60e78fbb80
fdo#82577: Handle Font
...
Put the VCL Font class in the vcl namespace. Avoids clash with the X11
Font typedef.
Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-18 08:54:37 +02:00
03043589c3
Clean up StorageMode parameter of SotStorage::OpenSotStorage
...
...which was only used to transport either STORAGE_TRANSACTED or sal_False
(i.e., 0, meaning "not STORAGE_TRANSACTED").
Change-Id: I25a894262bbefdb6c0634309bccfb1e56dad7d88
2014-09-15 18:22:37 +02:00
5bce329040
SfxHint: convert home-grown RTTI to normal C++ RTTI
...
Also note that I fixed a bug in SvxFontMenuControl::Notify
where the if statement had the check the wrong way around.
Change-Id: I611e8929c65818191e36bd80f2b985820ada4411
Reviewed-on: https://gerrit.libreoffice.org/11147
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com >
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com >
2014-09-06 15:47:44 -05:00
a7fbabdacd
fdo#52076 remove Library dir when no library
...
when saving to same storage (in place)
we already did that when empty "Standard" was the only library,
but not when there was no library...
Cannot get through that state in through UI, but possible through scripting.
Change-Id: I0f1129e034ac31b3eaf6bd388a03aee5aae5b87e
2014-09-04 12:06:51 +02:00
513d95f318
detect if Standard is only library to *save*
...
as opposed to only library at all
Change-Id: I23bebfe7d156e1f4a60bc5f265a3cf9d295f3e4a
2014-09-04 12:06:50 +02:00
6846c1c88e
add const qualifier
...
Change-Id: I88d61668b465e505cfa245dd17893828aaaecaa8
2014-09-04 12:06:50 +02:00
37b9ea92ba
convert SBX flag bits to type-safe enum
...
Change-Id: I18d5d6a27f06ee60a5cb3dc393bf05b51bba4817
Reviewed-on: https://gerrit.libreoffice.org/11070
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-08-26 04:30:03 -05:00
7e2b9fa213
Remove some useless tools/debug.hxx includes
...
Also remove the tools/solar.h included from tools/debug.hxx. The include of solar.h
header was necessary in some cases because of a macro or a typedef that was needed.
Change-Id: Ia6e15d5c2571c58c9e9138b0d0a7f08ae88053c9
Reviewed-on: https://gerrit.libreoffice.org/11075
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com >
Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com >
2014-08-22 16:33:18 -05:00
c319ccfc37
Revert "Simplify ImplRepository::impl_getLocationForModel return type"
...
This reverts commit 72305ed49d4c9ba968d7bf6d8d5ae564bb92147d, which was bogus,
cf. the comment in ImplRepository::getDocumentBasicManager about recursive
calls.
2014-08-22 09:10:40 +02:00
73b2ea1dfa
Remove BasicManagerCleaner
...
Change-Id: I55eccc6367cf3255af05c075631945f47417d682
2014-08-22 09:06:55 +02:00
72305ed49d
Simplify ImplRepository::impl_getLocationForModel return type
...
Change-Id: I937f96457347195ed18ddcdc75b1106840f0522e
2014-08-22 09:03:27 +02:00
8c5834d5cb
Remove trivial typedef, to make code more obvious
...
Change-Id: I70017a5c6f9403520ee79e9d0864352eb1c8e100
2014-08-22 08:59:01 +02:00
d718c1f65f
coverity#1202729 - ensure we have exactly a one dimensional array.
...
Change-Id: I6db8a2fb48ed7ce134a5c45c590c2ada0e19fc85
2014-08-21 00:39:45 +01:00
d21d5a7261
drop unnecessary shl.hxx includes
...
Change-Id: Ieb984987c4a4f888a563377e0500444b12f43506
2014-08-18 12:59:49 +01:00
d438c470d7
coverity#1231668 Unchecked return value
...
Change-Id: Ia7e47b5d42e9a488b3952f12d607b3f17661c44d
2014-08-17 16:39:21 +01:00
7cc627ff79
update_pch
...
Change-Id: Ic1dae7aac2f4367b4196ba3128c0aea9be1fbbda
2014-08-13 10:10:33 +02:00
d9baa2b06e
-Werror,-Wundefined-bool-conversion
...
Change-Id: I81edff750eab6bbeef75fbd1a5fcca0f01379daa
2014-08-11 16:00:46 +02:00
9bac4d413e
typo: more then -> more than
...
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
2014-08-01 23:40:12 +09:00
e5b0aa9a7c
basic: -Werror=sign-compare
...
Change-Id: I7c776faa74a61b0d263c3b446972da9461b3d4f6
2014-07-29 18:06:06 +02:00
ae7ca8b957
fdo#46037: remove unused comphelper/configurationhelper.hxx
...
Change-Id: I66f9d2912202ba1393d0c65189f8a945bca4fcaa
Reviewed-on: https://gerrit.libreoffice.org/10603
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2014-07-29 15:40:41 +00:00
