Commit Graph

195 Commits

Author SHA1 Message Date
03c7c26cbe java: final fields that can be static
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
2014-10-17 08:26:21 +02:00
4027bc476a fdo#84647 : Fixed default value for TickLableSkip value.
1. 'TextCanOverlap' property was stored as false if TickLableSkip
      is not equal to one.
   2. For OOXML charts TickLableSkip can be between 1 to 999999999.
   3. We can not apply zero or less than zero  value to TickLableSkip.
      ( As per specification)
   4. In axis model default value for TickLableSkip was zero which is
      incorrect.
   5. Added unit test to check 'TextCanOverlap' property for chart.

Change-Id: Ib3104b1d932f6e9376c149eabb201c8e9ad23da9
Reviewed-on: https://gerrit.libreoffice.org/11901
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-10-11 16:57:32 +00:00
890d0254db loplugin:passstuffbyref
Change-Id: If17bfdfdb51d5b9b8db563fccf09bb7608fcd0f8
2014-10-10 16:38:11 +02:00
e60183503e fdo#54361: Add additional unit test case.
Change-Id: Ifa3fd6f074d1957a468a1dad5dc2c223d38d24d4
2014-10-10 19:14:23 +05:30
610544eda1 chart2: fix the testDataLabelBordersDOCX on Mac
This test failed on Mac because it depends on the layout being finished,
since for SwXTextEmbeddedObjects the corresponding SwVirtFlyDrawObj are
inserted in the draw page not on import, but in layout.

Change-Id: I731b9b92838252ff50135f97343357992bc1933f
2014-10-01 18:28:24 +02:00
ba37fb02c2 Ensure we export correct label placement value for clustered bar charts
This is similar to 7b8073906adca8dae24c04a23708a3f3d582218f (Ensure we
export correct labal placement value for percent/stacked charts.,
2014-08-07), in case a clustered bar chart has a top placement ("t" in
OOXML), then MSO complains as well.

Change-Id: Iffd991127784e0e732f6ae55de956a328a3a53e5
2014-09-15 12:38:44 +02:00
d22a4d945c bnc#892610: OOXML import: Improve chart number formats.
If sourceLinked is used, do not set "PercentageNumberFormat" even if
showPercent is true. The format string should be used for "NumberFormat".

c8cc89ff802d86b1f3a69afe1b4835b7df7f70c7 unnecessarily disabled
"LinkNumberFormatToSource". Use that for data labels but not for axis.

Also, actually make attaching number format supplier work for Calc.
Previously, non standard formats were added into wrong supplier,
and they were thrown away later because it was attached too late.
(See also ChartModel::attachNumberFormatsSupplier)

Change-Id: Iaf9945abc3d82d0ac63d9f36b8888eb49f39ab57
2014-09-11 22:47:59 +02:00
4b4bff3402 java: no need to instantiate String objects directly
Change-Id: I7610774c94bf673ed3b574ffce04c4ee6ca93c03
2014-08-19 14:57:18 +02:00
ff0ad0493e java: use 'Integer.valueOf' instead of 'new Integer'
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
2014-08-19 14:57:17 +02:00
be1bb7b1cc java: use Boolean.valueOf instead of instantiating Boolean objects
Change-Id: Ie41d6b0170a035a694dd270c311a137fd1810e74
2014-08-19 14:57:16 +02:00
56ef5533fc java: classes in java.lang package do not need to be fully qualified
Change-Id: I7b18f62336c3a8ca4c538b30ce04c99f202a4756
2014-08-19 14:57:16 +02:00
e99535df4d remove executable bits
Change-Id: Iec785ae538de81325812b1e6fe33115789b39770
2014-08-17 05:50:13 +02:00
ac5954d7c5 java: remove commented out code
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
2014-08-14 10:59:48 +02:00
0477e6c39b java: add @Override annotation to overriding methods
Change-Id: I086964c6f6ce52c60c52b6dbc445d3c21d22c80a
2014-08-12 09:41:28 +02:00
b6a83e99c8 java: remove redundant null checks
Change-Id: Ia42e5ed715fbd3f5b84029a9844da55f307c6260
2014-08-08 09:48:19 +02:00
2d700944b5 java: remove unused imports
Change-Id: Idbba5bb89bee4d88ed0306d5151e238a1bc19cec
2014-08-08 09:48:17 +02:00
8d6cf7a147 java: remove dead methods
Change-Id: I9f2e705fd603a7c8832c0f0772bee9f395380a0d
2014-08-08 09:48:16 +02:00
5c5f083186 Another test for radar chart data label export.
This one doesn't support label placement property either.

Change-Id: If1f17a135eabd810033644e27db6b1e5c049daff
2014-08-07 19:32:35 -04:00
3119e04b45 Write test for exporting data label positions for percent stack bar chart.
Change-Id: Idebb56fc96828ec38d5c239c16e5b413a50c837f
2014-08-07 19:01:43 -04:00
9c2af3c885 Fix the test. It's bar3DChart not barChart.
Change-Id: I8e504dfee81557a1965bb4bbce4ea975c13fe775
2014-08-07 14:44:51 -04:00
3683cddee8 Write test for exporting data labels in area chart for OOXML.
Change-Id: Icbb17f56643f7d89bf739b0f218b2ca8a6309d9a
2014-08-07 14:44:51 -04:00
844d143905 Add test for default data label placement for line chart.
Change-Id: I25cf48703a286470907ccc5415a0fab479aa4b8c
2014-08-07 14:22:05 -04:00
96f890c638 Write test for doughnut chart export of data labels to OOXML.
We must not export label position properties for doughnut charts, else
MS Office would think the file is corrupt.

Change-Id: Icfab257ffb6da945b8add661e6455aa66cc475ab
2014-08-07 14:21:53 -04:00
d99d1d2c4e Remove the 2nd argument which was added unintentionally.
Change-Id: I264dba74bf4cab4beb97b33d3a71e82601119372
2014-08-06 14:37:27 -04:00
bd1fb229b4 update the reference files
Change-Id: I063100a632286b7fbec71c5fba00b9705972ac9f
2014-08-06 20:28:18 +02:00
2f24740766 Add test to ensure that we don't export label position attributes.
At least for 3D bar chart, exporting this would choke MS Office.

Change-Id: Ic6747f3c5502495d8cae734290183ff89b14fc70
2014-08-05 13:26:29 -04:00
0c5f51ebbc java: remove commented out code
Change-Id: I44e2043e5da23bc9421c03e550ef1d8b7ebaad36
2014-08-05 11:31:50 +02:00
0ee728634d bnc#886540: Add test cases for chart background fill variance.
"Automatic" fill in docx and xlsx should be solid white, whereas in
pptx it is no fill (transparent).

Change-Id: I7e64f2f895e4c4ed072a234e622a348599456f37
2014-08-04 12:25:56 -04:00
f493555623 java: remove some casting in lib.TestParameters#getMSF
where the return value is always cast to XMultiServiceFactory,
so just do the cast in the method and avoid noise at the call sites.

Change-Id: I3a2e06ac6edb3c6021eda6442032db57aaa22e13
2014-08-04 13:38:30 +02:00
dbe2da9334 Add chart import, percentage number formats, unit test.
Change-Id: Id1b73c153f4b09ab94446452e7eb096b529473f4
2014-07-29 22:58:16 +02:00
c2fd8c4492 bnc#885825: Write test for this.
Originally it was a pptx document, but switched to docx because reloading
an impress document in cppunit currently mysteriously crashes.

Change-Id: I3e9ba6b9a4dc7d3c0ca1d59a073dc8a4cca4008c
2014-07-26 23:38:56 -04:00
8b273da280 add SAL_OVERRIDE
Change-Id: I5c0f34f035765fcfd916b635ab18f5cb1bbcabb0
2014-07-20 16:17:53 +02:00
83da521ee2 one more simplification
Change-Id: I9aaf67872dde324f403598a7361cd4eda60b82b0
2014-07-19 22:22:40 +02:00
e674cd3f77 use the shared XPath test code in chart2
Change-Id: Ia8481516eb3d53f406824cc2ef8873fe1cba3909
2014-07-19 22:22:40 +02:00
dc4355e517 bnc#881025: Write test for this.
Change-Id: Ifb1f83bbe5f9bb9ecb7fca26f883d1331052f10d
2014-07-07 19:06:22 -04:00
344a596acc bnc#882383: Add chart unit test for GradientName property.
It needs to be set, so that the chart has colors. It was grey before.
The bug was fixed already in aacfd5038d05a02f8b1eade3a5896d3d7e959f3d,
which got pushed sooner, so this commit only changes
the property name from 'INVALID' to 'FillTransparenceGradientName'.

Change-Id: If06899258a4307d583480538338480ba5bb830b9
2014-07-07 17:25:51 +02:00
97857c2581 Test the import of data series values as well.
There was a bug in there earlier that none of the tests didn't catch.

Change-Id: I1f4ed1ba5e08e7842899a140163f9e165705569b
2014-07-03 12:32:00 -04:00
50a5d6ac3f Better and more descriptive naming.
Change-Id: Ic2e3b14399d2acc91c75922a25dc736b1605c320
2014-07-03 12:05:30 -04:00
d53a9dc1cc bnc#812796: Write test for this.
Right now, we skip hidden data series when importing OOXML charts into
our internal data table.  This of course means that if/when we add support
for hidden columns in the internal data table, we may want to change this.

Change-Id: Ida1b77821fbc2f8f937244576b52521b59d6ab89
2014-07-03 11:50:13 -04:00
994fc8faa1 fdo#54361:Add test case for the chart background
Change-Id: I03f0a45d821b14fe687b3ec7df98f9367adab1f2
Reviewed-on: https://gerrit.libreoffice.org/9978
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-07-03 14:18:13 +00:00
bdad8d9051 More fine-grained check of data series labels in the unit test.
Change-Id: I6b23126816bb114407f2b75545094bc297ee7cc3
2014-07-02 20:56:30 -04:00
3575dba98d remove whitespaces
Change-Id: I05ef3c1ffd4e2179e0142a21abf8a4578718102e
2014-07-02 23:03:07 +02:00
c6da184295 Track all uses of ErrorBarX and ErrorBarY UNO property names.
Change-Id: I994424c98d977c3a8f9138cccc17348de813a9d7
2014-06-26 19:36:46 -04:00
113866583c add test case for fdo#78080
Change-Id: If676eb03f5bd19f8abf13d1d7826d500d51e542e
2014-06-22 05:05:01 +02:00
a1d2c88124 add test case for property mapping
Change-Id: Ib8630d15f40b00c8620eeb1c79d5d9f00d07ef49
2014-06-22 05:05:00 +02:00
aac149e4ad fdo#71767: Write test for this.
Not a direct test for the reported bug, but to ensure that the reworked
properties survive import and export.

Change-Id: I6c5a4c98eca5180251f04a24346290dedc44447a
2014-06-20 12:03:06 -04:00
465503f52d sw: clean up leftover TextBox TODOs
Change-Id: I12782690368789849ea2ce2ed08ad4838a0a55db
2014-06-20 17:28:19 +02:00
860f543cdb chart2, sw: remaining textbox DOCX import test preparations
Ideally now all testcases handle both cases during DOCX import:

- current situation, when shape with text is imported as a Writer
  TextFrame
- future situation, when shape with text will be imported as shape with
  an assicated TextBox

Change-Id: I5b95ff4672cecf39eb744f8557f967ade73404c0
2014-06-18 10:24:54 +02:00
10f8d24540 fdo#77506: Enable this check.
Change-Id: Ib4ad7c1a1583b9fde1a06dc8e355442f10bb9bec
2014-06-12 11:27:18 -04:00
56ca1b7696 fdo#77506: (finally) write a unit test for this.
I've switched from using a Draw document to Writer document due to some
instability with Draw instance in our cppunit run.  The bug is reproducible
either way.

The test is disabled for now, since the bug has yet to be fixed.

Change-Id: I49e0417e1ecbc70f40aab8531237ae98ae58bdd3
2014-06-11 12:00:17 -04:00