Commit Graph

27 Commits

Author SHA1 Message Date
b67f325a26 rtl::Reference fits just fine here
Change-Id: I65499ac299fb474e581245c5237a0b184f1f2b60
2014-06-18 11:26:33 +02:00
209eea5457 chart2: Fix using the last shape
Clicking a shape button works only for the default shape,
not for the last used one.

Steps to reproduce:
1) Click on the drop-down arrow of one of the shape buttons,
   and select a shape. Notice that the button icon updates
   with the last selected shape.
2) Click on another button.
3) Click on the first button, and try to draw something.
   The button doesn't work anymore. Only opening the sub
   toolbar and selecting the shape there will work.

The problem is in ToolboxController::execute that requires
the command to be in the listener map, but we didn't
register sub commands (like .uno:SymbolShapes.sun).
Instead of doing that, we'll try some generic solution.
(Note that calling the corresponding method from
SvxTbxCtlCustomShapes like we do in other methods here
won't work, because ChartController::queryDispatch checks
for the "_self" target, but SfxToolBoxControl::Dispatch
doesn't provide it.)

Change-Id: I5be3dfd3ee3ca9ab9d8080929173dbe5984f61a0
2014-05-27 17:23:35 +03:00
0a861a50b6 error C2872: ´chart´ : ambiguous symbol
Change-Id: Ic6d8366b2754c7f626552d66821d40319910559c
2014-04-25 19:15:30 +01:00
f7731b7301 chart2: use constructor feature for ShapeToolbarController
Change-Id: Ic0a9dc23ddfde00cbb2bfa7cf3983ff0c6276654
2014-04-25 10:51:25 +02:00
329332ba52 chart2: sal_Bool->bool
Change-Id: I85751b4e636596ef88ef02bc958abdc6abf98427
2014-04-15 15:23:29 +02:00
5babf1b903 remove unnecessary scope qualifier from sal_Bool uses
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
196f980012 fdo#54938: Replace existsValue for cppu::supportsService
As now ::comphelper::existsValue is not used anymore, we're removing this too.

Change-Id: I9bd2544a9c378f5a18746255133f5684867e0114
Reviewed-on: https://gerrit.libreoffice.org/6378
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-23 14:58:17 +00:00
7be7824bbb chart2: String to OUString
Change-Id: I8abc6a31a46bea404e9d8b0c8777e3400dbf928c
Reviewed-on: https://gerrit.libreoffice.org/5865
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-09-08 02:23:15 +00:00
dd9c97d587 fdo#62475 removed pointless comments
Change-Id: I3f5e86dba2df950aeb12c895f52d99274c0959aa
Reviewed-on: https://gerrit.libreoffice.org/5148
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-07-29 11:34:33 +00:00
86fdce6011 fdo#46808, Convert svt::ToolboxController to XComponentContext
.. and all of it's friends

Change-Id: I408d9308d1d1a4f8ed0055ac5f4042d729c44d1e
2013-04-08 13:53:03 +02:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
d05287a9f1 RTL_CONSTASCII_USTRINGPARAM removals
Removed all occurences of RTL_CONSTASCII_USTRINGPARAM in chart2.

Change-Id: I0ab188e2d67a5fc17a3653e5213031f6e2c2581d
Reviewed-on: https://gerrit.libreoffice.org/2244
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-02-20 22:58:20 +00:00
750fc20611 replace remaining InterlockedCount() with inlined version
Change-Id: Ifcfa48fc87f905a91470a5b0fd597b02f220784c
Reviewed-on: https://gerrit.libreoffice.org/671
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-09-25 01:55:38 +00:00
63c508e3e8 re-base on ALv2 code. Includes:
118568: switch to using ucpp
    Patch contributed by Juergen Schmidt
    http://svn.apache.org/viewvc?view=revision&revision=1209396
2012-07-18 09:29:19 +01:00
8a01ee6243 Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator
Pattern used:

find . -name "*.cxx" -exec sed -i 's/\( *\)\(else if\|if\) *( *\([^!()|&]*\)\.equalsAsciiL( *RTL_CONSTASCII_STRINGPARAM *( *\([^)]*\) ) *) *)$/\1\2 ( \3 == \4 )/' \{\} \;
2012-04-06 14:30:05 +02:00
6da8379e14 remove include of pch header in chart2 2011-11-27 12:59:19 -06:00
12343c1556 Merge commit 'ooo/DEV300_m101' into integration/dev300_m101 2011-03-10 20:21:13 -05:00
cb2edbe3e4 Replace suitable equalsAscii calls with equalsAsciiL. 2011-01-19 23:12:18 +01:00
3d6a5a98cd removetooltypes01: #i112600# remove tooltypes from chart2 2011-01-14 15:18:08 +01:00
c94a7511bf merge vosremoval-mutex.diff
In practice the changeset is 'inspired' by vosremoval-mutex.diff
but was essentially redone manually
2010-10-25 17:57:36 -05:00
defa3490b4 use SolarMutexGuard to guard the SolarMutex 2010-10-25 17:54:58 -05:00
63bb42ab7d Add vim/emacs modelines to all source files
Fixes #fdo30794
Based on bin/add-modelines script (originally posted in mail
1286706307.1871.1399280959@webmail.messagingengine.com)

Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
2010-10-13 10:57:18 +02:00
a874863e70 chart45: #i110805# Chartshapes: Toolbarbuttons can't be opened 2010-04-14 17:59:20 +02:00
568a8725ae chartshapes: merge with DEV300_m72 2010-03-01 12:22:02 +01:00
8afe8f977f #i12587# Inserting/Editing arbitrary text objects in chart 2009-10-23 14:02:04 +00:00
4d3c143900 #i12587# Inserting/editing arbitrary text objects in chart 2009-10-21 12:52:00 +00:00