6cad548ee2
chart2: add some locking to chart::ChartType UNO service
...
On the libreoffice-4-3 branch, chart2_unoapi crashed with what looks
like a corrupted ChartType::m_aDataSeries triggering STL assertions.
Try to protect the mutable members with SolarMutex guards.
Change-Id: I3f2edd36b8ecf37ef60239415f70abfc8b59244d
2014-07-04 15:06:12 +02:00
3575dba98d
remove whitespaces
...
Change-Id: I05ef3c1ffd4e2179e0142a21abf8a4578718102e
2014-07-02 23:03:07 +02:00
1d38cb3655
fdo#71076, fdo#71767: Preserve number formats when charts are copied.
...
Change-Id: If5ae8852152012483237e7602e56a0c46ea8748a
2014-06-19 14:46:56 -04:00
2538e30ccc
Use define constant to keep track of all NumberFormat property usage.
...
Change-Id: I2a544922e03ec8253290ac8bf5a89c9cdd72d8dd
2014-06-19 14:46:56 -04:00
3e82897353
improve the inlinesimplememberfunctions clang plugin
...
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
184a00b962
loplugin: inlinesimplememberfunctions
...
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
439550c9f1
remove unnecessary and unused chart debug functionality
...
Change-Id: Ic8100b2afebe469709723b324394e08b7669d911
2014-06-07 04:48:16 +02:00
92b447876d
css already means ::com::sun::star
...
Change-Id: I48d7b746d7cc49246743c62480b0d225d2519342
2014-05-27 14:00:28 +02:00
227af32d8c
Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part18
...
Change-Id: Ibf958dbfbf7cdbe6ad31d390138be8d4d468c225
2014-05-20 23:29:53 +02:00
0d8908b359
Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part16
...
Change-Id: I78b3a0151397d4e69521e6b2451e93ea6e463376
2014-05-18 00:36:10 +02:00
ca52e5ff2c
support property mapping in new 3D charts
...
Change-Id: I3da71e354ed2595c1f5b2eaeb5fb565205d24de0
2014-05-16 12:44:15 +02:00
2bd7767d01
Resolves fdo#70681: fixincludeguards.pl: all that's left
...
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-05-15 12:50:46 +00:00
329332ba52
chart2: sal_Bool->bool
...
Change-Id: I85751b4e636596ef88ef02bc958abdc6abf98427
2014-04-15 15:23:29 +02:00
5babf1b903
remove unnecessary scope qualifier from sal_Bool uses
...
i.e. convert "::sal_Bool" to "sal_Bool"
Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
362d4f0cd4
Explicitly mark overriding destructors as "virtual"
...
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."
Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
692714b7da
chart2: loplugin:saloverride
...
Change-Id: I795c8337f3d5fcf3e39849204867f0d57f40c843
2014-03-29 18:10:09 +01:00
ffaf640b73
Add API wrapper to handle properties of new GL3D chart type.
...
Now the new proprety gets properly imported and exported to and from ODF.
Also, more on replacing string literals with define macro constants.
Change-Id: I4b773d68610a8aeaeb239901dac166e4dc2dd80d
2014-03-29 00:47:21 -04:00
0be6a5ef37
Transfer back properties from the chart type object to template object.
...
Change-Id: I3484a2ae0141087835e34e4e174bdc24b3357854
2014-03-29 00:47:20 -04:00
ef15c94699
Trying to move this RoundedEdge property from Diagram to GL3DBarChartType.
...
Then things stop working. Go figure.
Change-Id: I38893b20104537a64d279063c7b7dd708efb0d2f
2014-03-29 00:47:20 -04:00
68e20faf3f
Start using common symbols for textural UNO property names.
...
This will make it easier to track all uses of a UNO property name using
symbol database lookup, which is much faster and more accurate than grepping.
Change-Id: I8c2857504c29bcce01eb8c1f406dcbfb24331510
2014-03-29 00:47:19 -04:00
c260edff34
ChartTypeTemplate and its derivatives are not UNO service implementations
...
Change-Id: Ic4a4c0fe411c359f5305f01c8ff79ca48384b484
2014-03-28 14:14:42 +01:00
1d8f8c55f8
Missing XServiceInfo base class
...
Change-Id: Ib629a60d626c10ac9628d172896790e90d2daf51
2014-03-28 12:36:08 +01:00
567ef6d578
Second batch of adding SAL_OVERRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
f6f179c502
Pass the rounded edge property to the diagram object.
...
Change-Id: I71fa1bf82b879a1da69ca78d53bcf8072bdfa9ae
2014-03-26 23:14:58 -04:00
cea725111c
Add the UI bits for showing "rounded edge" property for GL3D chart.
...
Change-Id: Ia6083c423bf8286a0b562d490283f8e1328a0124
2014-03-26 23:14:58 -04:00
e1823a9f8a
Add a boolean "RoundedRectangle" property to the GL 3D chart.
...
Change-Id: I3cb23461718c5713c1e76d0b37d92b3e7849d13b
2014-03-26 23:14:57 -04:00
975bbf29df
Error: exception specification of overriding function is more lax than base
...
Change-Id: Iffcc2084e005b27653964ddc6e965744be370a16
2014-03-26 07:46:30 +02:00
44fc32edcd
Properly import and export the new chart type to and from ODF.
...
Change-Id: I38e9813c6eb853dfb92b1537cea0b9ad97473b57
2014-03-25 22:50:50 -04:00
05efb605b3
Add a new skeleton plotter for the GL3D bar chart.
...
It plots absolutely nothing. It's just a place holder for now.
Change-Id: I6eb9cc23481391b83f6946a8b49a6176c5b29cd7
2014-03-25 22:50:50 -04:00
be1152e0cc
List child type for GL3D bar chart type.
...
For now there is only one child type.
Change-Id: If39a3e75fdae62f0b20769c21e6a4e235ede941e
2014-03-25 22:50:49 -04:00
56aaa39ff8
Skeleton template class for GL3D bar chart type.
...
Still very much empty. It needs to be filled with sub-categories.
Change-Id: Iad7ad34efb264025541b585a92ee2ea7b8fff56f
2014-03-25 22:50:49 -04:00
349a5b72bf
Initial skeleton class for the new chart type. Still very much empty.
...
Change-Id: I5e9eaeb9337d51f59f800f8e676b8bc83b80df70
2014-03-25 22:50:48 -04:00
325ecb1d05
Let's be more defensive here by checking for null return objects.
...
Change-Id: I5164e7d82f882ea9fe296a5a2df616d396d6726f
2014-03-24 22:24:50 -04:00
fc9c196df1
add property mapping to a few more chart types
...
Change-Id: If02f865741524f74277b77615dea1bc71fb576eb
2014-03-09 19:27:49 +01:00
1e9993be10
don't hardcode property mapping, read them from chart2::XChartType
...
Change-Id: I7889dbddab603d7650d58a04f53e7c5fe38fcce2
2014-03-09 19:27:49 +01:00
4b9d59dbbb
no need for overwriting this method
...
Change-Id: I8d81f9f7d80ceabd85077acd3239069988be3586
2014-03-09 19:27:49 +01:00
f2cdf8848c
Remove visual noise from chart2
...
Change-Id: Ic8dc71c2815df265e1935e629e0220396a50aaac
Reviewed-on: https://gerrit.libreoffice.org/8239
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2014-02-27 00:44:41 -06:00
5e21a413c7
cppuhelper: retrofit std::exception into overriding exception specs
...
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-23 03:38:49 +00:00
7f0fe5444f
bool improvements
...
Change-Id: I8e83eb52a8873e6c7372091c697158053da82488
2014-01-22 08:22:35 +01:00
3c10c9ec66
Remove code that never effectively did anything
...
... since inception in 44569a657c4282757443ae06efc6441e571a0409 "CWS-TOOLING:
integrate CWS bubblechart."
Change-Id: I1785ef41bf7146ea7f4d8927165c38317d7183e8
2013-11-28 17:58:03 +01:00
75b7ce9c66
fixincludeguards.sh: chart2
...
Change-Id: I166e054926fb975949b3021cbc43b25a222f6198
2013-10-23 23:22:34 +02:00
3aea6c121d
Mark as const
...
Change-Id: I7ad2a1bd29afbf4813b1ad984081935ca84ec98a
2013-08-02 10:34:43 +09:00
dd9c97d587
fdo#62475 removed pointless comments
...
Change-Id: I3f5e86dba2df950aeb12c895f52d99274c0959aa
Reviewed-on: https://gerrit.libreoffice.org/5148
Reviewed-by: Luboš Luňák <l.lunak@suse.cz >
Tested-by: Luboš Luňák <l.lunak@suse.cz >
2013-07-29 11:34:33 +00:00
1946794ae0
mass removal of rtl:: prefixes for O(U)String*
...
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).
Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
ef53a3a12e
Some cppcheck cleaning
...
Change-Id: I993bd95b31f1090c747f01a899650e8873dcaada
2013-04-02 23:01:14 +02:00
aa46348777
remove C2U in chart2
...
Change-Id: Id7ebf66319f0891d276a3da95a95658aed59cbc7
2013-03-25 16:14:02 +01:00
bab961dd0a
Fix chart2 build
...
Change-Id: Ia3eb1c1576034c1cbc93e9fb4e60d205a325b132
2013-03-11 18:15:05 +01:00
ded39ea57b
#119989# Support relative 3D pie chart height when importing charts.
...
Reported by: Yan Li
Patch by: Yan Li, Tan Li, alg
Review by: alg(cherry picked from commit 2b1cedbe547ea8f7979f91873dd6e602ebb08a7b)
Signed-off-by: Fridrich Štrba <fridrich.strba@bluewin.ch >
Conflicts:
chart2/source/view/charttypes/PieChart.cxx
chart2/source/view/main/ChartView.cxx
sc/source/filter/inc/xlchart.hxx
Change-Id: Ibc6f070021c79809c651ba789409a5fb5096c185
2013-03-11 17:34:44 +01:00
a6b9173005
fdo#60148 Clean up warnings from the Clang compiler plugin
...
Change-Id: I08d755677c46c476710ecbd067ed9f7e2f54a671
loplugin: clean warnings: unused variables, incorrect indentation and log area.
Reviewed-on: https://gerrit.libreoffice.org/2544
Reviewed-by: Eike Rathke <erack@redhat.com >
Tested-by: Eike Rathke <erack@redhat.com >
2013-03-06 12:59:26 +00:00
