wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
362,282 Commits 5 Branches 0 Tags
a43ba14c532f7abb5cef243065d64a1283cf94de
Commit Graph

6102 Commits

Author SHA1 Message Date
Caolán McNamara
5bdfa8c124 Resolves: fdo#62682 crash on second export of svg 
because the first export has left "dangling" CalcFieldValueHdl Links in
Outliners that got created based on the Drawing Outliner while it had a
temporary CalcFieldValueHdl installed, and didn't get the old CalcFieldValueHdl
installed when the old Drawing Outliner one was re-installed.

Change-Id: I064a154ece488c9a4c3467b753451df7e73ae883
 2014-10-17 15:20:00 +01:00
Caolán McNamara
711e74544d coverity#1242624 Untrusted loop bound 
Change-Id: If2ae1982eec100f5602a13d648beec247ced6aa2
 2014-10-17 15:19:58 +01:00
Caolán McNamara
cf63ebe0f0 coverity#1242717 Untrusted loop bound 
Change-Id: I983bba075ab9626c90555fa41f9d473ae60fafea
 2014-10-17 15:19:56 +01:00
Caolán McNamara
bbe264a19f coverity#1242724 Untrusted value as argument 
Change-Id: I6041d09ef0a4ed4af5f1bf93f31a1eac60be1af7
 2014-10-17 15:19:56 +01:00
Stephan Bergmann
afcd04f74b Missing const 
Change-Id: I8d05851c162ee9215f773ebfb9435e549b1572d4
 2014-10-17 14:37:31 +02:00
Stephan Bergmann
fc78d8dfba Pass args by const & 
Change-Id: I510e1aba6772e1f8d4013b235e95a1e5599fd601
 2014-10-17 14:23:46 +02:00
David Tardon
582ef22d3e fdo#84854 it seems long is not enough on 32 bit 
Fraction used BigInt internally for computations, rational does nothing
like that.

Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
 2014-10-16 17:44:44 +02:00
osnola
57d3b5cfa6 Update to last libmwaw version 
+ add filters for MacDraw, MacDraw II and RagTime (v2-3 for Mac)

Change-Id: If84abff1baa75f9bfa951039781575b6a8648a84
 2014-10-16 17:44:43 +02:00
Noel Grandin
9341bf3dc3 java: when rethrowing, store the original exception 
Change-Id: I34ce000c48d2d79bfec854c8dd55d12f2bee29c7
 2014-10-16 12:27:15 +02:00
Noel Grandin
0f86ae0689 java: no need to call toString() on a String object 
Change-Id: I05fa4bf198b3d77b1217eb65b5a1c79915016522
 2014-10-16 08:15:44 +02:00
Caolán McNamara
cb4cb0c053 one of the oddest things I've seen 
Change-Id: Ia0240d212a39401ea119588f4a0731b2b99d1d1f
 2014-10-15 16:56:59 +01:00
Stephan Bergmann
b1023801e4 Blind Win fix attempt 
Change-Id: I39df464321685ebef29f44221bab9005295d0c3f
 2014-10-15 16:16:46 +02:00
Stephan Bergmann
ad9498f8b8 More -Werror,-Wunused-private-field 
...detected with a modified trunk Clang with

> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp	(revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp	(working copy)
> @@ -1917,9 +1917,10 @@
>    const Type *T = FD.getType()->getBaseElementTypeUnsafe();
>    // FIXME: Destruction of ObjC lifetime types has side-effects.
>    if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> -    return !RD->isCompleteDefinition() ||
> -           !RD->hasTrivialDefaultConstructor() ||
> -           !RD->hasTrivialDestructor();
> +    return !RD->hasAttr<WarnUnusedAttr>() &&
> +           (!RD->isCompleteDefinition() ||
> +            !RD->hasTrivialDefaultConstructor() ||
> +            !RD->hasTrivialDestructor());
>    return false;
>  }
>
> @@ -3517,9 +3518,11 @@
>    bool addFieldInitializer(CXXCtorInitializer *Init) {
>      AllToInit.push_back(Init);
>
> +#if 0
>      // Check whether this initializer makes the field "used".
>      if (Init->getInit()->HasSideEffects(S.Context))
>        S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
>      return false;
>    }

to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").

Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
 2014-10-15 15:58:56 +02:00
David Tardon
7d05bbd50d avoid double-delete 
This is a regression from commit b1d48f0d9a3442c11adae6e36325a463d89ce44e.

Change-Id: Iffd39782c1d1fd7be14f4d657919f704807a40f5
 2014-10-15 11:41:51 +02:00
Stephan Bergmann
bd86b38c5b Make ImportCGM signature match ImportCGMPointer (in sdcgmfilter.cxx) 
Change-Id: I363777ff59b1756a15615d3daaa0c95542632361
 2014-10-15 09:45:27 +02:00
Michael Meeks
e9e0ab4777 fix tinderboxen with the right sort of brackets. 
Change-Id: I13869771890ce5702d64053e7823dd5cedc82a40
 2014-10-14 18:16:52 -03:00
Caolán McNamara
b13591d48f valgrind: init GroupLevels 
Change-Id: Idccebc826ade29a507e115108d20fd461b7bb4ec
 2014-10-14 17:13:46 +01:00
Caolán McNamara
740617901d stray ;s all other the place 
Change-Id: If67bf3361e082c1321f42ae7717cc941dc96e74b
 2014-10-14 17:13:46 +01:00
Caolán McNamara
b251762c65 valgrind: multiple errors 
Change-Id: Ic0ee492710650165004ad05f523424ba1b094473
 2014-10-14 17:13:45 +01:00
Caolán McNamara
2e23493987 check for short reads 
Change-Id: I98a7d77cabe0207ff2b0190ccef47b87d1552930
 2014-10-14 17:13:45 +01:00
Caolán McNamara
aeea1cab43 sal_True->true 
Change-Id: Idbbc50afbb229dca1b62a7a0d1b2eeec9b0418d5
 2014-10-14 17:13:45 +01:00
Caolán McNamara
b2b5bc10b6 valgrind: Source and destination overlap in memcpy 
Change-Id: I0b83a1955b6752c1253cfd7992a50b932aac078d
 2014-10-14 17:13:44 +01:00
Caolán McNamara
61550120b4 valgrind: Mismatched free() / delete / delete [] 
Change-Id: I78a9e08fb3535f9fe6c61a6e192c7aff4ef0c527
 2014-10-14 17:13:44 +01:00
Caolán McNamara
4d82ccb1ed valgrind: Mismatched free() / delete / delete [] 
Change-Id: I293229dabb9a04f2e76b556e9da66921328ebe23
 2014-10-14 17:13:43 +01:00
Noel Grandin
af5ebbf783 create a macro library for implementing bit-flags types 
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>,
changed from a macro- to a template-based solution.  (Unfortunately MSVC 2012
does not support explicit conversion operators.  Worked around that with
explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and
SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a
baseline that requires unconditional support for them.)

Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396
 2014-10-13 17:45:57 +02:00
Caolán McNamara
34de4f3e1c coverity#1130166 Unchecked return value 
Change-Id: I0730a099463ac77afce4bb999f3f00ad7bb097c7
 2014-10-12 16:39:52 +01:00
Michael Stahl
3d85ec29dd filter: stop leaking temp files in xsltfilter test 
Change-Id: Icefec168910ba0b059f4b1887ec67cce8505ffd6
 2014-10-11 00:28:47 +02:00
Chr. Rossmanith
5e27d23d7e fdo#65864: dont't traverse defs-nodes when in shape writing mode 
Relevant for opening svg images via File->Open:
Children of the <defs> element should be interpreted only during the
style collecting step. Collecting <path> elements from clip paths
during the shape writing step leads to unwanted black polygons.

Change-Id: I73598134c9be2877e975a7e756541ec3026fe768
Reviewed-on: https://gerrit.libreoffice.org/11793
Reviewed-by: Thorsten Behrens <thb@documentfoundation.org>
Tested-by: Thorsten Behrens <thb@documentfoundation.org>
 2014-10-10 21:58:26 +00:00
Andras Timar
c1a7e72110 typo: follwing -> following 
Change-Id: Ia201473c84dc0923e8f4bee6329ad926cd6addd6
 2014-10-10 14:55:12 +02:00
Caolán McNamara
cb02551714 coverity#1242472 gold, Identical code for different branches 
Change-Id: Ibdba24ef03ee4732e216b32b3f9e665706e96e4a
 2014-10-10 12:50:25 +01:00
Noel Grandin
c2621e6482 cid#1244954 Uncaught exception 
Change-Id: Ica5e88ed8294c4256da2798093cd4a191b7c5313
 2014-10-10 10:14:16 +02:00
Juan Picca
47a2d7642d fdo#81356: convert Fraction to boost::rational<long> - wip 
* Added rational util functions used by Fraction class not
  available in the boost::rational class.
* Replaced usage of Fraction by boost::rational<long>
* Removed code that relies on:
  1. fraction.IsValid() -- rational only allow valid values, ie
     denominator() != 0
  2. rational.denominator() == 0 -- always false
  3. rational.denominator() < 0 -- always false but implementation
     detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation
* Simplified code that relies on:
  1. rational.denominator() != 0 -- always true
* BUGS EXIST because Fraction allows the creation of invalid values but
  boost::rational throws the exception boost::bad_rational

Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9
Reviewed-on: https://gerrit.libreoffice.org/11551
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
 2014-10-09 11:33:33 +00:00
Takeshi Abe
ad8c2f7090 fdo#75757: remove inheritance to std::vector 
from SvxMSDffShapeOrders.

Change-Id: Idf551f1fbde907759d6a296141e2837264dbbb10
Reviewed-on: https://gerrit.libreoffice.org/11840
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-10-08 15:18:32 +00:00
Takeshi Abe
b1d48f0d9a fdo#75757: remove inheritance to std::vector 
from PptSlidePersistList.

This also puts in assertions that every entry in a PptSlidePersistList
is non-null.
Cf. 9536a28ede89e8c29940e8ba225215a45667062c

Change-Id: Iea35532ed668e58a3f02d3f3433a66c2d4e1fe2a
Reviewed-on: https://gerrit.libreoffice.org/11807
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
 2014-10-06 14:09:20 +00:00
Noel Grandin
0745982dc5 loplugin: cstylecast 
Change-Id: I88a106081b7413bff6313d1e07f53e39d8350002
 2014-10-06 07:52:55 +02:00
Caolán McNamara
9b68625a9d coverity#1242529 silence Arguments in wrong order 
Change-Id: I662c89e6e3e0917b51e8084bc50a9ea38d6c0838
 2014-10-03 09:07:53 +01:00
Caolán McNamara
9403f75f44 coverity#1202776 'Constant' variable guards dead code 
Change-Id: Ib1d5dcc8b09e11a8ef2399e3ef1a5ae1769de90f
 2014-10-02 14:49:07 +01:00
Caolán McNamara
6250f61fc8 coverity#1242472 Identical code for different branches 
Change-Id: I32a74aa1ad42b975bca4b13403d261fd31deb8dd
 2014-10-01 20:29:02 +01:00
Tor Lillqvist
ec14701234 We require OS X SDK 10.8 or newer now 
Change-Id: I68eee76c8710c89af8e3c1e1006345f908923ece
 2014-10-01 17:27:59 +03:00
Noel Grandin
fc04f76336 fdo#82577: Handle Time 
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.

Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-01 07:34:23 +00:00
Noel Grandin
c9d4a2887c fdo#82577: Handle PolyPolygon 
Put the TOOLS PolyPolygon class in the tools namespace. Avoids clash with the Windows
PolyPolygon typedef.

Change-Id: I811ecbb3d55ba4ce66e4555a8586f60fcd57fb66
 2014-09-30 11:47:41 +02:00
Noel Grandin
8dbde0845a fdo#82577: Handle Region 
Put the VCL Region class in the vcl namespace. Avoids clash with the X11
Region typedef.

Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
 2014-09-30 09:58:23 +02:00
Adolfo Jayme Barrientos
89d408031b border_width from 12 to 6, as the rest of dialogs 
Second pass.

Change-Id: Ic4702d2ca7a9d54ee4712dcd073006f16b2d5d1d
Reviewed-on: https://gerrit.libreoffice.org/11669
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
 2014-09-28 19:42:47 +00:00
Noel Grandin
4e26b91568 remove unnecessary casts in misc calls to SvStream.Write* 
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: Ib80032e8626f5476a89b958f590441994594f4e4
 2014-09-26 15:27:18 +02:00
Noel Grandin
5cefde06ea remove unnecessary casts in calls to SvStream.WriteUInt32 
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: I1d848f19f82783e6eabf2da37dbde78fe36ea1e0
 2014-09-26 15:27:17 +02:00
Noel Grandin
04fd62096f remove unnecessary casts in calls to SvStream.WriteInt32 
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: I0c0172519479be0535a447e41a592fbf782751bd
 2014-09-26 15:27:17 +02:00
Noel Grandin
5501c8d222 remove unnecessary casts in calls to SvStream.WriteUInt16 
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: I482ca7abb84613971e7e8f839f7aa67a65cd71ff
 2014-09-26 15:26:48 +02:00
Noel Grandin
dedfa972bc remove unnecessary casts in calls to SvStream.WriteInt16 
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: Ie44bec6b988f3e46fe78d14b740818c9141f5df0
 2014-09-26 15:26:48 +02:00
Noel Grandin
bec72dd34f remove unnecessary casts in calls to SvStream.WriteUChar 
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: I2ea4c7d97e745b3e6a3834f41ac7bfefa4883c7a
 2014-09-26 15:26:19 +02:00
Noel Grandin
d46b16e1e4 remove unnecessary casts's 
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: I63f18be8e940098c2acbbc73ee49ede3a949fcb2
 2014-09-26 15:25:40 +02:00