Commit Graph

236 Commits

Author SHA1 Message Date
08d93506c2 Make these methods non-inline again.
Change-Id: I30c7969ab386f4cba2f0b44cbebe306ce6430b15
2014-10-03 15:31:20 -04:00
1df1c5eed9 formula: std::auto_ptr -> std::unique_ptr
Change-Id: I7b4784abf5177e22a9df33c5d4faccfd39801b11
2014-09-26 15:47:03 +02:00
234fba5b45 convert OSL_FAIL to SAL_WARN
Change-Id: I001f29dca5f2a01d70115bb309c99c64c4a65efb
2014-08-22 19:50:52 +02:00
fe4d72b563 it's about time to write GOALSEEK as ODFF ORG.OPENOFFICE.GOALSEEK
Change-Id: Ie5a0464b49baae62e217e87f4d0040151f3aa8a5
2014-08-21 15:43:09 +02:00
7c6a82d66e write COLOR function with extension namespace
and add to Excel import/export maps so it survives saving in that format

Change-Id: I3a8e07fdd1bded77d4bad60eefffeb0b1dbdd734
2014-08-21 15:10:08 +02:00
5021f29841 Remove some unused code
Change-Id: Ib1fb5108a858c35a5bbe8ba865e15660639725e3
Reviewed-on: https://gerrit.libreoffice.org/10593
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-07-29 14:20:36 +00:00
ce4e7a830d fdo#81038 Fixed FormulaTokenIterator to use std::vector instead of linked list
Change-Id: I09f9adfa52b64732cc6200a0dbeb6263435c7c07
Reviewed-on: https://gerrit.libreoffice.org/10565
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-07-27 04:03:07 +00:00
08e3e6c223 fdo#73148 add options to Calc function AGGREGATE
matrix-ranges not supported

Change-Id: I902c78da6d9c7a4a5f8c5e4a7e1678b69d49a6fe
Reviewed-on: https://gerrit.libreoffice.org/9449
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-07-08 10:23:03 +00:00
c9d037e5e8 resolved fdo#79957 propagate ForceArray through jump tokens
ForceArray parameters weren't propagated and enforced to array arguments
on svJump tokens (FormulaJumpToken), namely IF, CHOOSE, IFERROR and
IFNA.

Change-Id: Icf9074f11b826655a52858d778d9a0122d207aa4
2014-06-13 14:21:34 +02:00
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
f824604b5c fix spelling
Change-Id: I1a4d66a78549ea49649a6bed92acb44dbd8b13e2
2014-05-21 13:14:11 +02:00
636581bf87 most certainly == was meant
Change-Id: I1b0833daa576cd8603421e1036b8773badc8c775
2014-05-21 12:45:24 +02:00
c07b8dedf7 ODS load perf: transfer ownership of the ScTokenArray to save cycles.
Add API to wnsure we don't end up allocating 32k bytes of tokens
for each ScFormulaToken, as happens when you Add a token to a new
empty ScTokenArray.

Change-Id: Ib12a3065eb513243a2146ebb009fbaa650385dd9
2014-05-21 10:03:36 +01:00
3db8d606d5 hrc and src files: squeeze multiple newlines
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done

Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-19 20:04:22 +02:00
dd0f844728 add COLOR function
This function makes property mapping in charts more user friendly.

Change-Id: I01cfb31edd749ee474d5078042fa5c4b4a270f86
2014-05-19 08:13:37 +02:00
b6b0b95bae Bail out of group calculation in case the array fetching fails.
Change-Id: Ibb7575eeb025fc025d05b147629113796185c5d3
2014-05-14 16:25:38 -04:00
a921d38ad4 No more SetCompileForFAP(). Use respective flag setting methods instead.
Change-Id: Ib2256ebac8a7e63e7e24fb35d13d47b811bd8e19
2014-05-14 13:15:11 -04:00
69a7e7440c Use "stop on error" concept rather than "ignore error if true".
Just to keep the pattern of "true" -> "action", "false" -> "no action".

Change-Id: I6303bc779cd7048eef2fdc3c2abba8be8f15da6d
2014-05-14 13:15:11 -04:00
5db9391c06 Introduce a new boolean flag and use it in lieu of bCompileForFAP.
To make it sound more general than "compile for FAP".

Change-Id: Ia6916b6f3579a290be7d5074f809666be2bd2473
2014-05-14 13:15:10 -04:00
90c644a862 coverity#707866 Uninitialized pointer field
Change-Id: Ia80922b1819d41e4963689fda87750f0f507fd57
2014-05-10 21:13:04 +01:00
50d100f4ac Make a separate method to detemine if an opcode is a jump command.
Jump to make it a bit more pleasant to follow the code...

Change-Id: Ie9bef122e8bb63a2d8cc54acc9c8ddc9ac9a2e8a
2014-05-01 15:29:24 -04:00
29c9712b04 fdo#73148 (partial patch) Add Excel 2010 function AGGREGATE
Change-Id: If8fc8608699a14e573456af2e1180342be942dd1
Reviewed-on: https://gerrit.libreoffice.org/8475
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-04-25 09:39:31 +00:00
0882cc6675 fixincludeguards.sh: formula 2014-04-19 11:10:06 +02:00
eb4c43aa61 Avoid possible memory leaks in case of exceptions
Change-Id: Ie07c6c9989da444eb6052691696e95b808c23fb0
2014-04-15 16:12:31 +09:00
625c595fc3 fdo#76294: Intern strings in AddFormulaToken() as well.
And a whole bunch of changes needed to make that happen.

Change-Id: Idd98fbc99322c0d72fb0a7848d89cb1a6abc88b6
2014-04-14 18:34:20 -04:00
b09426b83c fdo#76294: Properly intern string literals in formula on xls import.
Change-Id: Ib3a442cbb68c23294762561f2911101a087a795e
2014-04-14 17:00:40 -04:00
56deaabb32 fdo#73149 add Excel 2010 functions ERF.PRECISE and ERFC.PRECISE
Change-Id: I3199470ec92923e8cc12156f21dd397d870cc1e0
Reviewed-on: https://gerrit.libreoffice.org/8930
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-04-11 13:43:14 +00:00
355baf5734 fdo#75741: Re-implement CompileNameFormula for formula groups.
Change-Id: I57e1e464ac5f7abc10ce5ea5752e036ddb6cf6d7
2014-04-07 14:43:16 -04:00
f07bdba6c5 fdo#71720 fix transalate strings
Change-Id: I8758e2407f1d3d1e09324b4fe5cc0442f8dda34d
Reviewed-on: https://gerrit.libreoffice.org/8819
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-04-02 18:43:14 +00:00
22dac22fe2 fdo#73147 add Excel2010 functions NETWORKDAYS.INTL and WORKDAY.INTL
Change-Id: I3ab9dde5c421a3a3e6022a27be37f23547197317
Reviewed-on: https://gerrit.libreoffice.org/8772
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-04-02 14:01:28 +00:00
4b060ce51a Remove remaining DBG_CTOR etc. remnants from formula
Change-Id: I36740cd276d2047552298606f24b2696ed61b36b
2014-03-28 15:34:01 +01:00
d4cc603a5f ISO.CEILING without _xlfn. prefix, it is defined in OOXML, fdo#71720 follow-up
Change-Id: I486261d34d62bc5eda0a202cbb1dcb875ffcf39b
2014-03-10 16:14:50 +01:00
ed77823837 fdo#71720 Add Excel 2010 functions
CEILING.PRECISE, ISO.CEILING, FLOOR.PRECISE

Change-Id: I047b65ca3adafb89fce9b6493948aa851ddca765
Reviewed-on: https://gerrit.libreoffice.org/8488
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-03-10 08:14:14 -05:00
0ca7ab6ea0 Make these non inline.
Change-Id: Ib139850380b039382565e3de3666eebb5750f32d
2014-03-06 20:50:02 -05:00
e4def6edaa fdo#72197 Add Excel 2010 functions
MODE.SNGL, MODE.MULT, NEGBINOM.DIST, Z.TEST

Change-Id: I55eb05e1ebdb9dbc3ce9ae84e3cdacfdfa112091
Reviewed-on: https://gerrit.libreoffice.org/7776
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-03-05 05:53:24 -06:00
41f5dda746 remove unused code in formula/FormulaTokenArray
formula::FormulaTokenArray::AddString(unsigned short const*)

Change-Id: I6c014f6ada3b75398112e81f9c8e7de7dd776c7d
2014-03-05 09:17:42 +02:00
d7f1f91b19 remove unused code in formula/vectortoken
Remove these methods:.
formula::DoubleVectorRefToken::GetRequestedArrayLength()
formula::SingleVectorRefToken::GetRequestedArrayLength()
formula::SingleVectorRefToken::SingleVectorRefToken(
    double const*, unsigned long, unsigned long)

and optimise some accessor methods.

Change-Id: I04f53593894a59dbefdd1cbc9505c6eb7cd8610b
2014-03-05 09:17:42 +02:00
6ef6dd0122 Store the length of originally requested array size prior to trimming.
This change adds GetRequestedArrayLength() method to both single and double
vector ref tokens, which returns the length of the requested array size prior
to trimming of the trailing empty cell region.

Change-Id: Iaba96fa2ea4ff3c8bccb0bc86fa4f1525e2f45fb
2014-02-27 21:19:36 -05:00
224f6c17f7 Remove visual noise from formula
Change-Id: Ie7503623ad9bec1806345f65b435c7bd94a08c2b
Reviewed-on: https://gerrit.libreoffice.org/8263
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 14:50:17 -06:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
2b9fe0c75e cid#707865 Uninitialized pointer field
Change-Id: I86c90a95093d6c90cbc733164a3b773468575b5b
2014-02-21 11:59:09 +02:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
8185ecf65a fdo#73146 Add Excel 2010 functions
PERCENTILE.EXC, PERCENTILE.INC
PERCENTRANK.EXC, PERCENTRANK.INC
QUARTILE.EXC, QUARTILE.INC
RANK.EQ, RANK.AVG

Function ScInterpreter::ScRank() has been rewritten to give the function
the same way of computing as the related functions in this patch.

Change-Id: If3096b265bd47ca5f4afcab7ff746f7c8511df82
Reviewed-on: https://gerrit.libreoffice.org/7319
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-01-30 12:30:56 +00:00
5b1e440304 fdo#72793 Add Excel 2010 functions
T.DIST, T.DIST.2T, T.DIST.RT, T.INV, T.INV.2T, T.TEST
Also, fixed some incorrect string assignments in
formula/source/core/resource/core_resource.src from previously
added Excel 2010 functions.

Change-Id: Ia4d13e7597d2a054d345a08b66b878f91c43f872
Reviewed-on: https://gerrit.libreoffice.org/7226
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-01-27 14:14:19 +00:00
9c09211bce Add internal cell function __DEBUG_VAR to sniff arbitrary internal state.
Useful for debugging in a more flashy way.  But never ever document this
for end users.  If you are an end user reading this, use this at your
own risk.  You have been warned.

Change-Id: Ibbdb45f576287f707106327704754ffaec27ba3c
2013-12-20 20:09:51 -05:00
b55259eeb5 typo fixes
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
924f9d7ea8 fdo#72158 Add Excel 2010 functions
LOGNORM.DIST, LOGNORM.INV, NORM.DIST, NORM.INV, NORM.S.DIST, NORM.S.INV

Change-Id: I695e0645642af1757a1dd7d7f0f15c9515e21309
Reviewed-on: https://gerrit.libreoffice.org/6883
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-12-16 20:25:45 +00:00
d1e1cd128c remove unused code (ancient Calc function ZELLERROR)
code has no function, except that calc documents with formula
ZELLERROR will not produce an error. But the formula is not
interpreted, so remains 'dead code'.

Change-Id: I6e7df7040a0273bcd3ebd497055924b7afdd3311
Reviewed-on: https://gerrit.libreoffice.org/7018
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-12-13 14:09:18 +00:00
8302495a21 store internal CONVERT to .xlsx/.xls and distinguish from CONVERT_ADD
Change-Id: Ie9b5f6ade1c25618aa990ce17bd7b2a2b46a250a
2013-12-02 18:58:00 +01:00