01552f1e77
SID_TOGGLE_MENUBAR (aka slot:6661, .uno:MenuBarVisible) is dead
...
...since introduction of XLayoutManager's private:resource/menubar/menubar in
3fb2acf5b77bff59909f616c44c7de17048b64d7 "INTEGRATION: CWS layoutmanager
(1.52.10); FILE MERGED" etc. and final removal of SID_TOGGLE_MENUBAR bits in
f605b16e395e8ccc3d1aba7907b0792039016f69 "INTEGRATION: CWS sfxcleanup (1.119.8);
FILE MERGED" etc.
What still needs fixing are
extensions/source/activex/SOActiveX.cxx
odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/CustomizeView.java
odk/examples/OLE/activex/SOActiveX.cpp
in a similar way as e.g. 0273d3d81d29d5c1f6c387cca633cd99722c100e "INTEGRATION:
CWS jl18 (1.6.8); FILE MERGED."
Change-Id: I52a43fc7186a4f60929ab6246a2da2e715be7510
2014-10-17 16:58:26 +02:00
5bdfa8c124
Resolves: fdo#62682 crash on second export of svg
...
because the first export has left "dangling" CalcFieldValueHdl Links in
Outliners that got created based on the Drawing Outliner while it had a
temporary CalcFieldValueHdl installed, and didn't get the old CalcFieldValueHdl
installed when the old Drawing Outliner one was re-installed.
Change-Id: I064a154ece488c9a4c3467b753451df7e73ae883
2014-10-17 15:20:00 +01:00
f5b1b266bc
coverity#1247646 Uncaught exception
...
Change-Id: I332fb602466613e9e79ba4510879411e0bee9da6
2014-10-17 15:19:54 +01:00
d63f917d31
coverity#1247643 Uncaught exception
...
Change-Id: I0da9140bf1f76a92c95c042c5039f7cfdbde6c34
2014-10-17 15:19:52 +01:00
6bb741b7f4
coverity#1247638 Uncaught exception
...
Change-Id: Ibdda31c2a8d8c3314173f381b60800ccfbcc25f7
2014-10-17 15:19:49 +01:00
0c0c77af06
coverity#1247635 Uncaught exception
...
Change-Id: Ic346a5820102a922f54c971e01587601991bd484
2014-10-17 15:19:47 +01:00
fabbdc70ad
coverity#1247632 Uncaught exception
...
Change-Id: I8d6df8c6853f0bd2f0b099d14bf0ac246170e7f1
2014-10-17 15:19:44 +01:00
ef057fc58e
coverity#1247629 Uncaught exception
...
Change-Id: Ib0f0555ba5630b225a4a5fbc64394becdeb9f7dd
2014-10-17 15:19:42 +01:00
51d86c9e62
Consistency around SdrAngleItem in svx/sxciaitm.hxx
...
...similar to what has been done for svx/sdtmfitm.hxx in
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."
Change-Id: I8e76e4751e50f5952c6dfff9ee10362166bf0523
2014-10-17 15:36:13 +02:00
968cadb825
allow construction of BigInt from sal_Int64 on 32 bit
...
Change-Id: Ib68920fc9bd693d2f2679b4fc27d9956dc42fc86
2014-10-17 13:17:21 +02:00
2f28fc6e99
Remove some completely unused SID_s
...
Change-Id: I1a259f9af77bbbffc4f0bc85beb7945e3d74ff77
2014-10-17 11:55:55 +02:00
b00b7a68a7
-Werror,-Wunused-private-field
...
Change-Id: I8f312a511b383e1f0f7943a210935386869035b1
2014-10-17 11:15:38 +02:00
eca78aee9b
Increase assert coverage of OUStringBuffer arguments
...
Only covers arguments that can be validated with a simple
comparison, and does not attempt validation of arguments which
would require calculation of the length of a string inline
Change-Id: I8a29c8743b47efe3dd45897a1f1371191a5ddb62
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >
2014-10-17 10:10:55 +02:00
582ef22d3e
fdo#84854 it seems long is not enough on 32 bit
...
Fraction used BigInt internally for computations, rational does nothing
like that.
Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-16 17:44:44 +02:00
aef6ab2098
Strip svidl down to what is still used
...
...the generated .ilb, .lst, and .sid outputs requested by SdiTarget were
apparently unused.
Change-Id: I1abb2abc7945070451fce4a98a11d955515e3f63
2014-10-16 08:13:33 +02:00
6832d9f0f0
coverity#735333 flush out pointless calls to IsRemote and IsOpen
...
etc.
Change-Id: I588d4486071b1e31897d4e6468a2c634d6856832
2014-10-15 16:56:57 +01:00
cbc1176c14
SfxMedium::IsRemote can be made const
...
Change-Id: Id6b14366d11c15ec1440482cfb725e497807fa2e
2014-10-15 16:56:57 +01:00
b1023801e4
Blind Win fix attempt
...
Change-Id: I39df464321685ebef29f44221bab9005295d0c3f
2014-10-15 16:16:46 +02:00
ad9498f8b8
More -Werror,-Wunused-private-field
...
...detected with a modified trunk Clang with
> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp (revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp (working copy)
> @@ -1917,9 +1917,10 @@
> const Type *T = FD.getType()->getBaseElementTypeUnsafe();
> // FIXME: Destruction of ObjC lifetime types has side-effects.
> if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> - return !RD->isCompleteDefinition() ||
> - !RD->hasTrivialDefaultConstructor() ||
> - !RD->hasTrivialDestructor();
> + return !RD->hasAttr<WarnUnusedAttr>() &&
> + (!RD->isCompleteDefinition() ||
> + !RD->hasTrivialDefaultConstructor() ||
> + !RD->hasTrivialDestructor());
> return false;
> }
>
> @@ -3517,9 +3518,11 @@
> bool addFieldInitializer(CXXCtorInitializer *Init) {
> AllToInit.push_back(Init);
>
> +#if 0
> // Check whether this initializer makes the field "used".
> if (Init->getInit()->HasSideEffects(S.Context))
> S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
> return false;
> }
to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html >
"-Wunused-private-field distracted by side effects").
Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15 15:58:56 +02:00
0ece187f92
loplugin: cstylecast
...
Change-Id: I0ccdd2ce18336afea67a3f296b26b2de50f14808
2014-10-15 13:57:08 +02:00
d9fa1247be
fdo#84938: replace SYMBOL_TYPE constants with enum
...
Change-Id: Ib3763f20d74c22e28d519a9ac47f6f3ab4e31f51
Reviewed-on: https://gerrit.libreoffice.org/11983
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-15 10:13:04 +00:00
7d05bbd50d
avoid double-delete
...
This is a regression from commit b1d48f0d9a3442c11adae6e36325a463d89ce44e.
Change-Id: Iffd39782c1d1fd7be14f4d657919f704807a40f5
2014-10-15 11:41:51 +02:00
872036c8e2
remove unused DECL_OBJHINT and IMPL_OBJHINT macros
...
these have been unused since we switch to using normal C++ RTTI with the
SfxHint subclasses
Change-Id: Ia271cfa01d2f49ed335e90f78309cd26d6ec9d8f
2014-10-15 10:42:50 +02:00
da77897d19
nDrehWink -> nRotationAngle
...
Change-Id: I33ca88f38210140931b12a05e426d1373243156e
2014-10-15 09:01:16 +02:00
9d24f6ba27
Missing ModelessDialog -> ModalDialog
...
Change-Id: I83a3eb34138c75dbc5a0239a9d761d22c6cd98a0
2014-10-14 20:32:15 +02:00
4e3772b1b4
fdo#75757: remove inheritance to std::map
...
from UniqueIndexImpl.
Change-Id: Iaa9040dff117ed5b05955c9f6eef31878dccf3b0
Reviewed-on: https://gerrit.libreoffice.org/11951
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-10-14 16:31:16 +00:00
60126254eb
Resolves: fdo#72587 make template dialog Modal
...
Change-Id: Iefb63bc7cdbff2217f16c1a72fc271361227588b
2014-10-14 17:16:34 +01:00
091742e86a
do not forward-declare templates
...
Change-Id: I3b0a145f70406f0c8a12b6c4b7876c4148f76e93
2014-10-14 17:56:23 +02:00
578fd01ee9
basebmp: accelerated method to create a clipping device.
...
This was some staggering proportion of tiled rendering documents
with complex clipping; it seems 'clear' is not what memset is for
1bit clip masks.
Change-Id: I9142ffb7d7016603feb7782d6f03b9992b9494e3
2014-10-14 12:04:13 -03:00
73b44845c6
Make -1 a valid value of enum MSO_SPT
...
...as e.g. CppunitTest_sw_filters_test under -fsanitize=undefined complains
> svx/source/customshapes/EnhancedCustomShapeTypeNames.cxx:304:13: runtime error: load of value 4294967295, which is not a valid value for type 'const MSO_SPT'
> EnhancedCustomShapeTypeNames::Get(MSO_SPT) svx/source/customshapes/EnhancedCustomShapeTypeNames.cxx:304:5
> SdrObjCustomShape::MergeDefaultAttributes(rtl::OUString const*) svx/source/svdraw/svdoashp.cxx:873:26
> SvxCustomShape::createCustomShapeDefaults(rtl::OUString const&) svx/source/unodraw/unoshap2.cxx:1933:26
> non-virtual thunk to SvxCustomShape::createCustomShapeDefaults(rtl::OUString const&) svx/source/unodraw/unoshap2.cxx:1934:1
> oox::vml::CustomShape::implConvertAndInsert(com::sun:⭐ :uno::Reference<com::sun:⭐ :drawing::XShapes> const&, com::sun:⭐ :awt::Rectangle const&) const oox/source/vml/vmlshape.cxx:976:9
> oox::vml::ComplexShape::implConvertAndInsert(com::sun:⭐ :uno::Reference<com::sun:⭐ :drawing::XShapes> const&, com::sun:⭐ :awt::Rectangle const&) const oox/source/vml/vmlshape.cxx:1073:12
> oox::vml::ShapeBase::convertAndInsert(com::sun:⭐ :uno::Reference<com::sun:⭐ :drawing::XShapes> const&, oox::vml::ShapeParentAnchor const*) const oox/source/vml/vmlshape.cxx:307:22
> oox::shape::ShapeContextHandler::getShape() oox/source/shape/ShapeContextHandler.cxx:432:27
> non-virtual thunk to oox::shape::ShapeContextHandler::getShape() oox/source/shape/ShapeContextHandler.cxx:545:1
> writerfilter::ooxml::OOXMLFastContextHandlerShape::sendShape(int) writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:1742:48
> writerfilter::ooxml::OOXMLFastContextHandlerShape::lcl_endFastElement(int) writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:1769:9
> writerfilter::ooxml::OOXMLFastContextHandler::endFastElement(int) writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:249:9
> non-virtual thunk to writerfilter::ooxml::OOXMLFastContextHandler::endFastElement(int) writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:250:1
> (anonymous namespace)::Entity::endElement() sax/source/fastparser/fastparser.cxx:484:13
> sax_fastparser::FastSaxParserImpl::callbackEndElement(char const*) sax/source/fastparser/fastparser.cxx:1216:9
> (anonymous namespace)::call_callbackEndElement(void*, char const*) sax/source/fastparser/fastparser.cxx:295:5
> doContent (instdir/program/libexpwraplo.so+0x369381)
> contentProcessor (instdir/program/libexpwraplo.so+0x34d9ee)
> doProlog (instdir/program/libexpwraplo.so+0x330991)
> prologProcessor (instdir/program/libexpwraplo.so+0x32a1f6)
> prologInitProcessor (instdir/program/libexpwraplo.so+0x38d185)
> XML_ParseBuffer (instdir/program/libexpwraplo.so+0x31359b)
> XML_Parse (instdir/program/libexpwraplo.so+0x30f34e)
> sax_fastparser::FastSaxParserImpl::parse() sax/source/fastparser/fastparser.cxx:1058:52
> sax_fastparser::FastSaxParserImpl::parseStream(com::sun:⭐ :xml::sax::InputSource const&) sax/source/fastparser/fastparser.cxx:852:13
> sax_fastparser::FastSaxParser::parseStream(com::sun:⭐ :xml::sax::InputSource const&) sax/source/fastparser/fastparser.cxx:1339:5
> non-virtual thunk to sax_fastparser::FastSaxParser::parseStream(com::sun:⭐ :xml::sax::InputSource const&) sax/source/fastparser/fastparser.cxx:1340:1
> writerfilter::ooxml::OOXMLDocumentImpl::resolve(writerfilter::Stream&) writerfilter/source/ooxml/OOXMLDocumentImpl.cxx:500:13
> WriterFilter::filter(com::sun:⭐ :uno::Sequence<com::sun:⭐ 🫘 :PropertyValue> const&) writerfilter/source/filter/ImportFilter.cxx:107:9
> non-virtual thunk to WriterFilter::filter(com::sun:⭐ :uno::Sequence<com::sun:⭐ 🫘 :PropertyValue> const&) writerfilter/source/filter/ImportFilter.cxx:173:1
> SfxObjectShell::ImportFrom(SfxMedium&, com::sun:⭐ :uno::Reference<com::sun:⭐ :text::XTextRange> const&) sfx2/source/doc/objstor.cxx:2271:21
> SfxObjectShell::DoLoad(SfxMedium*) sfx2/source/doc/objstor.cxx:767:23
> SwFiltersTest::filter(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, unsigned int, unsigned int, unsigned int, bool) sw/qa/core/filters-test.cxx:112:20
> SwFiltersTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, unsigned int, unsigned int, unsigned int) sw/qa/core/filters-test.cxx:71:12
> test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, unsigned int, unsigned int, unsigned int, bool) unotest/source/cpp/filters-test.cxx:111:24
> test::FiltersTest::testDir(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, unsigned int, unsigned int, unsigned int, bool) unotest/source/cpp/filters-test.cxx:137:5
> SwFiltersTest::testCVEs() sw/qa/core/filters-test.cxx:162:5
Change-Id: I8249f962585def8c98327cce9939e2b96b648612
2014-10-14 17:01:31 +02:00
e5486c46ae
Resolve some unnecessary typedefs
...
Change-Id: If57e32d41fe03db402aad74d2bd3e4d03c5e0643
2014-10-14 17:01:30 +02:00
9509952225
Reintroduce SFINAE-based selective enablement of &=, |=
...
...they had erroneously become unconditionally enabled. Also, rename Self to
Wrap.
Change-Id: I574662012bf74114b18f3bab0c1c5825a2bd61bb
2014-10-14 14:41:30 +02:00
2cd1128555
fixes and tests for o3tl::typed_flags
...
create test suite for typed_flags template.
fix the operator&= and operator|= definitions
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >
Conflicts:
include/o3tl/typed_flags_set.hxx
Change-Id: I1df9ae197889af98a2fd76ff2bc07756c7b14ced
2014-10-14 13:01:43 +02:00
a1a83ceb8b
Remove commented out code
...
Change-Id: I1ebcffc9f1b77b9491335c13ca99090385882ec3
2014-10-14 13:01:43 +02:00
2e57092d6f
No apparent reason to fix underlying type of PushFlags
...
Change-Id: I7d578b135c7a1e681a70484bba30ff1e8b33e04d
2014-10-14 13:01:42 +02:00
572f164173
Work around missing std::underlying_type in GCC 4.6
...
Change-Id: Ic641fe2f1771fe979423c58d285a96399ea16fe2
2014-10-14 09:32:26 +02:00
fa6ac05bea
fdo#84938 - replace LIST_ACTION constants with enum
...
Change-Id: I21c05ada0a793b1e3ddf87481e66b60b83529767
2014-10-14 09:09:33 +02:00
1175b25bf2
fdo#84213 Add show/hide ruler to sd context menu
...
Change-Id: Iee42ab31a82ed4459f956706cef513afcf70ef94
2014-10-13 21:21:25 +02:00
220a368692
oox: refactor embedded media import
...
Currently the oox import creates a temp file and leaks it, and there is
no way to clean it up afterwards. Unfortunately it turns out that
SdrModel has no way to access the imported OOXML storage, so add a
really ugly hack to get the embedded media into the SdrMediaObj by
setting both MediaURL and PrivateStream properties (currently oox really
wants to set the properties in alphabetical order too...)
Change-Id: I5a235fbeb08e7bc17faf066de52b94867e9a79a2
2014-10-13 19:23:41 +02:00
4be799fc82
build error: specialization in different namespace
...
Change-Id: Ic1730a49576a663a2e04a2386bd3962a21b6fc48
2014-10-13 17:21:28 +01:00
af5ebbf783
create a macro library for implementing bit-flags types
...
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >,
changed from a macro- to a template-based solution. (Unfortunately MSVC 2012
does not support explicit conversion operators. Worked around that with
explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and
SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a
baseline that requires unconditional support for them.)
Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396
2014-10-13 17:45:57 +02:00
f6d61562d4
vcl: Make ImplFontCharMap a pImpl and move functions to FontCharMap
...
To do this, I've made FontCharMap a friend class for ImplFontCharMap,
and have moved the functions directly into FontCharMap. In this patch,
I am attempting to stop the direct use of ImplFontCharMap by anything
other than FontCharMap. However, FontCharMap itself requires a
refcounter, so we will use FontCharMapPtr to access the font character
map.
Change-Id: I509b990a8cbd911c5cc1572c7d24fc5348ca06d9
Reviewed-on: https://gerrit.libreoffice.org/11823
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com >
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com >
2014-10-13 09:19:04 +00:00
f99ebf4681
RTF filter: fix \acc* handling
...
The exporter didn't write circle and underdot at all.
Change-Id: Ia8f45f2b03fb14e9a0027ec24ee7f36adc8c018d
2014-10-12 16:26:01 +02:00
4c12951a03
Typo: compatability->compatibility
...
Change-Id: If0b98a30452a9d1fcc340173deb6856755926471
2014-10-12 13:00:46 +02:00
8044acf2db
convert SFX_CALLMODE constants to SfxCallMode enum class
...
and fix a couple of bugs in SC and SW where the call mode was
being passed to the hints parameter by accident
Change-Id: Ief805410b3f7035e012e229e77f92d5832430f58
Reviewed-on: https://gerrit.libreoffice.org/11916
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-11 15:14:52 +00:00
cb7ede2d99
convert vcl StateChangedType to enum class
...
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f
Reviewed-on: https://gerrit.libreoffice.org/11843
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-11 15:14:32 +00:00
c51f77b1c0
fdo#75757: remove inheritance to std::map
...
from oox::core::Relations.
Change-Id: If2e0109a2ad6598436177b7638cb6d568fb2d3d6
Reviewed-on: https://gerrit.libreoffice.org/11899
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-10-11 14:24:09 +00:00
124a29f0f8
move the removeTree function from desktop to unotools
...
Change-Id: I98d3f4a68abfee42dac987633878b850134671d3
2014-10-11 00:28:48 +02:00
10e8e78d0b
Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happy
...
Change-Id: I4add22edf2bcfe9c1d5ef1641eabee08d402191d
2014-10-10 15:23:53 +02:00
61b6ab6424
Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happy
...
Change-Id: Id535824a9429576a469cf88d9bdbb6b53c5e314b
2014-10-10 15:02:11 +02:00
