Commit Graph

490 Commits

Author SHA1 Message Date
01552f1e77 SID_TOGGLE_MENUBAR (aka slot:6661, .uno:MenuBarVisible) is dead
...since introduction of XLayoutManager's private:resource/menubar/menubar in
3fb2acf5b77bff59909f616c44c7de17048b64d7 "INTEGRATION: CWS layoutmanager
(1.52.10); FILE MERGED" etc. and final removal of SID_TOGGLE_MENUBAR bits in
f605b16e395e8ccc3d1aba7907b0792039016f69 "INTEGRATION: CWS sfxcleanup (1.119.8);
FILE MERGED" etc.

What still needs fixing are

  extensions/source/activex/SOActiveX.cxx
  odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/CustomizeView.java
  odk/examples/OLE/activex/SOActiveX.cpp

in a similar way as e.g. 0273d3d81d29d5c1f6c387cca633cd99722c100e "INTEGRATION:
CWS jl18 (1.6.8); FILE MERGED."

Change-Id: I52a43fc7186a4f60929ab6246a2da2e715be7510
2014-10-17 16:58:26 +02:00
2f28fc6e99 Remove some completely unused SID_s
Change-Id: I1a259f9af77bbbffc4f0bc85beb7945e3d74ff77
2014-10-17 11:55:55 +02:00
582ef22d3e fdo#84854 it seems long is not enough on 32 bit
Fraction used BigInt internally for computations, rational does nothing
like that.

Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-16 17:44:44 +02:00
6832d9f0f0 coverity#735333 flush out pointless calls to IsRemote and IsOpen
etc.

Change-Id: I588d4486071b1e31897d4e6468a2c634d6856832
2014-10-15 16:56:57 +01:00
cbc1176c14 SfxMedium::IsRemote can be made const
Change-Id: Id6b14366d11c15ec1440482cfb725e497807fa2e
2014-10-15 16:56:57 +01:00
872036c8e2 remove unused DECL_OBJHINT and IMPL_OBJHINT macros
these have been unused since we switch to using normal C++ RTTI with the
SfxHint subclasses

Change-Id: Ia271cfa01d2f49ed335e90f78309cd26d6ec9d8f
2014-10-15 10:42:50 +02:00
9d24f6ba27 Missing ModelessDialog -> ModalDialog
Change-Id: I83a3eb34138c75dbc5a0239a9d761d22c6cd98a0
2014-10-14 20:32:15 +02:00
60126254eb Resolves: fdo#72587 make template dialog Modal
Change-Id: Iefb63bc7cdbff2217f16c1a72fc271361227588b
2014-10-14 17:16:34 +01:00
091742e86a do not forward-declare templates
Change-Id: I3b0a145f70406f0c8a12b6c4b7876c4148f76e93
2014-10-14 17:56:23 +02:00
8044acf2db convert SFX_CALLMODE constants to SfxCallMode enum class
and fix a couple of bugs in SC and SW where the call mode was
being passed to the hints parameter by accident

Change-Id: Ief805410b3f7035e012e229e77f92d5832430f58
Reviewed-on: https://gerrit.libreoffice.org/11916
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11 15:14:52 +00:00
10e8e78d0b Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happy
Change-Id: I4add22edf2bcfe9c1d5ef1641eabee08d402191d
2014-10-10 15:23:53 +02:00
61b6ab6424 Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happy
Change-Id: Id535824a9429576a469cf88d9bdbb6b53c5e314b
2014-10-10 15:02:11 +02:00
afb1fb14dc Use better casts
Change-Id: Ibcf2d715ac306bd4bedae716ad82c614f136d1bc
2014-10-10 14:40:02 +02:00
47a2d7642d fdo#81356: convert Fraction to boost::rational<long> - wip
* Added rational util functions used by Fraction class not
  available in the boost::rational class.
* Replaced usage of Fraction by boost::rational<long>
* Removed code that relies on:
  1. fraction.IsValid() -- rational only allow valid values, ie
     denominator() != 0
  2. rational.denominator() == 0 -- always false
  3. rational.denominator() < 0 -- always false but implementation
     detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation
* Simplified code that relies on:
  1. rational.denominator() != 0 -- always true
* BUGS EXIST because Fraction allows the creation of invalid values but
  boost::rational throws the exception boost::bad_rational

Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9
Reviewed-on: https://gerrit.libreoffice.org/11551
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2014-10-09 11:33:33 +00:00
05f1a88e19 typo: Lable -> Label
Change-Id: I8b9e9f75dd22ee5bff678c5bc0e1fa9381a103de
2014-10-09 13:02:50 +02:00
445336074c Remove pointless commented-out 'virtual' keywords
Nobody knows any more what such a metacomment was supposed to mean, if
it had any deeper meaning at all.

Change-Id: Iefb4fedc7b833c09ee0e39b3eb28202229323ef2
2014-10-06 22:39:18 +03:00
b9301c1be3 Remove unused macros
Change-Id: Id76b285d70acb4de3ab27dbf2f0f0bb4b46735c7
2014-10-06 11:03:38 +02:00
a836afe471 fdo#73151 Always open Styles&Formatting dialog in the sidebar
Change-Id: I05b63dc00023945d92fd837bd64042135d3f9aed
Reviewed-on: https://gerrit.libreoffice.org/11648
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-06 08:15:42 +00:00
0abf268f38 loplugin: cstylecast
Change-Id: I011a0eae37d01606d28c00f8ab3839f20bf309ce
2014-10-03 15:20:03 +02:00
039b887c54 loplugin: cstylecast
Change-Id: I4a230f45e91773fca7d537e91c9e9fb54773cf10
2014-10-02 07:37:20 +02:00
00d3903413 coverity#735489 constant guards dead code
Change-Id: I387dcfb34dd6f1fc74ed929cb6b2833ae8e0f574
2014-10-01 20:28:59 +01:00
e62e266022 coverity#1242662 unused member
Change-Id: Ie089a4afabb07e3b119563dafb162da427bb635d
2014-10-01 20:28:57 +01:00
e5bf214ebb loplugin: cstylecast
Change-Id: I6ea98852ba775d85ccd54823b67224ea7f587c65
2014-10-01 13:08:43 +02:00
8dbde0845a fdo#82577: Handle Region
Put the VCL Region class in the vcl namespace. Avoids clash with the X11
Region typedef.

Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
2014-09-30 09:58:23 +02:00
eba71a4937 sfx2: std::auto_ptr -> std::unique_ptr
Change-Id: I7bac4105494cdbbadd4c4d78ce1fcf03b8ccae6c
2014-09-29 09:57:16 +02:00
b75b473e2c fdo#75757: remove inheritance to std::vector
from SfxFoundCacheArr_Impl, by typedef'ing it as
boost::ptr_vector<SfxFoundCache_Impl>.

Change-Id: Id0e50370b440fb53dbb56dabca9743b27a08b90d
Reviewed-on: https://gerrit.libreoffice.org/11650
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-26 08:20:19 +00:00
5911154175 Start Center Template Manager Tweaks
Template Manager and the related Start Center view has same
transparent highlight color as Recent Documents. Also Template
thumbnail containers should have the same size as Recent Docs view.

Change-Id: I22e417a5c5ca5a849577d5a438a193371368fe24
Reviewed-on: https://gerrit.libreoffice.org/11467
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-25 12:28:41 +00:00
89ecdc47e1 Revert "fdo#73151 Always open Styles&Formatting dialog in the sidebar"
This reverts commit 473ed449a4b6f550dc1af47a07c6e0ef243a98b2, which made
JunitTest_toolkit_unoapi fail, as
AccessibleDropDownListBox.createTestEnvironment
(qadevOOo/tests/java/mod/_toolkit/AccessibleDropDownListBox.java) was no longer
able to find its AccessilbeRole.COMBO_BOX AccessibleDropDownListBox, which it
apparently expected to find in a docked stylist (cf. DesktopTools.dockStylist
in AccessibleDropDownListBox.initialize).
2014-09-25 11:01:52 +02:00
473ed449a4 fdo#73151 Always open Styles&Formatting dialog in the sidebar
This removes the floating window for Styles&Formatting as discussed in fdo#73151.

Change-Id: I352d27a4d30632dcfda8963c23629e62ab850524
Reviewed-on: https://gerrit.libreoffice.org/11253
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-24 17:57:52 +00:00
827c46e7d7 fdo#82577: Handle Window
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.

Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-23 14:11:39 +03:00
3ddae219e4 remove unused fields pName and pMethodName in SfxSlot class
Change-Id: Icca5a0dee296fae1abeb78ea8ffa2f9e934bb111
2014-09-22 07:29:17 +02:00
5398664eed fdo#62947 make IDs unique, fixes, better names
Change-Id: I6cbfd43f037fe89e0f753c67c9368b981b85bd35
2014-09-19 17:55:18 +02:00
60e78fbb80 fdo#82577: Handle Font
Put the VCL Font class in the vcl namespace. Avoids clash with the X11
Font typedef.

Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-18 08:54:37 +02:00
5f27596bed Add writer document font colors to color palettes
Change-Id: If3fedc45586eee068c40e92da87d5d550a456a64
2014-09-17 10:19:29 +02:00
ea733ab5b6 Turn SfxItemState into a C++11 scoped enumeration
...to gain further confidence in the claim "that none of the existing
code tries to uses combinations of these enum values"
(d92602c5b13d0a60439d86c5a033d124178726ca "more fixes for SfxItemState")

Change-Id: I987922d945e8738e38adfde83b869adf3ff35b13
Reviewed-on: https://gerrit.libreoffice.org/11384
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-12 06:08:32 +00:00
5bce329040 SfxHint: convert home-grown RTTI to normal C++ RTTI
Also note that I fixed a bug in SvxFontMenuControl::Notify
where the if statement had the check the wrong way around.

Change-Id: I611e8929c65818191e36bd80f2b985820ada4411
Reviewed-on: https://gerrit.libreoffice.org/11147
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-09-06 15:47:44 -05:00
0a8bf4b534 FloatingWindows are no longer loaded from resource files
Change-Id: I2705bbb4db52779e0065400f09604384fd9cf151
2014-09-06 07:02:42 +01:00
5fc238d11e convert RID_SCROLL_NAVIGATION_WIN floating window to .ui
Change-Id: I92d13856fc4d206323d5517a8a48671bba683fec
2014-09-05 12:21:57 +01:00
77ce41f257 convert RID_SVXTBX_UNDO_REDO_CTRL floating window to .ui
Change-Id: I88a5e0aec20170dfb71bf28cb35e860773657937
2014-09-03 15:58:26 +01:00
9fba10b5a5 Related fdo#82088: removing another bunch of alias
Change-Id: I6e2ab6d20723803aedb530b4d25aa79ec0edbb8f
Reviewed-on: https://gerrit.libreoffice.org/11260
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-09-03 02:03:34 -05:00
b3062ae65f fdo#44081 don't remove 'edit' pop-up menu entry from form in design mode
Change-Id: I009b0e1a155c298bd7f461547125df4ba76805d9
Reviewed-on: https://gerrit.libreoffice.org/11230
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-09-02 11:16:04 -05:00
dc5e892153 convert SID_RECORDING_FLOATWINDOW to .ui
Change-Id: Iae3f0269e5e7f830465580dc4a520ba01ef87a79
2014-09-02 15:26:54 +01:00
724b48d877 extent .ui loading to SfxFloatingWindows
Change-Id: I3e16ef8455b35faf14838509f315cb2f70e7cb9a
2014-09-02 12:14:43 +01:00
024f334c48 Revert "fdo#44081 don't remove 'edit' pop-up menu entry from form in design mode"
This reverts commit 15cea073e7ed4970e60967fe036fc492e2052203. I
overlooked the fact during review that this introduces an svx <-> sfx2
circular dependency.
2014-09-01 10:42:12 +02:00
15cea073e7 fdo#44081 don't remove 'edit' pop-up menu entry from form in design mode
Change-Id: I9700d0d729a8f2d1255fcd03a07e05799e21f8d0
Reviewed-on: https://gerrit.libreoffice.org/11152
Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-09-01 03:20:52 -05:00
c6270de939 fdo#80538 Show an infobar when document is in read-only mode
and remove the Edit icon from the toolbar

Change-Id: I27d9506bd0fb76b3f1ad056a9866f7744674a3e2
Reviewed-on: https://gerrit.libreoffice.org/11182
Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
2014-08-29 03:42:38 -05:00
6a39fdf81f callcatcher: update unused code
Change-Id: I6cb74836f98d7507359f39e1fd03a1462b2e0c31
2014-08-28 09:50:33 +01:00
53617c8651 callcatcher: update unused code
Change-Id: Idaed255e4f004ad555ccbd6ba9dc29bf522d3c5f
2014-08-27 10:18:31 +01:00
088b22cdf4 Remove some unused macros
Change-Id: Ic8395cc31845e510b6ef5fb2a1d5f66534295012
2014-08-26 23:21:06 +03:00
fe7d0ea643 convert sw use of template manager to new manager
this completes the conversion of resource hosted
dialogs and tabpages to .ui gtkbuilder format

Change-Id: Ic1b49d5560bfa47f287e04918c01daeebba28163
2014-08-26 15:36:52 +01:00