Commit Graph

681 Commits

Author SHA1 Message Date
9086a4bbd3 remove checks of __GCC_MINOR__ that are always true in GCC 4.6 or later
Change-Id: I4412a0c1e4dee94cd717f24b8df5e257d895f721
2014-10-02 20:00:18 +02:00
86cd29772e remove HAVE_GCC_PRAGMA_DIAGNOSTIC_MODIFY check and macro
This has been supported by GCC and clang for a very long time.

Change-Id: I410a2b39004c932003f8cbefe935aedb109b1163
2014-10-02 20:00:17 +02:00
67009cf202 l10ntools: std::auto_ptr -> std::unique_ptr
Change-Id: I595506b8c6d127abaa8d86bd0ed263edba210bb5
2014-09-30 12:28:53 +02:00
43ed0dbb59 l10ntools/source/export.cxx: be more std::
Change-Id: Ia5f96f7d2bf366a6156d198e73e7987a471f28da
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-19 11:49:01 +02:00
03626d7940 fdo#80650 src transl. merge must be case sensitive
This makes the desired changes in
workdir/SrsPartMergeTarget/starmath/source/symbol.src. The only other
merged file that is changed is
workdir/SrsPartMergeTarget/sw/source/ui/misc/numberingtypelistbox.src,
with changes like

                < "1, 2, 3, ..." ; 4/*SVX_NUM_ARABIC
-               < "a, b, c, ..." ; 0/*SVX_NUM_CHARS_UPPER_LETTER   */; > ;
+               < "A, B, C, ..." ; 0/*SVX_NUM_CHARS_UPPER_LETTER   */; > ;
                < "a, b, c, ..." ; 1/*SVX_NUM_CHARS_LOWER_LETTER   */; > ;

This looks okay to me too :-)

Change-Id: I729075209027ed1f3fec311c05b631c0f681708b
2014-09-14 13:40:16 +02:00
9e773854c8 l10ntools/source/export.cxx: add sanity check to aOutput.mSimple
Change-Id: I05074760f189dfc00ce14ec33002609a56797a6d
Reviewed-on: https://gerrit.libreoffice.org/11321
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-09 15:49:09 +00:00
181b1c0f7c l10ntools/source/export.cxx: improve style of code
Change-Id: Ieef44da0ab8f2d33faaf8c32970bb9d33df6750b
Reviewed-on: https://gerrit.libreoffice.org/11318
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-09-08 15:33:29 +00:00
5aeb852efc l10ntools-transex3: make pParseQueue field private
Change-Id: Ieefed6e939e12b668a635eb8d7e70def2d52a85d
Reviewed-on: https://gerrit.libreoffice.org/11315
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-09-08 02:00:05 -05:00
ed75aa2719 create clang plugin to warn about C-style casts
We don't like C-style casts in our nice C++ code

Change-Id: I94e7ec90de9275cd6e20c4146d4f3a74bed93c9d
Reviewed-on: https://gerrit.libreoffice.org/10367
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-09-07 02:42:30 -05:00
8dd8e93d42 remove AutoControls_tmpl from localize
Change-Id: I81b77599590410da2bd93fe538b143f934917e8e
2014-08-15 12:31:10 +02:00
1cf299efcc l10ntools: suppress warning C4245 from boost/crc.hpp
Change-Id: I2ed53b4f902ae694fc064375e8a9cfeba32f9d1c
2014-08-13 16:15:34 +02:00
a64675de59 coverity#1224977 integer overflow
Change-Id: Ic212489319ef06486323877227bc8f43cc9190cc
2014-07-10 22:11:27 +02:00
cdb6ea2351 coverity#1224978 integer overflow
Change-Id: Ie7dd90e6e395fb84802758e7d90ffac010dcced0
2014-07-10 22:11:27 +02:00
e50ef195bc New loplugin:stringconcat
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
2014-07-01 15:45:52 +02:00
856b55ecf5 fdo#80324 fix path of redline_tmpl.hrc
Change-Id: Ie1684fe456ea6f9cd4b93481aa73f5b51a20ba1b
2014-06-22 14:50:56 +02:00
9c883e6a27 coverity#1019333 Explicit null dereferenced
Change-Id: I3ac21f8613558cb0413f405287cdd394f3facf02
2014-06-19 10:26:51 +01:00
010c9320ba update usage instructions of pocheck tool
Change-Id: Ibc1c5051a601a83a6616e6a22c45b05394c54e88
2014-06-16 20:53:39 +02:00
d60759a96d loplugin:staticcall
Change-Id: I6f18ab4dc082e30e51b4c0020dff4ff098275b60
2014-06-13 17:54:28 +02:00
fb22eb4257 Fix XMLFile::SearchL10NElements signature
Change-Id: I34134f75ac5571a635256d349bf5a2f67ef8ef06
2014-06-11 23:47:41 +02:00
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
3b24dcc8a8 Remove unnecessary semicolons
A simplified version of the semantic match that finds this problem is
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r1@
statement S;
position p,p1;
@@
S@p1;@p

@script:python r2@
p << r1.p;
p1 << r1.p1;
@@
if p[0].line != p1[0].line_end:
    cocci.include_match(False)
@@
position r1.p;
@@
-;@p
// </smpl>

Change-Id: Ib9708d37fbb4c6060f88d5dae3814a2d37b2091e
Reviewed-on: https://gerrit.libreoffice.org/9493
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-27 01:19:00 -05:00
407db84412 Fix memory leak in xrmex tool
Change-Id: I102566a95b5b34daf60730ffef290913caf28eb2
2014-05-22 18:51:57 +02:00
4f9b21248f simplify ternary conditions "xxx ? yyy : false"
Look for code like:
   xxx ? yyy : false;
Which can be simplified to:
   xxx && yyy

Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-05-05 12:47:48 +02:00
157b688cea some more hrc cleanup
Change-Id: Ic1a99ef971168093835207dd084e50a4f02b5e5f
Reviewed-on: https://gerrit.libreoffice.org/9141
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-04-23 18:08:24 +00:00
1a5457a11c Avoid possible memory leaks in case of exceptions
Change-Id: I4b2b439615db0ff4598f405d1e339eebbff7ae91
2014-04-21 22:29:09 +09:00
aef2111fd1 l10ntools: helpex: don't crash if the file can't be parsed; return error
Change-Id: I637f8486b0774b399ed5e250868d756c944e50f6
2014-04-16 13:20:25 +02:00
931043ab31 Memory released through xmlFreeDoc should be acquired with xmlMalloc
Change-Id: I70db57257fa8226d9f18b7d970d85cc1769252ad
2014-04-11 12:23:47 +02:00
eb5e5ae0bf Remove extra newline
Change-Id: I192542c209a1b937672650d370d3f8e93d0bc9f5
2014-04-08 12:51:12 +02:00
52e359d82d Clean up function declarations
Change-Id: Ie1360857dc4ed3102c709c1ef5b5929e5d5d5d7b
2014-04-08 10:17:38 +02:00
c8c6c8319f Clean up unreferenced functions
Change-Id: Id2c90088298d389bd1cd8efad9aa26100965d6a2
2014-04-04 10:05:58 +02:00
1d81ca98f8 move remaining padmin dialogs into vcl
and so padmin is no more

Change-Id: I554cefa8b38581daad8a78bafa167448b0a0ef61
2014-03-21 11:23:02 +00:00
f8ee482b92 coverity#984098 Uninitialized pointer field
Change-Id: I671f7c98bdcfa828e7252ec13fd1b6b998ff7a87
2014-03-19 20:22:52 +00:00
86a32589e9 Find places where OUString and OString are passed by value.
It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.

So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.

Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
2014-03-18 08:32:26 +02:00
45cc7cfea2 fix comments
Change-Id: Iee6557755e4976e023d1c04bde24e3aa1d0fd062
Reviewed-on: https://gerrit.libreoffice.org/8369
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 10:06:13 -06:00
1a8ba67708 Remove visual noise from l10ntools
Change-Id: Ia10056ae9e1b9adfe74f299afac5c3c84fa8cea7
Reviewed-on: https://gerrit.libreoffice.org/8278
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 10:05:02 -06:00
f5d4d2bf56 cid#707946 Uninitialized pointer field
this field was actually only used to swap values between other values,
so convert it to local variables

Change-Id: I274e8978651f905c0bd2391ac4baaf5c23388425
2014-02-21 11:59:09 +02:00
cd21028016 cid#1038312 Dereference before null check
Change-Id: I280d9382a47c0a934f5b1cd79eead59f9a50e52e
2014-02-20 09:31:11 +02:00
94af3bc2a4 ulfex: remove unneeded bULF, it is always true
Change-Id: I1401fddfdd42eba96253f4dd19cf60bba8de6802
2014-02-18 17:30:23 +01:00
5dd4a06901 l10ntools: sal_Bool -> bool
Change-Id: Ifffdc0942b83b5761cbbbfc5db7d241be60815cb
2014-02-17 17:55:18 +01:00
bab7eebba1 moved impress remote clients to a separate repository
Change-Id: I654e3af31a6915f08ff808b351d304da773ad267
see: git://gerrit.libreoffice.org/impress_remote
2014-01-30 18:54:36 -06:00
ccb5f1a791 coverity#1158098 Explicit null dereferenced
Change-Id: Id21a206df7d9c221fabf8503d959bfe314217214
2014-01-29 13:37:59 +00:00
62736c5fb8 bool improvements
Change-Id: Ifc3b966ce84dfb1f3498d24a09b4f8614abba15c
2014-01-28 20:26:26 +01:00
35782f89b6 fdo#74119 fix unlocalized redline menu
Change-Id: Ia4836a69ddd8bebe8cc21cea67be96b029388cb1
2014-01-27 22:30:11 +01:00
f121dd3925 sal_Bool -> bool
Change-Id: Iacfeab2cc6fb8bb85b964a995c5df16d03ed2e53
2014-01-10 17:11:48 +01:00
46d0619b54 Transex3: modify src list localization/merge part
Avoid using numbers to identify the list items because
using numbers can lead to mixed translations. Use the
corresponding string instead.

Remove a hacky solution for mixed translations.
See: 95ea6cb21a7d7f4f163e642ba4b1e165a427a0d1

Change-Id: I6f1d48bf71fe2146f04f53c6b474dd7c0ce98678
2014-01-06 10:57:51 +01:00
1459d6b269 Transex3: modify list localization/export part
Avoid using numbers to identify the list items because
using numbers can lead to mixed translations. Use the
corresponding string instead.

Change-Id: I963efbf0b4d6b17f77c51cbda0af57efa66cf8cf
2013-12-27 07:14:58 +01:00
a5867ea097 Transex3: Simplify members for lists
No need for hashmaps (ExportListEntry) because only one
list is stored (en-US). One list member is enough instead of
one for all types.

Change-Id: I952d6616e436c5aa7656854f83d442434ffcbd54
2013-12-27 07:14:58 +01:00
d1c74734c8 Transex3: NO_LOCALIZE_EXPORT
In the past, NO_LOCALIZE_EXPORT macro must be used to
skip uneeded parsing of src files which has no localizable content.
It is unsued by now and it is more effective to handle
this files on gmake level:
gb_SrsTarget_add_nonlocalizable_files
gb_SrsTarget_add_nonlocalizable_templates

Plus remove some empty src file.

Change-Id: I8fc9b2db0b5fd7a3379d3c5be970c4fc691f4c53
2013-12-27 07:14:57 +01:00
bbee598513 Transex3: some string optimization
Change-Id: I66dab1cce489c670991d2c74ffc171638dfca3d7
2013-12-27 07:14:57 +01:00
87d683ead4 Transex3: no need to check whether a lang occurs twice
It was an old concept that besides the en-US entry
other language entries were also added and in this
case may happened that one lang occured twice.

Change-Id: Ifac7089309ecf4a59b128c0fea5e8b757ca2c8a8
2013-12-27 07:14:57 +01:00