Commit Graph

115 Commits

Author SHA1 Message Date
2bb99ca189 mysqlc: These shall be plain "Time" not "tools::Time" apparently
Change-Id: Id96a75bb8a07ea3b9701b9fe4692dfc81dbd8295
2014-10-01 10:35:31 +02:00
fc04f76336 fdo#82577: Handle Time
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.

Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-01 07:34:23 +00:00
f94fffaf52 mysqlc: std::auto_ptr -> std::unique_ptr
Change-Id: I0eb5f9fab5955d1f5790d3f5d269e069aff1c201
2014-09-30 12:28:53 +02:00
9703cc63ce Remove o3tl/heap_ptr.hxx, use std::unique_ptr instead
Change-Id: Iac70c9be13892a36bfb5975f62e5345b88d4f144
2014-09-24 14:54:51 +02:00
be75acefbc Translate German comment.
Change-Id: I3d452ac218005b40568ec116ede9962cc1e60a18
2014-09-17 14:11:17 +01:00
dbf99dfb98 mysqlc: sal_Bool -> bool
Change-Id: Ie479e1671b03fbb958886d4c01ecff41b2ad1d23
2014-07-02 08:42:58 +02:00
6b50e21473 deb#749592 mysql-connector doesn't work with remote connections
and also
fdo#77584 mysql-connector doesn't work over SSH tunnel

Not sure exactly how this got broken, I suspect that the UI code
has started unconditionally passing down the properties, just filling
them with empty spaces for the unused ones.

Anyhow, this appears to fix the problem.

Change-Id: I7ac2a0d6bae610f47d2a28daa9beb3ef0e2dbb52
Reviewed-on: https://gerrit.libreoffice.org/9565
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-05-30 08:24:31 -05:00
624a116d14 use OUString::startsWith()
Change-Id: I0fc77b50792e48be175ab7cc151509e097676849
2014-05-29 09:01:40 +02:00
ebc0a15515 remove more unnecesary OUString constructor use
when throwing exceptions

Change-Id: I6edfb6b6745499f802b0e3c0e096a36fb7c32aac
2014-05-29 09:01:40 +02:00
ac76cc7e60 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part20
Change-Id: If87cdfb2c605254f6d69baa4ca5aec09091caa68
2014-05-23 22:11:52 +02:00
aa214079b4 Kill DECL_PROP1IMPL and related
See http://nabble.documentfoundation.org/About-removing-macros-td4106620.html

Change-Id: Ib934eb3f27b656b5b2f8488c2103e8eee73f9623
2014-05-11 22:52:24 +02:00
794f09f195 simplify ternary conditions "xxx ? true : yyy"
Look for code like:
   xxx ? true : yyy;
Which can be simplified to:
   xxx || yyy

Change-Id: Ib7ca86580bfd0cf04674328a3c0cf3747de4758d
2014-05-06 07:45:25 +02:00
8bb2ce61c0 fixincludeguards.sh: some smaller dirs
Change-Id: Ic25bd678dc299627299b22145efd7bebcf2b39d0
2014-04-19 11:10:13 +02:00
b154c61766 Do not use sal/log.hxx in extensions
"For now, this functionality should only be used internally within LibreOffice.
It may change again in a future version." (sal/log.hxx)

And the condition that was checked already causes a RuntimeException, so was
somewhat redundant anyway.  Thanks to mstahl for spotting this.

Change-Id: I51cc4e75b3d3ffc97943613c61cb93c1fb48e59b
2014-04-07 13:39:09 +02:00
453ee351f3 fdo#43157 : clean up more OSL_POSTCOND
Change-Id: Iaca31b4e12c258b762b3d88fbad0fb08b4f1fc16
Reviewed-on: https://gerrit.libreoffice.org/8832
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-04-04 07:23:43 -05:00
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
4d6560f506 fdo#54938: Convert some places to use cppu::supportsService
The last cases are non obvious, so it's pratically done

Change-Id: Icae1da8e238f516eaed0f7fbdf96fff778eac547
Reviewed-on: https://gerrit.libreoffice.org/8445
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-03-04 07:30:02 -06:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
5d70084bc6 Remove visual noise from mysqlc
Change-Id: I5ee918bb193ea887e728e271dd4c0fb49a4dd6e9
Reviewed-on: https://gerrit.libreoffice.org/8282
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 10:07:23 -06:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
01b7bab713 auto_ptr -> heap_ptr
Change-Id: I1b11593fc936c0a4b45c319fd73ef3b629950752
2014-02-03 11:15:56 +01:00
9072e25992 auto_ptr -> scoped_ptr
Change-Id: I878aae330a3b1658c8bca83bd8a1126d2a8d26b6
2014-02-03 11:15:56 +01:00
c2c9e3969c USE_CPP_CONN is unused
...ever since 4946c62f2943dfb3466cc4214a9c8ccd922669b5 "mysqlconnector: initial
import from CWS mysqlnative"

Change-Id: I787d2ac5e48be307f47e41ecac907c36b07a92ea
2014-02-03 11:15:56 +01:00
396248a6bf Get rid of macros
Change-Id: Ic43441201309c3b466ed3dc7a5e85d0d006c0e44
2014-02-03 11:15:55 +01:00
22c6d5739e Fix typos
Change-Id: I0314d439412e9fcc0fbc6a7702e5ec3cddafc0c5
2014-02-03 09:47:44 +01:00
32b8c5c4a9 fdo#54938 Convert basctl, mysqlc, sdext, svgio, writerp. to cppu::supportsSer.
Change-Id: I60128dbb5bf83f25eea847fe655d7126c9077414
Reviewed-on: https://gerrit.libreoffice.org/7756
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Souza <marcos.souza.org@gmail.com>
2014-02-02 18:53:03 +00:00
b55259eeb5 typo fixes
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
fa2a7c1c95 Keep using component_getImplementationEnvironment in extensions
...instead of relying on the implicit CPPU_CURRENT_LANGUAGE_BINDING_NAME
convention.  Keeping that convention an implementation detail makes it easier to
do improvements in the future.  (Theoretically, the bundled extension in mysqlc
could be considered internal code and not adapted, but just be safe.)

Change-Id: Iae41a6e072dabc2bf7c1481ba6cfed61680edf37
2013-12-17 11:05:59 +01:00
08fe82e59c Remove unnecessary use of OUString constructor in + expressions
Convert code like
  aFilename =  OUString::number(nFilePostfixCount) + OUString(".bmp");
to
  aFilename =  OUString::number(nFilePostfixCount) + ".bmp";

Change-Id: I03f513ad1c8ec8846b2afbdc67ab12525ed07e50
2013-12-17 11:49:03 +02:00
dae9b7060d Drop duplicate #include
Change-Id: Ib8969d5cd4898b81a5dcd90dc313abd28adfe052
2013-12-10 15:52:49 +09:00
610b2b94b3 remove unnecessary use of OUString constructor when assigning
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
d366c9b20e remove unnecessary sal_Unicode casts in various places
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-11-14 08:17:32 +02:00
ef90021abe convert OUString !compareToAscii to equalsAscii
Convert code like
   if( ! aStr.compareToAscii("XXX") )
to
   if( aStr.equalsAscii("XXX") )
which is both clearer and faster.

Change-Id: I267511bccab52f5225b291acbfa4e388b5a5302b
2013-11-11 12:58:12 +02:00
e52779d2f8 remove unnecessary use of OUString constructor
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
2013-11-11 11:21:26 +02:00
02a11749da fdo#70496 revert to using libmysqlclient
Change-Id: I5b98b5e7840e4f1c6005aee0c1f43ef814ecf77b
2013-10-19 23:03:14 +02:00
67aec43915 cleanup
Change-Id: I7bfd221f89718ba8634417c93a26b3a199178694
2013-10-16 05:41:26 +02:00
3bafe5f5f5 Extension shared library components must not use the "prefix" feature
...at least no non-bundled ones, see 9dfcee9266c9769153444cdcd4ab0e6e636c3eb6
"Not being able to honor a 'prefix' is a rather hard error" and the description
there how that can lead to a crash when using mysql-connector-ooo.oxt:  "'rm -rf
instdir/*/share/extensions/mysql-connector-ooo', 'instdir/*/program/soffice
workdir/*/Extension/mysql-connector.oxt', install the [extension] per-user, then
'File - New - Database - Connect to an existing database: MySQL - Next >> -
Connect directly - Next >> - Database name: foo - Server / Port - Server: bar -
Next >> - Test Connection', crash."

This is a partial revert of cd79d51420b90117d0f3e1d5f3cdf9187bd61b88 "prefix all
component_getFactory methods."

Change-Id: Ia7a6272eb0597e3b3bbf4ab333174b3232448539
2013-10-11 15:03:11 +02:00
3f31bdd67a Update mysqlc's ColumnLocate::findColumn to throw for invalid column.
(This is to comply with the updated API specification.)

Change-Id: I4542fecc78a6e64011276dafc72c31d5533af1ab
Reviewed-on: https://gerrit.libreoffice.org/5923
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-09-12 17:26:27 +00:00
ba0a57702c remove OUString wrap for string literals
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-29 21:52:54 +00:00
8a8b1ae3e9 Some more toInt32 clean up
Change-Id: I4f7911cb283d67e7c7b883d629b39588e96f32c2
2013-06-14 18:33:07 +02:00
1e4422a4b4 re-base on ALv2 code. Includes:
Patches contributed by Mathias Bauer
        gnumake4 work variously
        http://svn.apache.org/viewvc?view=revision&revision=1394707
        http://svn.apache.org/viewvc?view=revision&revision=1394326
        http://svn.apache.org/viewvc?view=revision&revision=1397337
        http://svn.apache.org/viewvc?view=revision&revision=1397315
        http://svn.apache.org/viewvc?view=revision&revision=1396797

	Patches contributed by Andre Fischer
	Fixed getcsym.awk to handle #-comments that contain special regexp chars.
        http://svn.apache.org/viewvc?view=revision&revision=1230971
	118778: Added ADDITIONAL_REPOSITORIES environment variable and its
	automatic setup in configure.
        http://svn.apache.org/viewvc?view=revision&revision=1232004
	118160: Added external CoinMP library.
        http://svn.apache.org/viewvc?view=revision&revision=1233909

	Patches contributed by Herbert Duerr
	#i119168# use generic LICENSE file for langpacks and sdks
        http://svn.apache.org/viewvc?view=revision&revision=1310178
	macosxotoolhelper: need to quote perl regexp if it may contain regexp metachars
        http://svn.apache.org/viewvc?view=revision&revision=1183367
	allow gbuild with empty sysroot on linux
        http://svn.apache.org/viewvc?view=revision&revision=1179186

	Patches contributed by Ingo Schmidt
	native373: #164472# improvements for msi database
        http://svn.apache.org/viewvc?view=revision&revision=1167540
        http://svn.apache.org/viewvc?view=revision&revision=1167539

	Patches contributed by Jurgen Schmidt
	adapt setup package scripts to handle special DS_Store file for
	developer snapshot builds
        http://svn.apache.org/viewvc?view=revision&revision=1232430
	imported patch extensions_i117681.patch
	http://svn.apache.org/viewvc?view=revision&revision=1172102

	Patches contributed by Michael Stahl
	gbuild: RepositoryFixes.mk should be optional
        http://svn.apache.org/viewvc?view=revision&revision=1166123
	xslt filter: remove the FLA horror
	wordml import filter: replace FLA usage with plain XSLT
	http://svn.apache.org/viewvc?view=revision&revision=1363727

	Patch contributed by Oliver-Rainer Wittmann
	i#88652: applied patch, remove unicows deps
	http://svn.apache.org/viewvc?view=revision&revision=1177585

    Remove lots of OS2 conditionals, re-extract Rhino Java, unwind
    cppunit pieces, cleanup Mac image bits, remove coin-mp and
    re-package lpsolve, Oxygen & Crystal, fixup qstart bits, expand
    MPLv2 subset checking.

Change-Id: Iad5c8a76399620b892671633c0d8c29996db3564
2013-06-03 11:41:36 +01:00
1136925b23 initialized with plain 0, instead of sal_False/false
Change-Id: I2df1bd52293c4423de5ac4c41f9392be1e8d2ccf
2013-05-14 20:17:14 +09:00
e8ff469da5 Remove any remaining remnants of unused component_canUnload feature
Change-Id: I635fd006b5ba9f5fb0091748ee2ff9bc3c1a2d2a
2013-04-19 16:52:03 +02:00
cd79d51420 prefix all component_getFactory methods
Change-Id: I954176fdab9103125444dd2fb397673406f7aff9
2013-04-15 09:12:08 -04:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
39d45390f4 removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarations
s/(OUString\s+[a-zA-Z_][A-Za-z0-9_]*\s*)\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/$1\($2\)/gms

Change-Id: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b
Reviewed-on: https://gerrit.libreoffice.org/2835
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 10:48:30 +00:00
8b27d78b4a automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings
Done with a perl regex:

s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms

Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 09:00:26 +00:00
730df392f5 Do not try to dlopen a static internal libmariadb
Change-Id: Ib624089418e22c050e951acc4c487572c7e0ea25
2013-03-11 10:09:49 +01:00
f3c618e46e Adapt to removed MYSQL_LIB
...from cad422afb7a4dcd7592c502641b41a832703e536 "Adding libmariadb module for
internal mariadb (work in progress)."

Change-Id: Iba803a26be6f62589191122d4defc959cb3248eb
2013-03-10 23:14:27 +01:00
7011fc2c1d more s/MYSQLC/MARIADBC/ to make mysqlc actually build...
Change-Id: I286c2100c33371d5ed1ac0be3ae6393dabe6c4ef
2013-03-10 14:31:13 +01:00